Re: [U-Boot] A bit about board.c, board.c

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > My suggestion was: > > CONFIG_ARCH_GENERIC_BOARD - you get lib/board.c > not CONFIG_ARCH_GENERIC_BOARD - you get arch/xxx/lib/board.c If we do something like this, then the other way round. There should never be any #defines needed for the standard

Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads

2011-10-23 Thread Wolfgang Denk
Dear Graeme Russ, In message <4ea34086.4030...@gmail.com> you wrote: > > One problem I see with XON/XOFF is that if we don't send XOFF at the right > time, we run the risk of entering a busy loop (any reasonable timeout delay > for example) and loosing input. So in theory, we would need to send X

Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > > Can you please #ifdef it so it doesn't get added for the non-debug > > case, too? > > Well I could, but then if someone defines DEBUG in a file they will > get a link error I think. Or are you thinking of adding a new CONFIG > which *permits* people

Re: [U-Boot] [PATCH 1/2] fdt: Add new fdt_set_node_status & fdt_set_status_by_alias helpers

2011-10-23 Thread Wolfgang Denk
Dear Kumar Gala, In message <1318619444-2059-1-git-send-email-ga...@kernel.crashing.org> you wrote: > From: Shengzhou Liu > > Add common function fdt_set_node_status() to assist in various locations > that we set a nodes status. This function utilizes the status values > that are part of the E

Re: [U-Boot] [PATCH 2/2] serial: uartlite: Fix compilation warnings

2011-10-23 Thread Wolfgang Denk
Dear Michal Simek, In message <131890-17883-2-git-send-email-mon...@monstr.eu> you wrote: > Do not setup userial_ports array as const because > in uartlite_serial_putc is out_be32 which can't write > to tx_fifo if is const. > > Warning log: > serial_xuartlite.c: In function 'uartlite_serial_p

Re: [U-Boot] [Patch v2 6/7] powerpc/mpc8349emds: Migrate from spd_sdram to unified DDR driver

2011-10-23 Thread Wolfgang Denk
Dear Kumar Gala, In message <2a6300e8-a874-49ac-84cb-be681af1b...@freescale.com> you wrote: > > On Aug 26, 2011, at 1:32 PM, York Sun wrote: > > > Update MPC8349EMDS to use unified DDR driver instead of spd_sdram.c. > > The unified driver can initialize data using DDR controller. No need to > >

Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions

2011-10-23 Thread Mike Frysinger
On Sun, Oct 23, 2011 at 04:35, Wolfgang Denk wrote: > Simon Glass wrote: >> > Can you please #ifdef it so it doesn't get added for the non-debug >> > case, too? >> >> Well I could, but then if someone defines DEBUG in a file they will >> get a link error I think. Or are you thinking of adding a new

Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads

2011-10-23 Thread Graeme Russ
Hi Wolgang, On Oct 23, 2011 7:20 PM, "Wolfgang Denk" wrote: > > Dear Graeme Russ, > > In message <4ea34086.4030...@gmail.com> you wrote: > > > > One problem I see with XON/XOFF is that if we don't send XOFF at the right > > time, we run the risk of entering a busy loop (any reasonable timeout del

[U-Boot] [PATCH] Update s3c24x0 timer implementation

2011-10-23 Thread Mark Norman
I have been doing some work to get U-Boot running on a samsung S3C2440 based SBC (QQ2440). I experienced several issues getting the board running including "raise: Signal # 8 caught" errors being printed to the console. After a bit of debugging with a JTAG debugger I found the problems were due t

[U-Boot] debugX macro

2011-10-23 Thread Marek Vasut
Hi, I've been doing the debug() cleanup and found the debugX() macro is used only in very few patches. Maybe punting it altogether won't hurt. The following do use it: ./board/spc1920/hpi.c ./drivers/mtd/nand/s3c2410_nand.c Opinions? Thanks, Cheers! ___

[U-Boot] [PATCH] MPC85xx: remove broken "mpq101" board

2011-10-23 Thread Wolfgang Denk
The board stopped building some time ago, and the board maintainer agrtees to drop it - see http://article.gmane.org/gmane.comp.boot-loaders.u-boot/112674 Signed-off-by: Wolfgang Denk Cc: Alex Dubov Cc: Andy Fleming Cc: Kumar Gala --- MAINTAINERS |4 - board/mercury/mp

Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message you wrote: > > >> +void __assert_fail(const char *assertion, const char *file, unsigned line, > >> +const char *function) > >> +{ > >> + /* This will not return */ > >> + panic("%s:%u: %s: Assertion `%s' failed.", file, line, function, > >>

Re: [U-Boot] [PATCH 01/39] DEBUG: Fix debug macros

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message you wrote: > > > +#define debugX(level, fmt, args...)\ > > + debug_cond((_DEBUG && DEBUG >=3D (level)), fmt, ##args) > > i thought we were just going to punt debugX() ? Yes, please do! Best regards, Wolfgang Denk -- DENX Software Engineeri

Re: [U-Boot] [RESEND PATCH v3] Add assert() for debug assertions

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message you wrote: > > > __assert_fail() only ever gets used (and thus needs to be compiled in) > > if DEBUG is defined, right? =A0SO why cannot you wrap the code in a > > "#ifdef DEBUG" ? > > people often enable DEBUG on a per file basis. so if i'm debugging > drivers/

Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads

2011-10-23 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > > It should be sufficient to send XOFF after receiving a newline > > character. > > And, ergo, we send an XON when entering the readline function This is probably not sufficient, as some commands take direct input. I think both getc() and tstc() shou

Re: [U-Boot] [PATCH] Update s3c24x0 timer implementation

2011-10-23 Thread Wolfgang Denk
Dear Mark Norman, In message you wrote: > > Since the .rel.text section is required by the relocation code, I > assume that .bss global variables cannot be used until after > relocation? Why do you have to make such assumptions? That's documented behaviour. Didn't you RTFM? > After studying

Re: [U-Boot] debugX macro

2011-10-23 Thread Wolfgang Denk
Dear Marek Vasut, In message <201110231646.59439.marek.va...@gmail.com> you wrote: > > I've been doing the debug() cleanup and found the debugX() macro is used only > in > very few patches. Maybe punting it altogether won't hurt. > > The following do use it: > ./board/spc1920/hpi.c > ./drivers

Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318742050-2201-2-git-send-email-...@chromium.org> you wrote: > From: Scott Wood > > From: Scott Wood > > This improves the performance of U-Boot when accepting rapid input, > such as pasting a sequence of commands. > > Without this patch, on P4080DS I see a maxi

Re: [U-Boot] [PATCH v4 1/2] NS16550: trivial code clean for checkpatch

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318742050-2201-1-git-send-email-...@chromium.org> you wrote: > This removes most checkpatch warnings from the ns16550 driver and its > header. > > Signed-off-by: Simon Glass > --- > drivers/serial/ns16550.c | 37 - > include/n

Re: [U-Boot] [PATCH 1/2] nand_spl_simple: Add omap3 DMA usage to SPL

2011-10-23 Thread Wolfgang Denk
Dear Simon Schwarz, In message <1318759804-18688-2-git-send-email-simonschwarz...@gmail.com> you wrote: > This adds DMA copy for the nand spl implementation. If CONFIG_SPL_DMA_SUPPORT > is defined the DMA is used. > > Based on DMA driver patch: > http://thread.gmane.org/gmane.comp.boot-loaders.u

Re: [U-Boot] [PATCH 2/2] bootstage: Make use of BOOTSTAGE_ID_RUN_OS in show_boot_progress()

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318790446-24792-3-git-send-email-...@chromium.org> you wrote: > This changes the number 15 as used in boot_stage_progress() to use the > new name provided for it, > > Signed-off-by: Simon Glass ... > - show_boot_progress (15); > + show_boot_progress(BOOTST

Re: [U-Boot] [PATCH] gpio: Add PCA9698 40-bit I2C I/O port

2011-10-23 Thread Wolfgang Denk
Dear Dirk Eibach, In message <1319101940-780-1-git-send-email-eib...@gdsys.de> you wrote: > Signed-off-by: Dirk Eibach > --- > drivers/gpio/Makefile |1 + > drivers/gpio/pca9698.c | 143 > > include/pca9698.h | 34 +++ > 3 fi

Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code

2011-10-23 Thread Wolfgang Denk
Dear Roy Zang, In message <1319178713-12472-1-git-send-email-tie-fei.z...@freescale.com> you wrote: > TBIPA has been set in dtsec_init_phy () funciton in drivers/net/fm/eth.c > > So remove the duplicate code on platform Ethernet code. > > Signed-off-by: Roy Zang > Cc: Andy Fleming > Cc: Kumar

Re: [U-Boot] [PATCH] phy/marvell: Rewrite the MV88E1111 phy config function based on kernel code

2011-10-23 Thread Wolfgang Denk
Dear Roy Zang, In message <1319178713-12472-2-git-send-email-tie-fei.z...@freescale.com> you wrote: > The original m88es_config() does not do the SGMII mode > initialization and is buggy. Rewrite the function according to > 3.0.6 kernel function m88e_config_init() in drivers/net/phy/marve

Re: [U-Boot] [PATCH] spi/eon: add support for new EON spi flash EN25Q32B

2011-10-23 Thread Wolfgang Denk
Dear Shaohui Xie, In message <1317122494-13562-1-git-send-email-shaohui@freescale.com> you wrote: > Signed-off-by: Shaohui Xie > --- > drivers/mtd/spi/eon.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software

Re: [U-Boot] [PATCH] arm, post, memory: fix bug if sdram base != 0x00000000

2011-10-23 Thread Wolfgang Denk
Dear Heiko Schocher, In message <1317969600-32496-1-git-send-email...@denx.de> you wrote: > commit 8d3fcb5e60b6c8e1d530dbc2e2e33ec6a44670da breaks post > memory support for sdram base != 0x. Fix this. > > Signed-off-by: Heiko Schocher > Cc: Valentin Longchamp > Cc: Holger Brunck > ---

Re: [U-Boot] [PATCH 1/3 v2] net: emaclite: Use unsigned long for baseaddr

2011-10-23 Thread Wolfgang Denk
Dear Michal Simek, In message <1318497803-21874-2-git-send-email-mon...@monstr.eu> you wrote: > Baseaddr should be unsigned long. > > Signed-off-by: Michal Simek > > --- > v2: Fix merge confict - no function change > --- > drivers/net/xilinx_emaclite.c |4 ++-- > include/netdev.h

Re: [U-Boot] [PATCH 2/3 v2] net: emaclite: Move RX/TX ping pong initialization to

2011-10-23 Thread Wolfgang Denk
Dear Michal Simek, In message <1318497803-21874-3-git-send-email-mon...@monstr.eu> you wrote: > Init RX/TX ping pong directly from board not in the driver. > > Signed-off-by: Michal Simek > > --- > v2: Fix merge confict - no function change > --- > .../xilinx/microblaze-generic/microblaze-gene

Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads

2011-10-23 Thread Graeme Russ
Hi Wolfgang, On Oct 24, 2011 4:15 AM, "Wolfgang Denk" wrote: > > Dear Graeme Russ, > > In message < calbutcleg6c30en3n4ljpv1wojjfxwkekhvqymojy8+mgsz...@mail.gmail.com> you wrote: > > [snip] > > > This should not be necessary. Actually the implementation should not > > > need to know about such

Re: [U-Boot] [PATCH v3] common: fix missing function pointer relocation in fixup_cmdtable()

2011-10-23 Thread Wolfgang Denk
Dear Daniel Schwierzeck, In message <1318972342-3801-1-git-send-email-daniel.schwierz...@googlemail.com> you wrote: > In commit fa28bd2eef588ec2048ccafedb2b384d5a355858 patch v1 was applied > instead of v2. This is an incremental patch to update that commit > to version 2. > > Signed-off-by: Dan

Re: [U-Boot] [PATCHv10] new tool mkenvimage: generates an env image from an arbitrary config file

2011-10-23 Thread Wolfgang Denk
Dear David Wagner, In message <1318612616-16799-1-git-send-email-david.wag...@free-electrons.com> you wrote: > This tool takes a key=value configuration file (same as would a `printenv' > show) > and generates the corresponding environment image, ready to be flashed. > > use case: flash the env

Re: [U-Boot] debugX macro

2011-10-23 Thread Marek Vasut
On Sunday, October 23, 2011 07:23:26 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201110231646.59439.marek.va...@gmail.com> you wrote: > > I've been doing the debug() cleanup and found the debugX() macro is used > > only in very few patches. Maybe punting it altogether won't hurt. >

Re: [U-Boot] [PATCH v4 01/10] Add getenv_ulong() to read an integer from an environment variable

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318634718-10548-1-git-send-email-...@chromium.org> you wrote: > This is not an uncommon operation in U-Boot, so let's put it in a common > function. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Fix commit title from getenv_int() to getenv_ulong() > >

Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/arm/lib/board.c | 36 +++- > 1 files changed, 11 insert

Re: [U-Boot] [PATCH 03/10] avr32: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-4-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/avr32/lib/board.c | 16 +++- > 1 files changed, 3 insertions(+), 13 deletio

Re: [U-Boot] [PATCH 04/10] blackfin: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-5-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/blackfin/lib/board.c |9 ++--- > 1 files changed, 2 insertions(+), 7 deletions(-)

Re: [U-Boot] [PATCH 05/10] m68k: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-6-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/m68k/lib/board.c | 33 - > 1 files changed, 8 insertion

Re: [U-Boot] [PATCH 06/10] microblaze: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-7-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/microblaze/lib/board.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-)

Re: [U-Boot] [PATCH 07/10] mips: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-8-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/mips/lib/board.c | 14 +++--- > 1 files changed, 3 insertions(+), 11 deletions(

Re: [U-Boot] [PATCH 08/10] powerpc: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-9-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/powerpc/lib/board.c | 33 - > 1 files changed, 8 insert

Re: [U-Boot] [PATCH 09/10] sparc: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-10-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/sparc/lib/board.c | 13 +++-- > 1 files changed, 3 insertions(+), 10 deletions

Re: [U-Boot] [PATCH 10/10] x86: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-11-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/x86/lib/board.c | 14 +++--- > 1 files changed, 3 insertions(+), 11 deletions(

Re: [U-Boot] [PATCH v4 0/6] Run-time configuration of U-Boot via a flat device tree (fdt)

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, is there going to be an updated version of this patch series? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-

Re: [U-Boot] [PATCH] net/dns.c: Fix endian conversion for big-endian in dns command

2011-10-23 Thread Wolfgang Denk
Dear Bernhard Kaindl, In message <1318759162-10523-1-git-send-email-bernhard.kai...@gmx.net> you wrote: > From: Bernhard Kaindl > > net/dns.c used endian conversion macros wrongly (shorts in reply > were put swapped into CPU, and then ntohs() was used to swap it > back, which broke on big-endia

Re: [U-Boot] [PATCH] powerpc/lib/board.c: Call run_post(POST_ROM) before relocating

2011-10-23 Thread Wolfgang Denk
Dear Bernhard Kaindl, In message <1318759628-10668-1-git-send-email-bernhard.kai...@gmx.net> you wrote: > From: Bernhard Kaindl > > The call to run_post(POST_ROM) which can run the POST memory test > is currently called too late when gd has already been copied to DRAM. > > This results in fail

Re: [U-Boot] [PATCH 1/5] net: enc28j60_lpc2292: drop unused !NET_MULTI driver

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1318795453-18090-2-git-send-email-vap...@gentoo.org> you wrote: > Everyone seems to have converted to the new enc28j60 driver, so drop > this older one which isn't used and doesn't support NET_MULTI. > > Signed-off-by: Mike Frysinger > --- > drivers/net/Makefile

Re: [U-Boot] [PATCH 2/5] net: ns9750: drop !NET_MULTI driver

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1318795453-18090-3-git-send-email-vap...@gentoo.org> you wrote: > Only one board uses this driver (ns9750dev), but the board doesn't seem > to have an entry to actually build it in the Makefile/boards.cfg, so just > delete net support from its board config. > > Si

Re: [U-Boot] [PATCH 3/5] net: s3c4510b_eth: drop unused !NET_MULTI driver

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1318795453-18090-4-git-send-email-vap...@gentoo.org> you wrote: > No boards appear to use this driver, and it doesn't support NET_MULTI, > so punt the old driver. > > Signed-off-by: Mike Frysinger > --- > drivers/net/Makefile |1 - > drivers/net/s3c451

Re: [U-Boot] [PATCH 4/5] net: sc589: drop unused !NET_MULTI driver

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1318795453-18090-5-git-send-email-vap...@gentoo.org> you wrote: > No boards appear to use this driver, and it doesn't support NET_MULTI, > so punt the old driver. > > Signed-off-by: Mike Frysinger > --- > drivers/net/3c589.c | 517 > --

Re: [U-Boot] [PATCH 5/5] net: xilinx_enet: drop unused !NET_MULTI driver

2011-10-23 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1318795453-18090-6-git-send-email-vap...@gentoo.org> you wrote: > This driver doesn't support the NET_MULTI framework, and I can't find > any boards/configs/files that reference this subdir, so punt it all. > > Signed-off-by: Mike Frysinger > --- > board/xilinx/

Re: [U-Boot] [PATCH V3 3/3] mkimage: adding support for Davinci AIS image

2011-10-23 Thread Wolfgang Denk
Dear Stefano Babic, In message <1318846063-9496-1-git-send-email-sba...@denx.de> you wrote: > Some Davinci processors supports the Application > Image Script (AIS) boot process. The patch adds the generation > of the AIS image inside the mkimage tool to make possible > to generate a bootable U-boo

Re: [U-Boot] [PATCH v3 10/10] arm, davinci: add cam_enc_4xx support

2011-10-23 Thread Igor Grinberg
On 10/21/2011 08:32 AM, Heiko Schocher wrote: > - DM368 SOC > - booting with spl not with UBL from TI > - before loading u-boot from NAND into RAM, test > the RAM with the post memory test. If error > is found, switch all LEDs on and halt system. > - SPI Flash > Dataflash Typ: M25PE80 > - Eth

Re: [U-Boot] [PATCH v4 2/2] NS16550: buffer reads

2011-10-23 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > > > So how does kermit/ymodem send the XON after the user has entered the > > > receive command and we have sent the XOFF after the newline? > > > > Upon the first getc() that follows? > > And as there will be no corresponding newline, when do we send

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-23 Thread Graeme Russ
Hi Wolfgang, On Monday, October 24, 2011, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message you wrote: >> >> > > So how does kermit/ymodem send the XON after the user has entered the >> > > receive command and we have sent the XOFF after the newline? >> > >> > Upon the first getc() that fo

Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Wolfgang Denk
Dear Simon Glass, In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: > This changes the board code to use the new getenv_ulong() function. > > Signed-off-by: Simon Glass > --- > arch/arm/lib/board.c | 36 +++- > 1 files changed, 11 insert

[U-Boot] [PATCH] arch/arm/lib/board.c: fix build error

2011-10-23 Thread Wolfgang Denk
Commit dc8bbea "arm: Use getenv_ulong() in place of getenv(), strtoul" introduced a build error for all ARM boards with network support: board.c: In function 'board_init_r': board.c:569: error: 's' undeclared (first use in this function) board.c:569: error: (Each undeclared identifier is reported

[U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning

2011-10-23 Thread Wolfgang Denk
Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), strtoul" instroduced a build warning for some PPC systems: board.c: In function 'board_init_r': board.c:626: warning: unused variable 's' Fix it. Signed-off-by: Wolfgang Denk --- arch/powerpc/lib/board.c |5 +++-- 1 files ch

Re: [U-Boot] [PATCH 14/17 V4] M28: Add MMC SPL

2011-10-23 Thread Robert Schwebel
Hi Marek, On Sat, Oct 22, 2011 at 12:44:23AM +0200, Marek Vasut wrote: > board/denx/m28evk/power_init.c | 913 > ++ Shouldn't the power library functions go into arch/arm/cpu/arm926ejs/mx28/? They are not m28evk specific and should be re-usable by other MX2

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-23 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > > Problems happen only with multi-line input, so it is perfectly fine > > to handle just that - at the root cause, i. e. when input turns into > > multi-line input. > > Can the U-Boot command line handle multiple commands per line (delimited by > ; fo

Re: [U-Boot] [PATCH v3] arm926ejs: add NXP LPC32x0 cpu series support

2011-10-23 Thread Vladimir Zapolskiy
Hi Albert, On 22.10.2011 02:31, Albert ARIBAUD wrote: > Hi Vladimir, > > Le 18/10/2011 17:55, Vladimir Zapolskiy a écrit : >> This change adds initial support for NXP LPC32x0 SoC series. >> >> Signed-off-by: Vladimir Zapolskiy >> --- >> Changes from v2 to v3: >> * checkpatch.pl reports zero errors

[U-Boot] (no subject)

2011-10-23 Thread E-Loan & Credit Home
ELOAN FINANCE is a consulting group for international debt and equity project finance in addition to commercial mortgage finance in the WORLDWIDE market. We are certified loan lender and offer secured loans to individuals and companies at 2% low interest.We are focused on attempting to fill th

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-23 Thread Graeme Russ
Hi Wolfgang, On Monday, October 24, 2011, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message < calbutcjh8bvzfvh14d83wr2jov89o9jvjo9vzzb7r_zgkzz...@mail.gmail.com> you wrote: >> >> > Problems happen only with multi-line input, so it is perfectly fine >> > to handle just that - at the root cau

[U-Boot] [PATCH] arm: Correct build error introduced by getenv_ulong() patch

2011-10-23 Thread Simon Glass
Commit dc8bbea removed a local variable that is used in most ARM boards. Since we want to avoid an 'unused variable' warning with later compilers, and the #ifdef logic of whether this variable is required is bit painful, this declares the variable local to the block of code that needs it. Signed-

Re: [U-Boot] [PATCH 02/10] arm: Use getenv_ulong() in place of getenv(), strtoul

2011-10-23 Thread Simon Glass
Hi Wolfgang, On Sun, Oct 23, 2011 at 2:49 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1318552994-6653-3-git-send-email-...@chromium.org> you wrote: >> This changes the board code to use the new getenv_ulong() function. >> >> Signed-off-by: Simon Glass >> --- >>  arch/arm/lib/boa

Re: [U-Boot] [PATCH] arch/arm/lib/board.c: fix build error

2011-10-23 Thread Simon Glass
Hi Wolfgang, On Sun, Oct 23, 2011 at 2:51 PM, Wolfgang Denk wrote: > Commit dc8bbea "arm: Use getenv_ulong() in place of getenv(), strtoul" > introduced a build error for all ARM boards with network support: > > board.c: In function 'board_init_r': > board.c:569: error: 's' undeclared (first use

Re: [U-Boot] [PATCH 2/2] bootstage: Make use of BOOTSTAGE_ID_RUN_OS in show_boot_progress()

2011-10-23 Thread Simon Glass
Hi Wolfgang, On Sun, Oct 23, 2011 at 11:44 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1318790446-24792-3-git-send-email-...@chromium.org> you wrote: >> This changes the number 15 as used in boot_stage_progress() to use the >> new name provided for it, >> >> Signed-off-by: Simon

Re: [U-Boot] [PATCH v4 0/6] Run-time configuration of U-Boot via a flat device tree (fdt)

2011-10-23 Thread Simon Glass
Hi Wolfgang, On Sun, Oct 23, 2011 at 1:56 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > is there going to be an updated version of this patch series? There was a request to move the check_fdt function into the fdtdec library, and I think it makes sense. So I will do that and send an update. I

Re: [U-Boot] [PATCH] phy/marvell: Rewrite the MV88E1111 phy config function based on kernel code

2011-10-23 Thread Zang Roy-R61911
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, October 24, 2011 3:42 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Kumar Gala > Subject: Re: [U-Boot] [PATCH] phy/marvell: Rewrite the MV88E phy config > function based on kernel code > > Dear Ro

Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code

2011-10-23 Thread Zang Roy-R61911
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, October 24, 2011 3:37 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear R

Re: [U-Boot] [PATCH 1/2] Flatten and solidify block_dev_desc layout

2011-10-23 Thread Che-liang Chiou
Dear Wolfgang Denk, I guess I have to put this patchset on hold. I will get you back if we could proceed with this patchset. Regards, Che-Liang On Sat, Oct 22, 2011 at 3:09 AM, Wolfgang Denk wrote: > Dear Che-Liang Chiou, > > In message <1319178708-10881-2-git-send-email-clch...@chromium.org> y

Re: [U-Boot] [PATCH 0/2] api: extend accessible set of block device attributes

2011-10-23 Thread Che-liang Chiou
Hi Detlev, Oops, I did not know it is intentionally to keep the external apps API as it is now. I am working on an open source secure bootloader based on U-Boot. Mostly I wrote boot logic (by boot logic I mean prompting user and listing available devices sort of things). If you see U-Boot as a pl

[U-Boot] [PATCH] powerpc: Correct build warning introduced by getenv_ulong() patch

2011-10-23 Thread Simon Glass
Commit 1272592 introduced a warning since the variable 's' is no longer always used, depending on the CONFIG options. Signed-off-by: Simon Glass --- arch/powerpc/lib/board.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/lib/board.c b/arch/powerpc/

[U-Boot] [PATCH v2] arm: Correct build error introduced by getenv_ulong() patch

2011-10-23 Thread Simon Glass
Commit dc8bbea removed a local variable that is used in most ARM boards. Since we want to avoid an 'unused variable' warning with later compilers, and the #ifdef logic of whether this variable is required is bit painful, this declares the variable local to the block of code that needs it. Signed-

Re: [U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning

2011-10-23 Thread Simon Glass
Hi Wolfgang, On Sun, Oct 23, 2011 at 2:58 PM, Wolfgang Denk wrote: > Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), > strtoul" instroduced a build warning for some PPC systems: > > board.c: In function 'board_init_r': > board.c:626: warning: unused variable 's' > > Fix it. > >

Re: [U-Boot] [PATCH 0/8] Add tftpput command for uploading files over network

2011-10-23 Thread Simon Glass
Hi Albert, On Sat, Oct 22, 2011 at 9:15 AM, Simon Glass wrote: > Hi Albert, > > On Sat, Oct 22, 2011 at 1:21 AM, Albert ARIBAUD > wrote: >> Le 22/10/2011 06:51, Simon Glass a écrit : >>> >>> The tftpboot command permits reading of files over a network interface >>> using the Trivial FTP protocol

Re: [U-Boot] [PATCH 01/39] DEBUG: Fix debug macros

2011-10-23 Thread Simon Glass
Hi Marek, On Fri, Oct 21, 2011 at 5:16 PM, Marek Vasut wrote: > The current implementation of debug doesn't play well with GCC4.6. > This implementation also fixes GCC4.6 complaints about unused variables > while maintaining code size. > > Signed-off-by: Mike Frysinger > Signed-off-by: Marek Vas

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-23 Thread Simon Glass
Hi, On Sun, Oct 23, 2011 at 4:30 PM, Graeme Russ wrote: > Hi Wolfgang, > > On Monday, October 24, 2011, Wolfgang Denk wrote: >> Dear Graeme Russ, >> >> In message < > calbutcjh8bvzfvh14d83wr2jov89o9jvjo9vzzb7r_zgkzz...@mail.gmail.com> you > wrote: >>> >>> > Problems happen only with multi-line i

Re: [U-Boot] [PATCH] cosmetic, post: Codingstyle cleanup

2011-10-23 Thread Heiko Schocher
Hello Wolfgang, Wolfgang Denk schrieb: > Dear Heiko Schocher, > > In message <1316064766-5385-1-git-send-email...@denx.de> you wrote: >> +else >> /* Use old value */ >> newword = post_word_load () & ~POST_COLDBOOT; >> -} > ... >> if (bootmode == 0) >> -{

Re: [U-Boot] [PATCH v3] arm926ejs: add NXP LPC32x0 cpu series support

2011-10-23 Thread Wolfgang Denk
Dear Vladimir Zapolskiy, In message <4ea49d8e.2050...@mleia.com> you wrote: > > you're right, I have a board to make support for. However I presume that > > U-boot maintainers won't be happy to include a board with > > CONFIG_ENV_IS_NOWHERE, and unfortunately flash driver isn't yet ready > Why n

Re: [U-Boot] [PATCH] dcache:s5p CONFIG_SYS_CACHELINE_SIZE added for s5p UNIVERSAL C210 target

2011-10-23 Thread Minkyu Kang
On 10/18/2011 02:14 AM, Anton Staaf wrote: > On Mon, Oct 17, 2011 at 4:42 AM, Lukasz Majewski > wrote: >> Define the D-cache line size for S5PC210 UNIVERSAL reference target. >> >> Signed-off-by: Lukasz Majewski >> Signed-off-by: Kyungmin Park > > Acked-by: Anton Staaf > >> Cc: Minkyu Kang

Re: [U-Boot] [PATCH] dcache:s5p CONFIG_SYS_CACHELINE_SIZE added for s5p GONI target

2011-10-23 Thread Minkyu Kang
On 10/18/2011 02:14 AM, Anton Staaf wrote: > On Mon, Oct 17, 2011 at 4:42 AM, Lukasz Majewski > wrote: >> Define the D-cache line size for S5PC110 GONI reference target. >> >> Signed-off-by: Lukasz Majewski >> Signed-off-by: Kyungmin Park > > Acked-by: Anton Staaf > >> Cc: Minkyu Kang >> --

Re: [U-Boot] [PATCH v3 03/10] spl: add option for adding post memory test to the SPL framework

2011-10-23 Thread Heiko Schocher
Helllo Sergei, Sergei Shtylyov wrote: > Hello. > > On 21-10-2011 10:32, Heiko Schocher wrote: > >> Signed-off-by: Heiko Schocher >> Cc: Albert ARIBAUD >> Cc: Sandeep Paulraj >> --- >> no changes for v3 > >> doc/README.SPL |1 + >> spl/Makefile |1 + >> 2 files changed, 2 insertion

Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code

2011-10-23 Thread Wolfgang Denk
Dear Zang Roy-R61911, In message <2239ac579c7d3646a720227a37e02681200...@039-sn1mpn1-004.039d.mgd.msft.net> you wrote: > > > Please change the Subject: so everybody understands what you are > > doing. "powerpc/fm" is not exactly clear to everybody, and neither is > > TBIPA. > > > > Nor is clea

[U-Boot] [PATCH] [BUG] arm, lib: fix compile breakage

2011-10-23 Thread Heiko Schocher
since commit dc8bbea0170eb2aca428ea221c91fc2e5e11f199 building arch/arm/lib/board.c breaks if CONFIG_CMD_NET is defined. Fix this. Signed-off-by: Heiko Schocher Cc: Albert ARIBAUD Cc: Simon Glass --- arch/arm/lib/board.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [U-Boot] Pull request - microblaze

2011-10-23 Thread Michal Simek
Dear Wolfgang Denk, please pull these two patches to your tree. Thanks, Michal The following changes since commit 4962e38e9a4a053792722918bb11c5408549aebd: Stefano Babic (1): mkimage: adding support for Davinci AIS image are available in the git repository at: git://www.denx.de

Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform code

2011-10-23 Thread Zang Roy-R61911
> -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Monday, October 24, 2011 13:24 PM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear

[U-Boot] Dear Webmail Subscriber,

2011-10-23 Thread cablemas
Dear Webmail Subscriber, Due to spam complaints of email users in our webmail system,our investigation shows that your email address is compromised and is used to send out spam message in our webmail system. As a result, our network engineer will be conducting a maintenance in our webmail s

Re: [U-Boot] [PATCH] arch/powerpc/lib/board.c: fix build warning

2011-10-23 Thread Heiko Schocher
Hello Simon, Wolfgang, Simon Glass wrote: > Hi Wolfgang, > > On Sun, Oct 23, 2011 at 2:58 PM, Wolfgang Denk wrote: >> Commit 1272592 "powerpc: Use getenv_ulong() in place of getenv(), >> strtoul" instroduced a build warning for some PPC systems: >> >> board.c: In function 'board_init_r': >> boar