Dear Simon Schwarz,
In message <1318759804-18688-2-git-send-email-simonschwarz...@gmail.com> you
wrote:
> This adds DMA copy for the nand spl implementation. If CONFIG_SPL_DMA_SUPPORT
> is defined the DMA is used.
>
> Based on DMA driver patch:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/109744/focus=109747
>
> Signed-off-by: Simon Schwarz <simonschwarz...@gmail.com>
> Cc: scottw...@freescale.com
> Cc: s-paul...@ti.com
> ---
> drivers/mtd/nand/nand_spl_simple.c | 185
> ++++++++++++++++++++++++++++++++++--
> 1 files changed, 176 insertions(+), 9 deletions(-)
...
> + for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize) {
> + res += omap3_dma_conf_transfer(0, nand_chip.IO_ADDR_R,
> + (uint32_t *)p, CONFIG_SYS_NAND_ECCSIZE/4);
IIUC, drivers/mtd/nand/nand_spl_simple.c is a global, architecture
independent file. However, you are adding OMAP3 specific code here.
If we did the same for all other potentially supported architectures
and SoCs, we'd soon have a serious mess.
Please move architecture / SoC specific code out of such global
files.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There are always alternatives.
-- Spock, "The Galileo Seven", stardate 2822.3
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
