[U-Boot] [PATCH] ARM: MX5: Remove broken leftover TO-2 errata workaround

2011-07-14 Thread David Jander
This check is broken. r3 does not contain the silicon revision. Signed-off-by: David Jander --- arch/arm/cpu/armv7/mx5/lowlevel_init.S |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/arch/arm/cpu/armv7/mx5/lowlevel_init.S b/arch/arm/cpu/armv7/mx5/lowlevel_init.S ind

[U-Boot] [PATCH] ARM: MX51: PLL errata workaround

2011-07-14 Thread David Jander
This is a port of the official PLL errata workaround from Freescale to mainline u-boot. The PLL's in the i.MX51 processor can go out of lock due to a metastable condition in an analog flip-flop when used at high frequencies. This workaround implements an undocumented feature in the PLL (dither mode

Re: [U-Boot] [PATCH] ARM: MX5: Remove broken leftover TO-2 errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 09:13 AM, David Jander wrote: > This check is broken. r3 does not contain the silicon revision. > > Signed-off-by: David Jander > --- Hi David, > arch/arm/cpu/armv7/mx5/lowlevel_init.S |5 - > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/cpu

Re: [U-Boot] [PATCH] ARM: MX51: PLL errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 09:11 AM, David Jander wrote: > This is a port of the official PLL errata workaround from Freescale to > mainline u-boot. > The PLL's in the i.MX51 processor can go out of lock due to a metastable > condition in an analog flip-flop when used at high frequencies. > This workaround impl

[U-Boot] [PATCH V2] MX31: Cleanup clock function

2011-07-14 Thread Stefano Babic
The patch provide the same API used with other i.MX processors and get rid of mx31_ functions. Signed-off-by: Stefano Babic --- Changes since V1: - remove unneeded initialization for enum (Fabio Estevam) arch/arm/cpu/arm1136/mx31/generic.c| 21 - arch/arm/incl

Re: [U-Boot] [PATCH] I2C: mxc_i2c rework

2011-07-14 Thread Heiko Schocher
Hello Stefano, Stefano Babic wrote: > On 07/13/2011 11:53 AM, Marek Vasut wrote: >> Rewrite the mxc_i2c driver. >> * This version is much closer to Linux implementation. >> * Fixes IPG_PERCLK being incorrectly used as clock source >> * Fixes behaviour of the driver on iMX51 >> * Clean up codin

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

2011-07-14 Thread Heiko Schocher
Hello Marek, Marek Vasut wrote: > Rewrite the mxc_i2c driver. > * This version is much closer to Linux implementation. > * Fixes IPG_PERCLK being incorrectly used as clock source > * Fixes behaviour of the driver on iMX51 > * Clean up coding style a bit ;-) > > Based on commit: e39428d53d080a

Re: [U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe

2011-07-14 Thread Helmut Raiger
On 07/13/2011 01:46 PM, Detlev Zundel wrote: > >> The NDEBUG approach however, as Mike suggested, was what I was >> looking for in the first place. > Great! >Detlev > Again, not so great. U-boot uses all kinds of assert(), BUG_ON(), ASSERT() all over the place. This probably needs a project

Re: [U-Boot] handling of NAND blocks which go bad

2011-07-14 Thread Wolfgang Denk
Dear tkoka, In message <1310616218.8257.10.camel@localhost> you wrote: > I have a question about how u-boot handles NAND blocks going bad over > time, for example when uncorrectable ECC errors or erase failures are > encountered for blocks which are not already in the Bad Block Table. I > know th

Re: [U-Boot] [RFC PATCH v1 3/9] Extend build-system for SPL framework

2011-07-14 Thread Wolfgang Denk
Dear Aneesh, In message <4e1e8096.2000...@ti.com> you wrote: > > We were not sure whether to globally enable --gc-sections > unconditionally for SPL or not. My opinion is that these flags should > be globally enabled for all SPLs for the following reasons: ... > As such I propose that the above s

Re: [U-Boot] [RFC PATCH v1 3/9] Extend build-system for SPL framework

2011-07-14 Thread Aneesh V
On Thursday 14 July 2011 03:15 PM, Wolfgang Denk wrote: > Dear Aneesh, > > In message<4e1e8096.2000...@ti.com> you wrote: >> >> We were not sure whether to globally enable --gc-sections >> unconditionally for SPL or not. My opinion is that these flags should >> be globally enabled for all SPLs for

Re: [U-Boot] [PATCH] ARM: MX5: Remove broken leftover TO-2 errata workaround

2011-07-14 Thread David Jander
On Thu, 14 Jul 2011 10:16:51 +0200 Stefano Babic wrote: > On 07/14/2011 09:13 AM, David Jander wrote: > > This check is broken. r3 does not contain the silicon revision. > > > > Signed-off-by: David Jander > > --- > > Hi David, > > > arch/arm/cpu/armv7/mx5/lowlevel_init.S |5 - > > 1

Re: [U-Boot] [PATCH] ARM: MX51: PLL errata workaround

2011-07-14 Thread David Jander
On Thu, 14 Jul 2011 10:30:11 +0200 Stefano Babic wrote: > On 07/14/2011 09:11 AM, David Jander wrote: > > This is a port of the official PLL errata workaround from Freescale to > > mainline u-boot. > > The PLL's in the i.MX51 processor can go out of lock due to a metastable > > condition in an an

[U-Boot] [PATCH] integratorap: remove hardcoded 32MB memory cmdline

2011-07-14 Thread Linus Walleij
The default configuration for the Integrator AP forces memory to be 32 MB on the command line to the kernel, while we have perfect information and detection of the actual memory size in the ATAGs. Delete the confusion. Signed-off-by: Linus Walleij --- include/configs/integratorap.h |2 +- 1

Re: [U-Boot] [PATCH] ARM: MX51: PLL errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 12:13 PM, David Jander wrote: Hi David, > Freescale promised an official errata a week ago, but released the errata just > yesterday (hadn't seen it until now). > The number is ENGcm12051. > Do you mind including it in the commit yourself, or do you want me to re-post? Well, it is

Re: [U-Boot] [PATCH] ARM: MX51: PLL errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 12:23 PM, David Jander wrote: >> Hi David, >> >> do you have now also an official Errata number from Freescale to be >> added to your documentation ? > > Needless to say that this supersedes my patch sent back in May, 26th... which > btw did not help much, since _all_ PLL's are affec

Re: [U-Boot] [PATCH] ARM: MX51: PLL errata workaround

2011-07-14 Thread David Jander
Hi Stefano, On Thu, 14 Jul 2011 10:30:11 +0200 Stefano Babic wrote: > On 07/14/2011 09:11 AM, David Jander wrote: > > This is a port of the official PLL errata workaround from Freescale to > > mainline u-boot. > > The PLL's in the i.MX51 processor can go out of lock due to a metastable > > cond

Re: [U-Boot] [PATCH] ARM: MX5: Remove broken leftover TO-2 errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 12:20 PM, David Jander wrote: >> However, you also remove the setup for TO2. To fix the TO2 issue, we >> should read correctly the revision number (from IIM or from a fixed >> address, I do not remember now), and then apply the compare to the read >> value. > > Yes, you are right. >

Re: [U-Boot] [PATCH] ARM: MX5: Remove broken leftover TO-2 errata workaround

2011-07-14 Thread David Jander
On Thu, 14 Jul 2011 12:49:15 +0200 Stefano Babic wrote: > On 07/14/2011 12:20 PM, David Jander wrote: > > >> However, you also remove the setup for TO2. To fix the TO2 issue, we > >> should read correctly the revision number (from IIM or from a fixed > >> address, I do not remember now), and the

Re: [U-Boot] [PATCH 1/2] integratorap: disable dcache

2011-07-14 Thread Wolfgang Denk
Dear Linus Walleij, In message <1310598267-9711-1-git-send-email-linus.wall...@linaro.org> you wrote: > The Integrator AP with CM920T (ARM920T) does not boot without > D-cache disabled throughout, the actual problem comes at "bootm", > at this point U-Boot tries to disable D-cache which doesn't w

Re: [U-Boot] [PATCH 2/2] integratorap: fixup SDRAM memory size detection

2011-07-14 Thread Wolfgang Denk
Dear Linus Walleij, In message <1310598276-9741-1-git-send-email-linus.wall...@linaro.org> you wrote: > This fixes up the SDRAM memory detection code to work with the > latest relocation code, moves it all into dram_init() and > activates memory size detection for the Integrator AP. > > Signed-o

Re: [U-Boot] [PATCH] integratorap: remove hardcoded 32MB memory cmdline

2011-07-14 Thread Wolfgang Denk
Dear Linus Walleij, In message <1310639329-9677-1-git-send-email-linus.wall...@linaro.org> you wrote: > The default configuration for the Integrator AP forces memory to be > 32 MB on the command line to the kernel, while we have perfect > information and detection of the actual memory size in the

Re: [U-Boot] [PATCH 2/2] integratorap: fixup SDRAM memory size detection

2011-07-14 Thread Sergei Shtylyov
Hello. On 14-07-2011 3:04, Linus Walleij wrote: > This fixes up the SDRAM memory detection code to work with the > latest relocation code, moves it all into dram_init() and > activates memory size detection for the Integrator AP. > Signed-off-by: Linus Walleij > --- > board/armltd/integrator/i

[U-Boot] [PATCH] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread David Jander
This check was broken. r3 does not contain the silicon revision anymore, so we need to reload it. Signed-off-by: David Jander --- arch/arm/cpu/armv7/mx5/lowlevel_init.S |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/arm/cpu/armv7/mx5/lowlevel_init.S b/arch/arm/

[U-Boot] [PATCH] Let target 'cscope' follow symbolic links

2011-07-14 Thread Horst Kronstorfer
Without telling 'find' to follow symbolic links, files under include/asm and arch/$(ARCH)/include/asm/arch are not added to the cscope file list. Signed-off-by: Horst Kronstorfer --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index e56f

Re: [U-Boot] [PATCH] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 01:56 PM, David Jander wrote: > This check was broken. r3 does not contain the silicon revision anymore, so > we need to reload it. > > Signed-off-by: David Jander > --- Hi David, > arch/arm/cpu/armv7/mx5/lowlevel_init.S |4 +++- > 1 files changed, 3 insertions(+), 1 deletion

Re: [U-Boot] [PATCH] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread David Jander
On Thu, 14 Jul 2011 14:14:52 +0200 Stefano Babic wrote: > On 07/14/2011 01:56 PM, David Jander wrote: > > This check was broken. r3 does not contain the silicon revision anymore, so > > we need to reload it. > > > > Signed-off-by: David Jander > > --- > > Hi David, > > > arch/arm/cpu/armv7/m

Re: [U-Boot] [PATCH] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 02:30 PM, David Jander wrote: >> You have to protect the code related to TO2 with CONFIG_MX51. As I can >> see, the macro is called for MX.53, too, and the test produces wrong >> results. > > Wow, you are right! So this code was actually broken in more ways than I > initially thought

[U-Boot] [PATCH] miiphy: use strcpy() not sprintf()

2011-07-14 Thread Laurence Withers
In miiphy_register() the new device's name was initialised by passing a string parameter as the format string to sprintf(). As this would cause problems if it ever contained a '%' symbol, switch to using strcpy() instead. Signed-off-by: Laurence Withers Cc: Andy Fleming --- common/miiphyutil.c

[U-Boot] [PATCH V2] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread David Jander
This check was broken. r3 does not contain the silicon revision anymore, so we need to reload it. Also, this errata only applies to i.MX51. Changed in this version: - Added #ifdef CONFIG_MX51 around the workaround Signed-off-by: David Jander --- arch/arm/cpu/armv7/mx5/lowlevel_init.S |6 ++

Re: [U-Boot] [PATCH V2] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread Stefano Babic
On 07/14/2011 02:54 PM, David Jander wrote: > This check was broken. r3 does not contain the silicon revision anymore, so > we need to reload it. Also, this errata only applies to i.MX51. > > Changed in this version: > - Added #ifdef CONFIG_MX51 around the workaround > > Signed-off-by: David Jan

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread Jerry Van Baren
Hi Dave, This looks reasonable, with one minor nit... On 07/09/2011 04:40 PM, David A. Long wrote: > From: David A. Long > > Add a new "fdt_high" enviroment variable. This can be used to control (or > prevent) the > relocation of the flattened device tree on boot. It can be used to prevent > re

Re: [U-Boot] [PATCH] powerpc/85xx: enanle USB2 gadget mode for corenet ds board

2011-07-14 Thread Kumar Gala
1. fix commit message 'enanle' -> enable 2. add some details about how this change addresses the issue in commit message - k On Jul 13, 2011, at 9:42 PM, Shaohui Xie wrote: > Signed-off-by: Shaohui Xie > --- > arch/powerpc/cpu/mpc8xxx/fdt.c |3 ++- > board/freescale/corenet_ds/coren

[U-Boot] ARM POST Tests.

2011-07-14 Thread sreekumar.sivakumar
Hello , I am new to u-boot code. I had a requirement for running memory, cpu and cache tests as part of diagnostics, on an ARM based platform. After going through the code, I found that only PPC variants are available for cpu and cache post tests. 1) Is that a limitation, or Is it some sort of mis

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread David Long
On Thu, 2011-07-14 at 09:10 -0400, Jerry Van Baren wrote: > Hi Dave, > > This looks reasonable, with one minor nit... > > Need spaces around the "=" > > I will add the spaces before applying the patch unless you send an > updated patch. > OK, thanks much. Someone else recently pointed t

Re: [U-Boot] [PATCH] powerpc: Fix device tree padding associated with ramdisk

2011-07-14 Thread Kumar Gala
On Jul 6, 2011, at 8:16 PM, Kumar Gala wrote: > When booting with a ramdisk we bump the amount of memory reserved for > the device tree by FDT_RAMDISK_OVERHEAD. However we did not increase > the actual size in the device tree blob to match. > > Its possible on boundary cases that we dont have e

Re: [U-Boot] [PATCH 1/2] fdt: introduce fdt_create_phandle()

2011-07-14 Thread Kumar Gala
On May 10, 2011, at 3:14 PM, Timur Tabi wrote: > The ePAPR specification says that phandle properties should be called > "phandle", and not "linux,phandle". To facilitate the migration from > "linux,phandle" to "phandle", introduce function fdt_create_phandle(), which > creates a phandle in a gi

Re: [U-Boot] [PATCH 1/2] fdt: add prototype for fdt_increase_size()

2011-07-14 Thread Kumar Gala
On May 3, 2011, at 1:35 PM, Timur Tabi wrote: > Add a prototype for fdt_increase_size() so that anyone can call it. > > Signed-off-by: Timur Tabi > --- > include/fdt_support.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Jerry, Any comments on this? - k __

Re: [U-Boot] [GIT PULL] Pull request: u-boot-imx

2011-07-14 Thread Albert ARIBAUD
Hi Stefano, Le 13/07/2011 16:25, Stefano Babic a écrit : > Hi Albert, > > please pull from u-boot-imx. > > The following changes since commit 79642098a8345e2506ab0ff02e8c7ac4da405d0c: > >Add support for Network Space v2 and parents (2011-07-04 10:55:28 +0200) > > are available in the git repos

Re: [U-Boot] [PATCH V2] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread Albert ARIBAUD
Hi David, Le 14/07/2011 14:54, David Jander a écrit : > This check was broken. r3 does not contain the silicon revision anymore, so > we need to reload it. Also, this errata only applies to i.MX51. > > Changed in this version: > - Added #ifdef CONFIG_MX51 around the workaround Please keep patch

Re: [U-Boot] [PATCH 1/2] fdt: add prototype for fdt_increase_size()

2011-07-14 Thread Gerald Van Baren
Hi Kumar, Timur, On 07/14/2011 09:32 AM, Kumar Gala wrote: > > On May 3, 2011, at 1:35 PM, Timur Tabi wrote: > >> Add a prototype for fdt_increase_size() so that anyone can call it. >> >> Signed-off-by: Timur Tabi >> --- >> include/fdt_support.h |1 + >> 1 files changed, 1 insertions(+), 0 dele

Re: [U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe

2011-07-14 Thread Albert ARIBAUD
Hi Helmut, Le 11/07/2011 12:10, Helmut Raiger a écrit : > On 07/07/2011 06:46 PM, Albert ARIBAUD wrote: >> Hi Helmut, >> >> Le 04/07/2011 12:29, helmut.rai...@hale.at a écrit : >>> From: Helmut Raiger >> >> Seems like your git send-email config does not have your name along >> with your e-mail add

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

2011-07-14 Thread Albert ARIBAUD
Hi Marek, Le 13/07/2011 23:58, Marek Vasut a écrit : > V3+: Add commit ID into commit message What prevents a simple V4 here? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] miiphy: use strcpy() not sprintf()

2011-07-14 Thread Albert ARIBAUD
Hi Laurence, Le 14/07/2011 14:31, Laurence Withers a écrit : > In miiphy_register() the new device's name was initialised by passing a > string parameter as the format string to sprintf(). As this would cause > problems if it ever contained a '%' symbol, switch to using strcpy() > instead. Please

[U-Boot] [PATCH V3] ARM: MX5: Fix broken leftover TO-2 errata workaround

2011-07-14 Thread David Jander
This check was broken. r3 does not contain the silicon revision anymore, so we need to reload it. Also, this errata only applies to i.MX51. Signed-off-by: David Jander --- Changed in this version: - Move patch changelog below '---' line. arch/arm/cpu/armv7/mx5/lowlevel_init.S |6 +-

Re: [U-Boot] armv7: fix: Disable D cache for goni target (s5p)

2011-07-14 Thread Albert ARIBAUD
Hi Lukasz, Le 11/07/2011 09:41, Lukasz Majewski a écrit : > Signed-off-by: Lukasz Majewski > Cc: Minkyu Kang > Cc: Aneesh V > --- Can you please submit a V2 patch in which the commit message provides a rationale for turning the data cache off? People who want to turn it on later will benefit fr

Re: [U-Boot] [PATCH 1/2] fdt: introduce fdt_create_phandle()

2011-07-14 Thread Gerald Van Baren
On 07/14/2011 09:31 AM, Kumar Gala wrote: > > On May 10, 2011, at 3:14 PM, Timur Tabi wrote: > >> The ePAPR specification says that phandle properties should be called >> "phandle", and not "linux,phandle". To facilitate the migration from >> "linux,phandle" to "phandle", introduce function fdt_cr

[U-Boot] [PATCH v2] miiphy: use strncpy() not sprintf()

2011-07-14 Thread Laurence Withers
In miiphy_register() the new device's name was initialised by passing a string parameter as the format string to sprintf(). As this would cause problems if it ever contained a '%' symbol, switch to using strncpy() instead. Signed-off-by: Laurence Withers Cc: Andy Fleming --- Changes for v2: - U

Re: [U-Boot] [PATCH 1/3] arm: add CONFIG_MACH_TYPE option and documentation

2011-07-14 Thread Albert ARIBAUD
Hi Igor, Le 13/07/2011 07:52, Igor Grinberg a écrit : > Hi Albert, > > On 07/08/11 00:06, Igor Grinberg wrote: >> On 07/07/11 20:46, Albert ARIBAUD wrote: >>> Le 07/07/2011 18:51, Igor Grinberg a écrit : >>> >> If we have this option and it is documented, then any new board can use >> it

Re: [U-Boot] [PATCH 1/2] fdt: introduce fdt_create_phandle()

2011-07-14 Thread Kumar Gala
On Jul 14, 2011, at 9:01 AM, Gerald Van Baren wrote: > On 07/14/2011 09:31 AM, Kumar Gala wrote: >> >> On May 10, 2011, at 3:14 PM, Timur Tabi wrote: >> >>> The ePAPR specification says that phandle properties should be called >>> "phandle", and not "linux,phandle". To facilitate the migration

Re: [U-Boot] [PATCH 1/3] arm: add CONFIG_MACH_TYPE option and documentation

2011-07-14 Thread Albert ARIBAUD
Hi again Igor, Le 14/07/2011 16:10, Albert ARIBAUD a écrit : > Pragmatism against perfection: let's go for 2, then. Change the boards > you intended to change, and from now on reviewers for any change to a > board should point out the move to CONFIG_MACH_TYPE as mandatory. Forgot to mention: Th

[U-Boot] initramfs support through the initrd mechanism of u-boot

2011-07-14 Thread Cao, Da-Shi (EB-Presales-ZTE/HW-GZ)
Currently the support of Linux initial file system by u-boot is a file system image through "initrd". I tweaked a little of both the "lib_arm/armlinux.c" and the initramfs of Linux (a gziped cpio) so that the initramfs file could be passed to the kernel. For example: bootm c0008000 c1008000 will

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

2011-07-14 Thread Marek Vasut
On Thursday, July 14, 2011 03:55:03 PM Albert ARIBAUD wrote: > Hi Marek, > > Le 13/07/2011 23:58, Marek Vasut a écrit : > > V3+: Add commit ID into commit message > > What prevents a simple V4 here? No change in code ... but I suspect there'll be V4 anyway. > > Amicalement,

Re: [U-Boot] initramfs support through the initrd mechanism of u-boot

2011-07-14 Thread Albert ARIBAUD
Hi Thomas, Le 14/07/2011 16:17, Cao, Da-Shi (EB-Presales-ZTE/HW-GZ) a écrit : > Currently the support of Linux initial file system by u-boot is a file system > image through "initrd". I tweaked a little of both the "lib_arm/armlinux.c" > and the initramfs of Linux (a gziped cpio) so that the ini

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

2011-07-14 Thread Albert ARIBAUD
Hi again Marek, Le 14/07/2011 16:35, Marek Vasut a écrit : > On Thursday, July 14, 2011 03:55:03 PM Albert ARIBAUD wrote: >> Hi Marek, >> >> Le 13/07/2011 23:58, Marek Vasut a écrit : >>> V3+: Add commit ID into commit message >> >> What prevents a simple V4 here? > > No change in code ... but I s

Re: [U-Boot] [PATCH] powerpc: Fix device tree padding associated with ramdisk

2011-07-14 Thread Jerry Van Baren
Hi Kumar, Wolfgang On 07/06/2011 09:16 PM, Kumar Gala wrote: > When booting with a ramdisk we bump the amount of memory reserved for > the device tree by FDT_RAMDISK_OVERHEAD. However we did not increase > the actual size in the device tree blob to match. > > Its possible on boundary cases that w

Re: [U-Boot] [PATCH 1/3] arm: add CONFIG_MACH_TYPE option and documentation

2011-07-14 Thread Igor Grinberg
On 07/14/11 17:20, Albert ARIBAUD wrote: > Hi again Igor, > > Le 14/07/2011 16:10, Albert ARIBAUD a écrit : > >> Pragmatism against perfection: let's go for 2, then. Change the boards >> you intended to change, and from now on reviewers for any change to a >> board should point out the move to CON

[U-Boot] [PATCH v2 1/3] arm: add CONFIG_MACH_TYPE setting and documentation

2011-07-14 Thread Igor Grinberg
CONFIG_MACH_TYPE is used to set the machine type number in the common arm code instead of setting it in the board code. Boards with dynamically discoverable machine types can still set the machine type number in the board code. Signed-off-by: Igor Grinberg --- v2: Document the option as manda

Re: [U-Boot] [RESEND PATCH v2 1/5] Tegra2: Add macros to calculate bitfield shifts and masks

2011-07-14 Thread Albert ARIBAUD
Hi Anton, Le 13/07/2011 18:47, Anton Staaf a écrit : > I agree in general that it is preferable to be as explicit as > possible. But it is also good to be able to express your intent, > instead of implementation when possible. In other words, I would > rather be explicit about my intent, than t

Re: [U-Boot] [PATCH 1/2] arm, lib/board.c: Coding Style cleanup

2011-07-14 Thread Albert ARIBAUD
Hi Heiko, Sorry for having kept this patch unanswered so long. I am now on holiday, which means *a bit* more time for U-Boot, so here comes: Re: patch title, can you make it "arm: libboard.c: ..." rather than "arm, libboard.c" ? Also, make sure you rebase onto latest u-boot-arm/master for next

Re: [U-Boot] [PATCH v1 (WIP) 01/16] [Timer]Fix misuse of ARM *timer_masked() functions outside arch/arm

2011-07-14 Thread Albert ARIBAUD
Hi Wolfgang, Le 11/07/2011 23:57, Wolfgang Denk a écrit : > Dear Graeme Russ, > > In message<1309261269-4363-2-git-send-email-graeme.r...@gmail.com> you wrote: >> >> Signed-off-by: Graeme Russ > > I consider this a bug fix, independent from the other dicussion. This > should be applied in any ca

Re: [U-Boot] [RESEND PATCH v2 1/5] Tegra2: Add macros to calculate bitfield shifts and masks

2011-07-14 Thread Anton Staaf
On Thu, Jul 14, 2011 at 9:00 AM, Albert ARIBAUD wrote: > Hi Anton, > > Le 13/07/2011 18:47, Anton Staaf a écrit : > >> I agree in general that it is preferable to be as explicit as >> possible.  But it is also good to be able to express your intent, >> instead of implementation when possible.  In

Re: [U-Boot] [PATCH 1/2] integratorap: disable dcache

2011-07-14 Thread Linus Walleij
On Thu, Jul 14, 2011 at 1:39 PM, Wolfgang Denk wrote: > Sorry, but again I have to point out that I really dislike papering > over existing bugs.  If the disable D-cache in bootm does not work, > _this_ should be analyzed and fixed instead of globally disabling he > data cache. No problem, I did

Re: [U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe

2011-07-14 Thread Mike Frysinger
On Thursday, July 14, 2011 05:14:07 Helmut Raiger wrote: > On 07/13/2011 01:46 PM, Detlev Zundel wrote: > >> The NDEBUG approach however, as Mike suggested, was what I was > >> looking for in the first place. > > Again, not so great. U-boot uses all kinds of assert(), BUG_ON(), > ASSERT() all ove

[U-Boot] [PATCH V3 3/4] ARM: Warn when the machine ID isn't set.

2011-07-14 Thread Christopher Harvey
Linux cannot boot without it. Signed-off-by: Christopher Harvey --- V2: Used a #define instead of a constant. Used a printf instead of a debug. --- V3: Moved gd->bd->bi_arch_number = BI_ARCH_NUMBER_INVALID; before the init_sequence loop, so it doesn't overwrite existing values. Removed unne

Re: [U-Boot] [PATCH] miiphy: use strcpy() not sprintf()

2011-07-14 Thread Mike Frysinger
On Thursday, July 14, 2011 09:49:23 Albert ARIBAUD wrote: > Le 14/07/2011 14:31, Laurence Withers a écrit : > > In miiphy_register() the new device's name was initialised by passing a > > string parameter as the format string to sprintf(). As this would cause > > problems if it ever contained a '%'

Re: [U-Boot] [PATCH] integratorap: remove hardcoded 32MB memory cmdline

2011-07-14 Thread Linus Walleij
On Thu, Jul 14, 2011 at 1:44 PM, Wolfgang Denk wrote: >> --- a/include/configs/integratorap.h >> +++ b/include/configs/integratorap.h > > Please make sure to Cc: the board maintainer! Aw yes, that's one thing. Peter, are you still looking after the Integrator AP board support in U-boot? I maile

[U-Boot] [PATCH] post: fix indendation/brace confusion

2011-07-14 Thread Mike Frysinger
From: James Kosin The post.c code is missing braces around the pass case, and as a result, the diagnostic function will post both fail and pass for a failed test. The reason for this bug is probably the incorrect indentation used, so when reading the code it seems like there are proper braces.

Re: [U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe

2011-07-14 Thread Mike Frysinger
On Wednesday, July 13, 2011 02:32:37 Helmut Raiger wrote: for future reference, please dont send html e-mails -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/ma

Re: [U-Boot] [RESEND PATCH v2 1/5] Tegra2: Add macros to calculate bitfield shifts and masks

2011-07-14 Thread Albert ARIBAUD
Le 14/07/2011 19:29, Anton Staaf a écrit : > On Thu, Jul 14, 2011 at 9:00 AM, Albert ARIBAUD > wrote: >> Hi Anton, >> >> Le 13/07/2011 18:47, Anton Staaf a écrit : >> >>> I agree in general that it is preferable to be as explicit as >>> possible. But it is also good to be able to express your in

Re: [U-Boot] [RESEND PATCH v2 1/5] Tegra2: Add macros to calculate bitfield shifts and masks

2011-07-14 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > I'm not sure which example you mean. If you mean his #define of the > masks explicitly, those are fine by me. My above statement is about > the masking, oring and shifting that is done in the same way every > time and could be encoded in a macro that

Re: [U-Boot] [RESEND PATCH v2 1/5] Tegra2: Add macros to calculate bitfield shifts and masks

2011-07-14 Thread Anton Staaf
On Thu, Jul 14, 2011 at 11:30 AM, Wolfgang Denk wrote: > Dear Anton Staaf, > > In message > you > wrote: >> >> I'm not sure which example you mean.  If you mean his #define of the >> masks explicitly, those are fine by me.  My above statement is about >> the masking, oring and shifting that is

Re: [U-Boot] [RESEND PATCH v2 1/5] Tegra2: Add macros to calculate bitfield shifts and masks

2011-07-14 Thread Wolfgang Denk
Dear Anton Staaf, In message you wrote: > > In both cases the value 20 needs to come from somewhere. So you would > probably end up having: > >#define SCFR1_IPS_DIV_MASK 0x0380 >#define SCFR1_IPS_DIV_SHIFT 20 > > and > >(value & SCFR1_IPS_DIV_MASK) >> SCFR1_IPS_DIV_

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread Grant Likely
On Thursday, July 14, 2011, David Long wrote: > > > > > > > > On Thu, 2011-07-14 at 09:10 -0400, Jerry Van Baren wrote: > > > Hi Dave, > > This looks reasonable, with one minor nit... > > > > > > > Need spaces around the "=" > > I will add the spaces before applying the patch unless you send an >

[U-Boot] BDI2000 configuration for P2020DS

2011-07-14 Thread Ira W. Snyder
Hi everyone, Does anyone have a BDI2000 configuration for the P2020DS that they could share with me? The documentation Freescale sent me claims that U-Boot is in a 4MB SPI flash, however, the U-Boot that came with the board is unable to initialize the SPI subsystem per their instructions. => sf

Re: [U-Boot] [PATCH V3 3/4] ARM: Warn when the machine ID isn't set.

2011-07-14 Thread Igor Grinberg
Hi Christopher, On 07/14/11 21:02, Christopher Harvey wrote: > Linux cannot boot without it. > > Signed-off-by: Christopher Harvey > --- > > V2: > Used a #define instead of a constant. > Used a printf instead of a debug. > > --- > > V3: > Moved gd->bd->bi_arch_number = BI_ARCH_NUMBER_INVALID; bef

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread David Long
On Fri, 2011-07-15 at 03:50 +0900, Grant Likely wrote: > Regardless of this patch, the pandaboard uboot still needs to be > fixed. Setting an fdt_high variable is useful for debug, but it is not > a fix. > Then someone needs to own the issue of stopping the current u-boot default behavior of

Re: [U-Boot] [PATCH v1 (WIP) 00/16] [Timer]API Rewrite

2011-07-14 Thread Wolfgang Denk
Dear Graeme Russ, In message <4e1ce6ec.1030...@gmail.com> you wrote: > > Also remember that if we are looking to inherit nanosecond time base from > Linux, it will be extremely unlikely that every board will support a native > 1ns clock source. Typical examples would be 33MHz (~30ns) or 66MHz (~1

Re: [U-Boot] [PATCH v1 (WIP) 00/16] [Timer]API Rewrite

2011-07-14 Thread Wolfgang Denk
Dear "J. William Campbell", In message <4e1cf2e0.1030...@comcast.net> you wrote: > >Yes, this is true. However, the time_elapsed_since routine can do > this dynamically (i.e. add twice the timer resolution) . I think you had That would IMHO be a very bad idea. We have a number of place

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread Scott Wood
On Thu, 14 Jul 2011 15:12:25 -0400 David Long wrote: > On Fri, 2011-07-15 at 03:50 +0900, Grant Likely wrote: > > > > Regardless of this patch, the pandaboard uboot still needs to be > > fixed. Setting an fdt_high variable is useful for debug, but it is not > > a fix. > > > > > Then someone

Re: [U-Boot] [PATCH] post: fix indendation/brace confusion

2011-07-14 Thread James Kosin
Thanks Mike for this... I was making changes and wasn't sure why I added a call to remember the post results for event the manual tests; so, I could do a report for production purposes ... anyway my code was always marking the tests as passed even if they failed which is how I caught this. James

Re: [U-Boot] BDI2000 configuration for P2020DS

2011-07-14 Thread Wolfgang Denk
Dear "Ira W. Snyder", In message <20110714185958.ge19...@ovro.caltech.edu> you wrote: > > Does anyone have a BDI2000 configuration for the P2020DS that they could > share with me? Abatron ships a p2020ds.cfg with their firmware for the BDI. Do you think this is not working or not good enough?

Re: [U-Boot] [PATCH v1 (WIP) 01/16] [Timer]Fix misuse of ARM *timer_masked() functions outside arch/arm

2011-07-14 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <4e1f2100.2030...@aribaud.net> you wrote: > > Patch applies on u-boot-arm/master except for 4 files which are not found: > > board/ixdp425/flash.c, removed by commit > 973af335e61eede3578371330abd3971805887f5, "update/fix IXDP425 / IXDPG425 > boards" > > board/

Re: [U-Boot] BDI2000 configuration for P2020DS

2011-07-14 Thread Ira W. Snyder
On Thu, Jul 14, 2011 at 09:45:37PM +0200, Wolfgang Denk wrote: > Dear "Ira W. Snyder", > > In message <20110714185958.ge19...@ovro.caltech.edu> you wrote: > > > > Does anyone have a BDI2000 configuration for the P2020DS that they could > > share with me? > > Abatron ships a p2020ds.cfg with thei

Re: [U-Boot] [RFC PATCH v1 0/9] Prototype for generic SPL framework

2011-07-14 Thread Wolfgang Denk
Dear Daniel Schwierzeck, In message <1310569869-31810-1-git-send-email-daniel.schwierz...@googlemail.com> you wrote: > This patch series is the final proposal from Aneesh and myself for a > generic SPL framework. The implementation already works and have been > tested with in-tree and out-of-tree

Re: [U-Boot] [RESEND PATCH v2 1/5] Tegra2: Add macros to calculate bitfield shifts and masks

2011-07-14 Thread Anton Staaf
On Thu, Jul 14, 2011 at 11:44 AM, Wolfgang Denk wrote: > Dear Anton Staaf, > > In message > you > wrote: >> >> In both cases the value 20 needs to come from somewhere.  So you would >> probably end up having: >> >>    #define SCFR1_IPS_DIV_MASK      0x0380 >>    #define SCFR1_IPS_DIV_SHIFT

Re: [U-Boot] [RFC] gpio command: return value on write, additional actions

2011-07-14 Thread Mike Frysinger
On Wednesday, July 06, 2011 06:36:00 Wolfgang Denk wrote: > For consistency I would prefer to have all commands return the same > type of information, i. e. either an error status (like we do with all > other commands - any result values would then have to be passed as > environment settings) goin

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread David Long
On Thu, 2011-07-14 at 14:43 -0500, Scott Wood wrote: > You need to use lmb_reserve() to exclude any memory regions that are not > suitable for boot images -- see powerpc's arch_lmb_reserve() and > get_effective_memsize()/CONFIG_SYS_LINUX_LOWMEM_MAX_SIZE. If one excludes HIGHMEM from the area u-

Re: [U-Boot] BDI2000 configuration for P2020DS

2011-07-14 Thread Wolfgang Denk
Dear "Ira W. Snyder", In message <20110714195525.gf19...@ovro.caltech.edu> you wrote: > > It says, right at the top: > > ; The values used to configure the memory controller > ; are the ones U-boot uses to setup my system. > ; Your system may need different ones !!! > ; > ; This configuration is

Re: [U-Boot] [RFC PATCH v1 0/9] Prototype for generic SPL framework

2011-07-14 Thread Wolfgang Denk
Dear Daniel Schwierzeck, In message <1310569869-31810-1-git-send-email-daniel.schwierz...@googlemail.com> you wrote: > This patch series is the final proposal from Aneesh and myself for a > generic SPL framework. The implementation already works and have been > tested with in-tree and out-of-tree

Re: [U-Boot] BDI2000 configuration for P2020DS

2011-07-14 Thread McClintock Matthew-B29882
On Thu, Jul 14, 2011 at 1:59 PM, Ira W. Snyder wrote: > The documentation Freescale sent me claims that U-Boot is in a 4MB SPI > flash, however, the U-Boot that came with the board is unable to > initialize the SPI subsystem per their instructions. > > => sf probe 0 > SF: Unsupported Manufacturer

Re: [U-Boot] [PATCH] ARM: Correct CONFIG_(SYS_)CONSOLE_INFO_QUIET rename ommissions

2011-07-14 Thread Wolfgang Denk
Dear Albert, In message <1301393738-17625-1-git-send-email-gryr...@gmail.com> Gray Remlin wrote: > Correct some ommissions of renaming CONFIG_CONSOLE_INFO_QUIET to > CONFIG_SYS_CONSOLE_INFO_QUIET > > Signed-off-by: Gray Remlin > --- > include/configs/edminiv2.h |2 +- > include/configs/km

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread Scott Wood
On Thu, 14 Jul 2011 16:09:16 -0400 David Long wrote: > On Thu, 2011-07-14 at 14:43 -0500, Scott Wood wrote: > > > > You need to use lmb_reserve() to exclude any memory regions that are not > > suitable for boot images -- see powerpc's arch_lmb_reserve() and > > get_effective_memsize()/CONFIG_SY

Re: [U-Boot] BDI2000 configuration for P2020DS

2011-07-14 Thread Ira W. Snyder
On Thu, Jul 14, 2011 at 08:16:13PM +, McClintock Matthew-B29882 wrote: > On Thu, Jul 14, 2011 at 1:59 PM, Ira W. Snyder wrote: > > The documentation Freescale sent me claims that U-Boot is in a 4MB SPI > > flash, however, the U-Boot that came with the board is unable to > > initialize the SPI

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread David Long
On Thu, 2011-07-14 at 15:21 -0500, Scott Wood wrote: > You have memory below where the kernel is loaded? Our boot script loads the kernel 2MB into physical RAM. It loads the initrd and fdt from the same NAND flash file system into RAM below that. When we boot without specifying an FDT, u-boot

Re: [U-Boot] BDI2000 configuration for P2020DS

2011-07-14 Thread McClintock Matthew-B29882
On Thu, Jul 14, 2011 at 3:41 PM, Ira W. Snyder wrote: > I'm using the U-Boot that came on the board: 2009.11-V100R00. I have not > changed any DIP switches. My boot log is below. I think this version is missing stuff for SPI to work. Can you try a newer version? This board should support an altba

Re: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable

2011-07-14 Thread Scott Wood
On Thu, 14 Jul 2011 17:20:53 -0400 David Long wrote: > When we boot without specifying an FDT, u-boot does not relocate the > initrd. When we specify an FDT address in RAM, u-boot relocates both. > We do not need that relocation (in this case at least). Well, that does sound strange. I'd think

Re: [U-Boot] [PATCH v1 (WIP) 01/16] [Timer]Fix misuse of ARM *timer_masked() functions outside arch/arm

2011-07-14 Thread Graeme Russ
Hi Wolfgang, On 15/07/11 05:50, Wolfgang Denk wrote: > Dear Albert ARIBAUD, > > In message <4e1f2100.2030...@aribaud.net> you wrote: >> >> Patch applies on u-boot-arm/master except for 4 files which are not found: >> >> board/ixdp425/flash.c, removed by commit >> 973af335e61eede3578371330abd3971

Re: [U-Boot] [PATCH v1 (WIP) 00/16] [Timer]API Rewrite

2011-07-14 Thread J. William Campbell
On 7/14/2011 12:41 PM, Wolfgang Denk wrote: > Dear "J. William Campbell", > > In message<4e1cf2e0.1030...@comcast.net> you wrote: >> Yes, this is true. However, the time_elapsed_since routine can do >> this dynamically (i.e. add twice the timer resolution) . I think you had > That would IM

Re: [U-Boot] [PATCH v1 (WIP) 05/16] [Timer]Remove reset_timer() for non-Nios2 arches

2011-07-14 Thread Graeme Russ
On 12/07/11 08:02, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message <1309261269-4363-6-git-send-email-graeme.r...@gmail.com> you wrote: >> >> Signed-off-by: Graeme Russ > > Seems this patch conflicts with 03/16, which apparently already removed > the same code, at least in some places? T

  1   2   >