Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-17 Thread Tom Rini
On Wed, Oct 17, 2012 at 02:38:47PM -0700, Troy Kisky wrote: > On 10/17/2012 2:05 PM, Tom Rini wrote: > >-BEGIN PGP SIGNED MESSAGE- > >Hash: SHA1 > > > >On 10/17/12 13:32, Troy Kisky wrote: > >>On 10/11/2012 4:15 PM, Tom Rini wrote: > >>>On Fri, Oct 12, 2012 at 12:27:09AM +0200, stefano babi

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-17 Thread Troy Kisky
On 10/17/2012 2:05 PM, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/17/12 13:32, Troy Kisky wrote: On 10/11/2012 4:15 PM, Tom Rini wrote: On Fri, Oct 12, 2012 at 12:27:09AM +0200, stefano babic wrote: [snip] One reason to move into the board directory is that there was

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/17/12 13:32, Troy Kisky wrote: > On 10/11/2012 4:15 PM, Tom Rini wrote: >> On Fri, Oct 12, 2012 at 12:27:09AM +0200, stefano babic wrote: >> >> [snip] >>> One reason to move into the board directory is that there was a >>> decision to move rules

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-17 Thread Troy Kisky
On 10/11/2012 4:15 PM, Tom Rini wrote: On Fri, Oct 12, 2012 at 12:27:09AM +0200, stefano babic wrote: [snip] One reason to move into the board directory is that there was a decision to move rules related to only one arch or SOC where they belong to, that is in the corresponding arch/ or board/

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-11 Thread Tom Rini
On Fri, Oct 12, 2012 at 12:27:09AM +0200, stefano babic wrote: [snip] > One reason to move into the board directory is that there was a decision > to move rules related to only one arch or SOC where they belong to, that > is in the corresponding arch/ or board/ directory. I'll admit that maybe my

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-11 Thread stefano babic
Am 11/10/2012 22:33, schrieb Troy Kisky: > On 10/11/2012 4:11 AM, Stefano Babic wrote: >> Does it work something more direct (I have not tested, really...) ? >> >> In board Makefile, for example board/freescale/mx6qsabrelite, a rule for >> the imximage file: >> >> $(CONFIG_IMX_CONFIG): >> $(CC

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-11 Thread Troy Kisky
On 10/11/2012 4:11 AM, Stefano Babic wrote: Does it work something more direct (I have not tested, really...) ? In board Makefile, for example board/freescale/mx6qsabrelite, a rule for the imximage file: $(CONFIG_IMX_CONFIG): $(CC) -E -x c $< -I./include -o $@ And let unchanged in the

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-11 Thread Stefano Babic
Am 10/10/2012 04:03, schrieb Troy Kisky: > On 10/8/2012 6:38 AM, Stefano Babic wrote: >> On 04/10/2012 03:47, Troy Kisky wrote: >>> The '#' used as comments in the files cause the preprocessor >>> trouble, so change to /* */. >>> >>> Signed-off-by: Troy Kisky >>> --- >> Hi Troy, >> >>> Makefile

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-09 Thread Troy Kisky
On 10/8/2012 6:38 AM, Stefano Babic wrote: On 04/10/2012 03:47, Troy Kisky wrote: The '#' used as comments in the files cause the preprocessor trouble, so change to /* */. Signed-off-by: Troy Kisky --- Hi Troy, Makefile |3 +- board/esg/ima3-mx53/i

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-08 Thread Troy Kisky
On 10/8/2012 6:38 AM, Stefano Babic wrote: On 04/10/2012 03:47, Troy Kisky wrote: The '#' used as comments in the files cause the preprocessor trouble, so change to /* */. Signed-off-by: Troy Kisky --- Hi Troy, Makefile |3 +- board/esg/ima3-mx53/i

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-08 Thread Troy Kisky
On 10/7/2012 11:19 AM, Eric Nelson wrote: Hi Troy, On 10/03/2012 06:47 PM, Troy Kisky wrote: The '#' used as comments in the files cause the preprocessor trouble, so change to /* */. Signed-off-by: Troy Kisky --- Makefile |3 +- board/esg/ima3-mx53/im

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-08 Thread Stefano Babic
On 04/10/2012 03:47, Troy Kisky wrote: > The '#' used as comments in the files cause the preprocessor > trouble, so change to /* */. > > Signed-off-by: Troy Kisky > --- Hi Troy, > Makefile |3 +- > board/esg/ima3-mx53/imximage.cfg | 120

Re: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor

2012-10-07 Thread Eric Nelson
Hi Troy, On 10/03/2012 06:47 PM, Troy Kisky wrote: The '#' used as comments in the files cause the preprocessor trouble, so change to /* */. Signed-off-by: Troy Kisky --- Makefile |3 +- board/esg/ima3-mx53/imximage.cfg | 120 ++-