Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-21 Thread Prafulla Wadaskar
Shitrit > Subject: Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support > > Dear Wolfgand Denk > > Thanks for your review comments > > > -Original Message- > > From: Wolfgang Denk [mailto:w...@denx.de] > > Sent: Wednesday, May 20, 2009 3:29

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Prafulla Wadaskar
> > > Indentation by TABs only, please. > > Indentation is done by Lindent. > > Do you mean to do it manually? > > Yes, please, if Lindent does it wrong ... Done in V9 :-) Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://list

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Wolfgang Denk
Dear Prafulla Wadaskar, In message <73173d32e9439e4abb5151606c3e19e201cf9e6...@sc-vexch1.marvell.com> you wrote: > > > > + tmpdin = readl(KW_REG_SPI_DATA_IN); > > > + debug > > > + ("*** spi_xfer: din %08X > > ... %08x

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Prafulla Wadaskar
> ... > > > > > +#define KW_EGIGA0_BASE > (KW_REGISTER(0x72000)) > > > > > +#define KW_EGIGA1_BASE > (KW_REGISTER(0x76000)) > > > > > > > > Use a C struct? > > > These are the Base address referred by register structures. > > I am aware of this. > >

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Wolfgang Denk
Dear Prafulla, In message <73173d32e9439e4abb5151606c3e19e201cf9e6...@sc-vexch1.marvell.com> you wrote: > ... > > > > +#define KW_EGIGA0_BASE (KW_REGISTER(0x72000)) > > > > +#define KW_EGIGA1_BASE (KW_REGISTER(0x76000)) > > > > > > Use a C struct? > > These are t

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Prafulla Wadaskar
> > > > > +#define INTREG_BASE 0xd000 > > > +#define KW_REGISTER(x) (KW_REGS_PHY_BASE + x) > > > +#define KW_OFFSET_REG(INTREG_BASE + 0x20080) > > > + > > > +/* undocumented registers */ > > > +#define KW_REG_UNDOC_0x1470

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Stefan Roese
On Wednesday 20 May 2009 15:40:00 Prafulla Wadaskar wrote: > > I would like to give your Kirkwood support a try and start > > compiling the latest version before trying to port a custom > > board. Now I'm failing to compile the latest version posted > > on the list. Most likely I missed some patche

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Prafulla Wadaskar
> -Original Message- > From: Stefan Roese [mailto:s...@denx.de] > Sent: Wednesday, May 20, 2009 5:40 PM > To: u-boot@lists.denx.de > Cc: Prafulla Wadaskar; Ashish Karkare; Prabhanjan Sarnaik; > Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v8] Marvell Kirkwo

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Stefan Roese
Hi Prafulla, On Tuesday 19 May 2009 22:07:58 Prafulla Wadaskar wrote: > Kirkwood family controllers are highly integrated SOCs > based on Feroceon-88FR131/Sheeva-88SV131 cpu core. I would like to give your Kirkwood support a try and start compiling the latest version before trying to port a cust

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-20 Thread Prafulla Wadaskar
Subject: Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support > > Dear Prafulla Wadaskar, > > In message > <1242763678-13724-1-git-send-email-prafu...@marvell.com> you wrote: > > > > Kirkwood family controllers are highly integrated SOCs

Re: [U-Boot] [PATCH v8] Marvell Kirkwood family SOC support

2009-05-19 Thread Wolfgang Denk
Dear Prafulla Wadaskar, In message <1242763678-13724-1-git-send-email-prafu...@marvell.com> you wrote: > > Kirkwood family controllers are highly integrated SOCs > based on Feroceon-88FR131/Sheeva-88SV131 cpu core. ... > +/* > + * Window Size > + * Used with the Base register to set the address w