Re: [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

2014-12-10 Thread Masahiro Yamada
Hi Simon, On Fri, 5 Dec 2014 08:32:04 -0700 Simon Glass wrote: > +struct dm_i2c_chip { > + uint chip_addr; > + uint offset_len; > + uint flags; > +#ifdef CONFIG_SANDBOX > + struct udevice *emul; > +#endif > +}; I do not like this ifdef conditional. As mentioned in another rep

Re: [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

2014-12-09 Thread Simon Glass
Hi Heiko, On 8 December 2014 at 23:17, Heiko Schocher wrote: > Hello Simon, > > Am 09.12.2014 06:31, schrieb Simon Glass: > >> Hi, >> >> On Dec 5, 2014 8:32 AM, "Simon Glass" wrote: >>> >>> >>> The uclass implements the same operations as the current I2C framework >>> but >>> makes some changes

Re: [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

2014-12-08 Thread Heiko Schocher
Hello Simon, Am 09.12.2014 06:31, schrieb Simon Glass: Hi, On Dec 5, 2014 8:32 AM, "Simon Glass" wrote: The uclass implements the same operations as the current I2C framework but makes some changes to make it fit driver model better: - Remove the chip address from API calls - Remove the add

Re: [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

2014-12-08 Thread Masahiro Yamada
Hi Simon, On Mon, 8 Dec 2014 22:31:59 -0700 Simon Glass wrote: > Hi, > > On Dec 5, 2014 8:32 AM, "Simon Glass" wrote: > > > > The uclass implements the same operations as the current I2C framework but > > makes some changes to make it fit driver model better: > > > > - Remove the chip address

Re: [U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

2014-12-08 Thread Simon Glass
Hi, On Dec 5, 2014 8:32 AM, "Simon Glass" wrote: > > The uclass implements the same operations as the current I2C framework but > makes some changes to make it fit driver model better: > > - Remove the chip address from API calls > - Remove the address length from API calls > - Remove concept of

[U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

2014-12-05 Thread Simon Glass
The uclass implements the same operations as the current I2C framework but makes some changes to make it fit driver model better: - Remove the chip address from API calls - Remove the address length from API calls - Remove concept of 'current' I2C bus - Drop all existing init functions Acked-by: