Hi Simon,


On Fri,  5 Dec 2014 08:32:04 -0700
Simon Glass <s...@chromium.org> wrote:

> +struct dm_i2c_chip {
> +     uint chip_addr;
> +     uint offset_len;
> +     uint flags;
> +#ifdef CONFIG_SANDBOX
> +     struct udevice *emul;
> +#endif
> +};

I do not like this ifdef conditional.
As mentioned in another reply, I suppose we can move to sandbox-i2c.

Anyway, other parts look good enough.


Reviewed-by: Masahiro Yamada <yamad...@jp.panasonic.com>


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to