Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-04-13 Thread Marek Vasut
On Sunday, April 13, 2014 at 09:55:57 PM, Ian Campbell wrote: > On Mon, 2014-03-24 at 23:42 +0100, Olliver Schinagl wrote: > > On 03/24/2014 09:52 PM, Marek Vasut wrote: > > >> +/* Switch to 24MHz clock while changing PLL1 */ > > >> +writel(AXI_DIV_1 << AXI_DIV_SHIFT | > > >> +

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-04-13 Thread Ian Campbell
On Mon, 2014-03-24 at 23:42 +0100, Olliver Schinagl wrote: > On 03/24/2014 09:52 PM, Marek Vasut wrote: > >> + /* Switch to 24MHz clock while changing PLL1 */ > >> + writel(AXI_DIV_1 << AXI_DIV_SHIFT | > >> + AHB_DIV_2 << AHB_DIV_SHIFT | > >> + APB0_DIV_1 << APB0_DIV_SHIFT | > >>

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-28 Thread Marek Vasut
On Friday, March 28, 2014 at 09:25:40 AM, Hans de Goede wrote: > Hi, > > On 03/28/2014 09:20 AM, Ian Campbell wrote: > > On Thu, 2014-03-27 at 23:36 +0100, Marek Vasut wrote: > >> On Thursday, March 27, 2014 at 11:12:38 PM, Ian Campbell wrote: > >>> On Thu, 2014-03-27 at 23:00 +0100, Marek Vasut w

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-28 Thread Marek Vasut
On Friday, March 28, 2014 at 09:20:17 AM, Ian Campbell wrote: > On Thu, 2014-03-27 at 23:36 +0100, Marek Vasut wrote: > > On Thursday, March 27, 2014 at 11:12:38 PM, Ian Campbell wrote: > > > On Thu, 2014-03-27 at 23:00 +0100, Marek Vasut wrote: > > > > On Thursday, March 27, 2014 at 10:29:56 PM, I

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 09:20 AM, Ian Campbell wrote: > On Thu, 2014-03-27 at 23:36 +0100, Marek Vasut wrote: >> On Thursday, March 27, 2014 at 11:12:38 PM, Ian Campbell wrote: >>> On Thu, 2014-03-27 at 23:00 +0100, Marek Vasut wrote: On Thursday, March 27, 2014 at 10:29:56 PM, Ian Campbell wrote:

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-28 Thread Ian Campbell
On Thu, 2014-03-27 at 23:36 +0100, Marek Vasut wrote: > On Thursday, March 27, 2014 at 11:12:38 PM, Ian Campbell wrote: > > On Thu, 2014-03-27 at 23:00 +0100, Marek Vasut wrote: > > > On Thursday, March 27, 2014 at 10:29:56 PM, Ian Campbell wrote: > > > > On Mon, 2014-03-24 at 21:52 +0100, Marek Va

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-27 Thread Marek Vasut
On Thursday, March 27, 2014 at 11:12:38 PM, Ian Campbell wrote: > On Thu, 2014-03-27 at 23:00 +0100, Marek Vasut wrote: > > On Thursday, March 27, 2014 at 10:29:56 PM, Ian Campbell wrote: > > > On Mon, 2014-03-24 at 21:52 +0100, Marek Vasut wrote: > > > > > +static struct sunxi_timer *timer_base =

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-27 Thread Ian Campbell
On Thu, 2014-03-27 at 23:00 +0100, Marek Vasut wrote: > On Thursday, March 27, 2014 at 10:29:56 PM, Ian Campbell wrote: > > On Mon, 2014-03-24 at 21:52 +0100, Marek Vasut wrote: > > > > +static struct sunxi_timer *timer_base = > > > > + &((struct sunxi_timer_reg *)SUNXI_TIMER_BASE)->timer[TIMER

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-27 Thread Marek Vasut
On Thursday, March 27, 2014 at 10:29:56 PM, Ian Campbell wrote: > On Mon, 2014-03-24 at 21:52 +0100, Marek Vasut wrote: > > > +static struct sunxi_timer *timer_base = > > > + &((struct sunxi_timer_reg *)SUNXI_TIMER_BASE)->timer[TIMER_NUM]; > > > + > > > +/* macro to read the 32 bit timer: since

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-27 Thread Ian Campbell
On Mon, 2014-03-24 at 21:52 +0100, Marek Vasut wrote: > > +static struct sunxi_timer *timer_base = > > + &((struct sunxi_timer_reg *)SUNXI_TIMER_BASE)->timer[TIMER_NUM]; > > + > > +/* macro to read the 32 bit timer: since it decrements, we invert read > > value */ +#define READ_TIMER() (~readl

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-26 Thread Ian Campbell
On Mon, 2014-03-24 at 21:52 +0100, Marek Vasut wrote: > On Friday, March 21, 2014 at 10:54:18 PM, Ian Campbell wrote: > > This has been stripped back for mainlining and supports only sun7i. These > > changes are not useful by themselves but are split out to make the patch > > sizes more manageable.

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-26 Thread Ian Campbell
On Mon, 2014-03-24 at 23:42 +0100, Olliver Schinagl wrote: [...] > I've got a local cleanup patch set where I fixed this already to > clrsetbits_le32 >[...] > Same here, got that in my local tree too Could you post what you've got please? > >> +#ifdef CONFIG_SPL_BUILD > >> +#define PLL1_CFG(N, K

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-24 Thread Wolfgang Denk
Dear Olliver Schinagl, In message <5330b4c9.10...@schinagl.nl> you wrote: > > > sr32() is not defined anywhere. > it should be defined in > arch/arm/include/asm/arch-sunxi/sys_proto.h > and comes from > arch/arm/cpu/armv7/syslib.c Please avoid using sr32() alltogether. It is basically only used

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-24 Thread Olliver Schinagl
On 03/24/2014 09:52 PM, Marek Vasut wrote: On Friday, March 21, 2014 at 10:54:18 PM, Ian Campbell wrote: This has been stripped back for mainlining and supports only sun7i. These changes are not useful by themselves but are split out to make the patch sizes more manageable. [...] +int clock_i

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-24 Thread Marek Vasut
On Monday, March 24, 2014 at 11:42:17 PM, Olliver Schinagl wrote: > On 03/24/2014 09:52 PM, Marek Vasut wrote: > > On Friday, March 21, 2014 at 10:54:18 PM, Ian Campbell wrote: > >> This has been stripped back for mainlining and supports only sun7i. > >> These changes are not useful by themselves b

Re: [U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-24 Thread Marek Vasut
On Friday, March 21, 2014 at 10:54:18 PM, Ian Campbell wrote: > This has been stripped back for mainlining and supports only sun7i. These > changes are not useful by themselves but are split out to make the patch > sizes more manageable. [...] > +int clock_init(void) > +{ > + struct sunxi_ccm

[U-Boot] [PATCH v2 1/9] sunxi: initial sun7i clocks and timer support.

2014-03-21 Thread Ian Campbell
This has been stripped back for mainlining and supports only sun7i. These changes are not useful by themselves but are split out to make the patch sizes more manageable. As well as the following signed-off-by the sunxi branch shows commits to these files authored by the following: Alejandro Mery