Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-21 Thread Prafulla Wadaskar
> -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: 21 March 2012 16:27 > To: Prafulla Wadaskar > Cc: Luka Perkov; u-boot@lists.denx.de; drea...@doukki.net; Wolfgang > Denk > Subject: Re: [U-Boot] [PATCH v2] add new board nas62x0 >

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-21 Thread Marek Vasut
Dear Prafulla Wadaskar, > > -Original Message- > > From: Marek Vasut [mailto:ma...@denx.de] > > Sent: 21 March 2012 15:33 > > To: Prafulla Wadaskar > > Cc: Luka Perkov; u-boot@lists.denx.de; drea...@doukki.net; Wolfgang > > Denk > > Subject: Re:

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-21 Thread Prafulla Wadaskar
> -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: 21 March 2012 15:33 > To: Prafulla Wadaskar > Cc: Luka Perkov; u-boot@lists.denx.de; drea...@doukki.net; Wolfgang > Denk > Subject: Re: [U-Boot] [PATCH v2] add new board nas62x0 > > Dear

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-21 Thread Marek Vasut
Dear Prafulla Wadaskar, > > -Original Message- > > From: Marek Vasut [mailto:ma...@denx.de] > > Sent: 21 March 2012 12:52 > > To: Luka Perkov > > Cc: u-boot@lists.denx.de; drea...@doukki.net; Wolfgang Denk; Prafulla > > Wadaskar > > Subject: Re:

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-21 Thread Prafulla Wadaskar
> -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: 21 March 2012 12:52 > To: Luka Perkov > Cc: u-boot@lists.denx.de; drea...@doukki.net; Wolfgang Denk; Prafulla > Wadaskar > Subject: Re: [U-Boot] [PATCH v2] add new board nas62x0 > > Dear L

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-21 Thread Marek Vasut
Dear Luka Perkov, > Hi Marek, > > On Tue, Mar 20, 2012 at 07:48:05AM +0100, Marek Vasut wrote: > > > > > > > +#define CONFIG_SKIP_LOWLEVEL_INIT/* disable board > > > > > > > lowlevel_init > > > > > > > > */ > > > > > > > > > > Are you sure you want to skip lowlevel init? It'll break cac

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-20 Thread Luka Perkov
Hi Marek, On Tue, Mar 20, 2012 at 07:48:05AM +0100, Marek Vasut wrote: > > > > > > +#define CONFIG_SKIP_LOWLEVEL_INIT /* disable board lowlevel_init > > > > > > */ > > > > > > > > Are you sure you want to skip lowlevel init? It'll break cache setup > > > > > etc. I believe. > > > > > > > > I w

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-20 Thread Marek Vasut
Dear DrEagle, > Hi Luka, > > Le 19/03/2012 16:50, Marek Vasut a écrit : > > Dear Luka Perkov, > > > >> Hi Marek, > >> > >> On Sun, Mar 18, 2012 at 04:15:53PM +0100, Marek Vasut wrote: > + * Copyright (C) 2011 G??rald Kerma > >>> > >>> Can you please fix your name here? > >> > >> I think

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-20 Thread DrEagle
Hi Luka, Le 19/03/2012 16:50, Marek Vasut a écrit : > Dear Luka Perkov, > >> Hi Marek, >> >> On Sun, Mar 18, 2012 at 04:15:53PM +0100, Marek Vasut wrote: + * Copyright (C) 2011 G??rald Kerma >>> >>> Can you please fix your name here? >> >> I think your mail agent is not displaying UTF8 char

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-19 Thread Marek Vasut
Dear Luka Perkov, > Hi Marek, > > On Mon, Mar 19, 2012 at 04:50:52PM +0100, Marek Vasut wrote: > > > > > +#define IB62x0_OE_LOW(~(0)) > > > > > +#define IB62x0_OE_HIGH (~(0)) > > > > > > > > Fix this constant please (0x) and remove those parenthesis > > > >

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-19 Thread Luka Perkov
Hi Marek, On Mon, Mar 19, 2012 at 04:50:52PM +0100, Marek Vasut wrote: > > > > +#define IB62x0_OE_LOW (~(0)) > > > > +#define IB62x0_OE_HIGH (~(0)) > > > > > > Fix this constant please (0x) and remove those parenthesis ... > > > btw OE_HIGH and OE_LOW have both the same v

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-19 Thread Marek Vasut
Dear Luka Perkov, > Hi Marek, > > On Sun, Mar 18, 2012 at 04:15:53PM +0100, Marek Vasut wrote: > > > + * Copyright (C) 2011 G??rald Kerma > > > > Can you please fix your name here? > > I think your mail agent is not displaying UTF8 characters correctly. If > this is a problem we could change i

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-18 Thread Luka Perkov
Hi Marek, On Sun, Mar 18, 2012 at 04:15:53PM +0100, Marek Vasut wrote: > > + * Copyright (C) 2011 G??rald Kerma > > Can you please fix your name here? I think your mail agent is not displaying UTF8 characters correctly. If this is a problem we could change it if Gerald is ok with that. Nobody e

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-18 Thread Marek Vasut
Dear Luka Perkov, > Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220 boards. > > Only difference between boards is number of SATA ports. By default we > use only one SATA port. [...] > diff --git a/board/Marvell/ib62x0/ib62x0.h b/board/Marvell/ib62x0/ib62x0.h > new file mode 100

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-18 Thread Wolfgang Denk
Dear Luka Perkov, In message <20120317234054.ga21...@w500.lan> you wrote: > > Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220 boards. Just a tiny detail... ... > +/* > + * Version number information > + */ > +#ifdef CONFIG_BOARD_IS_IB_NAS6210 > +# define CONFIG_IDENT_STRING " Ra

Re: [U-Boot] [PATCH v2] add new board nas62x0

2012-03-18 Thread Luka Perkov
On Sun, Mar 18, 2012 at 12:40:54AM +0100, Luka Perkov wrote: > Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220 boards. > > Only difference between boards is number of SATA ports. By default we > use only one SATA port. Sorry wrong commit message. Please use this: Add support for

[U-Boot] [PATCH v2] add new board nas62x0

2012-03-18 Thread Luka Perkov
Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220 boards. Only difference between boards is number of SATA ports. By default we use only one SATA port. Signed-off-by: Luka Perkov Signed-off-by: Gerald Kerma --- Changes from version v1: * use tools/checkpatch.pl to locate patch