Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-06 Thread Albert ARIBAUD
Hi Aneesh, Le 05/08/2011 17:07, Aneesh V a écrit : > Hi Albert, > > On Monday 01 August 2011 04:48 PM, Aneesh V wrote: >> c2dd0d45540397704de9b13287417d21049d34c6 added dcache_enable() >> to board_init_r(). This enables d-cache for all ARM boards. >> As a result some of the arm boards that are not

Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-05 Thread Aneesh V
Hi Albert, On Monday 01 August 2011 04:48 PM, Aneesh V wrote: > c2dd0d45540397704de9b13287417d21049d34c6 added dcache_enable() > to board_init_r(). This enables d-cache for all ARM boards. > As a result some of the arm boards that are not cache-ready > are broken. Revert this change and allow plat

Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-02 Thread Albert ARIBAUD
Le 02/08/2011 16:35, Jason Liu a écrit : > Hi, Albert, > > 2011/8/2 Albert ARIBAUD: >> Hi Jason, >> >> Le 01/08/2011 18:33, Jason Liu a écrit : >> >>> Maybe there will be many many duplicated code like this, do you wish that? >> >> I don't think this will or should be duplicated for each ARM board;

Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-02 Thread Jason Liu
Hi, Albert, 2011/8/2 Albert ARIBAUD : > Hi Jason, > > Le 01/08/2011 18:33, Jason Liu a écrit : > >> Maybe there will be many many duplicated code like this, do you wish that? > > I don't think this will or should be duplicated for each ARM board; more > like suplicated by SoC, or more precisely, b

Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-01 Thread Albert ARIBAUD
Hi Jason, Le 01/08/2011 18:33, Jason Liu a écrit : > Maybe there will be many many duplicated code like this, do you wish that? I don't think this will or should be duplicated for each ARM board; more like suplicated by SoC, or more precisely, by ARM implementation (i.e., one cache handling fo

Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-01 Thread Wolfgang Denk
Dear Jason Liu, In message you wrote: > > > What about the following change? > > > > #ifndef CONFIG_SYS_DCACHE_OFF > >dcache_enable(); > > #else > > puts("WARNING: Caches not enabled\n"); > > #endif > > Or better: > > #ifdef CONFIG_SYS_DCACHE_ON > dcache_enable(); > #els

Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-01 Thread Jason Liu
2011/8/2 Jason Liu : > Hi, Aneesh, > > 2011/8/1 Aneesh V : >> c2dd0d45540397704de9b13287417d21049d34c6 added dcache_enable() >> to board_init_r(). This enables d-cache for all ARM boards. >> As a result some of the arm boards that are not cache-ready >> are broken. Revert this change and allow plat

Re: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-01 Thread Jason Liu
Hi, Aneesh, 2011/8/1 Aneesh V : > c2dd0d45540397704de9b13287417d21049d34c6 added dcache_enable() > to board_init_r(). This enables d-cache for all ARM boards. > As a result some of the arm boards that are not cache-ready > are broken. Revert this change and allow platform code to > take the decisi

[U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

2011-08-01 Thread Aneesh V
c2dd0d45540397704de9b13287417d21049d34c6 added dcache_enable() to board_init_r(). This enables d-cache for all ARM boards. As a result some of the arm boards that are not cache-ready are broken. Revert this change and allow platform code to take the decision on d-cache enabling. Also add some docu