Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-07 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <4c59cf1b.6050...@free.fr> you wrote: > > Wolfgang, would it be allowable for mvsata_ide to use macros intended > for cmd_ide? I see no problems with that, so yes from me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk &

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-05 Thread Albert ARIBAUD
Le 05/08/2010 07:27, Prafulla Wadaskar a écrit : >> Wolfgang, would it be allowable for mvsata_ide to use macros intended >> for cmd_ide? > > I don't think there will be any issue, let's wait for Wolfgang's feedback > > Regards.. > Prafulla . . I'll push a V7 of the patch and see if Wolfgang NAKs

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-04 Thread Prafulla Wadaskar
> -Original Message- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Thursday, August 05, 2010 1:34 AM > To: Albert ARIBAUD > Cc: Prafulla Wadaskar; u-boot@lists.denx.de; Prabhanjan > Sarnaik; Ashish Karkare; tanmay.upadh...@einfochips.com > Subject: Re: [PATCH V5 4/4] e

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-04 Thread Prafulla Wadaskar
> -Original Message- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Thursday, August 05, 2010 2:06 AM > To: Prafulla Wadaskar; Wolfgang Denk > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; > prabhan...@theia.denx.de; tanmay.upadh...@einfochips.com > Subj

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-04 Thread Albert ARIBAUD
Some thoughts, and then a question for Wolfgang regarding IDE config macros Le 04/08/2010 08:08, Prafulla Wadaskar a écrit : > I have two more suggestion, > 1. put ide_preinit function in mvsata driver, define CONFIG_IDE_PREINIT in > board config file This could help reducing the source code si

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-04 Thread Albert ARIBAUD
Le 04/08/2010 09:23, Albert ARIBAUD a écrit : > Le 04/08/2010 08:08, Prafulla Wadaskar a écrit : >> 3. Instead of adding fixed 41/50 usec delay between the writes to >> Scontrol It would be good if you can check/poll some status bit >> associated with IDE controller, this will make mvsata driv

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-04 Thread Albert ARIBAUD
Le 04/08/2010 08:08, Prafulla Wadaskar a écrit : > > >> -Original Message- >> From: Prafulla Wadaskar >> Sent: Tuesday, August 03, 2010 5:40 PM >> To: 'Albert ARIBAUD' >> Cc: u-boot@lists.denx.de; tanmay.upadh...@einfochips.com; >> Prabhanjan Sarnaik; Ashish Karkare >> Subject: RE: [PATCH

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-03 Thread Prafulla Wadaskar
> -Original Message- > From: Prafulla Wadaskar > Sent: Tuesday, August 03, 2010 5:40 PM > To: 'Albert ARIBAUD' > Cc: u-boot@lists.denx.de; tanmay.upadh...@einfochips.com; > Prabhanjan Sarnaik; Ashish Karkare > Subject: RE: [PATCH V5 4/4] edminiv2: add mvsata_ide and > cmd_ide support

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-03 Thread Prafulla Wadaskar
> -Original Message- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Tuesday, August 03, 2010 5:32 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; tanmay.upadh...@einfochips.com > Subject: Re: [PATCH V5 4/4] edminiv2: add mvsata_ide and > cmd_ide support > > (add

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-03 Thread Albert ARIBAUD
(adding Tanmay who might be interested in the OpenOCD init sequence issue) Le 02/08/2010 08:13, Albert ARIBAUD a écrit : Hi, Le 02/08/2010 05:35, Prafulla Wadaskar a écrit : I tried tweaking MPP setup for SATA related stuff, it's multiplexed with UART and other I/Os (NAND), What I observed:

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-01 Thread Albert ARIBAUD
Hi, Le 02/08/2010 05:35, Prafulla Wadaskar a écrit : > I tried tweaking MPP setup for SATA related stuff, it's multiplexed with UART > and other I/Os (NAND), > What I observed: if I boot kernel with sata support, kernel sata driver works > properly and I can detect and use IDE devices. > > So I

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-01 Thread Prafulla Wadaskar
> -Original Message- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Sunday, August 01, 2010 11:05 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH V5 4/4] edminiv2: add mvsata_ide and > cmd_ide support > > Hi Prafulla et al., > > Le 01/08/20

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-01 Thread Albert ARIBAUD
Hi Prafulla et al., Le 01/08/2010 18:48, Prafulla Wadaskar a écrit : > > >> -Original Message- >> From: Albert ARIBAUD [mailto:albert.arib...@free.fr] >> Sent: Friday, July 23, 2010 4:21 PM >> To: Prafulla Wadaskar >> Cc: u-boot@lists.denx.de >> Subject: Re: [PATCH V5 4/4] edminiv2: add mv

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-08-01 Thread Prafulla Wadaskar
> -Original Message- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Friday, July 23, 2010 4:21 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH V5 4/4] edminiv2: add mvsata_ide and > cmd_ide support ...snip... > > > Secondly I tried to genera

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-07-23 Thread Albert ARIBAUD
Hi Prafulla et al., Le 21/07/2010 12:26, Prafulla Wadaskar a écrit : >> +#define __io >> + > > Pls move this below inside #ifdef CONFIG_CMD_IDE Wilco. >> +#define CONFIG_CMD_IDE >> +#define CONFIG_DOS_PARTITION >> +#define CONFIG_CMD_EXT2 > > It's good if you use #ifdef here and pull all IDE sp

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-07-21 Thread Prafulla Wadaskar
> -Original Message- > From: u-boot-boun...@lists.denx.de > [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Albert Aribaud > Sent: Tuesday, July 13, 2010 5:33 PM > To: u-boot@lists.denx.de > Subject: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and > cmd

Re: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-07-19 Thread Prafulla Wadaskar
Albert Aribaud [albert.arib...@free.fr] Sent: Tuesday, July 13, 2010 5:32 PM To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support Add mvsata_ide port 1 initialization in edminiv2 init code Add mvsata_ide and cmd_ide configuration in edminiv2 config

[U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

2010-07-13 Thread Albert Aribaud
Add mvsata_ide port 1 initialization in edminiv2 init code Add mvsata_ide and cmd_ide configuration in edminiv2 config Signed-off-by: Albert Aribaud --- board/LaCie/edminiv2/edminiv2.c |7 ++ include/configs/edminiv2.h | 46 ++- 2 files changed,