Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Stefano Babic
On 13/12/2011 19:45, Scott Wood wrote: > On 12/13/2011 12:33 PM, Tom Rini wrote: >> So, we have various characteristics of the NAND chip that need to be >> described for SPL. Today we do CONFIG_SYS_NAND... but they're >> unchanged in every implementation and are calculated from other >> per-board

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Tom Rini
On Tue, Dec 13, 2011 at 11:45 AM, Scott Wood wrote: > On 12/13/2011 12:33 PM, Tom Rini wrote: >> So, we have various characteristics of the NAND chip that need to be >> described for SPL.  Today we do CONFIG_SYS_NAND... but they're >> unchanged in every implementation and are calculated from other

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Tom Rini
On Tue, Dec 13, 2011 at 11:52 AM, Scott Wood wrote: > On 12/13/2011 12:04 PM, Tom Rini wrote: >> On Tue, Dec 13, 2011 at 10:50 AM, Stefano Babic wrote: >>> Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM >>> which is likely to contain already loaded data. >>> The patch sa

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Scott Wood
On 12/13/2011 12:04 PM, Tom Rini wrote: > On Tue, Dec 13, 2011 at 10:50 AM, Stefano Babic wrote: >> Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM >> which is likely to contain already loaded data. >> The patch saves the oob data and the ecc on the stack replacing >> the

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread stefano babic
Am 13/12/2011 19:18, schrieb Wolfgang Denk: > Dear Tom, > > In message > you > wrote: >> >> Which covers the omap config file changes. Assuming Wolfgang doesn't >> see a problem with using SYS_... in defines, Scott, do you want this >> via your tree (in /next) since it's NAND or in mine since

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Scott Wood
On 12/13/2011 11:50 AM, Stefano Babic wrote: > /* Pick the ECC bytes out of the oob data */ > - for (i = 0; i < CONFIG_SYS_NAND_ECCTOTAL; i++) > + for (i = 0; i < (SYS_NAND_ECCTOTAL); i++) > ecc_code[i] = oob_data[nand_ecc_pos[i]]; [snip] > @@ -213,10 +203,10 @@ static i

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Scott Wood
On 12/13/2011 12:33 PM, Tom Rini wrote: > So, we have various characteristics of the NAND chip that need to be > described for SPL. Today we do CONFIG_SYS_NAND... but they're > unchanged in every implementation and are calculated from other > per-board values. So to avoid duplication in each conf

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Tom Rini
On Tue, Dec 13, 2011 at 11:18 AM, Wolfgang Denk wrote: > Dear Tom, > > In message > you > wrote: >> >> Which covers the omap config file changes.  Assuming Wolfgang doesn't >> see a problem with using SYS_... in defines, Scott, do you want this >> via your tree (in /next) since it's NAND or in

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Wolfgang Denk
Dear Tom, In message you wrote: > > Which covers the omap config file changes. Assuming Wolfgang doesn't > see a problem with using SYS_... in defines, Scott, do you want this > via your tree (in /next) since it's NAND or in mine since it's TI > boards? Assuming you don't see any problems of c

Re: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Tom Rini
On Tue, Dec 13, 2011 at 10:50 AM, Stefano Babic wrote: > Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM > which is likely to contain already loaded data. > The patch saves the oob data and the ecc on the stack replacing > the fixed address in RAM. > > Signed-off-by: Stefa

[U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack

2011-12-13 Thread Stefano Babic
Currently nand_spl_simple puts it's temp data at 0x1 offset in SDRAM which is likely to contain already loaded data. The patch saves the oob data and the ecc on the stack replacing the fixed address in RAM. Signed-off-by: Stefano Babic CC: Ilya Yanok CC: Scott Wood CC: Tom Rini CC: Simon S