On 13/12/2011 19:45, Scott Wood wrote: > On 12/13/2011 12:33 PM, Tom Rini wrote: >> So, we have various characteristics of the NAND chip that need to be >> described for SPL. Today we do CONFIG_SYS_NAND... but they're >> unchanged in every implementation and are calculated from other >> per-board values. So to avoid duplication in each config file, we >> drop them from there and use them only locally #define calculate them >> in the file that needs them. Since they're still system specific >> values, I had suggested calling them SYS_... but I wasn't sure what >> the right namespace is. I had a recollection that using CONFIG_ >> outside of config files was a bad idea. > > These symbols are not in a header file -- how about just plain ECCSTEPS > and ECCTOTAL?
Ok, agree - done in V4. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot