Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-15 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201203130547.30788.ma...@denx.de> you wrote: > > > I have to admit that I never understood the fuzz about being able to > > > boot zImages. I see more disadvanatges than advantages for this, but > > > some ARM people go frenzy when this top

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-15 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Graeme Russ, > > In message you wrote: > > > Frankly: I see no benefit in adding x86 support. > > > > Ouch! - Do you mean in common code or in general? > > I mean: I see no benefit in adding support for a "bootz" command for > x86 systems - and I don't see it on Pow

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-15 Thread Wolfgang Denk
Dear Marek Vasut, In message <201203130547.30788.ma...@denx.de> you wrote: > > > I have to admit that I never understood the fuzz about being able to > > boot zImages. I see more disadvanatges than advantages for this, but > > some ARM people go frenzy when this topic pops up - see recent > > dis

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-15 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > > Frankly: I see no benefit in adding x86 support. > > Ouch! - Do you mean in common code or in general? I mean: I see no benefit in adding support for a "bootz" command for x86 systems - and I don't see it on Power Architecture either. > > I see n

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Graeme Russ
Hi Marek, On Tue, Mar 13, 2012 at 3:50 PM, Marek Vasut wrote: > Dear Wolfgang Denk, > >> Dear Marek Vasut, >> >> In message <201203130113.19092.ma...@denx.de> you wrote: >> > > + zi = (struct zimage_header *)images->ep; >> > > + >> > > + if (zi->zi_magic != LINUX_ARM_ZIMAGE_MAGIC) { >> > >> > Thi

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201203130113.19092.ma...@denx.de> you wrote: > > > + zi = (struct zimage_header *)images->ep; > > > + > > > + if (zi->zi_magic != LINUX_ARM_ZIMAGE_MAGIC) { > > > > This gave me an idea ... this might be how to check for zImage inside > > bo

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Graeme Russ, > > In message you wrote: > > While we are on the subject - Do either of you think support for the x86 > > zimage/bzImage format should end up here in common code? Not that the x86 > > The common coe should be architecture-neutral. It might cann > archit

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Graeme Russ
Hi Wolfgang, On Tue, Mar 13, 2012 at 3:30 PM, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message > you > wrote: >> >> While we are on the subject - Do either of you think support for the x86 >> zimage/bzImage format should end up here in common code? Not that the x86 > > The common coe sh

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > While we are on the subject - Do either of you think support for the x86 > zimage/bzImage format should end up here in common code? Not that the x86 The common coe should be architecture-neutral. It might cann architecture-specific routines, which m

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Wolfgang Denk
Dear Marek Vasut, In message <201203130113.19092.ma...@denx.de> you wrote: > > > + zi = (struct zimage_header *)images->ep; > > + > > + if (zi->zi_magic != LINUX_ARM_ZIMAGE_MAGIC) { > > This gave me an idea ... this might be how to check for zImage inside bootm > and > be done with it. Sim

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Mike Frysinger
On Monday 12 March 2012 17:34:21 Marek Vasut wrote: > common/Makefile|1 + > common/cmd_bootm.c | 29 + > common/cmd_bootz.c | 175 > include/image.h|8 +++ new commands should be in include/config_cmd_all.h and the top level README > --- /dev/null > +++ b/common/cmd_bo

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Graeme Russ
Hi Marek, Wolfgang, On Tue, Mar 13, 2012 at 11:13 AM, Marek Vasut wrote: > Dear Wolfgang Denk, > >> >> While we are at it: >> >> +     zi = (struct zimage_header *)images->ep; >> + >> +     if (zi->zi_magic != LINUX_ARM_ZIMAGE_MAGIC) { > > This gave me an idea ... this might be how to check for z

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > btw - there is no need to full-quote. > > In message <201203122308.54249.ma...@denx.de> you wrote: > > > I have but a few formal questions / issues. > > > > I had a dilemma about the image.[ch] indeed. I was quite unsure where to > > put those, can yo

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Wolfgang Denk
Dear Marek Vasut, btw - there is no need to full-quote. In message <201203122308.54249.ma...@denx.de> you wrote: > > > I have but a few formal questions / issues. > > I had a dilemma about the image.[ch] indeed. I was quite unsure where to put > those, can you suggest proper location? I didn't

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1331588061-21546-1-git-send-email-ma...@denx.de> you wrote: > > This command boots Linux zImage from where the zImage is loaded to. > > Passing initrd and fdt is supported. > > I have but a few formal questions / issues. I had a dilemma ab

Re: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Wolfgang Denk
Dear Marek Vasut, In message <1331588061-21546-1-git-send-email-ma...@denx.de> you wrote: > > This command boots Linux zImage from where the zImage is loaded to. Passing > initrd and fdt is supported. I have but a few formal questions / issues. ... > --- a/common/cmd_bootm.c > +++ b/common/cmd_

[U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

2012-03-12 Thread Marek Vasut
From: Marek Vasut This command boots Linux zImage from where the zImage is loaded to. Passing initrd and fdt is supported. Tested on i.MX28 based DENX M28EVK Tested on PXA270 based Voipac PXA270. Signed-off-by: Marek Vasut Cc: Tom Warren Cc: albert.u.b...@aribaud.net Cc: aflem...@gmail.com, C