Dear Marek Vasut,
btw - there is no need to full-quote.
In message <201203122308.54249.ma...@denx.de> you wrote:
>
> > I have but a few formal questions / issues.
>
> I had a dilemma about the image.[ch] indeed. I was quite unsure where to put
> those, can you suggest proper location? I didn't want to create new file only
> for that matter.
Sorry, I have no good idea either.
If you omit comment header and includes, common/cmd_bootz.c adds less
than 10% to common/cmd_bootm.c - unless we extrace more common code
from other boot* commands, you might even add it to cmd_bootm.c (with
#ifdef's).
While we are at it:
+ zi = (struct zimage_header *)images->ep;
+
+ if (zi->zi_magic != LINUX_ARM_ZIMAGE_MAGIC) {
Do we have to care about endianess here?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"Now here's something you're really going to like!"
- Rocket J. Squirrel
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
