Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Mike Frysinger
On Tuesday, August 30, 2011 19:39:20 Graeme Russ wrote: > Another gd related thought - Is it safe to assume that gd will be cleared? > I hope so, as the pre-buffer console assumes gd->precon_buf_idx is > initially zero. i'm pretty sure you can. the Blackfin arch certainly memset's it to 0. -mike

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Graeme Russ
Hi Wolfgang On Wed, Aug 31, 2011 at 9:00 AM, Graeme Russ wrote: > Hi Simon, Mike, Wolfgang, > > On Wed, Aug 31, 2011 at 7:02 AM, Simon Glass wrote: >> Hi Wolfgang, >> >> On Tue, Aug 30, 2011 at 1:57 PM, Wolfgang Denk wrote: >>> Dear Simon Glass, >>> >>> In message >>> you >>> wrote: [s

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Graeme Russ
Hi Simon, Mike, Wolfgang, On Wed, Aug 31, 2011 at 7:02 AM, Simon Glass wrote: > Hi Wolfgang, > > On Tue, Aug 30, 2011 at 1:57 PM, Wolfgang Denk wrote: >> Dear Simon Glass, >> >> In message >> you >> wrote: >>> >>> In case it is interesting (which may be unlikely) here is the code >>> generate

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Simon Glass
Hi Wolfgang, On Tue, Aug 30, 2011 at 1:57 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> In case it is interesting (which may be unlikely) here is the code >> generated by my compiler (common code stripped) for your example, and > > Which architecture / which

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > In case it is interesting (which may be unlikely) here is the code > generated by my compiler (common code stripped) for your example, and Which architecture / which compiler is this? > one I added. It seems that % makes it worry about sign. Indeed

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Simon Glass
Hi Wolfgang, On Tue, Aug 30, 2011 at 1:08 PM, Wolfgang Denk wrote: > Dear Mike Frysinger, > > In message <201108301558.08010.vap...@gentoo.org> you wrote: >> >> > Please see my previous posting >> > (http://article.gmane.org/gmane.comp.boot-loaders.u-boot/106810) >> > >> > I don't think 3 additio

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201108301558.08010.vap...@gentoo.org> you wrote: > > > Please see my previous posting > > (http://article.gmane.org/gmane.comp.boot-loaders.u-boot/106810) > > > > I don't think 3 additional addembler instructions really play a big > > role here. > > i'm pretty sur

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Simon Glass
Hi Wolfgang, On Tue, Aug 30, 2011 at 12:52 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> > ... >> > +#define CIRC_BUF_IDX(idx) ((idx) % CONFIG_PRE_CON_BUF_SZ) >> >> The division here sticks in the craw, but unless we go with > > Does it?  Why? Only because of t

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Mike Frysinger
On Tuesday, August 30, 2011 15:52:38 Wolfgang Denk wrote: > Simon Glass wrote: > > > +#define CIRC_BUF_IDX(idx) ((idx) % CONFIG_PRE_CON_BUF_SZ) > > > > The division here sticks in the craw, but unless we go with > > Does it? Why? > > > CONFIG_PRE_CON_BUF_SZ_LOG2 then I don't see an easy way aro

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > ... > > +#define CIRC_BUF_IDX(idx) ((idx) % CONFIG_PRE_CON_BUF_SZ) > > The division here sticks in the craw, but unless we go with Does it? Why? > CONFIG_PRE_CON_BUF_SZ_LOG2 then I don't see an easy way around it, and > since this is serial output w

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Simon Glass
Hi Graeme, On Tue, Aug 30, 2011 at 5:49 AM, Graeme Russ wrote: > Allow redirection of console output prior to console initialisation to a > temporary buffer. > > To enable this functionality, the board configuration file must define: >  - CONFIG_PRE_CONSOLE_BUFFER - Enable pre-console buffer >  -

Re: [U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Mike Frysinger
On Tuesday, August 30, 2011 08:49:41 Graeme Russ wrote: > - if (!gd->have_console) > + if (!gd->have_console) { > +#ifdef CONFIG_PRE_CONSOLE_BUFFER > + pre_console_putc(c); > +#endif > return; > + } add inline stubs for the pre_console_xxx helpers and you can

[U-Boot] [PATCH V2] console: Implement pre-console buffer

2011-08-30 Thread Graeme Russ
Allow redirection of console output prior to console initialisation to a temporary buffer. To enable this functionality, the board configuration file must define: - CONFIG_PRE_CONSOLE_BUFFER - Enable pre-console buffer - CONFIG_PRE_CON_BUF_ADDR - Base address of pre-console buffer - CONFIG_PRE_