Hi Wolfgang, On Tue, Aug 30, 2011 at 12:52 PM, Wolfgang Denk <w...@denx.de> wrote: > Dear Simon Glass, > > In message > <CAPnjgZ1fXCCFDcwCWgZD7H-siVEV-H+Ks5TPeiT=ngs743f...@mail.gmail.com> you > wrote: >> > ... >> > +#define CIRC_BUF_IDX(idx) ((idx) % CONFIG_PRE_CON_BUF_SZ) >> >> The division here sticks in the craw, but unless we go with > > Does it? Why?
Only because of the division. But as Mike mentions later, the compiler will avoid it for powers of two. So all is well. > >> CONFIG_PRE_CON_BUF_SZ_LOG2 then I don't see an easy way around it, and >> since this is serial output we can't honestly claim to worry much >> about performance. > > Please see my previous posting > (http://article.gmane.org/gmane.comp.boot-loaders.u-boot/106810) > > I don't think 3 additional addembler instructions really play a big > role here. Yes I saw it, thanks. Regards, Simon > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de > Every time history repeats itself the price goes up. > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
