Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-11-19 Thread Peter Tyser
Hi Jon, On Wed, 2008-11-19 at 11:29 -0600, Jon Loeliger wrote: > Peter Tyser wrote: > > >>> We have the standard Freescale DDR printf's turned into debug as that is > >>> much, much more verbose than the output above. > >> Indeed :-( > > Hrm. Out of curiosity, which printf()s do you find noisy?

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-11-19 Thread Jon Loeliger
Peter Tyser wrote: >>> We have the standard Freescale DDR printf's turned into debug as that is >>> much, much more verbose than the output above. >> Indeed :-( Hrm. Out of curiosity, which printf()s do you find noisy? > Many boards I look at don't use TABS. In particular Freescale reference >

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-11-18 Thread Wolfgang Denk
Dear Peter Tyser, In message <[EMAIL PROTECTED]> you wrote: > > > You indent the lines by a single space, but they should be indented by > > a TAB. > > Many boards I look at don't use TABS. In particular Freescale reference > platforms. Many boards even have different amounts of spaces:) I don

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-11-18 Thread Peter Tyser
On Tue, 2008-11-18 at 23:20 +0100, Wolfgang Denk wrote: > Dear Peter Tyser, > > In message <[EMAIL PROTECTED]> you wrote: > > > > This information is very useful to a customer and doesn't add much as > > far as output. No newlines at least. The output also prints > > information which is configu

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-11-18 Thread Wolfgang Denk
Dear Peter Tyser, In message <[EMAIL PROTECTED]> you wrote: > > This information is very useful to a customer and doesn't add much as > far as output. No newlines at least. The output also prints > information which is configurable. I think giving the user feedback > about how they have the boa

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-11-18 Thread Peter Tyser
On Tue, 2008-11-18 at 22:44 +0100, Wolfgang Denk wrote: > Dear Peter Tyser, > > In message <[EMAIL PROTECTED]> you wrote: > > > > Initial support for Extreme Engineering Solutions XPedite5370 - > > a MPC8572-based 3U VPX single board computer with a PMC/XMC > > site. > ... > > > diff --git a/boa

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-11-18 Thread Wolfgang Denk
Dear Peter Tyser, In message <[EMAIL PROTECTED]> you wrote: > > Initial support for Extreme Engineering Solutions XPedite5370 - > a MPC8572-based 3U VPX single board computer with a PMC/XMC > site. ... > diff --git a/board/xes/common/fsl_85xx_ddr.c b/board/xes/common/fsl_85xx_ddr.c > new file mo

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-10-24 Thread Peter Tyser
> > board/xes/common/fsl_8572_clk.c | 51 +++ > > board/xes/common/fsl_85xx_ddr.c | 93 ++ > > board/xes/common/fsl_85xx_pci.c | 287 + > > > Could you take a look at the new PCI code Kumar submitted (which I > just applied), and rework the board code to imit

Re: [U-Boot] [PATCH 3/3] XPedite5370 board support

2008-10-24 Thread Andy Fleming
On Thu, Oct 23, 2008 at 5:23 PM, Peter Tyser <[EMAIL PROTECTED]> wrote: > Initial support for Extreme Engineering Solutions XPedite5370 - > a MPC8572-based 3U VPX single board computer with a PMC/XMC > site. > > Signed-off-by: Peter Tyser <[EMAIL PROTECTED]> > --- > MAINTAINERS