Hi Jon,
On Wed, 2008-11-19 at 11:29 -0600, Jon Loeliger wrote:
> Peter Tyser wrote:
>
> >>> We have the standard Freescale DDR printf's turned into debug as that is
> >>> much, much more verbose than the output above.
> >> Indeed :-(
>
> Hrm. Out of curiosity, which printf()s do you find noisy?
There are some printf()s related to chip/bank interleaving in
cpu/mpc8xxx/main.c:
printf("\nMemory controller interleaving enabled: ");
printf("Cache-line interleaving!\n");
printf("Bank(chip-select) interleaving enabled: ");
printf("CS0+CS1 and CS2+CS3\n");
I do think the info is useful, just a bit wordy (and are the !'s
necessary:). With those printfs in main.c enabled, there could be 4
printf lines on bootup related to DDR - clocking, size, and 2 for
interleaving.
> > Many boards I look at don't use TABS. In particular Freescale reference
> > platforms. Many boards even have different amounts of spaces:) I don't
> > see the value of indentation in this case as it doesn't increase
> > readability and just makes already long lines even longer.
>
> Really? Which ones? We should clean those up!
The MPC8548CDS and MPC8349EMDS headers were the 2 I looked at that had
inconsistent spacing, but I didn't look all that thoroughly. An 'ls
include/configs/MPC* | xargs grep -i "^\ \+\""' should show the boards
which don't use proper indentation for the environment variables in
general.
So much cleanup, so little time:)
Best,
Peter
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
