Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-19 Thread Stefano Babic
On 30/05/2012 07:43, Marek Vasut wrote: > This function can be overridden at run-time and allows implementors > of new boards based on the i.MX28 chip to fine-tune the memory params. > It is possible to write into the dram_vals array because when the SPL > runs, it is located SRAM. Therefore the lo

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-18 Thread Marek Vasut
Dear Stefano Babic, > On 18/06/2012 17:43, Marek Vasut wrote: > >> So ... what do you expect me to do? The register is called HW_DRAM_CTL29 > >> (very descriptive) ... do you want me to create a file full of > >> HW_DRAM_CTLnn ? > > > > Would adding such comment be enough to satisfy you? (In slig

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-18 Thread Stefano Babic
On 18/06/2012 17:43, Marek Vasut wrote: >> >> So ... what do you expect me to do? The register is called HW_DRAM_CTL29 >> (very descriptive) ... do you want me to create a file full of >> HW_DRAM_CTLnn ? > > Would adding such comment be enough to satisfy you? (In slightly more polite > manner I

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-18 Thread Marek Vasut
Dear Stefano Babic, > > On 18/06/2012 16:23, Marek Vasut wrote: > > > Dear Fabio Estevam, > > > > > >> Hi Marek, > > >> > > >> On Thu, May 31, 2012 at 3:45 PM, Marek Vasut wrote: > > >>> Call this or similar in your spl_boot.c to adjust the DRAM > > >>> configuration. Actually I think even the

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-18 Thread Marek Vasut
Dear Stefano Babic, > On 18/06/2012 16:23, Marek Vasut wrote: > > Dear Fabio Estevam, > > > >> Hi Marek, > >> > >> On Thu, May 31, 2012 at 3:45 PM, Marek Vasut wrote: > >>> Call this or similar in your spl_boot.c to adjust the DRAM > >>> configuration. Actually I think even the following value

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-18 Thread Stefano Babic
On 18/06/2012 16:23, Marek Vasut wrote: > Dear Fabio Estevam, > >> Hi Marek, >> >> On Thu, May 31, 2012 at 3:45 PM, Marek Vasut wrote: >>> Call this or similar in your spl_boot.c to adjust the DRAM configuration. >>> Actually I think even the following value should fix your problem: >>> >>> void

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-18 Thread Marek Vasut
Dear Fabio Estevam, > Hi Marek, > > On Thu, May 31, 2012 at 3:45 PM, Marek Vasut wrote: > > Call this or similar in your spl_boot.c to adjust the DRAM configuration. > > Actually I think even the following value should fix your problem: > > > > void mx28_adjust_memory_params(uint32_t *dram_vals

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-06-18 Thread Fabio Estevam
Hi Marek, On Thu, May 31, 2012 at 3:45 PM, Marek Vasut wrote: > Call this or similar in your spl_boot.c to adjust the DRAM configuration. > Actually I think even the following value should fix your problem: > > void mx28_adjust_memory_params(uint32_t *dram_vals) > { >        dram_vals[0x74 >> 2]

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-05-31 Thread Marek Vasut
Dear Fabio Estevam, > Hi Marek, > > On Wed, May 30, 2012 at 2:43 AM, Marek Vasut wrote: > > This function can be overridden at run-time and allows implementors > > of new boards based on the i.MX28 chip to fine-tune the memory params. > > It is possible to write into the dram_vals array because

Re: [U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-05-31 Thread Fabio Estevam
Hi Marek, On Wed, May 30, 2012 at 2:43 AM, Marek Vasut wrote: > This function can be overridden at run-time and allows implementors > of new boards based on the i.MX28 chip to fine-tune the memory params. > It is possible to write into the dram_vals array because when the SPL > runs, it is locate

[U-Boot] [PATCH] i.MX28: Add function to adjust memory parameters

2012-05-29 Thread Marek Vasut
This function can be overridden at run-time and allows implementors of new boards based on the i.MX28 chip to fine-tune the memory params. It is possible to write into the dram_vals array because when the SPL runs, it is located SRAM. Therefore the location is writable. There is no possibility of t