Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Joris Offouga
Hi Fabio, Le 29/01/2020 à 17:10, Tom Rini a écrit : On Wed, Jan 29, 2020 at 12:59:28PM -0300, Fabio Estevam wrote: On Wed, Jan 29, 2020 at 12:35 PM Tom Rini wrote: Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few Yes, CONFIG_DM_GPIO is selected in mx7dsabresd_defconfig

Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Fabio Estevam
Hi Tom, On Wed, Jan 29, 2020 at 1:10 PM Tom Rini wrote: > Lets see. Yup, talking this all out as gotten me to seeing that yes, > your patch is correct and all we need in the Makefile. Thanks! > > Reviewed-by: Tom Rini I have just sent v2 that places it inside the ifndef CONFIG_SPL_BUILD bloc

Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Tom Rini
On Wed, Jan 29, 2020 at 12:59:28PM -0300, Fabio Estevam wrote: > On Wed, Jan 29, 2020 at 12:35 PM Tom Rini wrote: > > > Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few > > Yes, CONFIG_DM_GPIO is selected in mx7dsabresd_defconfig. OK, good. > > > other i.MX boards that a

Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Fabio Estevam
On Wed, Jan 29, 2020 at 12:35 PM Tom Rini wrote: > Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few Yes, CONFIG_DM_GPIO is selected in mx7dsabresd_defconfig. > other i.MX boards that are also broken something needs to be moved to > Kconfig / updated still. I can submit a

Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Tom Rini
On Wed, Jan 29, 2020 at 11:57:00AM -0300, Fabio Estevam wrote: > On Wed, Jan 29, 2020 at 11:55 AM Tom Rini wrote: > > > OK, why is the fix to do what you did here and NOT enable > > CONFIG_SPL_GPIO on the platform(s) in question to match the rest of > > Because mx7dsabresd_defconfig does not sup

Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Fabio Estevam
On Wed, Jan 29, 2020 at 11:55 AM Tom Rini wrote: > OK, why is the fix to do what you did here and NOT enable > CONFIG_SPL_GPIO on the platform(s) in question to match the rest of Because mx7dsabresd_defconfig does not support SPL.

Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Tom Rini
On Wed, Jan 29, 2020 at 11:41:15AM -0300, Fabio Estevam wrote: > Since commit bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL") > the CONFIG_DM_74X164 is no longer built for mx7dsabresd_defconfig, as > this target does not use CONFIG_SPL_GPIO. > > Remove such dependency and let the th

[PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

2020-01-29 Thread Fabio Estevam
Since commit bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL") the CONFIG_DM_74X164 is no longer built for mx7dsabresd_defconfig, as this target does not use CONFIG_SPL_GPIO. Remove such dependency and let the the 74X164 GPIO driver be built again. This restores Ethernet functionalit