Re: [PATCH] gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

[Tom Rini]

On Wed, Jan 29, 2020 at 11:41:15AM -0300, Fabio Estevam wrote:
> Since commit bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL")
> the CONFIG_DM_74X164 is no longer built for mx7dsabresd_defconfig, as
> this target does not use CONFIG_SPL_GPIO.
> 
> Remove such dependency and let the the 74X164 GPIO driver be built
> again.
> 
> This restores Ethernet functionality on the imx7-sdb board as the
> Ethernet reset PHY comes from a GPIO driven by a 74LV595PW I/O
> expander.
> 
> Fixes: bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL")
> Signed-off-by: Fabio Estevam <feste...@gmail.com>
> ---
>  drivers/gpio/Makefile | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index 449046b64c..aa41a24cd0 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -10,13 +10,11 @@ endif
>  obj-$(CONFIG_$(SPL_TPL_)DM_GPIO) += gpio-uclass.o
>  
>  obj-$(CONFIG_$(SPL_)DM_PCA953X)      += pca953x_gpio.o
> -ifdef CONFIG_$(SPL_TPL_)GPIO
> -obj-$(CONFIG_DM_74X164)              += 74x164_gpio.o
> -endif
>  
>  obj-$(CONFIG_AT91_GPIO)      += at91_gpio.o
>  obj-$(CONFIG_ATMEL_PIO4)     += atmel_pio4.o
>  obj-$(CONFIG_BCM6345_GPIO)   += bcm6345_gpio.o
> +obj-$(CONFIG_DM_74X164)              += 74x164_gpio.o
>  obj-$(CONFIG_INTEL_GPIO)     += intel_gpio.o
>  obj-$(CONFIG_INTEL_ICH6_GPIO)        += intel_ich6_gpio.o
>  obj-$(CONFIG_INTEL_BROADWELL_GPIO)   += intel_broadwell_gpio.o

OK, why is the fix to do what you did here and NOT enable
CONFIG_SPL_GPIO on the platform(s) in question to match the rest of
bcee8d6764f9 and make the obj- line above look like the pca953x_gpio.o
one?  Thanks!

-- 
Tom

signature.asc
Description: PGP signature