On Wed, Jan 29, 2020 at 12:59:28PM -0300, Fabio Estevam wrote: > On Wed, Jan 29, 2020 at 12:35 PM Tom Rini <tr...@konsulko.com> wrote: > > > Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few > > Yes, CONFIG_DM_GPIO is selected in mx7dsabresd_defconfig.
OK, good. > > > other i.MX boards that are also broken something needs to be moved to > > Kconfig / updated still. > > I can submit a patch moving CONFIG_DM_74X164 from > include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig. OK, please do. > > In fact, uh, there's a good bit of confusion around that line in the > > Makefile. The test on 'CONFIG_$(SPL_TPL_)GPIO' will never be true as > > there is only 'DM_GPIO' (and SPL/TPL variants) and > > 'SPL/TPL_GPIO_SUPPORT' and no 'GPIO' itself. So everyone using > > 74x164_gpio.o is broken right now. > > Yes, that's the reason I came up with this patch. > > > Do you want to take a pass at trying to unpack and fix this mess or > > should I? Thanks again! > > I am glad to fix this, but what exactly needs to be done? > > This patch plus another one that moves CONFIG_DM_74X164 from > include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig is all we > need, no? Lets see. Yup, talking this all out as gotten me to seeing that yes, your patch is correct and all we need in the Makefile. Thanks! Reviewed-by: Tom Rini <tr...@konsulko.com> -- Tom
signature.asc
Description: PGP signature
