Re: [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled

2012-04-09 Thread puneets
Dear Marek, After applying these 4 patches I don't see any alignment spew and it detects the mass storage device perfectly though I see a warning "EHCI timed out on TD - token=0x80008c80" consistently in each "usb reset". Thanx & Regards, Puneet On Monday 09 April 2012 08:42 AM, Marek Vasut

Re: [U-Boot] [PATCH v9] usb: align buffers at cacheline

2012-04-06 Thread puneets
Hi Marek, I tested on tegra2, Seaboard and didn't see these messages though see lots of messages "ERROR: v7_dcache_inval_range - stop address is not aligned - 0x3fb7c608" which are expected. PFA the logs if you can make out anything useful. Try to increase the delay in handshake(); Thanks, Pu

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-04-02 Thread puneets
Hi Marek/Tom, As I understood correctly. I would merge my changes in "denx-uboot-arm/master" as "u-boot-tegra/master", where actually I tested my patch, is pulled in "denx-uboot-arm/master". Will that work... Thanks & Regards, Puneet On Monday 02 April 2012 10:02 PM, Marek Vasut wrote: Dear

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-19 Thread puneets
Hi Marek, I adapted my patch for git://git.denx.de/u-boot-usb.git master branch. As the build for target "Seaboard" is broken once I enable USB in Seaboard.h, I am unable to test my changes on "u-boot-usb". I would have to merge lots of changes from "denx-uboot-tegra" to make it working for "u-

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-16 Thread puneets
Hi Marek, I need to remove the changes in ehci_hcd.c as per Mike's comment and adapt my patch for git://git.denx.de/u-boot-usb.git master branch. So will be sending next patch with the above changes, shortly. With this resultant patch we see warnings for few start address warnings(related to e

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-08 Thread puneets
Hi Marek, On Thursday 08 March 2012 07:42 PM, Marek Vasut wrote: Dear puneets, Hi Marek, On Thursday 08 March 2012 03:36 AM, Marek Vasut wrote: Dear puneets, Hi Mike, On Tuesday 06 March 2012 08:37 AM, Mike Frysinger wrote: * PGP Signed by an unknown key On Monday 05 March 2012 09:46:21

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-08 Thread puneets
Hi Marek, On Thursday 08 March 2012 03:36 AM, Marek Vasut wrote: Dear puneets, Hi Mike, On Tuesday 06 March 2012 08:37 AM, Mike Frysinger wrote: * PGP Signed by an unknown key On Monday 05 March 2012 09:46:21 Puneet Saxena wrote: As DMA expects the buffers to be equal and larger then cache

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-07 Thread puneets
Hi Mike, Forgot to write the link in below mail. Here is the link: http://lists.denx.de/pipermail/u-boot/2011-December/112138.html Do you want me to show a warning where I am making size as cacheline size? Thanx & Regards,, Puneet On Wednesday 07 March 2012 12:42 PM, puneets wrote: Hi

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-06 Thread puneets
Hi Mike, On Tuesday 06 March 2012 08:37 AM, Mike Frysinger wrote: * PGP Signed by an unknown key On Monday 05 March 2012 09:46:21 Puneet Saxena wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. i don't think this statement is true. DM

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-05 Thread puneets
Hi Simon, I do see only first warning on all the devices and rest of the warnings on a few mass storage device. My patch fixing these warnings is not accepted. Please see below link for further info - http://lists.denx.de/pipermail/u-boot/2012-March/119404.html IMO, these warnings spew when w

Re: [U-Boot] [PATCH v3 2/2] usb: Add CONFIG to fetch string descriptor

2012-03-05 Thread puneets
Hi Marek, On Monday 05 March 2012 06:18 PM, Marek Vasut wrote: Dear Puneet Saxena, Hi Marek, On Thursday 01 March 2012 05:15 PM, Marek Vasut wrote: Hi! Hi Marek, On Thursday 01 March 2012 02:59 AM, Marek Vasut wrote: Add "CONFIG_USB_STRING_FETCH" to fetch first string descriptor length an

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread puneets
On Friday 02 March 2012 08:11 PM, Marek Vasut wrote: On Friday 02 March 2012 07:16 PM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena --- Changes for V3: - Removed local descriptor elem

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread puneets
On Friday 02 March 2012 07:16 PM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena --- Changes for V3: - Removed local descriptor elements copy to global descriptor elements - Removed

Re: [U-Boot] [PATCH v3 1/2] usb: align buffers at cacheline

2012-03-02 Thread puneets
Hi, On Friday 02 March 2012 04:13 PM, Marek Vasut wrote: Hi, On Friday 02 March 2012 12:08 AM, Marek Vasut wrote: On Thursday 01 March 2012 03:05 AM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet

Re: [U-Boot] [PATCH v3 1/2] usb: align buffers at cacheline

2012-03-01 Thread puneets
Hi, On Friday 02 March 2012 12:08 AM, Marek Vasut wrote: On Thursday 01 March 2012 03:05 AM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena --- Changes for V2: - Use "ARCH_DMA_MINALIGN"

Re: [U-Boot] [PATCH v3 1/2] usb: align buffers at cacheline

2012-03-01 Thread puneets
On Thursday 01 March 2012 03:05 AM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena --- Changes for V2: - Use "ARCH_DMA_MINALIGN" directly - Use "ALIGN" to align size as cacheline

Re: [U-Boot] [PATCH v3 2/2] usb: Add CONFIG to fetch string descriptor

2012-03-01 Thread puneets
Hi Marek, On Thursday 01 March 2012 05:15 PM, Marek Vasut wrote: Hi! Hi Marek, On Thursday 01 March 2012 02:59 AM, Marek Vasut wrote: Add "CONFIG_USB_STRING_FETCH" to fetch first string descriptor length and then pass this length to fetch string descriptor. Signed-off-by: Puneet Saxena ---

Re: [U-Boot] [PATCH v3 2/2] usb: Add CONFIG to fetch string descriptor

2012-03-01 Thread puneets
Hi Marek, On Thursday 01 March 2012 02:59 AM, Marek Vasut wrote: Add "CONFIG_USB_STRING_FETCH" to fetch first string descriptor length and then pass this length to fetch string descriptor. Signed-off-by: Puneet Saxena --- Changes for V2: - Change existing config by "CONFIG_USB_STRING_FETCH"

Re: [U-Boot] [PATCH v2 1/2] usb: align buffers at cacheline

2012-02-28 Thread puneets
Hi Marek, IMO, Simon has already mentioned the reason of using ALLOC_CACHE_ALIGN_BUFFER, Please find below my explanation about other doubts. On Monday 27 February 2012 10:19 PM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cachel

Re: [U-Boot] [PATCH 1/2] usb: align buffers at cacheline

2012-02-27 Thread puneets
Hi, On Friday 24 February 2012 06:12 PM, Simon Glass wrote: Hi, On Thu, Feb 23, 2012 at 6:25 AM, Puneet Saxena wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena Signed-off-by: Jim Lin --- Changes for v2:

Re: [U-Boot] [PATCH 1/2] usb: align buffers at cacheline

2012-02-24 Thread puneets
Hi Mike, On Thursday 23 February 2012 11:45 PM, Mike Frysinger wrote: * PGP Signed by an unknown key On Thursday 23 February 2012 09:25:25 Puneet Saxena wrote: --- a/common/usb_storage.c +++ b/common/usb_storage.c -static unsigned char usb_stor_buf[512]; -static ccb usb_ccb; +#ifdef ARCH_DMA_M

Re: [U-Boot] [PATCH 2/2] usb: Add quirk "USB_QUIRK_STRING_FETCH_255"

2012-02-23 Thread puneets
On Thursday 23 February 2012 09:34 PM, Tom Warren wrote: Puneet, -Original Message- From: Puneet Saxena Sent: Thursday, February 23, 2012 7:25 AM To: u-boot@lists.denx.de; s...@chromium.org Cc: vap...@gentoo.org; Tom Warren; Puneet Saxena Subject: [PATCH 2/2] usb: Add quirk "USB_QUIRK_S