On 7/2/2015 5:17 PM, Haikun Wang wrote:
> Some old dataflash chips don't have device ID,
> we should identif them using bits in the flash status byte.
> Add a variable status_byte in struct flash_info,
> and assign correct value for above old chips.
> Add those chips to the supported flash chip tab
On 7/7/2015 1:33 AM, Simon Glass wrote:
> On 2 July 2015 at 03:12, Haikun Wang wrote:
>> Signed-off-by: Haikun Wang
>> ---
>> drivers/mtd/spi/sf_dataflash.c | 28 +---
>> 1 file changed, 17 insertions(+), 11 deletions(-)
>
> Missing commit message. Otherwise:
>
> Review
On 7/7/2015 1:33 AM, Simon Glass wrote:
> On 2 July 2015 at 03:12, Haikun Wang wrote:
>> Add error handler when write/erase flash fail.
>>
>> Signed-off-by: Haikun Wang
>> ---
>> drivers/mtd/spi/sf_dataflash.c | 30 ++
>> 1 file changed, 22 insertions(+), 8 deletion
On 7/7/2015 1:33 AM, Simon Glass wrote:
> Hi,
>
> On 2 July 2015 at 03:12, Haikun Wang wrote:
>> Signed-off-by: Haikun Wang
>
> Missing commit message. Doesn't this mean it will always do the verify?
>
>> ---
>> drivers/mtd/spi/sf_dataflash.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> dif
On 7/2/2015 5:17 PM, Haikun Wang wrote:
> Signed-off-by: Haikun Wang
> ---
> drivers/mtd/spi/sf_dataflash.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c
> index 3111f4f..f83f994 100644
> --- a/drivers/
On 5/11/2015 10:59 AM, Simon Glass wrote:
> Hi,
>
> On 10 May 2015 at 07:04, Jagan Teki wrote:
>> On 8 May 2015 at 13:51, haikun.w...@freescale.com
>> wrote:
>>> On 5/8/2015 1:53 PM, Jagan Teki wrote:
On 8 May 2015 at 08:14, haikun.w...@freescale.com
wrote:
> On 5/7/2015 7:44 PM, J
= -I binary -O binary \
--pad-to=$(CONFIG_SPL_PAD_TO)
u-boot-with-spl.bin: spl/u-boot-spl.bin $(SPL_PAYLOAD) FORCE
$(call if_changed,pad_cat)
Best regards,
Wang Haikun
___
U-Boot mailing list
U-Boot@lists.de
lication (at least the first part).
>
> Anyway I don't see any problem with this change.
Hi Simon,
The "model" information is hard-coded.
Sometimes we need print run-time information of the board.
We just want to print the version information and they are stored in the
on-board FP
On 7/8/2015 3:13 PM, Bin Meng wrote:
> Hi,
>
> On Wed, Jul 8, 2015 at 2:51 PM, Wang Haikun wrote:
>> On 6/26/2015 7:53 PM, Haikun Wang wrote:
>>> From: Haikun Wang
>>>
>>> Bring in required device tree files for ls2085a from Linux.
>>> These
r future, with DTS
being replaced by ACPI gradually for ARM64 platforms, it was discussed
that in a longer run it would be beneficial to move DTS out of both
u-boot and Linux and maintain it as a separate tree."
Best regards,
Wang Haikun
>
> Signed-off-by: Haikun Wang
> ---
On 7/7/2015 1:33 AM, Simon Glass wrote:
> Hi,
>
> On 2 July 2015 at 03:12, Haikun Wang wrote:
>> Signed-off-by: Haikun Wang
>
> Missing commit message. Doesn't this mean it will always do the verify?
OK, I will add the commit message.
It will always do the verify.
>
>> ---
>> drivers/mtd/spi/sf
On 7/1/2015 4:00 PM, Jagan Teki wrote:
> On 1 July 2015 at 07:27, Wang Haikun wrote:
>> On 6/30/2015 7:24 PM, Jagan Teki wrote:
>>> Hi Haikun,
>>>
>>> On 30 June 2015 at 04:48, Simon Glass wrote:
>>>> Hi,
>>>>
>>>> On 26
On 6/30/2015 7:24 PM, Jagan Teki wrote:
> Hi Haikun,
>
> On 30 June 2015 at 04:48, Simon Glass wrote:
>> Hi,
>>
>> On 26 June 2015 at 05:30, Haikun Wang wrote:
>>> Atmel DataFlash chips have commands different from common spi
>>> flash commands.
>>> Atmel DataFlash also have special page-size.
>>
On 6/29/2015 5:26 PM, Jagan Teki wrote:
> On 29 June 2015 at 14:45, Haikun Wang wrote:
>> From: Haikun Wang
>>
>> sst25wf040b doesn't support Auto Address Increment Programming command.
>> Remove SST_WR flag.
>>
>> Signed-off-by: Haikun Wang
>> ---
>> Changes in V2:
>> - Remove extra line
>>
>>
On 6/27/2015 3:35 AM, Jagan Teki wrote:
> On 26 June 2015 at 17:27, Haikun Wang wrote:
>> From: Haikun Wang
>>
>> sst25wf040b doesn't support Auto Address Increment Programming command.
>> Remove SST_WR flag.
>>
>> Signed-off-by: Haikun Wang
>> ---
>> drivers/mtd/spi/sf_params.c | 3 ++-
>> 1
On 6/28/2015 2:32 AM, Jagan Teki wrote:
> From: Haikun Wang
>
> PI and QSPI only work when boot from QSPI on ls1021a.
> This patch only enable options in qspi boot defconfig.
>
> Test log on LS1021AQDS:
> => sf probe 1:0
> SPI DataFlash: Detected at45db021d with page size 256 Bytes, erase size 256
On 6/28/2015 2:32 AM, Jagan Teki wrote:
> From: Haikun Wang
>
> Enable Driver Model SPI for ls1021atwr board.
> DSPI and QSPI only be enabled when boot from QSPI.
> DSPI and QSPI are compatible under Driver Model SPI.
>
> Signed-off-by: Haikun Wang
> Tested-by: Review Code-CDREVIEW
> Reviewed-by
On 6/28/2015 2:32 AM, Jagan Teki wrote:
> From: "haikun.w...@freescale.com"
>
> Atmel DataFlash chips have commands different from common spi
> flash commands.
> Atmel DataFlash also have special page-size.
> This driver add support for accessing Atmel DataFlash.
> It is based on the Driver Model.
On 6/29/2015 3:43 PM, Jagan Teki wrote:
> From: Haikun Wang
>
> Enable Driver Model SPI for ls1021aqds board.
> DSPI and QSPI is enabled only when boot from QSPI.
> DSPI and QSPI are compatible under Driver Model SPI.
>
> Signed-off-by: Haikun Wang
> Reviewed-by: Jagan Teki
> ---
> Changes in v8
On 6/28/2015 2:32 AM, Jagan Teki wrote:
> From: "haikun.w...@freescale.com"
>
> The type of DSPI flash on ls1021aqds is AT45DB021, it has specail
> commands and page-size.
> Use the special spi flash driver instead of "spi_flash_std" driver.
>
> Signed-off-by: Haikun Wang
> Reviewed-by: Simon Gla
On 6/28/2015 2:36 AM, Jagan Teki wrote:
> Hi Haikun,
>
> Please check the series and let me know, will pull the same.
Hi Jagan,
Except a clerical error in include/configs/ls1021aqds.h, it looks fine.
And I have verified them on LS1021AQDS board.
>
> On 28 June 2015 at 00:05, Jagan Teki wrote:
>>
On 6/28/2015 2:32 AM, Jagan Teki wrote:
> From: Haikun Wang
>
> Enable Driver Model SPI for ls1021aqds board.
> DSPI and QSPI is enabled only when boot from QSPI.
> DSPI and QSPI are compatible under Driver Model SPI.
>
> Signed-off-by: Haikun Wang
> Reviewed-by: Jagan Teki
> ---
> Changes in v7
On 6/26/2015 2:43 PM, Jagan Teki wrote:
> On 26 June 2015 at 08:43, Wang Haikun wrote:
>> On 6/25/2015 9:24 PM, Jagan Teki wrote:
>>> On 19 June 2015 at 13:44, Jagan Teki wrote:
>>>> On 19 June 2015 at 13:20, Wang Haikun wrote:
>>>>> On 6/19/2015
On 6/25/2015 9:24 PM, Jagan Teki wrote:
> On 19 June 2015 at 13:44, Jagan Teki wrote:
>> On 19 June 2015 at 13:20, Wang Haikun wrote:
>>> On 6/19/2015 3:34 PM, Jagan Teki wrote:
>>>> On 18 June 2015 at 12:24, Jagan Teki wrote:
>>>>> On 18 June 2015
On 6/19/2015 3:34 PM, Jagan Teki wrote:
> On 18 June 2015 at 12:24, Jagan Teki wrote:
>> On 18 June 2015 at 07:50, Wang Haikun wrote:
>>> On 6/17/2015 8:30 PM, Simon Glass wrote:
>>>> Hi,
>>>>
>>>> On 17 June 2015 at 03:36, Bin Meng wrote:
it.am.freescale.net:8181/33447
>>
>> Is this URL Freescale internal? I cannot access it.
>>
>
> Looks like it. BTW patman will remove these Gerrit tags automatically.
Yes, it is our internal URL.
I forget to remove it.
It couldn't be better if it will be removed
Driver Model SPI for ls1021aqds
Best regards,
Wang Haikun
>
> On 18 May 2015 at 18:55, Haikun Wang wrote:
>> From: Haikun Wang
>>
>> Enable Driver Model SPI for ls1021atwr board.
>> DSPI and QSPI only be enabled when boot from QSPI.
>> DSPI and QSPI are compa
On 5/18/2015 9:28 PM, Haikun Wang wrote:
> The type of DSPI flash on ls1021aqds is AT45DB021, it has specail
> commands and page-size.
> Use the special spi flash driver instead of "spi_flash_std" driver.
>
> Signed-off-by: Haikun Wang
> ---
> arch/arm/dts/ls1021a-qds.dts | 2 +-
> 1 file chang
On 5/18/2015 9:28 PM, Haikun Wang wrote:
> Atmel DataFlash chips have commands different from common spi
> flash commands.
> Atmel DataFlash also have special page-size.
> This driver add support for accessing Atmel DataFlash.
> It is based on the Driver Model.
> Example:
> => sf probe 1:0
> SPI Da
On 5/19/2015 12:22 AM, Sun York-R58495 wrote:
> Haikun,
>
> On 05/18/2015 06:24 AM, Haikun Wang wrote:
>> Enable Driver Model SPI for ls1021aqds board.
>> DSPI and QSPI is enabled only when boot from QSPI.
>> DSPI and QSPI are compatible under Driver Model SPI.
>>
>> Signed-off-by: Haikun Wang
>>
file
>> @@ -15,6 +15,7 @@ endif
>> #ifndef CONFIG_DM_SPI
>> obj-$(CONFIG_SPI_FLASH) += sf_probe.o
>> #endif
>> +obj-$(CONFIG_DM_SF_DATAFLASH) += sf_dataflash.o
>
> This looks confuse to me, CONFIG_SF_DATAFLASH looks simpler.
Fine.
>
> For long run all the driver stuff could move to DM, no need to specify
> explicitly.
>
> BTW:
> Did you define this any board config?
I will add it to LS1021AQDS board config and submit a separate patch.
[snip]
Best regards,
Wang Haikun
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
_MCR_CRXF | DSPI_MCR_CTXF;
> + dspi_write32(bus, DSPI_MCR, mcr_val);
> +
> + /* resume module */
> + dspi_halt(bus, 0);
> +
> + priv->mcr_val = mcr_val;
> +
> + debug("%s probe done, bus-num %d.\n", bus->name, bus->seq);
> +
>
not needed
+#define DSPI_MCR_CSIS2 (0x0004)
+#define DSPI_MCR_CSIS1 (0x0002)
+#define DSPI_MCR_CSIS0 (0x0001)
+#define DSPI_MCR_DOZE (0x8000)
+#define DSPI_MCR_MDIS (0x4000)
+#define DSPI_MC
33 matches
Mail list logo