[PATCH v2 1/3] clk: rockchip: rk3328: use HDMIPHY PLL as a clock parent for VOP_DCLK

2025-04-04 Thread Vasily Khoruzhick
("clk: rockchip: rk3328: Add VOP clk support") Signed-off-by: Vasily Khoruzhick --- v2: no change drivers/clk/rockchip/clk_rk3328.c | 76 +++ 1 file changed, 16 insertions(+), 60 deletions(-) diff --git a/drivers/clk/rockchip/clk_rk3328.c b/drivers/clk/rock

Re: [PATCH v2 3/3] rockchip: rock64-rk3328_defconfig: enable HDMI output and USB keyboard

2025-04-04 Thread Vasily Khoruzhick
On Sun, Mar 30, 2025 at 4:45 AM Jonas Karlman wrote: > > Hi Vasily, > > On 2025-03-23 23:50, Vasily Khoruzhick wrote: > > Enable HDMI output and USB keyboard on Rock64 board > > > > Signed-off-by: Vasily Khoruzhick > > --- > > v2: no change >

Re: [PATCH v2 2/3] video: rockchip: rk3328: filter unsupported modes

2025-04-01 Thread Vasily Khoruzhick
On Sun, Mar 30, 2025 at 4:57 AM Jonas Karlman wrote: > > Hi Vasily, > > + /* Limit pixel clock to 297MHz. While RK3328 support higher rates and > > it > > + * works in Linux, it doesn't seem to work in u-boot. That limits max > > + * resolution to 1440p > > + */ > > + retu

Re: [PATCH v2 2/3] video: rockchip: rk3328: filter unsupported modes

2025-03-23 Thread Vasily Khoruzhick
her. We can either leave it broken as it is now and wait for someone else to fix it or plug it with a workaround for a time being. I'd be happy to test the fix if you volunteer to debug it. Regards, Vasily пн, 24 мар. 2025 г., 01:51 Vasily Khoruzhick : > >> While RK3328 is capable

[PATCH v2 3/3] rockchip: rock64-rk3328_defconfig: enable HDMI output and USB keyboard

2025-03-23 Thread Vasily Khoruzhick
Enable HDMI output and USB keyboard on Rock64 board Signed-off-by: Vasily Khoruzhick --- v2: no change configs/rock64-rk3328_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig index 6d00b52e62f

[PATCH v2 2/3] video: rockchip: rk3328: filter unsupported modes

2025-03-23 Thread Vasily Khoruzhick
;) Signed-off-by: Vasily Khoruzhick --- v2: add a comment that max pixel clock limit is a workaround drivers/video/rockchip/rk3328_hdmi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/video/rockchip/rk3328_hdmi.c b/drivers/video/rockchip/rk3328_hdmi.c index 763669c09be

Re: [PATCH 1/3] clk: rockchip: rk3328: use HDMIPHY PLL as a clock parent for VOP_DCLK

2025-01-18 Thread Vasily Khoruzhick
On Sat, Jan 18, 2025 at 4:53 AM Matwey V. Kornilov wrote: > Both UART-console and HDMI-console works with this patcheset on my Rock64 > board. > > Tested-by: Matwey V. Kornilov Thanks for testing!

Re: [PATCH 2/3] video: rockchip: rk3328: filter unsupported modes

2025-01-18 Thread Vasily Khoruzhick
On Wed, Jan 15, 2025 at 2:48 AM Quentin Schulz wrote: > > Hi Vasily, Hey Quentin, > > +static bool rk3328_hdmi_mode_valid(struct udevice *dev, > > +const struct display_timing *timing) > > +{ > > + return timing->pixelclock.typ <= 29700; > > +} > > + > > T

[PATCH 3/3] rockchip: rock64-rk3328_defconfig: enable HDMI output and USB keyboard

2025-01-13 Thread Vasily Khoruzhick
Enable HDMI output and USB keyboard on Rock64 board Signed-off-by: Vasily Khoruzhick --- configs/rock64-rk3328_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig index 6d00b52e62f..ae3512625cf 100644 --- a

[PATCH 2/3] video: rockchip: rk3328: filter unsupported modes

2025-01-13 Thread Vasily Khoruzhick
;) Signed-off-by: Vasily Khoruzhick --- drivers/video/rockchip/rk3328_hdmi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/video/rockchip/rk3328_hdmi.c b/drivers/video/rockchip/rk3328_hdmi.c index 763669c09be..d02c58c44c5 100644 --- a/drivers/video/rockchip/rk3328_hdmi.c +++ b/

[PATCH 1/3] clk: rockchip: rk3328: use HDMIPHY PLL as a clock parent for VOP_DCLK

2025-01-13 Thread Vasily Khoruzhick
("clk: rockchip: rk3328: Add VOP clk support") Signed-off-by: Vasily Khoruzhick --- drivers/clk/rockchip/clk_rk3328.c | 76 +++ 1 file changed, 16 insertions(+), 60 deletions(-) diff --git a/drivers/clk/rockchip/clk_rk3328.c b/drivers/clk/rockchip/clk

[PATCH] rockchip: sdhci: rk3568: bypass DLL when clk <= 52 MHz

2023-03-08 Thread Vasily Khoruzhick
For Rockchip platform, DLL bypass bit and start bit need to be set if DLL is not locked. With this change applied eMMC in my NanoPi R5S can run at 52 MHz. Based on linux commit b75a52b0dda3 ("mmc: sdhci-of-dwcmshc: Update DLL and pre-change delay for rockchip platform") Signed-off-

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-07 Thread Vasily Khoruzhick
of a while() {} in order to allow a first check for reg == 0. > > Co-developed-by: Frank Wang > Signed-off-by: Frank Wang > Signed-off-by: Eugen Hristev Tested-by: Vasily Khoruzhick # rk3568-based board > --- > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 109 +

Re: [PATCH v2 3/3] Revert "arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates"

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 4:48 PM Kever Yang wrote: > > Hi Vasily, Hi Kever, > Please use a new patch instead of a revert, I think I merge the > patch twice by mistake, so there is another one need to remove. Sure, I changed the patch subject and description in v3. Regards, Vasily

[PATCH v3 2/2] arm64:dts: rk356x-u-boot: do not drop combphy1 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
We have stubs for CLK_PCIEPHY_REF now, so there is no reason to modify the dtsi. This essentialy reverts commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates"). Signed-off-by: Vasily Khoruzhick --- v3: change patch subject and description from defa

[PATCH v3 1/2] clk: rockchip: rk3568: add stubs for CLK_PCIEPHY_REF clocks

2023-03-07 Thread Vasily Khoruzhick
Device tree contains assigned-clock-rates property for these, but default value will work just fine Reviewed-by: Kever Yang Signed-off-by: Vasily Khoruzhick --- v3: add r-b tag from Kever v2: implement stubs for CLK_PCIEPHY_REF instead of dropping assigned-clock properties drivers/clk

Re: [PATCH v2 1/3] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 4:52 PM Kever Yang wrote: > > Hi Vasily, Hi Keven, > This patch is cover by patch[1] from Eugen, right? Yeah, I didn't notice Eugen's patch. Anyway, he sent his patch earlier, so please discard mine. Regards, Vasily

[PATCH v2 3/3] Revert "arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates"

2023-03-07 Thread Vasily Khoruzhick
This reverts commit 5bec4b0de7851a254fb4447b3599a60f95550141. Signed-off-by: Vasily Khoruzhick --- v2: revert dropping assigned-clock properties because we have stubs for CLK_PCIEPHY_REF clocks now arch/arm/dts/rk356x-u-boot.dtsi | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/arm

[PATCH v2 2/3] clk: rockchip: rk3568: add stubs for CLK_PCIEPHY_REF clocks

2023-03-07 Thread Vasily Khoruzhick
Device tree contains assigned-clock-rates property for these, but default value will work just fine Signed-off-by: Vasily Khoruzhick --- v2: implement stubs for CLK_PCIEPHY_REF instead of dropping assigned-clock properties drivers/clk/rockchip/clk_rk3568.c | 3 +++ 1 file changed, 3 insertions

[PATCH v2 1/3] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Vasily Khoruzhick
PHY driver needs to enable PHY supply, otherwise port will remain unpowered. Signed-off-by: Vasily Khoruzhick --- v2: address check_patch.pl issues drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 64 ++- 1 file changed, 61 insertions(+), 3 deletions(-) diff --git a/drivers/phy

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
just fine. > > > > commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 > > > > assigned-clocks/rates") > > > > dropped these properties for combphy1, so let's drop them for combphy0 > > > > as well. > > >

[PATCH] rockchip: sdhci: rk3568: fix clock setting logic

2023-03-07 Thread Vasily Khoruzhick
c_tran speed to non-zero value (26MHz in my case), and on subsequent re-init when mmc layer asks for 400KHz it sets 26MHz instead. Fix it by using MAX(mmc->tran_speed, mmc->clock) Signed-off-by: Vasily Khoruzhick --- drivers/mmc/rockchip_sdhci.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
clude "rk356x-u-boot.dtsi" > > +#include "rk3568-u-boot.dtsi" > > > > / { > > chosen { > > diff --git a/arch/arm/dts/rk3568-u-boot.dtsi > > b/arch/arm/dts/rk3568-u-boot.dtsi > > new file mode 100644 > > index 00..c67

[PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
combphy0 is failing to probe due to unhandled assigned-clocks and assigned-clocks-rates. commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates") dropped these properties for combphy1, so let's drop them for combphy0 as well. Signed-off-by: Va

[PATCH 1/2] phy: rockchip-inno-usb2: add support for phy-supply

2023-03-07 Thread Vasily Khoruzhick
PHY driver needs to enable PHY supply, otherwise port will remain unpowered. Signed-off-by: Vasily Khoruzhick --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 59 ++- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c

Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes

2023-03-07 Thread Vasily Khoruzhick
On Wed, Mar 1, 2023 at 6:49 PM Kever Yang wrote: Hi Kever, > So I have take this patch set, and we can improve later when kernel have > a version and we have a better solution for U-Boot. My concern is that dts will be overwritten during the next dts sync with the kernel. U-boot specific proper

Re: [PATCH V2 7/9] gpio/rockchip: rk_gpio support v2 gpio controller

2023-02-23 Thread Vasily Khoruzhick
differs > from the older versions of the GPIO controller. > > Signed-off-by: Peter Geis > Signed-off-by: Chris Morgan With pinctrl part from https://patchwork.ozlabs.org/project/uboot/patch/20230217115845.75303-11-ja...@amarulasolutions.com/ Tested-by: Vasily Khoruzhick > --- >

Re: [PATCH V2 8/9] arm64: dts: rockchip: add gpio-ranges property to gpio nodes

2023-02-23 Thread Vasily Khoruzhick
On Mon, Feb 13, 2023 at 2:30 PM Chris Morgan wrote: > > From: Chris Morgan > > Add gpio-ranges property to GPIO nodes so that the bank ID can > be correctly derived for each GPIO bank. Should not it be merged into linux first? Otherwise it will be overwritten during the next dts sync with linux.

[PATCH] clk: rockchip: rk3568: add more supported clk rates for sdmmc and emmc

2023-02-23 Thread Vasily Khoruzhick
SDHCI driver may attempt to set 26MHz clock, but clk_rk3568 will return error in this case. Apparently, SDHCI silently ignores the error and as a result eMMC initialization fails. Add 25 MHz and 26 MHz clk rates for sdmmc and emmc on rk3568 to fix that. Signed-off-by: Vasily Khoruzhick

Re: [PATCH v4 1/1] arm64: dts: rockchip: rk3568: Add Radxa ROCK 3 Model A board support

2023-02-23 Thread Vasily Khoruzhick
here. > > > Thanks, > Akash > > On 23-02-2023 06:01, Vasily Khoruzhick wrote: > > On Tue, Feb 14, 2023 at 12:11 PM Akash Gajjar > > wrote: > > > > Hi Akash, > > > >> Add Radxa ROCK 3 Model A support. sync rk3568-rock-3a.dts from Linux &

Re: [PATCH v4 1/1] arm64: dts: rockchip: rk3568: Add Radxa ROCK 3 Model A board support

2023-02-22 Thread Vasily Khoruzhick
On Tue, Feb 14, 2023 at 12:11 PM Akash Gajjar wrote: Hi Akash, > Add Radxa ROCK 3 Model A support. sync rk3568-rock-3a.dts from Linux 6.2.0-rc7 > > Board Specifications > - Rockchip RK3568 > - 2/4/8GB LPDDR4 3200MT/s > - eMMC socket, SD card slot Have you actually tested eMMC support? It seems

Re: [PATCH 1/5] sunxi: video: No double clock on DE2

2020-09-16 Thread Vasily Khoruzhick
not support "2x pll" in TCON_CLK_REG > > So I wrote where I tested this patch. > It should be discussed with original author. Sorry, I don't remember the details on why the driver uses pll-video0-2x, that's the code from 2017 > Regards. > > CC: Vasily Khoruzhick

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-28 Thread Vasily Khoruzhick
On Thu, Nov 28, 2019 at 4:59 PM Kever Yang wrote: > > Hi Vasily, > > On 2019/11/28 下午11:51, Vasily Khoruzhick wrote: > > On Thu, Nov 28, 2019 at 1:23 AM Kever Yang > > wrote: > >> Hi Vasily, > >> > >> I think this should not be needed, s

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-28 Thread Vasily Khoruzhick
ther. So could you merge this patch please unless someone else wants to work on this issue? Thanks, Vasily. [1] https://github.com/anarsoul/u-boot-pine64/commit/7a50e58f09c68efe08f0b9912805fb9b3c985751 > Thanks, > - Kever > On 2019/11/28 下午2:14, Vasily Khoruzhick wrote: > > Rockpro64 doesn't boot reliably after

[U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2019-11-27 Thread Vasily Khoruzhick
Rockpro64 doesn't boot reliably after soft reset, so let's force power on reset by asserting sysreset pin if we detected soft reset. Signed-off-by: Vasily Khoruzhick --- arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 8 configs/rockpro64-rk3399_defconfig| 1 + 2 files

[U-Boot] [PATCH 1/2] rockchip: rk3399: fix force power on reset

2019-11-27 Thread Vasily Khoruzhick
Currently code doesn't even compile since it uses wrong define for ifdef. Fix that and also add missing include Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init") Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-rockchip/rk3399/rk3399.c | 5 +++-- 1

Re: [U-Boot] [PATCH v2 2/8] rockchip: rk3399: Support common spl_board_init

2019-11-27 Thread Vasily Khoruzhick
On Thu, Jun 20, 2019 at 11:57 AM Jagan Teki wrote: > > Support common spl_board_init by moving code from puma > board file into, common rk3399-board-spl.c. > > Part of the code has sysreset-gpio, regulators_enable_boot_on > but right now only puma board is using this with relevant > config options

Re: [U-Boot] Reboot is broken on RockPro64 with mainline u-boot and ATF

2019-11-27 Thread Vasily Khoruzhick
On Wed, Nov 27, 2019 at 9:53 AM Jagan Teki wrote: > > Hi, > > On Mon, Nov 25, 2019 at 10:56 PM Vasily Khoruzhick wrote: > > > > Hey guys, > > > > Looks like reboot is broken on RockPro64 (RK3399-based) with mainline > > u-boot and ATF (ATF already has a

Re: [U-Boot] Reboot is broken on RockPro64 with mainline u-boot and ATF

2019-11-27 Thread Vasily Khoruzhick
On Mon, Nov 25, 2019 at 9:25 AM Vasily Khoruzhick wrote: > > Hey guys, > > Looks like reboot is broken on RockPro64 (RK3399-based) with mainline > u-boot and ATF (ATF already has a fix [1]). Added Philipp and Simon to CC. Can anyone please help me with this issue? > When

[U-Boot] Reboot is broken on RockPro64 with mainline u-boot and ATF

2019-11-25 Thread Vasily Khoruzhick
Hey guys, Looks like reboot is broken on RockPro64 (RK3399-based) with mainline u-boot and ATF (ATF already has a fix [1]). When I type 'reboot' in linux I get back to u-boot, but subsequent linux boot hangs in most cases. Sometimes I get this warning: [ 62.400363] rcu: INFO: rcu_sched detecte

Re: [U-Boot] [PATCH] power: fan53555: add support for Silergy SYR82X and SYR83X

2019-11-19 Thread Vasily Khoruzhick
ie id* and *rev id* and update in the next patch. Likely you're missing another patch from me, see https://patchwork.ozlabs.org/patch/1196194/ so ID you're getting here are not correct. > Could we enable this feature on all rk3399 development boards That's out of scope of this patch. &

Re: [U-Boot] [PATCH] rockchip: i2c: don't sent stop bit after each message

2019-11-17 Thread Vasily Khoruzhick
On Sun, Nov 17, 2019 at 7:26 PM David.Wu wrote: > > Hi Vasily, > > 在 2019/11/17 3:32, Vasily Khoruzhick 写道: > > + rk_i2c_send_stop_bit(i2c); > > + rk_i2c_disable(i2c); > > I think it is better to also stop i2c if i2c xfer failed, how do you > feel about

[U-Boot] [PATCH] power: fan53555: fix fan53555_regulator_set_value

2019-11-17 Thread Vasily Khoruzhick
fan53555_regulator_set_value() passes its own dev to pmic_clrsetbits() instead of its parent (pmic). As result u-boot crashes when you try to set voltage on fan53555 regulator Signed-off-by: Vasily Khoruzhick --- drivers/power/regulator/fan53555.c | 2 +- 1 file changed, 1 insertion(+), 1

[U-Boot] [PATCH] rockchip: i2c: don't sent stop bit after each message

2019-11-16 Thread Vasily Khoruzhick
That's not correct and it breaks SMBUS-style reads and and writes for some chips (e.g. SYR82X/SYR83X). Stop bit should be sent only after the last message. Signed-off-by: Vasily Khoruzhick --- drivers/i2c/rk_i2c.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dr

[U-Boot] [PATCH] power: fan53555: add support for Silergy SYR82X and SYR83X

2019-11-16 Thread Vasily Khoruzhick
SYR82X and SYR83X are almost identical to FAN53555, the only difference is different die ID and revision, voltage ranges and steps. Signed-off-by: Vasily Khoruzhick --- drivers/power/pmic/fan53555.c | 7 +++-- drivers/power/regulator/fan53555.c | 45 ++ include

Re: [U-Boot] [PATCH] rockchip: rk3399: Add Pinebook Pro laptop support

2019-11-14 Thread Vasily Khoruzhick
On Wed, Nov 13, 2019 at 4:51 PM Peter Robinson wrote: > > Add initial support for Pinebook Pro laptop. Hi Peter, > Specification > - Rockchip RK3399 > - 4GB Dual-Channel LPDDR4 > - SD card slot > - eMMC socket > - 128Mb SPI Flash > - PCIe 4X slot > - AP6256 for WiFi + BT > - 1920*1080 screen > -

Re: [U-Boot] [PATCH v2] rockchip: rk3399: split rockpro64 out of evb_rk3399

2019-11-10 Thread Vasily Khoruzhick
On Sun, Nov 10, 2019 at 7:01 AM Peter Robinson wrote: > > On Sat, Nov 9, 2019 at 7:25 PM Vasily Khoruzhick wrote: > > > > rockpro64 needs to setup I/O domains in order for USB to work in u-boot. > > Since we currently don't have a driver to do that, split it in

[U-Boot] [PATCH v2] rockchip: rk3399: split rockpro64 out of evb_rk3399

2019-11-09 Thread Vasily Khoruzhick
rockpro64 needs to setup I/O domains in order for USB to work in u-boot. Since we currently don't have a driver to do that, split it into its own board file and initialize I/O domains here. Signed-off-by: Vasily Khoruzhick --- v2: add missing include/configs/rockpro64_rk3399.h arch/arm

Re: [U-Boot] [PATCH] rockchip: rk3399: split rockpro64 out of evb_rk3399

2019-11-09 Thread Vasily Khoruzhick
On Sat, Nov 9, 2019 at 12:41 AM Vasily Khoruzhick wrote: > > rockpro64 needs to setup I/O domains in order for USB to work in u-boot. > Since we currently don't have a driver to do that, split it into its own > board file and initialize I/O domains here. Please discard this p

Re: [U-Boot] USB doesn't work on Rockpro64 in u-boot

2019-11-09 Thread Vasily Khoruzhick
On Thu, Nov 7, 2019 at 10:33 PM Jagan Teki wrote: > > Hi Vasily, > > On Fri, Nov 8, 2019 at 9:18 AM Vasily Khoruzhick wrote: > > > > I checked voltage on regulator enable pin and it's 1.5v in u-boot (and it's > > not enough to enable regulator!) and in

[U-Boot] [PATCH] rockchip: rk3399: split rockpro64 out of evb_rk3399

2019-11-09 Thread Vasily Khoruzhick
rockpro64 needs to setup I/O domains in order for USB to work in u-boot. Since we currently don't have a driver to do that, split it into its own board file and initialize I/O domains here. Signed-off-by: Vasily Khoruzhick --- arch/arm/mach-rockchip/rk3399/Kconfig | 20 +++

Re: [U-Boot] USB doesn't work on Rockpro64 in u-boot

2019-11-07 Thread Vasily Khoruzhick
On Wed, Nov 6, 2019 at 11:28 PM Vasily Khoruzhick wrote: > > On Wed, Nov 6, 2019 at 7:48 PM Vasily Khoruzhick wrote: > > > > On Wed, Nov 6, 2019 at 8:50 AM Jagan Teki > > wrote: > > > > > > Hi Vasily, > > > > > > On Wed, No

Re: [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel

2019-11-07 Thread Vasily Khoruzhick
On Thu, Nov 7, 2019 at 12:26 PM Soeren Moch wrote: > > On 07.11.19 21:04, Vasily Khoruzhick wrote: > > On Thu, Nov 7, 2019 at 3:11 AM Soeren Moch wrote: > >> The most important change for u-boot is the fix for the vdd-log pwm > >> voltage regulator to avoid over

Re: [U-Boot] [PATCH 1/2] arm: dts: rk3399-rockpro64: sync dts from linux kernel

2019-11-07 Thread Vasily Khoruzhick
On Thu, Nov 7, 2019 at 3:11 AM Soeren Moch wrote: > > The most important change for u-boot is the fix for the vdd-log pwm > voltage regulator to avoid overvoltage for the VD_LOGIC power domain. I don't see any changes to vdd-log regulator in this patch that can help avoiding overvoltage. It just

Re: [U-Boot] USB doesn't work on Rockpro64 in u-boot

2019-11-06 Thread Vasily Khoruzhick
On Wed, Nov 6, 2019 at 7:48 PM Vasily Khoruzhick wrote: > > On Wed, Nov 6, 2019 at 8:50 AM Jagan Teki wrote: > > > > Hi Vasily, > > > > On Wed, Nov 6, 2019 at 9:17 AM Vasily Khoruzhick wrote: > > > > > > Hi Akash, Jagan, > > > > &g

Re: [U-Boot] USB doesn't work on Rockpro64 in u-boot

2019-11-06 Thread Vasily Khoruzhick
On Wed, Nov 6, 2019 at 8:50 AM Jagan Teki wrote: > > Hi Vasily, > > On Wed, Nov 6, 2019 at 9:17 AM Vasily Khoruzhick wrote: > > > > Hi Akash, Jagan, > > > > Looks like USB is not functional in u-boot on Rockpro64. u-boot is > > from git, commi

[U-Boot] USB doesn't work on Rockpro64 in u-boot

2019-11-05 Thread Vasily Khoruzhick
Hi Akash, Jagan, Looks like USB is not functional in u-boot on Rockpro64. u-boot is from git, commit 680023c5fab6b1777c0c6f2e76e5d2effb7903a0. I'm using u-boot SPL and mainline ATF (19adcb415c313d656324d54e7608cdc7d7a5c414 is ATF commit) 'usb start' doesn't detect anything but hubs and looks lik

Re: [U-Boot] [PATCH v3 3/3] configs: sopine-baseboard: Enable SPI-FLASH

2019-10-19 Thread Vasily Khoruzhick
On Wed, Oct 16, 2019 at 9:23 AM Jagan Teki wrote: > > SoPine has winbond SPI-FLASH, so enable the same in defconfig > and add aliases for spi0 in -u-boot.dtsi > > Signed-off-by: Jagan Teki > --- > Changes for v3: > - none > > arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi | 12

Re: [U-Boot] [PATCH v2 00/99] ram: rk3399: Add LPDDR4 support

2019-06-20 Thread Vasily Khoruzhick
On Mon, Jun 17, 2019 at 12:37 AM Jagan Teki wrote: > > This is the v2 set for supporting LPDDR4 with associated > features, wrt to previous series[1]. > > Thanks to > - YouMin Chen > - Akash Gajjar > - Kever Yang > for supporting all the help on this work. > > On summary this series support > - Co

Re: [U-Boot] [PATCHv3 01/10] arm: Remove zipitz2 board

2019-05-29 Thread Vasily Khoruzhick
On Wed, May 29, 2019 at 2:01 PM Tom Rini wrote: > > Per discussion on the list, drop this board again. > > Cc: Vasily Khoruzhick > Signed-off-by: Tom Rini Acked-by: Vasily Khoruzhick Thanks for submitting this patch! > --- > arch/arm/Kconfig | 5 -- >

Re: [U-Boot] [linux-sunxi] [PATCH 0/2] sunxi: A64: enable first USB port on Pine64 boards

2019-05-17 Thread Vasily Khoruzhick
On Wed, May 15, 2019 at 5:46 PM Andre Przywara wrote: > > Since the beginning the upper USB port on Pine64 boards (Pine64+, SoPine > baseboard, Pine64-LTS, Pinebook) was not working under U-Boot. > This is due to the PHY for those pins being shared with the OTG > controller, which we didn't even e

Re: [U-Boot] U-Boot PXA support

2019-05-09 Thread Vasily Khoruzhick
On Thu, May 9, 2019 at 7:56 AM Marek Vasut wrote: > > On 5/9/19 4:02 PM, Tom Rini wrote: > > On Mon, May 06, 2019 at 09:26:04AM -0400, Tom Rini wrote: > > > >> Hey folks, > >> > >> I'm attempting, again, to see what we need to do in order to use gcc-8.x > >> for U-Boot and ran into, again: > >> ht

Re: [U-Boot] [PATCH] sunxi: A64: pinebook-u-boot: Include sunxi-u-boot.dtsi

2019-01-25 Thread Vasily Khoruzhick
ne. This patch and whole DM_MMC series: Tested-by: Vasily Khoruzhick # Tested on Pinebook > --- > arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/dts/sun50i-a64-pinebook-u-boot.dtsi > b/arch/arm/dts/sun50i-a64-p

Re: [U-Boot] [PATCH v3 9/9] arm: dts: sunxi: Enumerate MMC2 as MMC1

2019-01-21 Thread Vasily Khoruzhick
On Mon, Jan 21, 2019 at 8:24 PM Vasily Khoruzhick wrote: > > For me it shows: > > => mmc list > mmc@1c0f000: 0 (SD) > mmc@1c1: 1 > mmc@1c11000: 2 > > I'm testing this patches applied onto u-boot-sunxi/master on Pinebook. > I tried 'distclean', a

Re: [U-Boot] [PATCH v3 9/9] arm: dts: sunxi: Enumerate MMC2 as MMC1

2019-01-21 Thread Vasily Khoruzhick
On Mon, Jan 21, 2019 at 7:46 AM Jagan Teki wrote: > > On Mon, Jan 21, 2019 at 9:08 PM Vasily Khoruzhick wrote: >scanning usb for storage devices... 0 Storage Device(s) found > Hit any key to stop autoboot: 0 > => > => > => mmc list > mmc@1c0f000: 0

Re: [U-Boot] [PATCH v3 9/9] arm: dts: sunxi: Enumerate MMC2 as MMC1

2019-01-21 Thread Vasily Khoruzhick
On Mon, Jan 21, 2019 at 2:32 AM Jagan Teki wrote: > > Environment and fastboot MMC devices are configured based number > of mmc slots defined on particular board in sunxi platform. > > If number of slots are not more than 1, it assigns 0 which usually mmc > device on SD slot. With DM_MMC it is det

Re: [U-Boot] [PATCH 0/9] sunxi: enable DM_MMC

2019-01-19 Thread Vasily Khoruzhick
On Sat, Jan 19, 2019 at 12:35 PM André Przywara wrote: > Thanks for the report! So is this with this U-Boot on an SD card or on > the eMMC? This is with u-boot on eMMC and no SD card present in the slot. > Can you try to add the mmc1 = &mmc2; alias that Jagan suggested: > https://lists.denx.de/

Re: [U-Boot] [PATCH 0/9] sunxi: enable DM_MMC

2019-01-19 Thread Vasily Khoruzhick
On Fri, Jan 18, 2019 at 5:32 PM Andre Przywara wrote: > > This series enables the Allwinner MMC driver to drive all SoCs with its > DM_MMC variant. We use the gates clock and reset support from the new > clock driver, but keep the actual mod clock in its somewhat hackish > state. Properly supporti

Re: [U-Boot] [PATCH 0/7] mmc: sunxi: Enable DM_MMC

2019-01-11 Thread Vasily Khoruzhick
On Fri, Jan 11, 2019 at 10:04 AM Jagan Teki wrote: > > I thought of waiting this till CLK framework gets Mainline, > but migration deadline for DM_MMC and BLK seems expiring in > next release. So instead of doing so huddle and make some last > minute changes, I have managed to add CLK, Reset code

Re: [U-Boot] [PATCH v2 0/3] sunxi-mmc: enable new clock mode on A64

2018-11-21 Thread Vasily Khoruzhick
On Thu, Nov 15, 2018 at 11:20 AM Vasily Khoruzhick wrote: > > On Fri, Nov 9, 2018 at 8:41 PM Vasily Khoruzhick wrote: > > > > A64 requires new clock mode on SD and eMMC controllers. Not using > > new clock mode causes stability issues of the driver - SPL may > > oc

Re: [U-Boot] [PATCH v2 0/3] sunxi-mmc: enable new clock mode on A64

2018-11-15 Thread Vasily Khoruzhick
On Fri, Nov 9, 2018 at 8:41 PM Vasily Khoruzhick wrote: > > A64 requires new clock mode on SD and eMMC controllers. Not using > new clock mode causes stability issues of the driver - SPL may > occasionally fail to load u-boot from SD for some particular SD card > on some par

Re: [U-Boot] [PATCH] sunxi: use 6MHz PLL_VIDEO step for DE2 for higher resolution LCD

2018-11-13 Thread Vasily Khoruzhick
On Tue, Nov 13, 2018 at 8:32 AM Jagan Teki wrote: > > On Mon, Oct 29, 2018 at 2:08 PM Maxime Ripard > wrote: > > > > On Sun, Oct 28, 2018 at 02:26:12PM -0700, Vasily Khoruzhick wrote: > > > From: Icenowy Zheng > > > > > > DE2 SoCs can support

[U-Boot] [PATCH v2 3/3] sunxi-mmc: use new mode on both controllers on A64

2018-11-09 Thread Vasily Khoruzhick
Using new mode improves stability of eMMC and SD cards. Without it SPL fails to load u-boot from SD on Pinebook. Signed-off-by: Vasily Khoruzhick Reviewed-by: Chen-Yu Tsai --- arch/arm/mach-sunxi/Kconfig | 1 + drivers/mmc/sunxi_mmc.c | 10 +++--- 2 files changed, 8 insertions(+), 3

[U-Boot] [PATCH v2 2/3] sunxi-mmc: don't double clock for new mode unconditionally

2018-11-09 Thread Vasily Khoruzhick
de is used. Some cards can't handle that and as result SPL fails to load u-boot. Fixes: de9b1771c3b ("mmc: sunxi: Support new mode") Signed-off-by: Vasily Khoruzhick --- drivers/mmc/sunxi_mmc.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mmc/sunxi_mmc.c b/driv

[U-Boot] [PATCH v2 1/3] sunxi-mmc: introduce new MMC_SUNXI_HAS_MODE_SWITCH option

2018-11-09 Thread Vasily Khoruzhick
A64 doesn't have a mode switch in CCM, and CCM_MMC_CTRL_MODE_SEL_NEW is not defined, so compilation fails if MMC_SUNXI_HAS_NEW_MODE is enabled Introduce new MMC_SUNXI_HAS_MODE_SWITCH option to be able to ifdef usage of CCM_MMC_CTRL_MODE_SEL_NEW Signed-off-by: Vasily Khoruzhick --- arc

[U-Boot] [PATCH v2 0/3] sunxi-mmc: enable new clock mode on A64

2018-11-09 Thread Vasily Khoruzhick
delay calibration" from my Pinebook series. Tested on Pinebook and Pine64-LTS. Fixes eMMC failures on Olinuxino-A64 [1] [1] https://github.com/armbian/build/commit/03199b3879af24c94029460b8cdf0d41048afc92#commitcomment-31028421 Vasily Khoruzhick (3): sunxi-mmc: introduce new MMC_SUNXI_HAS_MODE_SWI

Re: [U-Boot] [PATCH 1/3] sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option

2018-11-06 Thread Vasily Khoruzhick
On Tue, Nov 6, 2018 at 8:13 PM Chen-Yu Tsai wrote: > > On Wed, Nov 7, 2018 at 11:59 AM Vasily Khoruzhick wrote: > > > > A64 doesn't have a mode switch in CCM, so introduce new > > MMC_SUNXI_HAS_NEW_MODE_SWITCH option to support new clock mode on A64 > > &

[U-Boot] [PATCH 3/3] sunxi-mmc: use new mode on both controllers on A64

2018-11-06 Thread Vasily Khoruzhick
Using new mode improves stability of eMMC and SD cards. Without it SPl fails to load u-boot from SD on Pinebook. Signed-off-by: Vasily Khoruzhick Tested-by: Zhaofeng Li --- arch/arm/mach-sunxi/Kconfig | 1 + drivers/mmc/sunxi_mmc.c | 10 +++--- 2 files changed, 8 insertions(+), 3

[U-Boot] [PATCH 1/3] sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option

2018-11-06 Thread Vasily Khoruzhick
A64 doesn't have a mode switch in CCM, so introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option to support new clock mode on A64 Signed-off-by: Vasily Khoruzhick Tested-by: Zhaofeng Li --- arch/arm/mach-sunxi/Kconfig | 1 + drivers/mmc/Kconfig | 4 drivers/mmc/sunxi_mmc.c

[U-Boot] [PATCH 2/3] sunxi-mmc: don't double clock for new mode unconditionally

2018-11-06 Thread Vasily Khoruzhick
n't handle that and as result SPL fails to load u-boot. Fixes: de9b1771c3b ("mmc: sunxi: Support new mode") Signed-off-by: Vasily Khoruzhick Tested-by: Zhaofeng Li --- drivers/mmc/sunxi_mmc.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mmc/sunxi_mmc.c b/driv

[U-Boot] [PATCH 0/3] sunxi-mmc: enable new clock mode on A64

2018-11-06 Thread Vasily Khoruzhick
delay calibration" from my Pinebook series. Tested on Pinebook and Pine64-LTS. Vasily Khoruzhick (3): sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option sunxi-mmc: don't double clock for new mode unconditionally sunxi-mmc: use new mode on both controllers on A64 arch/arm/mac

Re: [U-Boot] [PATCH 0/4] sunxi: A64/H3/H5 DT updates

2018-11-05 Thread Vasily Khoruzhick
On Sun, Nov 4, 2018 at 10:55 PM Jagan Teki wrote: > Marked as "Waiting for Upstream" in patchwork, will push it MW, just > send your series on top it. I've just sent v5, see https://patchwork.ozlabs.org/project/uboot/list/?series=74203 Please note that my series depends on this series.

[U-Boot] [PATCH v5 3/4] sun50i: A64: add support for R_I2C controller

2018-11-05 Thread Vasily Khoruzhick
Allwinner A64 has a I2C controller, which is in the R_ MMIO zone and has two groups of pinmuxes on PL bank, so it's called R_I2C. Add support for this I2C controller and the pinmux which doesn't conflict with RSB. Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-

[U-Boot] [PATCH v5 4/4] sunxi: DT: add support for Pinebook

2018-11-05 Thread Vasily Khoruzhick
Pinebook is a laptop produced by Pine64, with USB-connected keyboard, USB-connected touchpad and an eDP LCD panel connected via a RGB-eDP bridge from Analogix. Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-by: Maxime Ripard Cc: Vagrant Cascadian --- arch/arm/dts/Makefile

[U-Boot] [PATCH v5 2/4] dm: video: bridge: don't fail to activate bridge if reset or sleep GPIO is missing

2018-11-05 Thread Vasily Khoruzhick
Both GPIOs are optional, so we shouldn't fail if any is missing. Without this fix reset is not deasserted if sleep GPIO is missing. Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-by: Maxime Ripard Reviewed-by: Andre Przywara Cc: Vagrant Cascadian --- drivers/video/b

[U-Boot] [PATCH v5 1/4] mmc: sunxi: add support for automatic delay calibration

2018-11-05 Thread Vasily Khoruzhick
A64 and H6 support automatic delay calibration and Linux driver uses it instead of hardcoded delays. Add support for it to u-boot driver. Fixes eMMC instability on Pinebook Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-by: Maxime Ripard Reviewed-by: Andre Przywara Cc

[U-Boot] [PATCH v5 0/4] Add support for Pinebook

2018-11-05 Thread Vasily Khoruzhick
: - sync device tree files with linux-next v5: - drop patch to sync device tree files with linux-next Vasily Khoruzhick (4): mmc: sunxi: add support for automatic delay calibration dm: video: bridge: don't fail to activate bridge if reset or sleep GPIO is missing sun50i: A64: add sup

Re: [U-Boot] [PATCH 0/4] sunxi: A64/H3/H5 DT updates

2018-11-04 Thread Vasily Khoruzhick
On Sun, Nov 4, 2018 at 9:13 PM Jagan Teki wrote: > > On Mon, Oct 29, 2018 at 6:27 AM Andre Przywara wrote: > > > > This updates the .dts and .dtsi files used in U-Boot to what will become > > the new DTs in Linux 4.20 (anytime soon). > > Those updates are not too useful for U-Boot itself, but kee

Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook

2018-11-03 Thread Vasily Khoruzhick
On Sat, Nov 3, 2018 at 2:15 PM André Przywara wrote: > > On 11/3/18 8:19 PM, Vasily Khoruzhick wrote: > > > > You need "allwinner" branch from this repo. > > I deliberately switched the standard branch away, since everything is > merged in mainline ATF now (i

Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook

2018-11-03 Thread Vasily Khoruzhick
On Sat, Nov 3, 2018 at 1:18 PM Vasily Khoruzhick wrote: > > Video is supposed to work, but you need ATF from Andre to enable LCD power: > > https://github.com/apritzel/arm-trusted-firmware/ You need "allwinner" branch from this repo. > On Sat, Nov 3, 2018 at 11:53

Re: [U-Boot] [PATCH v4 0/5] Add support for Pinebook

2018-11-03 Thread Vasily Khoruzhick
ot however works fine and the system is able to boot and the > correct dtb is loaded. > > Tested-by: Dennis Gilmore > > El mar, 30-10-2018 a las 14:36 -0700, Vagrant Cascadian escribió: > > Tested series applied to u-boot 2018.11-rc3 on pinebook, both with > > reboot and co

[U-Boot] [PATCH] sunxi: use 6MHz PLL_VIDEO step for DE2 for higher resolution LCD

2018-10-28 Thread Vasily Khoruzhick
From: Icenowy Zheng DE2 SoCs can support LCDs up to 1080p (e.g. A64), and 3MHz step won't let PLL_VIDEO be high enough for them. Use 6MHz step for PLL_VIDEO when using DE2, to satisfy 1080p LCD. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Tested-by: Vasily Khoru

[U-Boot] [PATCH v4 4/5] sun50i: A64: add support for R_I2C controller

2018-10-28 Thread Vasily Khoruzhick
Allwinner A64 has a I2C controller, which is in the R_ MMIO zone and has two groups of pinmuxes on PL bank, so it's called R_I2C. Add support for this I2C controller and the pinmux which doesn't conflict with RSB. Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-

[U-Boot] [PATCH v4 5/5] sunxi: DT: add support for Pinebook

2018-10-28 Thread Vasily Khoruzhick
Pinebook is a laptop produced by Pine64, with USB-connected keyboard, USB-connected touchpad and an eDP LCD panel connected via a RGB-eDP bridge from Analogix. Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-by: Maxime Ripard Cc: Vagrant Cascadian --- arch/arm/dts/Makefile

[U-Boot] [PATCH v4 3/5] sunxi: DT: A64: update device tree files for Allwinner A64 SoC

2018-10-28 Thread Vasily Khoruzhick
Updates the device tree files from the linux-next tree, exactly Linux commit: commit 8c60c36d0b8c (tag: next-20181019) Author: Stephen Rothwell Date: Fri Oct 19 18:13:43 2018 +1100 Add linux-next specific files for 20181019 Signed-off-by: Stephen Rothwell Signed-off-by: Vasily

[U-Boot] [PATCH v4 1/5] mmc: sunxi: add support for automatic delay calibration

2018-10-28 Thread Vasily Khoruzhick
A64 and H6 support automatic delay calibration and Linux driver uses it instead of hardcoded delays. Add support for it to u-boot driver. Fixes eMMC instability on Pinebook Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-by: Maxime Ripard Reviewed-by: Andre Przywara Cc

[U-Boot] [PATCH v4 2/5] dm: video: bridge: don't fail to activate bridge if reset or sleep GPIO is missing

2018-10-28 Thread Vasily Khoruzhick
Both GPIOs are optional, so we shouldn't fail if any is missing. Without this fix reset is not deasserted if sleep GPIO is missing. Signed-off-by: Vasily Khoruzhick Acked-by: Maxime Ripard Tested-by: Maxime Ripard Reviewed-by: Andre Przywara Cc: Vagrant Cascadian --- drivers/video/b

[U-Boot] [PATCH v4 0/5] Add support for Pinebook

2018-10-28 Thread Vasily Khoruzhick
well - init ret variable in video_bridge_set_active() - fix order of dts files Makefile - split anx6345 binding into sun50i-a64-pinebook-u-boot.dts - drop speaker_amp node from pinebook dts - drop unnecessary options from defconfig v4: - sync device tree files with linux-next V

Re: [U-Boot] [PATCH 3/3] pwm: sunxi: choose best prescaler to improve PWM resolution

2018-10-24 Thread Vasily Khoruzhick
I think this series already went into Anatolij's u-boot-staging/ag...@denx.de, please make sure that you don't introduce any conflicts.On Wed, Oct 24, 2018 at 9:28 AM Jagan Teki wrote: > > On Wed, Oct 17, 2018 at 10:28 AM Vasily Khoruzhick wrote: > > > > Choose b

Re: [U-Boot] [PATCH 3/3] pwm: sunxi: choose best prescaler to improve PWM resolution

2018-10-22 Thread Vasily Khoruzhick
On Mon, Oct 22, 2018 at 11:29 AM Jagan Teki wrote: > > On Wed, Oct 17, 2018 at 10:28 AM Vasily Khoruzhick wrote: > > > > Choose best prescaler to improve PWM resolution. Without this change > > driver chooses first prescaler that gives us period value within > >

  1   2   3   >