[PATCH] board: ti: am62px: tifs-rm-cfg/rm-cfg: Update DMA resource sharing for CPSW

2025-02-05 Thread Siddharth Vadapalli
s ability to claim the CPSW DMA resources listed above. Signed-off-by: Siddharth Vadapalli --- Hello, This patch is based on commit d6da3dbaef Merge patch series "cmd: Add support for optee commands." of the next branch of U-Boot. Patch has been tested on AM62PX SoC running Linux, ens

[PATCH v2 1/2] configs: j721e_evm_a72_defconfig: Re-enable MUX_MMIO at U-Boot proper

2025-02-01 Thread Siddharth Vadapalli
nfigs: j721e_evm_*_defconfig: Add configs for Hyperflash boot") Signed-off-by: Siddharth Vadapalli --- This patch has been newly introduced in this series and has no v1. configs/j721e_evm_a72_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/j721e_evm_a72_d

[PATCH v2 2/2] configs: j7200_evm_a72_defconfig: Re-enable MUX_MMIO at U-Boot proper

2025-02-01 Thread Siddharth Vadapalli
regression by re-enabling MUX_MMIO. Fixes: 038f6faea9f0 ("configs: j7200_evm_*_defconfig: Add configs for Hyperflash boot") Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/patch/20250127162509.965644-1-s-vadapa...@ti.com/ Changes since v1: - Rephra

[PATCH v2 0/2] FIX: Re-enable MUX_MMIO on J721E/J7200

2025-02-01 Thread Siddharth Vadapalli
-vadapa...@ti.com/ Changes since v1: - Added patch to fix issue on J721E as well. Regards, Siddharth. Siddharth Vadapalli (2): configs: j721e_evm_a72_defconfig: Re-enable MUX_MMIO at U-Boot proper configs: j7200_evm_a72_defconfig: Re-enable MUX_MMIO at U-Boot proper configs

Re: [PATCH] configs: j7200_evm_a72_defconfig: Re-enable CONFIG_MUX_MMIO

2025-01-28 Thread Siddharth Vadapalli
On Mon, Jan 27, 2025 at 09:53:33PM +0530, Siddharth Vadapalli wrote: +Vaishnav. I had accidentally sent the patch to the wrong email address. > Commit under Fixes which claimed to enable configs for Hyperflash, changed > "CONFIG_MUX_MMIO=y" to "CONFIG_SPL_MUX_MMIO=y"

[PATCH] configs: j7200_evm_a72_defconfig: Re-enable CONFIG_MUX_MMIO

2025-01-27 Thread Siddharth Vadapalli
p for PCIe, which is done by the drivers/mux/mmio.c driver. Fix this by re-enabling CONFIG_MUX_MMIO. Fixes: 038f6faea9f0 ("configs: j7200_evm_*_defconfig: Add configs for Hyperflash boot") Signed-off-by: Siddharth Vadapalli --- Hello, This patch is based on commit d8a7100d658 Subtre

[PATCH] configs: am62ax_evm_a53_defconfig: enable USB DFU support

2025-01-22 Thread Siddharth Vadapalli
The config fragment "am62x_a53_usbdfu.config" which adds USB DFU support for AM62x SoC is applicable to the AM62Ax SoC as well. Hence, include it in "am62ax_evm_a53_defconfig" in order to enable support for USB DFU flash and boot. Signed-off-by: Siddharth Vadapalli --- H

Re: [PATCH] usb: xhci-dwc3: Bail out if "dr_mode" is "peripheral"

2025-01-16 Thread Siddharth Vadapalli
On Thu, Jan 16, 2025 at 10:36:45AM +0100, Mattijs Korpershoek wrote: > Hi Siddharth, Hello Mattijs, > > On lun., déc. 09, 2024 at 15:20, Roger Quadros wrote: > > > Hi Siddharth, > > > > On 06/12/2024 13:04, Siddharth Vadapalli wrote: [...] > >> diff

Re: [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-20 Thread Siddharth Vadapalli
On Fri, Dec 20, 2024 at 10:37:49AM -0600, Tom Rini wrote: > On Fri, Dec 20, 2024 at 09:49:46PM +0530, Siddharth Vadapalli wrote: > > On Fri, Dec 20, 2024 at 08:25:28AM -0600, Tom Rini wrote: > > > On Fri, Dec 20, 2024 at 10:19:31AM +0530, Siddharth Vadapalli wrote: > > >

[PATCH v3 3/3] configs: am62px_evm_a53_defconfig: enable USB DFU support

2024-12-20 Thread Siddharth Vadapalli
_a53_defconfig" which are present in the "am62x_a53_usbdfu.config" config fragment that is being included. Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek Reviewed-by: Roger Quadros --- v2: https://patchwork.ozlabs.org/project/uboot/patch/20241218124542.351944

[PATCH v3 2/3] configs: am62x_r5_usbdfu: extend for AM62Px

2024-12-20 Thread Siddharth Vadapalli
Disable configs which are not required for USB DFU functionality, in order to allow reusing this fragment for AM62Px SoC. Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek Reviewed-by: Roger Quadros --- v2: https://patchwork.ozlabs.org/project/uboot/patch

[PATCH v3 1/3] board: ti: am62px: env: include environment for DFU Boot

2024-12-20 Thread Siddharth Vadapalli
Include the TI K3 DFU environment to support DFU Boot and DFU Flash. Also add "usb" to the list of "boot_targets". While at it, add a newline at the end of the file. Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek Reviewed-by: Roger Qu

[PATCH v3 0/3] Add support for USB DFU boot on AM62Px

2024-12-20 Thread Siddharth Vadapalli
ct/uboot/cover/20241218124542.3519447-1-s-vadapa...@ti.com/ The USB DFU config fragments for AM62x are to be re-used for enabling USB DFU boot on AM62Px as follows: R5 => am62px_evm_r5_defconfig + am62x_r5_usbdfu.config A53 => am62px_evm_a53_defconfig + am62x_a53_usbdfu.config Regards, Siddharth. Si

Re: [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-20 Thread Siddharth Vadapalli
On Fri, Dec 20, 2024 at 08:25:28AM -0600, Tom Rini wrote: > On Fri, Dec 20, 2024 at 10:19:31AM +0530, Siddharth Vadapalli wrote: > > On Thu, Dec 19, 2024 at 11:00:44AM -0600, Tom Rini wrote: > > > > Hello Tom, > > > > > On Thu, Dec 19, 2024 at 1

Re: [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-19 Thread Siddharth Vadapalli
On Fri, Dec 20, 2024 at 10:19:31AM +0530, Siddharth Vadapalli wrote: > On Thu, Dec 19, 2024 at 11:00:44AM -0600, Tom Rini wrote: > > Hello Tom, > > > On Thu, Dec 19, 2024 at 11:41:10AM +0200, Roger Quadros wrote: > > > > > > > > > O

Re: [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-19 Thread Siddharth Vadapalli
On Thu, Dec 19, 2024 at 11:00:44AM -0600, Tom Rini wrote: Hello Tom, > On Thu, Dec 19, 2024 at 11:41:10AM +0200, Roger Quadros wrote: > > > > > > On 19/12/2024 07:50, Siddharth Vadapalli wrote: [...] > > > > > > Please let me know if this patc

Re: [PATCH v2 3/5] configs: am62px_evm_a53_defconfig: enable USB DFU support

2024-12-19 Thread Siddharth Vadapalli
On Thu, Dec 19, 2024 at 11:38:23AM +0200, Roger Quadros wrote: > Hi Siddharth, > > On 19/12/2024 07:43, Siddharth Vadapalli wrote: > > On Wed, Dec 18, 2024 at 03:47:20PM +0200, Roger Quadros wrote: > > > > Hello Roger, > > > >> Hi Siddharth, > >

Re: [PATCH v2 5/5] doc: board: document support for USB DFU boot on AM62Px SoC

2024-12-18 Thread Siddharth Vadapalli
On Wed, Dec 18, 2024 at 04:08:01PM +0200, Roger Quadros wrote: Hello Roger, > > > On 18/12/2024 14:45, Siddharth Vadapalli wrote: [...] > > +DFU based boot > > +-- > > + > > +To boot the board over DFU, set the switches to DFU mode and connect t

Re: [PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-18 Thread Siddharth Vadapalli
On Wed, Dec 18, 2024 at 04:05:47PM +0200, Roger Quadros wrote: Hello Roger, > Hi Siddharth, > > On 18/12/2024 14:45, Siddharth Vadapalli wrote: > > Enable USB0 instance of the USB controller for USB DFU boot functionality > > which requires the "bootph-all" proper

Re: [PATCH v2 3/5] configs: am62px_evm_a53_defconfig: enable USB DFU support

2024-12-18 Thread Siddharth Vadapalli
On Wed, Dec 18, 2024 at 03:47:20PM +0200, Roger Quadros wrote: Hello Roger, > Hi Siddharth, > > On 18/12/2024 14:45, Siddharth Vadapalli wrote: > > The config fragment "am62x_a53_usbdfu.config" which adds USB DFU support > > for AM62x SoC is applicable to the AM6

Re: [PATCH v2 0/5] Add support for USB DFU boot on AM62Px

2024-12-18 Thread Siddharth Vadapalli
On Wed, Dec 18, 2024 at 01:59:37PM +0100, Mattijs Korpershoek wrote: Hello Mattijs, > Hi Siddharth, > > Thank you for the series. > > On mer., déc. 18, 2024 at 18:15, Siddharth Vadapalli > wrote: > > > Hello, > > > > This series add support for US

[PATCH v2 5/5] doc: board: document support for USB DFU boot on AM62Px SoC

2024-12-18 Thread Siddharth Vadapalli
Since USB DFU boot is supported on AM62Px SoC, document the steps required to build the image for USB DFU boot along with the steps to send images using the "dfu-util" tool. Signed-off-by: Siddharth Vadapalli --- This patch has been newly introduced in this series based on the dis

[PATCH v2 4/5] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-18 Thread Siddharth Vadapalli
Enable USB0 instance of the USB controller for USB DFU boot functionality which requires the "bootph-all" property in order to have USB enabled at all stages of the USB DFU boot. Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek --- v1: https://patchwork.ozlabs.o

[PATCH v2 2/5] configs: am62x_r5_usbdfu: extend for AM62Px

2024-12-18 Thread Siddharth Vadapalli
Disable configs which are not required for USB DFU functionality, in order to allow reusing this fragment for AM62Px SoC. Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek --- v1: https://patchwork.ozlabs.org/project/uboot/patch/20241217131658.2920799-4-s-vadapa...@ti.com

[PATCH v2 3/5] configs: am62px_evm_a53_defconfig: enable USB DFU support

2024-12-18 Thread Siddharth Vadapalli
_a53_defconfig" which are present in the "am62x_a53_usbdfu.config" config fragment that is being included. Signed-off-by: Siddharth Vadapalli --- This patch has been newly introduced in this series based on the discussion at: https://patchwork.ozlabs.org/project/uboot/patch/202412171316

[PATCH v2 1/5] board: ti: am62px: env: include environment for DFU Boot

2024-12-18 Thread Siddharth Vadapalli
Include the TI K3 DFU environment to support DFU Boot and DFU Flash. Also add "usb" to the list of "boot_targets". While at it, add a newline at the end of the file. Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/patch/2024121713165

[PATCH v2 0/5] Add support for USB DFU boot on AM62Px

2024-12-18 Thread Siddharth Vadapalli
be re-used for enabling USB DFU boot on AM62Px as follows: R5 => am62px_evm_r5_defconfig + am62x_r5_usbdfu.config A53 => am62px_evm_a53_defconfig + am62x_a53_usbdfu.config Series has been tested on AM62P5-SK. Logs validating USB DFU boot on AM62P5-SK with this series: https://gist.github.com

Re: [PATCH 2/4] board: ti: am62px: env: include environment for DFU Boot

2024-12-18 Thread Siddharth Vadapalli
On Wed, Dec 18, 2024 at 12:00:08PM +0100, Mattijs Korpershoek wrote: > On mer., déc. 18, 2024 at 15:44, Siddharth Vadapalli > wrote: > > > On Wed, Dec 18, 2024 at 10:57:36AM +0100, Mattijs Korpershoek wrote: > > > > Hello Mattijs, > > > >> Hi Sid

Re: [PATCH 2/4] board: ti: am62px: env: include environment for DFU Boot

2024-12-18 Thread Siddharth Vadapalli
On Wed, Dec 18, 2024 at 10:57:36AM +0100, Mattijs Korpershoek wrote: Hello Mattijs, > Hi Siddharth, > > Thank you for the patch. > > On mar., déc. 17, 2024 at 18:46, Siddharth Vadapalli > wrote: > > > Include the TI K3 DFU environment to support DFU Boot and DFU F

Re: [PATCH 1/4] dfu: do not overwrite "dfu_alt_info"

2024-12-17 Thread Siddharth Vadapalli
On Tue, Dec 17, 2024 at 02:55:13PM -0600, Jon Humphreys wrote: > Siddharth Vadapalli writes: > > > From: Jonathan Humphreys > > > > For use-cases such as USB DFU Boot, "spl_dfu_cmd()" will setup the > > appropriate value for "dfu_alt_info". To f

Re: [PATCH] dfu: Prevent set_dfu_alt_info() from overwriting a previous value

2024-12-17 Thread Siddharth Vadapalli
On Tue, Dec 17, 2024 at 02:48:35PM -0600, Jonathan Humphreys wrote: Hello Jon, Thank you for posting this patch. I will drop the equivalent of this patch when I post the v2 series for: https://patchwork.ozlabs.org/project/uboot/cover/20241217131658.2920799-1-s-vadapa...@ti.com/ > If CONFIG_SET_D

Re: [PATCH v2 0/5] EFI Capsule "dfu_alt_info" fixes for TI Boards

2024-12-17 Thread Siddharth Vadapalli
On Thu, Nov 28, 2024 at 12:09:41AM -0600, Jon Humphreys wrote: Hello Jon, > Siddharth Vadapalli writes: > > > On Mon, Nov 25, 2024 at 07:51:54PM -0600, Jon Humphreys wrote: > > > > Hello Jon, > > > > [...] > > > >> > >> Hi Siddharth

[PATCH 4/4] arm: dts: k3-am62p5-sk-u-boot: enable USB0 for USB DFU boot

2024-12-17 Thread Siddharth Vadapalli
Enable USB0 instance of the USB controller for USB DFU boot functionality which requires the "bootph-all" property in order to have USB enabled at all stages of the USB DFU boot. Signed-off-by: Siddharth Vadapalli --- arch/arm/dts/k3-am62p5-sk-u-boot.dtsi | 10 ++ 1 file c

[PATCH 3/4] configs: am62x_r5_usbdfu: extend for AM62Px

2024-12-17 Thread Siddharth Vadapalli
Disable configs which are not required for USB DFU functionality, in order to allow reusing this fragment for AM62Px SoC. Signed-off-by: Siddharth Vadapalli --- configs/am62x_r5_usbdfu.config | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/am62x_r5_usbdfu.config b/configs

[PATCH 2/4] board: ti: am62px: env: include environment for DFU Boot

2024-12-17 Thread Siddharth Vadapalli
Include the TI K3 DFU environment to support DFU Boot and DFU Flash. Also add "usb" to the list of "boot_targets". Signed-off-by: Siddharth Vadapalli --- board/ti/am62px/am62px.env | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/board/ti/am62px/a

[PATCH 0/4] Add support for USB DFU boot on AM62Px

2024-12-17 Thread Siddharth Vadapalli
U boot on AM62Px as follows: R5 => am62px_evm_r5_defconfig + am62x_r5_usbdfu.config A53 => am62px_evm_a53_defconfig + am62x_a53_usbdfu.config Series has been tested on AM62P5-SK. Logs validating USB DFU boot on AM62P5-SK with this series: https://gist.github.com/Siddharth-Vadapalli-at-TI/50198ee3348c2db73e0db

[PATCH 1/4] dfu: do not overwrite "dfu_alt_info"

2024-12-17 Thread Siddharth Vadapalli
function only when "dfu_alt_info" is not defined. Signed-off-by: Jonathan Humphreys Signed-off-by: Siddharth Vadapalli --- drivers/dfu/dfu.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index 756569217bb..ab8abae1d8

Re: [PATCH] configs: am62x_evm_*: Fix USB DFU configuration

2024-12-09 Thread Siddharth Vadapalli
On Mon, Dec 09, 2024 at 02:32:37PM +0200, Roger Quadros wrote: Hello Roger, > On 06/12/2024 12:07, Siddharth Vadapalli wrote: [...] > > Looking at the list of compatibles in dwc3-generic.c and focusing on the > > compatible "ti,keystone-dwc3", I see that this compatib

[PATCH] usb: xhci-dwc3: Bail out if "dr_mode" is "peripheral"

2024-12-06 Thread Siddharth Vadapalli
Since the compatible "snps,dwc3" can be specified in the device-tree for the Designware USB Controller configured for not only Host and OTG modes of operation, but also for Peripheral mode of operation, bail out if "dr_mode" is "peripheral". Signed-off-by: Siddhart

Re: [PATCH] configs: am62x_evm_*: Fix USB DFU configuration

2024-12-06 Thread Siddharth Vadapalli
On Fri, Dec 06, 2024 at 11:44:38AM +0200, Roger Quadros wrote: > > > On 06/12/2024 11:17, Roger Quadros wrote: > > Hello Siddharth, > > > > On 06/12/2024 09:19, Siddharth Vadapalli wrote: [...] > >> 2. With the understanding that "dr_mode" doesn

Re: [PATCH] configs: am62x_evm_*: Fix USB DFU configuration

2024-12-06 Thread Siddharth Vadapalli
On Fri, Dec 06, 2024 at 11:17:28AM +0200, Roger Quadros wrote: > Hello Siddharth, > > On 06/12/2024 09:19, Siddharth Vadapalli wrote: [...] > > While this fixes the issue, I am wondering if the issue lies elsewhere. > > In U-Boot, the compatible "snps,dwc3" is a

Re: [PATCH] configs: am62x_evm_*: Fix USB DFU configuration

2024-12-05 Thread Siddharth Vadapalli
; after "usb start", but the driver won't be probed (absence of "+" in the "Probed" column of "dm tree" output). I just wanted to point this out as a possible fix for other scenarios. Disabling "CONFIG_USB_XHCI_DWC3" seems to be the best c

Re: [PATCH] phy: don't spam console if phys property is absent in device node

2024-12-05 Thread Siddharth Vadapalli
t; Signed-off-by: Roger Quadros Reviewed-by: Siddharth Vadapalli Regards, Siddharth.

Re: [PATCH v2 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-12-04 Thread Siddharth Vadapalli
On Wed, Dec 04, 2024 at 11:57:14AM +0200, Roger Quadros wrote: > > > On 04/12/2024 09:47, Siddharth Vadapalli wrote: > > On Wed, Dec 04, 2024 at 09:32:23AM +0200, Roger Quadros wrote: > >> > >> > >> On 04/12/2024 07:16, Siddharth Vadapalli wrote: >

Re: [PATCH v2 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-12-04 Thread Siddharth Vadapalli
On Wed, Dec 04, 2024 at 04:36:53PM +0200, Roger Quadros wrote: > > > On 04/12/2024 15:37, Siddharth Vadapalli wrote: > > On Wed, Dec 04, 2024 at 02:34:56PM +0200, Roger Quadros wrote: > >> > >> > >> On 04/12/2024 12:05, Siddharth Vadapalli wrote: >

Re: [PATCH v2 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-12-04 Thread Siddharth Vadapalli
On Wed, Dec 04, 2024 at 02:34:56PM +0200, Roger Quadros wrote: > > > On 04/12/2024 12:05, Siddharth Vadapalli wrote: [...] > > Why not do what this patch does? What is the issue with the current > > patch (apart from the checks, which I could retain as well if others >

Re: [PATCH v2 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-12-03 Thread Siddharth Vadapalli
On Wed, Dec 04, 2024 at 09:32:23AM +0200, Roger Quadros wrote: > > > On 04/12/2024 07:16, Siddharth Vadapalli wrote: > > On Tue, Dec 03, 2024 at 09:23:11PM +0200, Roger Quadros wrote: [...] > >>> +++ b/drivers/usb/dwc3/dwc3-generic.c > >>> @@ -51,7

Re: [PATCH v2 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-12-03 Thread Siddharth Vadapalli
On Tue, Dec 03, 2024 at 09:23:11PM +0200, Roger Quadros wrote: Hello Roger, > Hi Siddharth, > > > On 03/12/2024 11:37, Siddharth Vadapalli wrote: > > There are only two callers of "dwc3_generic_probe()", namely: > > 1. dwc3_generic_peripheral_prob

[PATCH v2 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-12-03 Thread Siddharth Vadapalli
ed on the caller of "dwc3_generic_probe()". Ideally, the USB ID pin should be used to determine whether or not the requested role can be enabled. However, that can be implemented in the future as an incremental feature over the current implementation. Signed-off-by: Siddharth Vadapalli

[PATCH v2 2/2] board: ti: am62ax: env: include environment for DFU

2024-12-03 Thread Siddharth Vadapalli
Include the TI K3 DFU environment to support DFU Boot and DFU Flash. Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/list/?series=434253&state=%2A&archive=both No changes since v1. board/ti/am62ax/am62ax.env | 1 + 1 file changed, 1 insertion(

[PATCH v2 0/2] AM62A DWC3: Add support for USB DFU boot in OTG mode

2024-12-03 Thread Siddharth Vadapalli
will be required to test USB DFU on AM62A (bootph-all property to be added to ensure that USB Controller is present at all stages for DFU Boot): https://gist.github.com/Siddharth-Vadapalli-at-TI/53ba02cb0ff4a09c47e920d08247065f The above device-tree changes will be made to the Linux device-tree,

Re: [PATCH 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-12-01 Thread Siddharth Vadapalli
On Fri, Nov 29, 2024 at 02:28:36PM +0200, Roger Quadros wrote: > > > On 28/11/2024 19:20, Siddharth Vadapalli wrote: [...] > > USB DFU boot utilizes this driver when the "dr_mode" is set to "otg" in > > the device-tree for AM62A. This driver is invoked

Re: [PATCH 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-11-28 Thread Siddharth Vadapalli
Hello Roger, On 28-11-2024 18:40, Roger Quadros wrote: > > > On 26/11/2024 14:03, Siddharth Vadapalli wrote: >> There are only two callers of "dwc3_generic_probe()", namely: >> 1. dwc3_generic_peripheral_probe() >> 2. dwc3_generic_host_probe() >> Curre

Re: [PATCH 0/2] AM62A DWC3: Add support for USB DFU boot in OTG mode

2024-11-28 Thread Siddharth Vadapalli
Hello Roger, On 28-11-2024 18:15, Roger Quadros wrote: > > > On 26/11/2024 14:03, Siddharth Vadapalli wrote: >> Hello, >> >> This series adds support for USB DFU boot on TI's AM62A SoC which has >> two instances of DWC3 USB Controllers namely USB0 and

[PATCH 0/2] AM62A DWC3: Add support for USB DFU boot in OTG mode

2024-11-26 Thread Siddharth Vadapalli
tches in this series, the following device-tree changes will be required to test USB DFU on AM62A (bootph-all property to be added to ensure that USB Controller is present at all stages for DFU Boot): https://gist.github.com/Siddharth-Vadapalli-at-TI/53ba02cb0ff4a09c47e920d08247065f The above devic

[PATCH 1/2] usb: dwc3-generic: set "mode" based on caller of dwc3_generic_probe()

2024-11-26 Thread Siddharth Vadapalli
e expected "mode" of the USB Controller, use that "mode" instead of the one specified in the device-tree. This shall allow the USB Controller to function both as a "Host" and as a "Peripheral" when the "mode" is "otg" in the device-tre

[PATCH 2/2] board: ti: am62ax: env: include environment for DFU

2024-11-26 Thread Siddharth Vadapalli
Include the TI K3 DFU environment to support DFU Boot and DFU Flash. Signed-off-by: Siddharth Vadapalli --- board/ti/am62ax/am62ax.env | 1 + 1 file changed, 1 insertion(+) diff --git a/board/ti/am62ax/am62ax.env b/board/ti/am62ax/am62ax.env index 97122fb57ba..96d9e1e2797 100644 --- a/board/ti

Re: [PATCH v2 1/5] board: ti: am64x: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-25 Thread Siddharth Vadapalli
On Tue, Nov 26, 2024 at 10:33:30AM +0530, Vignesh Raghavendra wrote: Hello Vignesh, [...] > > + /* > > +* Since the EFI Capsule support is enabled only for Serial Flash, > > +* update the "dfu_alt_info" environment variable only if the > > +* interface happens to be "sf" (Serial Fl

Re: [PATCH v2 0/5] EFI Capsule "dfu_alt_info" fixes for TI Boards

2024-11-25 Thread Siddharth Vadapalli
On Mon, Nov 25, 2024 at 07:51:54PM -0600, Jon Humphreys wrote: Hello Jon, [...] > > Hi Siddharth, this is an issue that I also discovered while working on a > separate issue with Collabora, but haven't posted a patch yet. The issue > is that when DFU booting, spl_dfu_cmd() will setup it's own

Re: [PATCH v2 5/5] board: ti: j784s4: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-24 Thread Siddharth Vadapalli
On Mon, Nov 25, 2024 at 09:29:01AM +0530, Kumar, Udit wrote: > Hi Siddharth > > On 11/24/2024 12:37 PM, Siddharth Vadapalli wrote: > > Commit a4d5e5daa847 ("board: sk-am69: Define capsule update firmware info") > > updated the "dfu_alt_info" variab

Re: [PATCH v2 1/5] board: ti: am64x: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-24 Thread Siddharth Vadapalli
On Mon, Nov 25, 2024 at 09:27:50AM +0530, Kumar, Udit wrote: > On 11/24/2024 12:37 PM, Siddharth Vadapalli wrote: > > Commit 5b84d2de5e6c ("board: am64x: Define capsule update firmware info") > > updated the "dfu_alt_info" variable to support use-cases with Ser

Re: [PATCH v2 2/5] board: ti: j721e: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-24 Thread Siddharth Vadapalli
On Mon, Nov 25, 2024 at 09:27:08AM +0530, Kumar, Udit wrote: > Hi Siddharth Hello Udit, > > On 11/24/2024 12:37 PM, Siddharth Vadapalli wrote: > > Commit 9bd6cc292fa8 ("board: j721e: Define capsule update firmware info") > > updated the "dfu_alt_info"

[PATCH v2 5/5] board: ti: j784s4: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-23 Thread Siddharth Vadapalli
nfo" only when the interface is "sf". Fixes: a4d5e5daa847 ("board: sk-am69: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-6-s-vadapa...@ti.com/ Changes since v1: - R

[PATCH v2 4/5] board: ti: am62px: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-23 Thread Siddharth Vadapalli
nfo" only when the interface is "sf". Fixes: 0af78a1a729d ("board: am62px: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-5-s-vadapa...@ti.com/ Changes since v1: - R

[PATCH v2 3/5] board: ti: am62x: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-23 Thread Siddharth Vadapalli
nfo" only when the interface is "sf". Fixes: 2af879df86f8 ("board: am62x: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-4-s-vadapa...@ti.com/ Changes since v1: - Replaced &qu

[PATCH v2 2/5] board: ti: j721e: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-23 Thread Siddharth Vadapalli
nfo" only when the interface is "sf". Fixes: 9bd6cc292fa8 ("board: j721e: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-3-s-vadapa...@ti.com/ Changes since v1: - Replaced &qu

[PATCH v2 1/5] board: ti: am64x: evm: Set "dfu_alt_info" only if interface is Serial Flash

2024-11-23 Thread Siddharth Vadapalli
nfo" only when the interface is "sf". Fixes: 5b84d2de5e6c ("board: am64x: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- v1: https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-2-s-vadapa...@ti.com/ Changes since v1: - Replaced &qu

[PATCH v2 0/5] EFI Capsule "dfu_alt_info" fixes for TI Boards

2024-11-23 Thread Siddharth Vadapalli
ace is indeed Serial Flash ("sf"), it breaks use-cases such as USB DFU Boot where the interface is RAM ("ram"). As of commit 52c0e5f8a3 Merge branch '2024-11-22-assorted-fixes' of the master branch of U-Boot, USB DFU Boot on AM625-SK is non-functional. Logs:

[PATCH 5/5] board: ti: j784s4: evm: Set "dfu_alt_info" only if interface is SPI Flash

2024-11-23 Thread Siddharth Vadapalli
nfo" only when the interface is "sf". Fixes: a4d5e5daa847 ("board: sk-am69: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- board/ti/j784s4/evm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/board/ti/j784s4/evm.c b/boa

[PATCH 4/5] board: ti: am62px: evm: Set "dfu_alt_info" only if interface is SPI Flash

2024-11-23 Thread Siddharth Vadapalli
only when the interface is "sf". Fixes: 0af78a1a729d ("board: am62px: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- board/ti/am62px/evm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/board/ti/am62px/evm.c b/boa

[PATCH 2/5] board: ti: j721e: evm: Set "dfu_alt_info" only if interface is SPI Flash

2024-11-23 Thread Siddharth Vadapalli
only when the interface is "sf". Fixes: 9bd6cc292fa8 ("board: j721e: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- board/ti/j721e/evm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/board/ti/j721e/evm.c b/board/ti/j7

[PATCH 1/5] board: ti: am64x: evm: Set "dfu_alt_info" only if interface is SPI Flash

2024-11-23 Thread Siddharth Vadapalli
only when the interface is "sf". Fixes: 5b84d2de5e6c ("board: am64x: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- board/ti/am64x/evm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/board/ti/am64x/evm.c b/board/ti/am

[PATCH 3/5] board: ti: am62x: evm: Set "dfu_alt_info" only if interface is SPI Flash

2024-11-23 Thread Siddharth Vadapalli
only when the interface is "sf". Fixes: 2af879df86f8 ("board: am62x: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli --- board/ti/am62x/evm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/board/ti/am62x/evm.c b/board/ti/am

[PATCH 0/5] EFI Capsule "dfu_alt_info" fixes for TI Boards

2024-11-23 Thread Siddharth Vadapalli
is indeed SPI Flash ("sf"), it breaks use-cases such as USB DFU Boot where the interface is RAM ("ram"). As of commit 52c0e5f8a3 Merge branch '2024-11-22-assorted-fixes' of the master branch of U-Boot, USB DFU Boot on AM625-SK is non-functional. Logs:

[PATCH v3 2/2] configs: j7200_evm_a72_defconfig: Enable configs for PCI support

2024-10-13 Thread Siddharth Vadapalli
TI's J7200 SoC has a single instance of PCIe Controller namely PCIe1 which is a Cadence PCIe Controller. To support PCIe functionality with the PCIe1 instance of PCIe, enable the corresponding configs. Signed-off-by: Siddharth Vadapalli --- v2: https://patchwork.ozlabs.org/project/uboot/

[PATCH v3 1/2] pci: Add TI K3 Cadence PCIe Controller

2024-10-13 Thread Siddharth Vadapalli
Add support for the Cadence PCIe Controller present on TI's K3 SoCs. This driver is an adaptation of the Linux driver. Signed-off-by: Siddharth Vadapalli --- v2: https://patchwork.ozlabs.org/project/uboot/patch/20241011130258.3452687-2-s-vadapa...@ti.com/ Changes since v2: - Addressed

[PATCH v3 0/2] Add TI K3 PCIe Controller support for J7200

2024-10-13 Thread Siddharth Vadapalli
7200_evm_a72_defconfig to enable NVMe configs since NVMe is now supported with this series. The logs corresponding to validating PCI Root-Complex functionality with an NVMe SSD connected to the PCIe Connector on J7200-EVM are at: https://gist.github.com/Siddharth-Vadapalli-at-TI/c64a2defa6b5b59e

Re: [PATCH v2 1/2] pci: Add TI K3 Cadence PCIe Controller

2024-10-11 Thread Siddharth Vadapalli
On Fri, Oct 11, 2024 at 07:15:03PM -0600, Tom Rini wrote: Hello Tom, > On Fri, Oct 11, 2024 at 06:32:57PM +0530, Siddharth Vadapalli wrote: > > Add support for the Cadence PCIe Controller present on TI's K3 SoCs. > > This driver is an adaptation of the Linux driver. &g

[PATCH v2 2/2] configs: j7200_evm_a72_defconfig: Enable configs for PCI support

2024-10-11 Thread Siddharth Vadapalli
TI's J7200 SoC has a single instance of PCIe Controller namely PCIe1 which is a Cadence PCIe Controller. To support PCIe functionality with the PCIe1 instance of PCIe, enable the corresponding configs. Signed-off-by: Siddharth Vadapalli --- configs/j7200_evm_a72_defconfig | 5 + 1

[PATCH v2 1/2] pci: Add TI K3 Cadence PCIe Controller

2024-10-11 Thread Siddharth Vadapalli
Add support for the Cadence PCIe Controller present on TI's K3 SoCs. This driver is an adaptation of the Linux driver. Signed-off-by: Siddharth Vadapalli --- drivers/pci/Kconfig| 6 + drivers/pci/Makefile | 1 + drivers/pci/pcie_cdns_ti.c

[PATCH v2 0/2] Add TI K3 PCIe Controller support for J7200

2024-10-11 Thread Siddharth Vadapalli
ponding to validating PCI Root-Complex functionality with an NVMe SSD connected to the PCIe Connector on J7200-EVM are at: https://gist.github.com/Siddharth-Vadapalli-at-TI/18a64e0c258f74274d80c5871594f0dc Regards, Siddharth. Siddharth Vadapalli (2): pci: Add TI K3 Cadence PCIe Controller

Re: [PATCH] usb: gadget: cdns3: Fix cdns3_ep_config() by setting ep.maxpacket

2024-10-07 Thread Siddharth Vadapalli
On Mon, Oct 07, 2024 at 05:37:52PM +0530, Siddharth Vadapalli wrote: > On Mon, Oct 07, 2024 at 03:02:34PM +0300, Roger Quadros wrote: > > Hello Roger, [...] > > from include/linux/usb/gadget.h > > > > * struct usb_ep - device side representation of USB endpoint &g

[PATCH v2] usb: gadget: cdns3: Fix cdns3_ep_config() by setting ep.maxpacket

2024-10-07 Thread Siddharth Vadapalli
cket" member of "struct usb_ep", it may lead to an incorrect value of TD_SIZE when compared with what the USB controller actually expects (max_packet_size). Fix this. Fixes: 7e91f6ccdc84 ("usb: Add Cadence USB3 host and gadget driver") Signed-off-by: Siddharth Vadapall

Re: [PATCH] usb: gadget: cdns3: Fix cdns3_ep_config() by setting ep.maxpacket

2024-10-07 Thread Siddharth Vadapalli
On Mon, Oct 07, 2024 at 03:02:34PM +0300, Roger Quadros wrote: Hello Roger, > On 07/10/2024 13:42, Siddharth Vadapalli wrote: > > The function cdns3_ep_config() calculates the maximum packet size based > > on the Endpoint Type and the Gadget Speed and stores it

[PATCH] usb: gadget: cdns3: Fix cdns3_ep_config() by setting ep.maxpacket

2024-10-07 Thread Siddharth Vadapalli
cket" member of "struct usb_ep", it may lead to an incorrect value of TD_SIZE when compared with what the USB controller actually expects (max_packet_size). Fix this by using usb_ep_set_maxpacket_limit(). Fixes: 7e91f6ccdc84 ("usb: Add Cadence USB3 host and gadget driver")

[PATCH] usb: gadget: cdns3: Fix missing cache operations for non-zero Endpoints

2024-09-30 Thread Siddharth Vadapalli
, failing to invalidate the cache associated with the TRB pool within cdns3_transfer_completed() results in the transfers never being completed. Fix this. Fixes: 7e91f6ccdc84 ("usb: Add Cadence USB3 host and gadget driver") Signed-off-by: Siddharth Vadapalli --- Hello, This patch is based

Re: [RFC PATCH 1/2] pci: Add TI K3 Cadence PCIe Controller

2024-08-21 Thread Siddharth Vadapalli
On Wed, Aug 21, 2024 at 12:00:20PM -0600, Tom Rini wrote: > On Wed, Aug 21, 2024 at 08:29:07PM +0530, Siddharth Vadapalli wrote: > [...] > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > >

[RFC PATCH 2/2] configs: j7200_evm_a72_defconfig: Enable configs for PCI support

2024-08-21 Thread Siddharth Vadapalli
TI's J7200 SoC has a single instance of PCIe Controller namely PCIe1 which is a Cadence PCIe Controller. To support PCI functionality with the PCIe1 instance of PCIe, enable the corresponding configs. Signed-off-by: Siddharth Vadapalli --- configs/j7200_evm_a72_defconfig | 4 1

[RFC PATCH 1/2] pci: Add TI K3 Cadence PCIe Controller

2024-08-21 Thread Siddharth Vadapalli
Add support for the Cadence PCIe Controller present on TI's K3 SoCs. This driver is an adaptation of the Linux driver. Signed-off-by: Siddharth Vadapalli --- drivers/pci/Kconfig| 6 + drivers/pci/Makefile | 1 + drivers/pci/pcie_cdns_ti.c

[RFC PATCH 0/2] Add TI K3 PCIe Controller support for J7200

2024-08-21 Thread Siddharth Vadapalli
series with the following changes made to the device-tree for J7200: https://gist.github.com/Siddharth-Vadapalli-at-TI/1a498722ebb332da6f88abe05a43f2c4 The device-tree changes are required since the "reg-mux" driver is not currently implemented in U-Boot. I will work on porting the "

Re: [PATCH] usb: cdns3: continue probe even when USB PHY device does not exist

2024-07-02 Thread Siddharth Vadapalli
On Tue, Jul 02, 2024 at 04:20:43PM +0300, Roger Quadros wrote: > > > On 02/07/2024 15:07, Siddharth Vadapalli wrote: > > Prior to commit cd295286c786 ("usb: cdns3: avoid error messages if phys > > don't exist"), cdns3_probe() errors out only on failing

[PATCH] usb: cdns3: continue probe even when USB PHY device does not exist

2024-07-02 Thread Siddharth Vadapalli
Extend commit cd295286c786 to treat -ENODEV as an acceptable return value of generic_phy_get_by_name() and continue device probe as was the case prior to the commit. Fixes: cd295286c786 ("usb: cdns3: avoid error messages if phys don't exist") Signed-off-by: Siddharth Vadapalli ---

[PATCH] board/include: ti/env: j721e.env/ti_common: Fix cpsw0_qsgmii_phyinit

2024-06-27 Thread Siddharth Vadapalli
do_main_cpsw0_qsgmii_phyinit" which defaults to setting "do_main_cpsw0_qsgmii_phyinit" to zero, but at the same time, it allows the board to update the value at runtime. Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally") Signed-off-by: Siddha

Re: [PATCH 1/5] net: eth-uclass: guard against reentrant eth_init()/eth_halt() calls

2024-04-26 Thread Siddharth Vadapalli
On Fri, Apr 26, 2024 at 10:02:24AM +0200, Matthias Schiffer wrote: > With netconsole, any log message can result in an eth_init(), possibly > causing an reentrant call into eth_init() if a driver's ops print > anything: > > eth_init() -> driver.start() -> printf() -> netconsole -> eth_init() >

Re: [PATCH v2] net: ti: am65-cpsw-nuss: handle missing PHY in am65_cpsw_phy_init() gracefully

2024-03-28 Thread Siddharth Vadapalli
4 gigabit eth switch > subsystem driver") > Signed-off-by: Alexander Sverdlin Reviewed-by: Siddharth Vadapalli Regards, Siddharth.

Re: [PATCH] net: ti: am65-cpsw-nuss: Don't crash in am65_cpsw_phy_init()

2024-03-28 Thread Siddharth Vadapalli
to emphasize this instead. Something like: net: ti: am65-cpsw-nuss: Update am65_cpsw_phy_init() to handle PHY absence The rest of the patch looks good to me. With the subject reworded, Reviewed-by: Siddharth Vadapalli Regards, Siddharth. > > am65_cpsw_ofdata_parse_phy() tries to handle

Re: [PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-20 Thread Siddharth Vadapalli
On 24/02/20 03:24PM, Siddharth Vadapalli wrote: > On 24/02/20 12:51PM, Dan Carpenter wrote: > > On Fri, Feb 16, 2024 at 04:11:05PM +0530, Siddharth Vadapalli wrote: > > > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c > > > index eea9ec9659..8a6625f034

[PATCH v2] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-20 Thread Siddharth Vadapalli
es: a8837cf43839 ("dma: ti: k3-udma: Query DMA channels allocated from Resource Manager") Signed-off-by: Siddharth Vadapalli --- Hello, This patch is based on commit 3e6f2a94bf Merge tag 'u-boot-imx-master-20240219' of https://gitlab.denx.de/u-boot/custodians/u-boot

Re: [PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-20 Thread Siddharth Vadapalli
On 24/02/20 12:51PM, Dan Carpenter wrote: > On Fri, Feb 16, 2024 at 04:11:05PM +0530, Siddharth Vadapalli wrote: > > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c > > index eea9ec9659..8a6625f034 100644 > > --- a/drivers/dma/ti/k3-udma.c > > +++

[PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-16 Thread Siddharth Vadapalli
es: a8837cf43839 ("dma: ti: k3-udma: Query DMA channels allocated from Resource Manager") Signed-off-by: Siddharth Vadapalli --- Hello, This patch is based on commit 9e00b6993f Merge tag 'u-boot-dfu-20240215' of https://source.denx.de/u-boot/custodians/u-boot-dfu of the master

  1   2   >