ned-off-by: Rabin Vincent
---
common/cli_hush.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index d643912..296542f 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
@@ -3217,7 +3217,7 @@ static int parse_stream_outer(struct in_str
On Sat, Nov 01, 2014 at 09:12:37AM -0600, Simon Glass wrote:
> On 29 October 2014 16:21, Rabin Vincent wrote:
> > + assert(run_command("setenv ut_var '\"'; setenv ut_var2
> > \"${ut_var}\"", 0) == 0);
> > + assert(!st
On Sat, Nov 01, 2014 at 09:11:34AM -0600, Simon Glass wrote:
> On 29 October 2014 16:21, Rabin Vincent wrote:
> > Attempting to run the sandbox leads to a segfault, because some dynamic
> > libraries (outside of u-boot) attempt to use malloc() to allocate memory
> > before u-
parse_stream_outer() checks for rcode not being -1, but rcode is only
ever 0 or 1.
Signed-off-by: Rabin Vincent
---
common/cli_hush.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index 9607e93..a07ae71 100644
--- a/common/cli_h
t\;'setenv catX "setenv catout
'\\\''\$\$catin'\\\''"' \; run catX
Signed-off-by: Rabin Vincent
---
test/command_ut.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/test/command_ut.c b/test/command_ut.c
index 926573a..21804a4
sandbox crashes if a variable is set in the -c command, because
hush's top_vars is not allocated. Call cli_init() from sandbox
to ensure this is done before we execute the -c command.
$ ./u-boot -c 'a=1'
...
Segmentation fault (core dumped)
Signed-off-by: Rabin Vincent
---
a
init.c:126
#8 0x77ddd1ca in _dl_start_user () from /lib64/ld-linux-x86-64.so.2
Signed-off-by: Rabin Vincent
---
common/dlmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/dlmalloc.c b/common/dlmalloc.c
index f987339..d87834d 100644
--- a/common/dlmalloc
run_command() returns success even if the command had a syntax error;
correct this behaviour.
Signed-off-by: Rabin Vincent
---
common/cli_hush.c | 2 +-
test/command_ut.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/cli_hush.c b/common/cli_hush.c
index a07ae71
Attempting to run:
- an empty string
- a string with just spaces
returns different error codes, 1 for the empty string and 0
for the string with just spaces. Make both of them return
0 for consistency.
Signed-off-by: Rabin Vincent
---
common/cli_hush.c | 4 +++-
test/command_ut.c | 3 +++
2
On Thu, Apr 14, 2011 at 04:03, Simon Glass wrote:
> On Wed, Apr 13, 2011 at 12:16 PM, Andy Fleming wrote:
>>> + read_buf &= ~HW_CFG_RXDOFF_;
>>> +
>>> +#ifdef CONFIG_TEGRA2
>>> + /* Tegra2 requires NET_IP_ALIGN = 0 */
>>> +#define NET_IP_ALIGN 0
>>> +#else
>>> + /* set Rx data o
Use C structs for registers, and use readl/writel instead of custom
accessors.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
drivers/serial/serial_pl01x.c | 56 ++--
drivers/serial/serial_pl01x.h | 41 --
2 files
Hi Tom,
On Sun, Apr 11, 2010 at 10:45:41PM +0200, Tom wrote:
> Rabin Vincent wrote:
> > On Fri, Apr 9, 2010 at 6:57 PM, Vaibhav Bedia
> > wrote:
> >> As all Cortex processors implement the ARMv7 architecture a better grouping
> >> IMHO would be cpu/cortex/a8 an
+endif
>
> Using an `ifdef' / `else' / `endif' would seem more logical to me.
Updated patch below.
Rabin
>From 2131e817d21162d0dd47b56cc068eb868b1ac7fc Mon Sep 17 00:00:00 2001
From: Rabin Vincent
Date: Tue, 13 Apr 2010 15:18:56 +0530
Subject: [PATCHv2 1/2] Allow SOC to
$CPUDIR. CPU-specific Makefiles can
choose to include code from inside $SUBCPU as necessary.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
Makefile |2 +-
board/freescale/mx51evk/config.mk |2 +-
config.mk |7 ++-
doc
A9, we don't put
any source files in the top-level a8 directory. When such code is
needed, we can put the a8-specific code and Makefiles in
arch/arm/cpu/cortex/a8 and use $SUBCPU to reference it from the
arch/arm/cpu/cortex Makefiles.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vi
On Fri, Apr 9, 2010 at 6:57 PM, Vaibhav Bedia wrote:
> As all Cortex processors implement the ARMv7 architecture a better grouping
> IMHO would be cpu/cortex/a8 and cpu/cortex/a9. The common stuff can be under
> cpu/cortex/.
Perhaps Tom can clarify if he's OK with this, since he wanted a separate
Add base board code for the MOP500 board, which uses the U8500 SoC.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
MAINTAINERS |4 ++
MAKEALL |9 +++
Makefile |9 +++-
board/stericsson/mop500
The Ux500 variants of the pl011 have separate LCRH registers for RX and
TX. The TX register is at the same offset as the unmodified pl011, so
we need to additionally program only the RX register.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
drivers/serial/serial_pl01x.c |8
Add the base SoC code for ST-Ericsson's Ux500 series of Cortex A9 based
SoCs.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/arm_cortexa9/ux500/Makefile | 45 ++
cpu/arm_cortexa9/ux500/clock.c| 56 +++
cpu/arm_cortexa9/
Conditionally compile the code calling lowlevel_init, to avoid the
following build error when CONFIG_SKIP_LOWLEVEL_INIT is defined:
start.S:218: undefined reference to `lowlevel_init'
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/arm_cortexa9/start.S |4 +++-
1
Add Cortex A9 support by copying the code for Cortex A8. The only
change is a removal of some OMAP3 specific code.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/{arm_cortexa8 => arm_cortexa9}/Makefile |0
cpu/{arm_cortexa8 => arm_cortexa9}/config.mk |
It contains only 8815-specific addresses, so move it to an appropriate
location and name, freeing up the nomadik.h name for common
Nomadik-family peripherals.
Cc: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
.../{nomadik.h => asm-arm/arch-nomadik/nmdk881
Eliminate register address #defines by using C structs, and move the
rest of the header contents into timer.c.
Cc: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/arm926ejs/nomadik/timer.c | 45 ++--
include/asm-arm/arch-nomadik/mtu.h
Cc: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
drivers/gpio/nomadik_gpio.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/nomadik_gpio.c b/drivers/gpio/nomadik_gpio.c
index 670b684..d084235 100644
--- a
Change the Nomadik MTU driver to get the clock rate and prescaler from
the config file. Also remove the hardcoded divisors and do the
calculations based on the configured rate.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
drivers/misc/nomadik_mtu.c
The Nomadik MTU driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/arm926ejs/nomadik/Makefile |2 +-
drivers/misc/Makefile
Change the Nomadik GPIO driver to get the base addresses from platform
specific code, since it will be used on multiple platforms with
different base addresses.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
board/st/nhk8815/nhk8815.c |9
Eliminate some single-use macros. USEC_TO_COUNT and COUNT_TO_USEC are
replaced in a later patch.
Cc: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/arm926ejs/nomadik/timer.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/cpu
The Nomadik GPIO driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
board/st/nhk8815/nhk8815.c |2 +-
cpu/arm926ejs/nomadik/Makefile
v2: Addressed review comments.
This series adds base support for ST-Ericsson's Ux500 series of Cortex-A9 based
SoCs. Several peripherals are shared with the Nomadik family, for which
support already exists in U-Boot.
Rabin Vincent (13):
Nomadik: move nomadik.h to asm/arch/nhk8815.h
No
On Sun, Mar 28, 2010 at 07:49:15PM +0200, Tom wrote:
> Rabin Vincent wrote:
> > + /* UART2 */
> > + nmk_gpio_af(29, GPIO_ALT_C);
> > + nmk_gpio_af(30, GPIO_ALT_C);
>
> Change these to immediates to logical #define's
I've changed this in the other plac
On Sun, Mar 28, 2010 at 07:42:27PM +0200, Tom wrote:
> Rabin Vincent wrote:
> > +/* Turn on peripheral clock at PRCC level */
> > +void u8500_clock_enable(int periph, int kern, int cluster)
> > +{
> > + struct clkrst *clkrst = (struct clkrst *) clkrst_base[periph -
On Sun, Mar 28, 2010 at 07:32:17PM +0200, Tom wrote:
> Rabin Vincent wrote:
> > diff --git a/include/configs/nhk8815.h b/include/configs/nhk8815.h
[...]
> > #ifndef __ASSEMBLY__
> > -#include
> > +#include
>
> It would be better if the #include was not in co
On Sun, Mar 28, 2010 at 07:30:01PM +0200, Tom wrote:
> Rabin Vincent wrote:
> > The Nomadik MTU driver will also be used on the U8500 SoC, so move it
> > out of platform-specific code.
> >
> > Acked-by: Alessandro Rubini
> > Acked-by: Michael Brandt
Add base board code for the MOP500 board, which uses the U8500 SoC.
Acked-by: Michael Brandt
Tested-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
MAINTAINERS |4 ++
MAKEALL |1 +
Makefile |3 +
board
The Ux500 variants of the pl011 have separate LCRH registers for RX and
TX. The TX register is at the same offset as the unmodified pl011, so
we need to additionally program only the RX register.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
I have used the style of the surrounding
Conditionally compile the code calling lowlevel_init, to avoid the
following build error when CONFIG_SKIP_LOWLEVEL_INIT is defined:
start.S:218: undefined reference to `lowlevel_init'
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/arm_cortexa8/start.S |4 +++-
1
Add the base SoC code for ST-Ericsson's Ux500 series of Cortex A9 based
SoCs.
Even though this is a Cortex A9, we put it under Cortex A8 to avoid code
duplication, since the CPU specific code can be used unmodified across
the two CPUs.
Acked-by: Michael Brandt
Signed-off-by: Rabin Vi
Change the Nomadik MTU driver to get the clock rate and prescaler from
the config file. Also remove the hardcoded divisors and do the
calculations based on the configured rate.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
drivers/misc/nomadik_mtu.c
Change the Nomadik GPIO driver to get the base addresses from platform
specific code, since it will be used on multiple platforms with
different base addresses.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
board/st/nhk8815/nhk8815.c |7
quot; posted by Alessandro Rubini on 2009-11-25:
http://lists.denx.de/pipermail/u-boot/2009-November/064800.html
Cc: Alessandro Rubini
Rabin Vincent (8):
Nomadik: move timer code to drivers/misc
Nomadik: move gpio driver to drivers/gpio
nomadik_gpio: get base address from platform code
nomad
The Nomadik MTU driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
cpu/arm926ejs/nomadik/Makefile |2 +-
drivers/misc/Makefile
The Nomadik GPIO driver will also be used on the U8500 SoC, so move it
out of platform-specific code.
Acked-by: Alessandro Rubini
Acked-by: Michael Brandt
Signed-off-by: Rabin Vincent
---
board/st/nhk8815/nhk8815.c |2 +-
cpu/arm926ejs/nomadik/Makefile
On Fri, Jul 10, 2009 at 02:52:32PM +0200, Drasko DRASKOVIC wrote:
[...]
> Suppose that I allocated one register in start.S and put in it some data I
> want to have later on C side. From start.S we enter to start_armboot(void)
> function.
> Would this work :
>
> void start_armboot (void)
> {
>
On Tue, Jun 02, 2009 at 05:47:09PM +0200, Herrmann Ulrich wrote:
> Rabin Vincent's fix for little endian systems fixes only the issues
> regarding responses received on the command line.
> However the SD card's SCR register is received on the DAT0 line
> - therefore it must be handled in an endi
Andy,
On Sun, Apr 05, 2009 at 01:30:52PM +0530, Rabin Vincent wrote:
> Remove some repeated words and superfluous newlines in the mmc command
> help entries.
>
> Signed-off-by: Rabin Vincent
Any comments on this set of patches?
Rabin
__
Now that response is a uint, we can drop all the casts.
Signed-off-by: Rabin Vincent
---
drivers/mmc/fsl_esdhc.c | 10 +-
drivers/mmc/mmc.c | 20 ++--
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc
on little endian systems because they
assume that the bytes in the uints are in big endian byte order.
This patch fixes this by changing the response to be an array of four
uints and replacing the char-wise accesses with equivalent uint-wise
accesses.
Signed-off-by: Rabin Vincent
---
drivers
The generic MMC core uses direct long long divisions, which do not build
with ARM EABI toolchains. Use lldiv() instead, which works everywhere.
Signed-off-by: Rabin Vincent
---
drivers/mmc/mmc.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/mmc.c b
find_mmc_device returns NULL if an invalid device number is specified.
Check for this to avoid dereferencing NULL pointers.
Signed-off-by: Rabin Vincent
---
common/cmd_mmc.c |9 +
drivers/mmc/mmc.c |2 +-
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/common
Remove some repeated words and superfluous newlines in the mmc command
help entries.
Signed-off-by: Rabin Vincent
---
common/cmd_mmc.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
index f1fa32f..bd55ff1 100644
--- a/common
51 matches
Mail list logo
