Re: [PATCH v3 17/46] boot: Support compressed booti images in bootm

2024-12-05 Thread Peter Korsgaard
pressed, a check is made to NIT: DEcompressed. -- Bye, Peter Korsgaard

[PATCH v2] boot/image-board.c: boot_get_fpga(): pass compatible flag to fpga_load()

2024-11-05 Thread Peter Korsgaard
For E.G. signed FPGA bitstreams, similar to how it is done for the FPGA loading from SPL since commit 71f1a5392aad ("spl: fit: pass real compatible flags to fpga_load()"). Signed-off-by: Peter Korsgaard --- Changes since v1: - Reference correct SPL commit boot/image-bo

Re: [PATCH] boot/image-board.c: boot_get_fpga(): pass compatible flag to fpga_load()

2024-11-05 Thread Peter Korsgaard
On 10/28/24 17:55, Peter Korsgaard wrote: For E.G. signed FPGA bitstreams, similar to how it is done for the FPGA loading from SPL since commit 282eed50ecb7 ("fpga: pass compatible flags to fpga_load()"). Ups, that should have been commit 71f1a5392aad ("spl: fit: pass real c

[PATCH] boot/image-board.c: boot_get_fpga(): pass compatible flag to fpga_load()

2024-10-28 Thread Peter Korsgaard
For E.G. signed FPGA bitstreams, similar to how it is done for the FPGA loading from SPL since commit 282eed50ecb7 ("fpga: pass compatible flags to fpga_load()"). Signed-off-by: Peter Korsgaard --- boot/image-board.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletion

[PATCH] usb: dwc3-generic: Ensure reset GPIO is configured as an output

2023-06-28 Thread Peter Korsgaard
GPIOD_ACTIVE_LOW is not enough to configure a GPIO as an output, we need GPIOD_IS_OUT as well. Fixes: b252d79b0936d60b ("usb: dwc3: Add support to reset usb ULPI phy") Signed-off-by: Peter Korsgaard --- drivers/usb/dwc3/dwc3-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [U-Boot] [linux-sunxi] Re: [PATCH 1/3] dm: Add migration plan for CONFIG_BLK

2018-04-03 Thread Peter Korsgaard
win). But I don't think we can require people to have > both an arm and an aarch64 compiler available in order to build U-Boot > for some aarch64. No, please not. It would make it very hard to handle U-Boot builds in Buildroot for these boards. -- Bye, Peter Korsgaard _

Re: [U-Boot] [linux-sunxi] Re: [PATCH v3 1/5] sunxi: a64: Enable FIT Signature

2017-12-14 Thread Peter Korsgaard
>>>>> "Jagan" == Jagan Teki writes: > On Wed, Dec 13, 2017 at 9:38 PM, Peter Korsgaard wrote: >>>>>>> "Maxime" == Maxime Ripard writes: >> >> Hi, >> >> >> +++ b/arch/arm/mach-sunxi/Kconfig >>

Re: [U-Boot] [linux-sunxi] Re: [PATCH v3 1/5] sunxi: a64: Enable FIT Signature

2017-12-13 Thread Peter Korsgaard
I'm really not sure we should force it by default. How much code size > is it adding? Not only that, enabling FIT_SIGNATURE support disables support for the legacy images (uImage / boot.scr) for security reasons, so it may very well break existing setups. -- Bye, Peter Korsgaard __

Re: [U-Boot] Permission denied make: *** [core-dependencies] Error 126 in Buildroot-2015.08.1

2016-08-30 Thread Peter Korsgaard
n denied > /bin/bash: support/dependencies/check-host-tar.sh: Permission denied > /bin/bash: support/dependencies/check-host-xzcat.sh: Permission denied > /bin/bash: > /home/ram/Desktop/buildroot-2015.08.1/support/dependencies/dependencies.sh: > Permission denie

Re: [U-Boot] [PATCH v2] sunxi: display: Use PWM to drive backlight where applicable

2016-08-26 Thread Peter Korsgaard
, avoiding a brightness > change while the kernel loads. > +++ b/drivers/video/sunxi_display.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -34,7 +35,6 @@ > #define PWM_ON 1 > #define

Re: [U-Boot] [PATCH] sunxi: display: Use PWM to drive backlight where applicable

2016-08-22 Thread Peter Korsgaard
efine SUNXI_PWM_CTRL_POLARITY0(x) ((x) << 5) > + > +#define SUNXI_PWM_PERIOD_80PCT 0x04af03c0 > + > +#if defined CONFIG_MACH_SUN4I || defined CONFIG_MACH_SUN5I > +#define SUNXI_PWM_PIN0 SUNXI_GPB(2) > +#endif > + This should afaik wo

Re: [U-Boot] [PATCH] SPL: sunxi: don't force .BSS into DRAM

2016-06-30 Thread Peter Korsgaard
ei to point me > in the right direction I'd have spend even more time to find a fix. Agreed. The toolchain will complain loudly about an overflow of SRAM space, but not about BSS access before DRAM is available. -- Bye, Peter Korsgaard _

Re: [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times

2016-04-02 Thread Peter Korsgaard
gets free-ed on a probe failure or on removal, so we must safe the > pointer elsewhere. s/safe/save/ (twice). Otherwise it looks sensibe to me. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] sunxi: Add defconfig for yones toptech bs1078-v2 tablet

2016-03-22 Thread Peter Korsgaard
linux-sunxi.org/Yones_Toptech_BS1078_V2 Signed-off-by: Peter Korsgaard --- board/sunxi/MAINTAINERS | 5 + configs/Yones_Toptech_BS1078_V2_defconfig | 24 2 files changed, 29 insertions(+) create mode 100644 configs/Yones_Toptech_BS1078_V2_defconfig diff --gi

Re: [U-Boot] [PATCH] Add CONFIG_GMAC_TX_DELAY=4 for OlinuXino Lime2

2016-03-22 Thread Peter Korsgaard
iable connection. Arguably no connection is better then an > unreliable one. True. -- Venlig hilsen, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Add CONFIG_GMAC_TX_DELAY=4 for OlinuXino Lime2

2016-03-22 Thread Peter Korsgaard
and then >call the init function currently used for RTL8211C and others, >this assumes that the more generic init function will not reset >the force master mode bit. So what happens if you connect two of these boards together without a switch in between? Will they be ab

Re: [U-Boot] [PATCH 3/3] omap4_panda: Convert to config_distro_bootcmd.h

2016-03-15 Thread Peter Korsgaard
cboot; " \ > - "fi; " \ This breaks legacy boot on pandaboard here. In Buildroot we have the kernel + dtb in partition 0:2 and no custom boot script, which used to be handled by the loadimage stuff, but that is no longer called. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] sunxi: Sync dts files with the upstream kernel

2016-03-15 Thread Peter Korsgaard
dts files. I've asked the > authors of the kernel commits adding these to submit a matching defconfig > to u-boot. > dts => sun6i-a31s-yones-toptech-bs1078-v2.dts} | 180 --- FYI, I've done some work for this one.

Re: [U-Boot] [PATCH 0/4] ARM: sheevaplug: misc fixes

2016-03-14 Thread Peter Korsgaard
> I'll send the pull request shortly. Thanks! -- Venlig hilsen, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/4] ARM: sheevaplug: misc fixes

2016-03-14 Thread Peter Korsgaard
>>>>> "Luka" == Luka Perkov writes: Hi, > On Sun, Jan 17, 2016 at 06:23:41PM +0100, Peter Korsgaard wrote: >> The following patch series fixes a number of issues I noticed while updating >> a sheevaplug from 2013.10 to 2016.01: >> >&g

Re: [U-Boot] [PATCH] sunxi: power: add support for sy8106a driver

2016-02-21 Thread Peter Korsgaard
BLE > See I2C0_ENABLE help text. > endif > +if SUNXI_GEN_SUN6I > config R_I2C_ENABLE > bool "Enable the PRCM I2C/TWI controller" > -default n > +# This is used for the pmic on H3 > + default y if MACH_SUN8I_H3 > +default n if !MACH_S

Re: [U-Boot] Banan Pro (ahci-sunxi) SATA port stopped working after switching to U-Boot v2016.01

2016-01-22 Thread Peter Korsgaard
> According to the Bananapro VDD25-SATA either comes from a dedicated You forgot 'schematics'. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/4] ARM: sheevaplug: correct nand partition layout

2016-01-19 Thread Peter Korsgaard
instead of direct offsets? Thanks! True. I wanted to do as minimal change as possible, but I'll take a look at using mtdparts and send a patch. Thanks. -- Venlig hilsen, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/4] ARM: sheevaplug: unbreak kernel bootargs / mtdparts command by dropping double mtdparts=

2016-01-17 Thread Peter Korsgaard
y dropping the double 'mtdparts='. Signed-off-by: Peter Korsgaard --- include/configs/sheevaplug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h index 7d773a8..8110f83 100644 --- a/include/configs/sheeva

[U-Boot] [PATCH 3/4] ARM: sheevaplug: drop unneded 'usb start' from boot command

2016-01-17 Thread Peter Korsgaard
The default bootcommand executes x_bootcmd_usb AFTER loading a kernel from nand and just before executing it, which only slows down boot without adding any functionality - So drop it. Signed-off-by: Peter Korsgaard --- include/configs/sheevaplug.h | 2 +- 1 file changed, 1 insertion(+), 1

[U-Boot] [PATCH 4/4] ARM: sheevaplug: correct nand partition layout

2016-01-17 Thread Peter Korsgaard
isn't passed on the command line / CONFIG_MTD_CMDLINE_PARTS isn't enabled) with 1MB for u-boot / environment, 4MB for the kernel and the rest for the rootfs, so use that layout here and adjust the kernel loading to match. Signed-off-by: Peter Korsgaard --- include/configs/sheevaplug.

[U-Boot] [PATCH 1/4] ARM: sheevaplug: unbreak default environment

2016-01-17 Thread Peter Korsgaard
: Peter Korsgaard --- include/configs/sheevaplug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h index ebc3d64..7d773a8 100644 --- a/include/configs/sheevaplug.h +++ b/include/configs/sheevaplug.h @@ -65,7 +65,7

[U-Boot] [PATCH 0/4] ARM: sheevaplug: misc fixes

2016-01-17 Thread Peter Korsgaard
Hi, The following patch series fixes a number of issues I noticed while updating a sheevaplug from 2013.10 to 2016.01: Peter Korsgaard (4): ARM: sheevaplug: unbreak default environment ARM: sheevaplug: unbreak kernel bootargs / mtdparts command by dropping double mtdparts= ARM

Re: [U-Boot] [PATCH] sunxi: Remove Orangepi PC RAM speed to 624 MHz

2015-12-24 Thread Peter Korsgaard
=3881979 > CONFIG_DRAM_ODT_EN=y > # CONFIG_VIDEO is not set > -- > 2.5.0 > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] dm: Add timeline and guide for porting serial drivers

2015-11-15 Thread Peter Korsgaard
>>>>> "Simon" == Simon Glass writes: > Add a README with a brief guide to porting serial drivers over to use > driver model. > Add a timeline also. All serial drivers should be converted by the end > of January 2

Re: [U-Boot] [PATCH] mx6: titanium: Move BSP code to barco board directory

2013-11-03 Thread Peter Korsgaard
>>>>> "Stefan" == Stefan Roese writes: Stefan> Since the titanium board is not a Freescale board, move its Stefan> BSP code from the freescale board directory to the newly created Stefan> barco board directory. Stefan> Signed-off-by: Stefan Roese St

Re: [U-Boot] Location of Titanium board

2013-11-03 Thread Peter Korsgaard
directory instead. Sounds good, thanks. -- Bye, Peter Korsgaard This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4 5/5] board/ti/am335x/README: update for NAND boot

2013-09-03 Thread Peter Korsgaard
t from MMC/SD card Pekon> + U-Boot # mmc rescan Pekon> + # erase flash Pekon> + U-Boot # nand erase.chip Pekon> + U-Boot # env default -f -a Pekon> + U-Boot # saveenv Pekon> + # flash MLO. redundant copies of MLO are kept for backup s/r

Re: [U-Boot] [PATCH v2 5/5] am335x_evm: Add basic README

2013-07-08 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> Add a README for the family of boards the am335x_evm covers, and include Tom> instructions on preparing and using falcon mode, for various media. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Ko

Re: [U-Boot] [PATCH v2 3/5] am335x_evm: Update eMMC falcon mode locations

2013-07-08 Thread Peter Korsgaard
evious kernel Tom> location was part of the area we set aside for U-Boot itself, so move it Tom> up a bit higher. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/5] am335x_evm: Correct DFU ALT settings for falcon mode

2013-07-08 Thread Peter Korsgaard
Tom> the limit on U-Boot for ease of math later. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] am335x_evm: Update, document Falcon Mode support

2013-07-03 Thread Peter Korsgaard
with erasing small areas at a time, Tom> +however on eMMC we must keep erases aligned to eraseblocks and thus the Tom> +first erase we issue will erase the partition table. Really? I thought eMMC behaved just like SD cards? Tom> +# Ensure are able to talk with this mmc device

Re: [U-Boot] [PATCH 1/2] README.falcon: Note how we determine if we can boot the OS or not

2013-07-03 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard Tom> --- Tom> doc/README.falcon |2 ++ Tom> 1 file changed, 2 insertions(+) Tom> diff --git a/doc/README.falcon b/doc/README.falcon Tom> in

Re: [U-Boot] [PATCH] spl_mmc.c: Detect missing kernel image in RAW MMC

2013-06-28 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> Currently, we assume that if we can read from MMC correctly, we have Tom> found a valid image. This is not the case as an empty area will read Tom> just fine. Add a check for a valid IH_MAGIC. Tom> Signed-off-by: To

Re: [U-Boot] [PATCH] am33xx: fix the ddr_cmdtctrl structure

2013-06-17 Thread Peter Korsgaard
ta0_ioctrl are never configured because Ilya> of this mapping mismatch. Ilya> Signed-off-by: Ilya Ledvich Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] arm, am33xx: move s_init to a common place

2013-06-15 Thread Peter Korsgaard
t; still. Really? We have a am335x based board using a 25MHz input clock, and I haven't noticed any problems. What are those problems exactly? -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] am33xx: Correct NON_SECURE_SRAM_START/END

2013-05-31 Thread Peter Korsgaard
0x402F0400 Tom> -#define CONFIG_SPL_MAX_SIZE (101 * 1024) Tom> +/* Tom> + * Place the image at the start of the ROM defined image space and leave Tom> + * space for SRAM scratch entries (see arch/arm/include/omap_common.h). Tom> + * We limit our size to the ROM-defined dowloaded image area, and use the s/dowloaded/downloaded/ Otherwise it looks good. Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V3 1/4] README: document CONFIG_ENV_IS_IN_MMC

2013-05-23 Thread Peter Korsgaard
>>>>> "Stephen" == Stephen Warren writes: Stephen> On 05/23/2013 03:59 PM, Peter Korsgaard wrote: >>>>>>> "S" == Stephen Warren writes: >> Stephen> ... S> + These two values are in units of bytes, but mus

Re: [U-Boot] [PATCH V3 1/4] README: document CONFIG_ENV_IS_IN_MMC

2013-05-23 Thread Peter Korsgaard
S> + - CONFIG_ENV_SIZE: S> + S> + These two #defines specify the offset and size of the environment S> + area within the specified MMC device. S> + S> + These two values are in units of bytes, but must be aligned to an S> + MMC sector boundary. s/to a

Re: [U-Boot] [PATCH V2 3/4] env_mmc: allow negative CONFIG_ENV_OFFSET

2013-05-23 Thread Peter Korsgaard
#endif S> + S> + if (offset < 0) S> + offset += mmc->capacity; S> + S> + *env_addr = offset; S> + This is quite a mix of data types (u32/s64/u64). Not directly related to this patch, but it would imho be nicer to let env_mmc work directly with block numbers instead of bytes, that way stuff would also work with >4GB MMCs. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V2 1/4] README: document CONFIG_ENV_IS_IN_MMC

2013-05-23 Thread Peter Korsgaard
S> + This value must also be aligned to an MMC sector boundary. S> + S> + - CONFIG_ENV_SIZE_REDUND (optional): S> + S> + This value need not be set, even when CONFIG_ENV_OFFSET_REDUND is S> + set. If this value is set, it must be set to the same value as S> + CONFIG

Re: [U-Boot] [PATCH v2 7/7] am335x_evm: Add support to boot from NOR.

2013-05-16 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: >> Ok, that's interesting info which imho belongs in the commit >> message. Tom> Reworded, thanks! Great, thanks. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Bo

Re: [U-Boot] [PATCH v2 6/7] am335x_evm: Add support for the NOR module on the memory cape

2013-05-16 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Hi, Tom> But I ended up with one non-default on all of omap3,which just Tom> says "lets re-program cs0 for our split". Ok, thanks. -- Bye, Peter Korsgaard ___ U-Bo

Re: [U-Boot] [PATCH v2 7/7] am335x_evm: Add support to boot from NOR.

2013-05-16 Thread Peter Korsgaard
dmm on am33xx builds. Ok, that's interesting info which imho belongs in the commit message. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 6/7] am335x_evm: Add support for the NOR module on the memory cape

2013-05-16 Thread Peter Korsgaard
the solution is simply to have: init_gpmc_nand() and init_gpmc_nor() ? -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 7/7] am335x_evm: Add support to boot from NOR.

2013-05-16 Thread Peter Korsgaard
cks(); Tom> @@ -67,6 +70,7 @@ void config_dmm(const struct dmm_lisa_map_regs *regs) Tom> writel(regs->dmm_lisa_map_1, &hw_lisa_map_regs->dmm_lisa_map_1); Tom> writel(regs->dmm_lisa_map_0, &hw_lisa_map_regs->dmm_lisa_map_0); Tom> } Tom> +#endif -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 6/7] am335x_evm: Add support for the NOR module on the memory cape

2013-05-16 Thread Peter Korsgaard
Tom> gpmc_init(); Tom> +#ifdef CONFIG_NOR Tom> + /* Reconfigure CS0 for NOR instead of NAND. */ Tom> + enable_gpmc_cs_config(gpmc_nor, &gpmc_cfg->cs[0], Tom> + CONFIG_SYS_FLASH_BASE, GPMC_SIZE_16M); Tom> +#endif Tom> + Perhaps the nand handling should just get moved out of gpmc_init() (or the _cs_config args should be passed to gpmc_init() ). Tom> return 0; Tom> } -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 5/7] am335x_evm: Rework board_is_foo() checks

2013-05-15 Thread Peter Korsgaard
> problems when this code could be running from read-only memory. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 4/7] am335x_evm: Only set CONFIG_NAND when !CONFIG_SPI_BOOT

2013-05-15 Thread Peter Korsgaard
it Tom> present. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard Tom> --- Tom> Changes in v2: Tom> - Reword commit message Thanks! -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 3/7] am335x_evm: Update SPI_BOOT support, add MTDPARTS info

2013-05-15 Thread Peter Korsgaard
usage (we had not re-defined ENV_SIZE). Tom> - Given extra space, keep env size as 128KiB, add redundant environment. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard Tom> --- Tom> Changes in v2: Tom> - Correct physmap -> m25p80 in mtdparts (Peter K). Tom> - Style

Re: [U-Boot] [PATCH v2 1/7] am33xx/omap3: Clean up gpmc_init slightly

2013-05-15 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> We don't really need the gpmc_config, base and size variables and can Tom> just call enable_gpmc_cs_config more directly, like the boards which Tom> need to re-configure CS0 or CS1 do. Tom> Signed-off-by: Tom Rin

[U-Boot] [PATCHv3 6/6] am335x: enable falcon boot mode for mmc (raw and fat) and nand

2013-05-13 Thread Peter Korsgaard
R (if used). For nand, we use the last sector of the partition reserved for u-boot. This also enables the spl command in the full u-boot so the kernel parameter area snapshot can be created. Signed-off-by: Peter Korsgaard --- board/ti/am335x/board.c |9 + include/configs/am

[U-Boot] [PATCHv3 2/6] spl_mmc: mmc_load_image_fat(): Add filename argument and move fat init out

2013-05-13 Thread Peter Korsgaard
So we can use it for falcon mode as well. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index 0c50657..fac6f2d 100644 --- a/drivers/mmc

[U-Boot] [PATCHv3 0/6] Falcon boot mode for spl_mmc

2013-05-13 Thread Peter Korsgaard
MTDPARTS_DEFAULT settings according to Tom Rini's feedback. Changes since V1: - Adjusted am335x parameters according to Tom Rini's feedback. Added spl command for easy kernel parameter area snapshot creation. Peter Korsgaard (6): spl_mmc: return error from mmc_load_image_{raw,f

[U-Boot] [PATCHv3 3/6] spl_mmc: add Falcon mode support for FAT variant

2013-05-13 Thread Peter Korsgaard
If Falcon mode support is enabled (and the system isn't directed into booting u-boot), it will instead try to load kernel from CONFIG_SPL_FAT_LOAD_KERNEL_NAME file and kernel argument parameters from CONFIG_SPL_FAT_LOAD_ARGS_NAME, both from the same partition as u-boot. Signed-off-by:

[U-Boot] [PATCHv3 4/6] spl_mmc: mmc_load_image_raw(): Add sector argument

2013-05-13 Thread Peter Korsgaard
So we can use it for falcon mode as well. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index d250b40..d710c0d 100644 --- a/drivers/mmc/spl_mmc.c +++ b

[U-Boot] [PATCHv3 1/6] spl_mmc: return error from mmc_load_image_{raw, fat} rather than hanging

2013-05-13 Thread Peter Korsgaard
So we can instead fallback to doing something else on errors. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index 7efdcb8..0c50657 100644

[U-Boot] [PATCHv3 5/6] spl_mmc: add Falcon mode support for raw variant

2013-05-13 Thread Peter Korsgaard
ector CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Signed-off-by: Peter Korsgaard --- README| 10 ++ drivers/mmc/spl_mmc.c | 18 ++ 2 files changed, 28 insertions(+) diff --git a/README b/README index 595c05d..3bac95b 100644 --- a/README +++ b/README @@ -2915,6 +2915,16 @@ FIT uImage f

Re: [U-Boot] [PATCH 6/6] am335x_evm: Add support to boot from NOR.

2013-05-12 Thread Peter Korsgaard
il we move from flash to DDR. And it is Tom> fast enough here at least that it doesn't seem like we'd gain on Tom> falcon mode like we do on other medium. Ok. It would be good to mention this in the commit message. -- Bye, Peter Korsgaard ___

Re: [U-Boot] [PATCH 6/6] am335x_evm: Add support to boot from NOR.

2013-05-12 Thread Peter Korsgaard
_PHY_SMSC Tom> -#if !defined(CONFIG_SPI_BOOT) Tom> +#if !defined(CONFIG_SPI_BOOT) && !defined(CONFIG_NOR_BOOT) Tom> #define CONFIG_NAND Tom> #endif Tom> @@ -520,6 +530,19 @@ Tom> #define CONFIG_SYS_FLASH_BASE(0x0800) Tom> #define CONFIG_SYS_FLAS

Re: [U-Boot] [PATCH 5/6] am335x_evm:Add support for the NOR module on the memory cape

2013-05-12 Thread Peter Korsgaard
(0x0100, &gpmc_cfg->irqstatus); Tom> writel(0x00000100, &gpmc_cfg->irqenable); Tom> writel(0x0012, &gpmc_cfg->config); Tom> +#endif So now you cannot E.G. have a single binary working on both the nand flash of the evm and beaglebone? That's not really nice. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/6] am335x_evm: Add MTDPARTS info for SPI flash

2013-05-12 Thread Peter Korsgaard
384k(u-boot)," \ Tom> + "4k(u-boot-env),3464k(kernel),-(rootfs)" Tom> #endif /* SPI support */ Tom> /* Unsupported features */ Tom> -- Tom> 1.7.9.5 Tom> ___ Tom> U-Boot mailing list T

Re: [U-Boot] [PATCH 3/6] am335x_evm: Only set CONFIG_NAND when !CONFIG_SPI_BOOT

2013-05-12 Thread Peter Korsgaard
Tom> -#endif Tom> #endif /* ! __CONFIG_AM335X_EVM_H */ Tom> -- Tom> 1.7.9.5 Tom> ___ Tom> U-Boot mailing list Tom> U-Boot@lists.denx.de Tom> http://lists.denx.de/mailman/listinfo/u-boot -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/6] am335x_evm: Drop useless CONFIG_ENV_IS_NOWHERE

2013-05-12 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> We always set a CONFIG_ENV_IS_...somewhere... so drop the initial define Tom> of NOWHERE. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [U-Boot] [PATCHv2 6/6] RFC: am335x: enable falcon boot mode for mmc (raw and fat) and nand

2013-05-08 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Hi, >> This also enables the spl command in the full u-boot so the kernel >> parameter area snapshot can be created. >> >> Signed-off-by: Peter Korsgaard Tom> You forgot to drop the RFC

[U-Boot] [PATCHv2 4/6] spl_mmc: mmc_load_image_raw(): Add sector argument

2013-05-08 Thread Peter Korsgaard
So we can use it for falcon mode as well. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index d250b40..d710c0d 100644 --- a/drivers/mmc/spl_mmc.c +++ b

[U-Boot] [PATCHv2 0/6] Falcon boot mode for spl_mmc

2013-05-08 Thread Peter Korsgaard
Rini's feedback. Added spl command for easy kernel parameter area snapshot creation. Peter Korsgaard (6): spl_mmc: return error from mmc_load_image_{raw,fat} rather than hanging spl_mmc: mmc_load_image_fat(): Add filename argument and move fat init out spl_mmc: add Falcon

[U-Boot] [PATCHv2 6/6] RFC: am335x: enable falcon boot mode for mmc (raw and fat) and nand

2013-05-08 Thread Peter Korsgaard
R (if used). For nand, we use the last sector of the partition reserved for u-boot. This also enables the spl command in the full u-boot so the kernel parameter area snapshot can be created. Signed-off-by: Peter Korsgaard --- board/ti/am335x/board.c |9 + include/configs/am

[U-Boot] [PATCHv2 3/6] spl_mmc: add Falcon mode support for FAT variant

2013-05-08 Thread Peter Korsgaard
If Falcon mode support is enabled (and the system isn't directed into booting u-boot), it will instead try to load kernel from CONFIG_SPL_FAT_LOAD_KERNEL_NAME file and kernel argument parameters from CONFIG_SPL_FAT_LOAD_ARGS_NAME, both from the same partition as u-boot. Signed-off-by:

[U-Boot] [PATCHv2 5/6] spl_mmc: add Falcon mode support for raw variant

2013-05-08 Thread Peter Korsgaard
ector CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Signed-off-by: Peter Korsgaard --- README| 10 ++ drivers/mmc/spl_mmc.c | 18 ++ 2 files changed, 28 insertions(+) diff --git a/README b/README index 595c05d..3bac95b 100644 --- a/README +++ b/README @@ -2915,6 +2915,16 @@ FIT uImage f

[U-Boot] [PATCHv2 2/6] spl_mmc: mmc_load_image_fat(): Add filename argument and move fat init out

2013-05-08 Thread Peter Korsgaard
So we can use it for falcon mode as well. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index 0c50657..fac6f2d 100644 --- a/drivers/mmc

[U-Boot] [PATCHv2 1/6] spl_mmc: return error from mmc_load_image_{raw, fat} rather than hanging

2013-05-08 Thread Peter Korsgaard
So we can instead fallback to doing something else on errors. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index 7efdcb8..0c50657 100644

Re: [U-Boot] [PATCH] tools: default image: use ih_size for checking data size

2013-05-07 Thread Peter Korsgaard
rupted data! A related usecase is checking the version info of whatever is written to flash - E.G. mkimage -l /dev/mtdN But that already fails as stat returns st_size=0 for devices. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] am33xx: Fix warning with CONFIG_DISPLAY_CPUINFO

2013-04-26 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> The arm_freq and ddr_freq variables are unused, so remove. Fixup Tom> whitespace slightly while in here. Tom> Signed-off-by: Tom Rini Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [U-Boot] [PATCH 6/6] RFC: am335x: enable falcon boot mode for mmc (raw and fat)

2013-04-10 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Hi, Tom> We should do some real defines here while at it, since the GP EVM Tom> has NAND :) Peter> Yes. It's a bit unfortunate that CONFIG_SPL_OS_BOOT is a global Peter> setting, so you need all the variou

Re: [U-Boot] [PATCH 1/3] OMAP3/4/5/AM33xx: Correct logic for checking FAT or RAW MMC

2013-04-09 Thread Peter Korsgaard
CE_CPGMAC 70 Tom> #define BOOT_DEVICE_MMC2_2 0xFF Tom> + Tom> +#define MMC_BOOT_DEVICES_START BOOT_DEVICE_MMC1 Tom> +#define MMC_BOOT_DEVICES_END BOOT_DEVICE_MMC2 Doesn't this break ti814x with the funky inverted mmc1/mmc2? -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] am335x: Enable MMC1 clock

2013-04-04 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> We must not assume ROM has enabled the clock for MMC1. Tom> Reported-by: Koen Kooi Tom> Signed-off-by: Tom Rini Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot

Re: [U-Boot] [PATCH 1/8] Prepare for TI816X : reuse existing code from TI814X

2013-03-28 Thread Peter Korsgaard
to ti814x_evm.h at this point. It afaik already has it. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 6/8] Add TI816X specific register definitions

2013-03-28 Thread Peter Korsgaard
; +#define CPSW_MDIO_BASE0x4A100800 ti816x doesn't have CPSW, so the name is a bit odd (the base address matches the emac mdio module). The emac driver expects an asm/arch/emac_defs.h header with a EMAC_MDIO_BASE_ADDR define (among others). Perhaps just drop it from here

Re: [U-Boot] [PATCH 5/8] Add TI816X cpu definitions

2013-03-28 Thread Peter Korsgaard
M */ TENART> +#if defined(CONFIG_TI816X) TENART> +#define DMM_BASE 0x4E00 TENART> +#else TENART> #define DMM_BASE 0x4E40 TENART> +#endif I don't think that's right. Matt's series uses DMM_BASE to refer to the lisa registers, which are offset 0x40 from the DMM region, so I think you can drop this. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 7/8] Add TI816X mmc clock reference

2013-03-28 Thread Peter Korsgaard
>>>>> "TENART" == TENART Antoine writes: Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/8] Add TI816X mux definitions.

2013-03-28 Thread Peter Korsgaard
>>>>> "TENART" == TENART Antoine writes: Acked-by: Peter Korsgaard I just now noticed that you forgot to sign off on your patches (-s option). -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de htt

Re: [U-Boot] [PATCH 1/8] Prepare for TI816X : reuse existing code from TI814X

2013-03-28 Thread Peter Korsgaard
>>>>> "TENART" == TENART Antoine writes: TENART> Rename some CONFIG_TI814X to a more generic CONFIG_81XX Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 6/6] RFC: am335x: enable falcon boot mode for mmc (raw and fat)

2013-03-27 Thread Peter Korsgaard
>> to test. Tom> Well, CONFIG_SYS_NAND_SPL_KERNEL_OFFS would be where we say nandimgsrc Tom> is in env. Stefano, looking at twister, the spl export looks like it Tom> goes right at the start of the rootfs, isn't that bad? Or at least,

Re: [U-Boot] [PATCH 6/6] RFC: am335x: enable falcon boot mode for mmc (raw and fat)

2013-03-27 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> On Sun, Mar 24, 2013 at 10:51:33PM +0100, Peter Korsgaard wrote: >> Jump into full u-boot mode if a 'c' character is received on the uart. >> >> We need to adjust the spl bss/malloc area to not

[U-Boot] [PATCH 0/6] Falcon boot mode for spl_mmc

2013-03-24 Thread Peter Korsgaard
Ehh, seems I fat fingered the subject :/ On Sun, Mar 24, 2013 at 10:51 PM, Peter Korsgaard wrote: > Hi, > > This patch series adds falcon boot mode for MMC (raw and FAT), similar to > the existing nand support. > > This series applies on top of the recent spl_mmc variab

[U-Boot] sba...@denx.de

2013-03-24 Thread Peter Korsgaard
support for the am335x evm board, which has been used to test the series. That patch should not be committed as is. -- Bye, Peter Korsgaard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/6] spl_mmc: mmc_load_image_fat(): Add filename argument and move fat init out

2013-03-24 Thread Peter Korsgaard
So we can use it for falcon mode as well. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index 0c50657..fac6f2d 100644 --- a/drivers/mmc

[U-Boot] [PATCH 3/6] spl_mmc: add Falcon mode support for FAT variant

2013-03-24 Thread Peter Korsgaard
If Falcon mode support is enabled (and the system isn't directed into booting u-boot), it will instead try to load kernel from CONFIG_SPL_FAT_LOAD_KERNEL_NAME file and kernel argument parameters from CONFIG_SPL_FAT_LOAD_ARGS_NAME, both from the same partition as u-boot. Signed-off-by:

[U-Boot] [PATCH 4/6] spl_mmc: mmc_load_image_raw(): Add sector argument

2013-03-24 Thread Peter Korsgaard
So we can use it for falcon mode as well. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index d250b40..d710c0d 100644 --- a/drivers/mmc/spl_mmc.c +++ b

[U-Boot] [PATCH 5/6] spl_mmc: add Falcon mode support for raw variant

2013-03-24 Thread Peter Korsgaard
ector CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Signed-off-by: Peter Korsgaard --- README| 10 ++ drivers/mmc/spl_mmc.c | 18 ++ 2 files changed, 28 insertions(+) diff --git a/README b/README index ef1aca1..a30b7a2 100644 --- a/README +++ b/README @@ -2845,6 +2845,16 @@ FIT uImage f

[U-Boot] [PATCH 6/6] RFC: am335x: enable falcon boot mode for mmc (raw and fat)

2013-03-24 Thread Peter Korsgaard
Jump into full u-boot mode if a 'c' character is received on the uart. We need to adjust the spl bss/malloc area to not overlap with the loadaddr of the kernel (sdram + 32k), so move it past u-boot instead. Signed-off-by: Peter Korsgaard --- board/ti/am335x/board.c

[U-Boot] [PATCH 1/6] spl_mmc: return error from mmc_load_image_{raw, fat} rather than hanging

2013-03-24 Thread Peter Korsgaard
So we can instead fallback to doing something else on errors. Signed-off-by: Peter Korsgaard --- drivers/mmc/spl_mmc.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/spl_mmc.c b/drivers/mmc/spl_mmc.c index 7efdcb8..0c50657 100644

[U-Boot] [PATCH] spl_mmc: cleanup variable types

2013-03-21 Thread Peter Korsgaard
block_read returns unsigned long, so it doesn't make sense to check for < 0. and neither does marking the header structure as const and then casting away the constness to load data into it. Also cleanup some unneeded pointer casting while we're at it. Signed-off-by: Peter Korsgaard

Re: [U-Boot] [PATCH 1/2] mmc: mmc_getcd/getwp: use sensible defaults

2013-03-21 Thread Peter Korsgaard
>>>>> "Tom" == Tom Rini writes: Tom> On Thu, Mar 21, 2013 at 03:00:03PM +0100, Peter Korsgaard wrote: >> Let mmc_getcd() return true and mmc_getwp() false if mmc driver doesn't >> provide handlers for them. >> >> Signed-off-by:

  1   2   3   >