Re: [U-Boot] [PATCH 06/25] dm: spi: Add a uclass for SPI

2014-07-17 Thread Pavel Herrmann
On Thursday 17 of July 2014 20:01:29 Pavel Herrmann wrote: > Hi > > On Thursday 17 of July 2014 09:26:47 Simon Glass wrote: > > Hi Pavel, > > > > On 17 July 2014 01:57, Pavel Herrmann wrote: > > > Hi > > > > > > On Wednesday 16 of

Re: [U-Boot] [PATCH 06/25] dm: spi: Add a uclass for SPI

2014-07-17 Thread Pavel Herrmann
Hi On Thursday 17 of July 2014 09:26:47 Simon Glass wrote: > Hi Pavel, > > On 17 July 2014 01:57, Pavel Herrmann wrote: > > Hi > > > > On Wednesday 16 of July 2014 23:39:44 Simon Glass wrote: > >> Hi Pavel, > >> > >> On 15 July 2014 02:

Re: [U-Boot] [PATCH 06/25] dm: spi: Add a uclass for SPI

2014-07-17 Thread Pavel Herrmann
Hi On Wednesday 16 of July 2014 23:39:44 Simon Glass wrote: > Hi Pavel, > > On 15 July 2014 02:26, Pavel Herrmann wrote: > > Hi > > > > On Monday 14 of July 2014 18:56:13 Simon Glass wrote: > > > Add a uclass which provides access to SPI buses and inclu

Re: [U-Boot] [PATCH v2 26/29] dm: Add child_pre_probe() and child_post_remove() methods

2014-07-17 Thread Pavel Herrmann
On Wednesday 16 of July 2014 23:41:57 Simon Glass wrote: > Hi Pavel, > > On 15 July 2014 02:26, Pavel Herrmann wrote: > > Hi > > > > On Tuesday 08 of July 2014 21:38:16 Simon Glass wrote: > >> ... > >> + > >> +Note that the information tha

Re: [U-Boot] [PATCH v2 26/29] dm: Add child_pre_probe() and child_post_remove() methods

2014-07-15 Thread Pavel Herrmann
like interface, which is simpler (does not give you the ability to control bad block management, among other things). regards Pavel Herrmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 06/25] dm: spi: Add a uclass for SPI

2014-07-15 Thread Pavel Herrmann
follow a certain template, such as bus_ops(struct udevice *bus, struct udevice *child, ...) struct spi_slave would be a prime candidate to have in child->parentdata (which should only be accessed by the parent IIUC) regards Pavel Herrmann ___ U-Boot maili

Re: [U-Boot] [PATCH v4 15/15] dm: Expand and improve the device lifecycle docs

2014-06-06 Thread Pavel Herrmann
ould go to activation/probe(), which is described in step 2 regards Pavel Herrmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v5 06/16] dm: Add README for driver model

2013-11-06 Thread Pavel Herrmann
he original design was done with the possibility of loading drivers as modules at runtime, while only having certain uclasses compiled in. having dynamic ID numbers would complicate things (more precisely, no dynamic uclass loading, uclass id map would be part of the

Re: [U-Boot] [RFC PATCH] WIP: Simplified device model implementation and demo

2013-04-27 Thread Pavel Herrmann
On Saturday 27 of April 2013 09:08:48 Simon Glass wrote: > Hi Pavel, > > On Fri, Apr 26, 2013 at 8:35 AM, Pavel Herrmann wrote: > > Hi > > > > On Friday 26 of April 2013 06:30:17 Simon Glass wrote: > >> Hi Peter, > >> > >> On Wed, A

Re: [U-Boot] [RFC PATCH] WIP: Simplified device model implementation and demo

2013-04-26 Thread Pavel Herrmann
Hi On Friday 26 of April 2013 06:30:17 Simon Glass wrote: > Hi Peter, > > On Wed, Apr 24, 2013 at 9:51 AM, Pavel Herrmann wrote: > > Hello > > > > On Wednesday 24 of April 2013 08:53:09 Simon Glass wrote: > > > snip > > > > Thanks for building

Re: [U-Boot] [RFC PATCH] WIP: Simplified device model implementation and demo

2013-04-24 Thread Pavel Herrmann
Hello On Wednesday 24 of April 2013 08:53:09 Simon Glass wrote: > From: Pavel Herrmann > > ** Please note that this is very early code. I am sending out an RFC to > get comments. This is not a commit message. This will only build on sandbox > and all you can do it try the '

Re: [U-Boot] [PATCH 3/4] fix memory corruption on versatile

2012-12-27 Thread Pavel Herrmann
ly the driver knows what private data it created during initialization). we have an infrastructure in place that walks the DM driver tree and calls these relocation hooks in a sane order. after this is done, we forget about the early heap (enable caches if it was in locked cache or whatever). Pavel Herrmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/4] fix memory corruption on versatile

2012-12-25 Thread Pavel Herrmann
Hi, On Tuesday 25 December 2012 12:37:55 Albert ARIBAUD wrote: > Hi Pavel, > > On Mon, 24 Dec 2012 15:57:30 +0100, Pavel Herrmann > > wrote: > > Hi, > > > > On Monday 24 December 2012 14:56:03 Albert ARIBAUD wrote: > > > Hi Pavel, > > > &g

Re: [U-Boot] [PATCH 3/4] fix memory corruption on versatile

2012-12-24 Thread Pavel Herrmann
Hi, On Monday 24 December 2012 14:56:03 Albert ARIBAUD wrote: > Hi Pavel, > > On Mon, 24 Dec 2012 02:27:53 +0100, Marek Vasut wrote: > > Dear Pavel Herrmann, > > > > > ARM board.c doesnt respect CONFIG_SYS_GBL_DATA_OFFSET, nor do all boards > > > set it,

Re: [U-Boot] [PATCH] fix linker generated lists on non-C locales

2012-12-02 Thread Pavel Herrmann
On Sunday 02 of December 2012 19:12:17 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Sunday 02 of December 2012 18:50:53 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > Setting LC_COLLATE=C is not enough if LC_ALL=en_US.utf8. The resul

Re: [U-Boot] [PATCH] fix linker generated lists on non-C locales

2012-12-02 Thread Pavel Herrmann
On Sunday 02 of December 2012 19:12:17 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Sunday 02 of December 2012 18:50:53 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > Setting LC_COLLATE=C is not enough if LC_ALL=en_US.utf8. The resul

Re: [U-Boot] [PATCH] fix linker generated lists on non-C locales

2012-12-02 Thread Pavel Herrmann
On Sunday 02 of December 2012 18:50:53 Marek Vasut wrote: > Dear Pavel Herrmann, > > > Setting LC_COLLATE=C is not enough if LC_ALL=en_US.utf8. The result is a > > build that has no available commands. Setting LC_ALL=C for the generator > > script helps. > > >

[U-Boot] [PATCH] fix linker generated lists on non-C locales

2012-12-02 Thread Pavel Herrmann
Setting LC_COLLATE=C is not enough if LC_ALL=en_US.utf8. The result is a build that has no available commands. Setting LC_ALL=C for the generator script helps. Signed-off-by: Pavel Herrmann --- helper.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helper.mk b

Re: [U-Boot] [PATCH] ZFS: fix some warnings, cleanup

2012-10-16 Thread Pavel Herrmann
Hi On Monday 15 of October 2012 17:33:47 Tom Rini wrote: > On Wed, Sep 19, 2012 at 05:32:36PM +0200, Pavel Herrmann wrote: > > Fix warnings about type mismatch in cmd_zfs. > > Dont use a global block_dev_desc, instead use a local one in each cmd. > > > > Signed-off-by:

Re: [U-Boot] [PATCH V3 2/4] FAT: make use of disk_partition_t.part

2012-10-15 Thread Pavel Herrmann
On Monday 15 of October 2012 10:40:25 Stephen Warren wrote: > On 10/13/2012 01:38 PM, Pavel Herrmann wrote: > > Hi > > > > On Wednesday 10 October 2012 12:14:00 Stephen Warren wrote: > >> From: Stephen Warren > >> > >> This removes the sta

Re: [U-Boot] [PATCH V3 2/4] FAT: make use of disk_partition_t.part

2012-10-13 Thread Pavel Herrmann
and the string you are patching up here (along with many others, due to unification of disk interfaces) is changed. Best Regards Pavel Herrmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH 2/2] fs: add partition switch libary, implement ls and fsload commands

2012-10-13 Thread Pavel Herrmann
s is a "partition switch library", when it doesnt deal with partitions at all. Care to explain? Or maybe call it "filesystem-auto detection" or something? Best Regards Pavel Herrmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 08/10] split AU1X00 specific code from cmd_ide.c

2012-10-09 Thread Pavel Herrmann
move special case of ide_swap_read() for AU1X00 SoC into SoC-specific directory. Signed-off-by: Pavel Herrmann --- Changes for v2: rebase on top of next include missing to fix compilation arch/mips/cpu/mips32/au1x00/Makefile | 2 +- arch/mips/cpu/mips32/au1x00/au1x00_ide.c | 32

[U-Boot] [PATCH v2 07/10] move CPC45 ide_led to the same file as other IDE hooks

2012-10-09 Thread Pavel Herrmann
Keep all IDE-related hooks and overrides in a single file, to avoid confusion Signed-off-by: Pavel Herrmann --- Changes for v2: style fixes board/cpc45/cpc45.c | 15 --- board/cpc45/ide.c | 15 +++ 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a

[U-Boot] [PATCH v2 04/10] change all versions of input_data() and output_data() to global weak aliases

2012-10-09 Thread Pavel Herrmann
: Pavel Herrmann --- Changes for v2: rebase on top of next use "shorts" as a count parameter for the short-aligned I/O calls board/esd/cpci750/ide.c | 1 - board/linkstation/ide.c | 1 - board/pcs440ep/pcs440ep.c | 1 - common/cmd_ide.c

[U-Boot] [PATCH v2 02/10] split mpc8xx hooks from cmd_ide.c

2012-10-09 Thread Pavel Herrmann
mpc8xx-based boards, and therefore are placed in arch/ppc/lib/ note: checkpatch still emits warnings about using volatile Signed-off-by: Pavel Herrmann --- Changes for v2: style fixes arch/powerpc/lib/Makefile| 1 + arch/powerpc/lib/ide.c | 201

Re: [U-Boot] [PATCH 04/10] change all versions of input_data() and output_data() to global weak aliases

2012-10-09 Thread Pavel Herrmann
On Sunday 07 of October 2012 20:14:23 Marek Vasut wrote: > Dear Pavel Herrmann, > > > This changes input_data() and friends from static function to global > > symbols under weak alias, to enable board specific overrides (and > > therefore get rid of board-specific cod

Re: [U-Boot] [PATCH 05/10] split CPC45 board-specific IDE functions from cmd_ide.c

2012-10-09 Thread Pavel Herrmann
On Sunday 07 of October 2012 20:20:08 Marek Vasut wrote: > Dear Pavel Herrmann, > > > Move input_data() and friends to board/cpc45/ide.c, as overrides for weak > > aliases in cmd_ide.c > > > > note: checkpatch emits warnings about using volatile > >

Re: [U-Boot] [PATCH 08/10] split AU1X00 specific code from cmd_ide.c

2012-10-09 Thread Pavel Herrmann
On Monday 08 of October 2012 16:38:46 Tom Rini wrote: > On Sun, Oct 07, 2012 at 05:56:12PM +0200, Pavel Herrmann wrote: > > Move special case of ide_swap_read() for AU1X00 SoC into SoC-specific > > directory. > > > > Signed-off-by: Pavel Herrmann > > Two problem

[U-Boot] [PATCH 10/10] remove unnecessary includes from cmd_ide.c

2012-10-07 Thread Pavel Herrmann
mpc8xx and mpc5xxx specific includes in cmd_ide.c are not required, remove them. Signed-off-by: Pavel Herrmann --- common/cmd_ide.c | 8 1 file changed, 8 deletions(-) diff --git a/common/cmd_ide.c b/common/cmd_ide.c index 4f3ff54..891ce21 100644 --- a/common/cmd_ide.c +++ b/common

[U-Boot] [PATCH 09/10] split PCS440EP specific code from cmd_ide.c

2012-10-07 Thread Pavel Herrmann
Move specific ide_input_data and friends to board-specific file. Signed-off-by: Pavel Herrmann --- board/pcs440ep/pcs440ep.c | 56 +++ common/cmd_ide.c | 18 --- 2 files changed, 56 insertions(+), 18 deletions(-) diff --git a

[U-Boot] [PATCH 08/10] split AU1X00 specific code from cmd_ide.c

2012-10-07 Thread Pavel Herrmann
Move special case of ide_swap_read() for AU1X00 SoC into SoC-specific directory. Signed-off-by: Pavel Herrmann --- arch/mips/cpu/mips32/au1x00/Makefile | 2 +- arch/mips/cpu/mips32/au1x00/au1x00_ide.c | 33 common/cmd_ide.c | 6

[U-Boot] [PATCH 07/10] move CPC45 ide_led to the same file as other IDE hooks

2012-10-07 Thread Pavel Herrmann
Keep all IDE-related hooks and overrides in a single file, to avoid confusion. Signed-off-by: Pavel Herrmann --- board/cpc45/cpc45.c | 15 --- board/cpc45/ide.c | 15 +++ 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/board/cpc45/cpc45.c b/board/cpc45

[U-Boot] [PATCH 06/10] make ide_led() a weak alias

2012-10-07 Thread Pavel Herrmann
: Pavel Herrmann --- common/cmd_ide.c | 63 1 file changed, 27 insertions(+), 36 deletions(-) diff --git a/common/cmd_ide.c b/common/cmd_ide.c index 89849d5..2f3b077 100644 --- a/common/cmd_ide.c +++ b/common/cmd_ide.c @@ -81,19 +81,6

[U-Boot] [PATCH 05/10] split CPC45 board-specific IDE functions from cmd_ide.c

2012-10-07 Thread Pavel Herrmann
Move input_data() and friends to board/cpc45/ide.c, as overrides for weak aliases in cmd_ide.c note: checkpatch emits warnings about using volatile Signed-off-by: Pavel Herrmann --- board/cpc45/Makefile | 2 +- board/cpc45/ide.c| 130

[U-Boot] [PATCH 02/10] split mpc8xx hooks from cmd_ide.c

2012-10-07 Thread Pavel Herrmann
mpc8xx-based boards, and therefore are placed in arch/ppc/lib/ note: checkpatch still emits warnings about using volatile Signed-off-by: Pavel Herrmann --- arch/powerpc/lib/Makefile| 1 + arch/powerpc/lib/ide.c | 207 +++ arch/powerpc/lib/ide.h

[U-Boot] [PATCH 03/10] split IVM power hooks from cmd_ide.c

2012-10-07 Thread Pavel Herrmann
Move power control code from ide_reset() into IVM-specific IDE reset code. Signed-off-by: Pavel Herrmann --- board/ivm/ivm.c | 46 ++ common/cmd_ide.c | 48 2 files changed, 46 insertions(+), 48

[U-Boot] [PATCH 04/10] change all versions of input_data() and output_data() to global weak aliases

2012-10-07 Thread Pavel Herrmann
: Pavel Herrmann --- board/esd/cpci750/ide.c | 1 - board/linkstation/ide.c | 1 - board/pcs440ep/pcs440ep.c | 1 - common/cmd_ide.c | 57 ++- include/ide.h | 11 + 5 files changed, 48 insertions(+), 23 deletions

[U-Boot] [PATCH 01/10] remove CONFIG_SC3 from cmd_ide.c

2012-10-07 Thread Pavel Herrmann
There is no difference in codepath with CONFIG_SC3 enabled, so just remove it Signed-off-by: Pavel Herrmann --- common/cmd_ide.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/common/cmd_ide.c b/common/cmd_ide.c index 6e1e568..4b94e23 100644 --- a/common/cmd_ide.c +++ b/common

[U-Boot] [PATCH 00/10] IDE code cleanup

2012-10-07 Thread Pavel Herrmann
conversion, where most of the cmd_ide code will create a new universal IDE driver, and all hooks and overrides will be provided in its platform data. note: this series has not been tested on the actual hardware Pavel Herrmann (10): remove CONFIG_SC3 from cmd_ide.c split mpc8xx hooks from

[U-Boot] [PATCH v6 1/2] Loop block device for sandbox

2012-09-28 Thread Pavel Herrmann
This driver uses files as block devices, can be used for testing disk operations on sandbox. A new command "sata_loop" is introduced to load files in runtime. Signed-off-by: Pavel Herrmann --- Changes for v6: sync with new version of "Fix checkpatch warnings about externs in

[U-Boot] [PATCH v2 2/2] Fix checkpatch warnings about externs in *.c

2012-09-28 Thread Pavel Herrmann
Move all extern declarations of sata_dev_desc[] into to make checkpatch happy, inslude in every sata driver, and remove now duplicit declarations of sata API functions. Signed-off-by: Pavel Herrmann --- Changes for v2: use include/sata.h instead of a separate header file drivers/block

[U-Boot] [PATCH 1/2] remove unnecessary code in ata_piix

2012-09-28 Thread Pavel Herrmann
g the requested port number. Signed-off-by: Pavel Herrmann --- drivers/block/ata_piix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/block/ata_piix.c b/drivers/block/ata_piix.c index c81d11a..1c3ab8a 100644 --- a/drivers/block/ata_piix.c +++ b/drivers/block/ata_piix.c @@ -204,9 +

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-24 Thread Pavel Herrmann
On Saturday 22 September 2012 15:59:46 Pavel Herrmann wrote: > On Saturday 22 of September 2012 15:33:10 Marek Vasut wrote: > > Dear Pavel Herrmann, > > > > > On Saturday 22 of September 2012 02:09:15 Marek Vasut wrote: >

Re: [U-Boot] [PATCH] FAT: split block device interactions from filesystem logic

2012-09-23 Thread Pavel Herrmann
add some CCs On Wednesday 19 September 2012 16:34:02 Pavel Herrmann wrote: > Put block device interaction code into separate file from filesystem logic. > This makes it easier to change block device API, and is similar to what > other filesystems do. > Cleanup some logic inconsisten

Re: [U-Boot] [PATCH] ZFS: fix some warnings, cleanup

2012-09-23 Thread Pavel Herrmann
Add some CCs On Wednesday 19 September 2012 17:32:36 Pavel Herrmann wrote: > Fix warnings about type mismatch in cmd_zfs. > Dont use a global block_dev_desc, instead use a local one in each cmd. > > Signed-off-by: Pavel Herrmann > --- > common/cmd_zfs.c | 7 +

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-22 Thread Pavel Herrmann
On Saturday 22 of September 2012 15:33:10 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Saturday 22 of September 2012 02:09:15 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > [...] > > > > > > > >

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-22 Thread Pavel Herrmann
On Saturday 22 of September 2012 02:09:15 Marek Vasut wrote: > Dear Pavel Herrmann, > > [...] > > > > > one or none - requests on USB flashes should not pass through > > > > block_controller_driver. > > > > > > Uh, what do t

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 23:11:57 Marek Vasut wrote: > Dear Pavel Herrmann, > > [...] > > > > I mean the particular block_controller_driver instance routes the > > > "read/write block" request from downstream block_device through > > > SAT

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 21:17:43 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 21 of September 2012 20:00:10 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > [...] > > > > > > > > > you should have a b

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 20:01:27 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 21 of September 2012 18:08:13 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > On Friday 21 of September 2012 17:39:21 Marek

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 20:00:10 Marek Vasut wrote: > Dear Pavel Herrmann, > > [...] > > > > > you should have a blockdev driver for USB flash and SD, but not > > > > blockctrl > > > > > > I'm lost again. Do I also need a

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 18:08:13 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 21 of September 2012 17:39:21 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > [...] > > > > > > > > Can't the old

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 17:55:10 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 21 of September 2012 17:34:27 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > [...] > > > > > > > > > blockctrl = AHCI

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 17:34:27 Marek Vasut wrote: > Dear Pavel Herrmann, > > [...] > > > > > blockctrl = AHCI, PIIX... whichever chip you have between SATA and PCI > > > > (or generally disk-bus and board-bus) > > > > > > So this

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 17:39:21 Marek Vasut wrote: > Dear Pavel Herrmann, > > [...] > > > > Can't the old driver just have a compat section in them? Like I did with > > > serial stuff: > > > > > > 1) rename the inter

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 15:58:55 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 21 of September 2012 14:51:33 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > On Thursday 20 of September 2012 22:05:36 Marek

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 15:56:38 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 21 of September 2012 14:51:33 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > On Thursday 20 of September 2012 22:05:36 Marek

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 15:53:26 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 21 of September 2012 14:39:14 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > On Thursday 20 of September 2012 21:58:17 Marek

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 14:51:33 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Thursday 20 of September 2012 22:05:36 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > This core provides unified access to different blo

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 14:39:14 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Thursday 20 of September 2012 21:58:17 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > This core will register all block devices (disk, cards, parti

Re: [U-Boot] [PATCH 02/11] DM: add support for scanning DOS partitions to blockdev core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 14:47:24 Marek Vasut wrote: > Dear Pavel Herrmann, > > [...] > > > > > +static int init(struct core_instance *core) > > > > > > I'd say, rename it to block_core_init() or something, so the syms in > > > u-bo

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Friday 21 of September 2012 14:51:33 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Thursday 20 of September 2012 22:05:36 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > This core provides unified access to different blo

Re: [U-Boot] [PATCH 02/11] DM: add support for scanning DOS partitions to blockdev core

2012-09-21 Thread Pavel Herrmann
On Thursday 20 of September 2012 22:03:05 Marek Vasut wrote: > Dear Pavel Herrmann, > > [..] > > > +#define BLOCKDEV_IFTYPE_BITS 4 > > +#define BLOCKDEV_IFTYPE_COUNT (1< > +#define BLOCKDEV_IFTYPE_MAX BLOCKDEV_IFTYPE_COUNT-1 > > I saw th

Re: [U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-21 Thread Pavel Herrmann
On Thursday 20 of September 2012 22:05:36 Marek Vasut wrote: > Dear Pavel Herrmann, > > > This core provides unified access to different block controllers (SATA, > > SCSI). > > Description of the patch missing or is sub-par. You should work on this > skill. > &

Re: [U-Boot] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
On Thursday 20 of September 2012 21:58:17 Marek Vasut wrote: > Dear Pavel Herrmann, > > > This core will register all block devices (disk, cards, partitons) and > > provide unfied access to them, instead of current method with device + > > partition offset > > >

Re: [U-Boot] [U-Boot-DM] [PATCH 01/11] DM: add block device core

2012-09-21 Thread Pavel Herrmann
Hi On Friday 21 of September 2012 02:19:00 Vikram Narayanan wrote: > On Fri, Sep 21, 2012 at 1:07 AM, Pavel Herrmann wrote: > > This core will register all block devices (disk, cards, partitons) and > > provide unfied access to them, instead of current method with device + >

[U-Boot] [PATCH 00/11] Add DM blockdev subsystem

2012-09-20 Thread Pavel Herrmann
This series adds the new unified blockdev subsystem based on DM, converts all filesystems and associated commands to the new API and adds a compatibility wrapper for current SATA drivers. Note: this is based on current DM branch with some FS cleanup patches sent out recently. Pavel Herrmann (11

[U-Boot] [PATCH 01/11] DM: add block device core

2012-09-20 Thread Pavel Herrmann
This core will register all block devices (disk, cards, partitons) and provide unfied access to them, instead of current method with device + partition offset Signed-off-by: Pavel Herrmann --- Makefile | 1 + drivers/blockdev/Makefile | 42 include/dm

[U-Boot] [PATCH 11/11] DM: switch sandbox to DM blockdev

2012-09-20 Thread Pavel Herrmann
add CONFIG_DM_BLOCK to include/configs/sandbox.h to enable it all Signed-off-by: Pavel Herrmann --- arch/sandbox/lib/board.c | 8 include/configs/sandbox.h | 4 2 files changed, 12 insertions(+) diff --git a/arch/sandbox/lib/board.c b/arch/sandbox/lib/board.c index c79cc62

[U-Boot] [PATCH 10/11] DM: use new blockdev API in ZFS

2012-09-20 Thread Pavel Herrmann
cmd_zfsdm.c is a copy of cmd_zfs.c with just trivial changes, but those touch large portion of the lines due to different number of parameters (old API has a separate parameter for interface and for disk number, new API has this as one) Signed-off-by: Pavel Herrmann --- common/Makefile

[U-Boot] [PATCH 09/11] DM: use new blockdev API in reiserfs

2012-09-20 Thread Pavel Herrmann
cmd_reiserdm.c is a copy of cmd_reiser.c with just trivial changes, but those touch large portion of the lines due to different number of parameters (old API has a separate parameter for interface and for disk number, new API has this as one) Signed-off-by: Pavel Herrmann --- common/Makefile

[U-Boot] [PATCH 07/11] DM: use new blockdev API in FAT

2012-09-20 Thread Pavel Herrmann
cmd_fatdm.c is a copy of cmd_fat.c with just trivaial changes, but those touch large portion of the lines due to different number of parameters (old API has a separate parameter for interface and for disk number, new API has this as one) Signed-off-by: Pavel Herrmann --- common/Makefile

[U-Boot] [PATCH 08/11] DM: use new blockdev API in ext2

2012-09-20 Thread Pavel Herrmann
cmd_ext2dm.c is a copy of cmd_ext2.c with just trivial changes, but those touch large portion of the lines due to different number of parameters (old API has a separate parameter for interface and for disk number, new API has this as one) Signed-off-by: Pavel Herrmann --- common/Makefile

[U-Boot] [PATCH 04/11] DM: add sata_legacy driver for blockctrl

2012-09-20 Thread Pavel Herrmann
This driver works by wrapping the old SATA API to new blockctrl API Signed-off-by: Pavel Herrmann --- drivers/blockctrl/Makefile | 1 + drivers/blockctrl/sata_legacy.c | 166 2 files changed, 167 insertions(+) create mode 100644 drivers/blockctrl

[U-Boot] [PATCH 06/11] DM: add cmd_block command

2012-09-20 Thread Pavel Herrmann
cmd_block is the equivalent of cmd_sata for DM blockdev/blockctrl devices. Signed-off-by: Pavel Herrmann --- common/Makefile| 2 + common/cmd_block.c | 139 + 2 files changed, 141 insertions(+) create mode 100644 common/cmd_block.c

[U-Boot] [PATCH 02/11] DM: add support for scanning DOS partitions to blockdev core

2012-09-20 Thread Pavel Herrmann
Enable blockdev core to automatically create partitions based on DOS partition table. This code is based on /disk/, and should eventually replace it. Signed-off-by: Pavel Herrmann --- drivers/blockdev/Makefile| 1 + drivers/blockdev/core.c | 752

[U-Boot] [PATCH 03/11] DM: add block controller core

2012-09-20 Thread Pavel Herrmann
This core provides unified access to different block controllers (SATA, SCSI). Signed-off-by: Pavel Herrmann --- Makefile | 1 + drivers/blockctrl/Makefile | 42 ++ drivers/blockctrl/core.c | 349 + include/dm/blockctrl.h

[U-Boot] [PATCH 05/11] DM: add ata and partition blockdev drivers

2012-09-20 Thread Pavel Herrmann
ata blockdev is an universal child of a blockctrl device, be it (P/S)ATA or SCSI partition blockdev is a child of other blockdev drivers Signed-off-by: Pavel Herrmann --- drivers/blockdev/Makefile| 2 +- drivers/blockdev/ata.c | 234

[U-Boot] [PATCH] ZFS: fix some warnings, cleanup

2012-09-19 Thread Pavel Herrmann
Fix warnings about type mismatch in cmd_zfs. Dont use a global block_dev_desc, instead use a local one in each cmd. Signed-off-by: Pavel Herrmann --- common/cmd_zfs.c | 7 +-- fs/zfs/zfs.c | 2 -- include/zfs_common.h | 3 --- 3 files changed, 5 insertions(+), 7 deletions

[U-Boot] [PATCH] FAT: split block device interactions from filesystem logic

2012-09-19 Thread Pavel Herrmann
Put block device interaction code into separate file from filesystem logic. This makes it easier to change block device API, and is similar to what other filesystems do. Cleanup some logic inconsistencies as well. Signed-off-by: Pavel Herrmann --- fs/fat/Makefile| 4 +- fs/fat/dev.c

Re: [U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c

2012-09-16 Thread Pavel Herrmann
On Sunday 16 September 2012 14:37:16 Marek Vasut wrote: > Dear Pavel Herrmann, > ... > Won't include/sata.h work just fine ? I feel include/sata.h is a "consumer-facing" header, and implementation details such as the array used for all data-retention for command and driv

[U-Boot] [PATCH v5 1/2] Loop block device for sandbox

2012-09-16 Thread Pavel Herrmann
This driver uses files as block devices, can be used for testing disk operations on sandbox. A new command "sata_loop" is introduced to load files in runtime. Signed-off-by: Pavel Herrmann --- Changes for v5: use common sata extern header - this requires "[PATCH] Fix chec

[U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c

2012-09-16 Thread Pavel Herrmann
Move all extern declarations of sata_dev_desc into a single header file. Signed-off-by: Pavel Herrmann --- drivers/block/ata_piix.c | 4 +--- drivers/block/dwc_ahsata.c | 1 + drivers/block/dwc_ahsata.h | 2 -- drivers/block/fsl_sata.c | 3 +-- drivers/block/pata_bfin.c| 1

Re: [U-Boot] [PATCH v4 1/2] Loop block device for sandbox

2012-09-16 Thread Pavel Herrmann
Hi On Thursday 13 September 2012 15:31:39 Tom Rini wrote: > On Fri, Sep 07, 2012 at 11:19:03AM +0200, Pavel Herrmann wrote: > > On Friday 07 of September 2012 01:29:55 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > This driver uses files as

Re: [U-Boot] [PATCH v4 1/2] Loop block device for sandbox

2012-09-07 Thread Pavel Herrmann
On Friday 07 of September 2012 11:26:48 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 07 of September 2012 01:29:55 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > This driver uses files as block devices, can be used for

Re: [U-Boot] [PATCH v4 1/2] Loop block device for sandbox

2012-09-07 Thread Pavel Herrmann
On Friday 07 of September 2012 01:29:55 Marek Vasut wrote: > Dear Pavel Herrmann, > > > This driver uses files as block devices, can be used for testing disk > > operations on sandbox. > > A new command "sata_loop" is introduced to load files in runtime. > &g

[U-Boot] [PATCH v4 1/2] Loop block device for sandbox

2012-09-06 Thread Pavel Herrmann
This driver uses files as block devices, can be used for testing disk operations on sandbox. A new command "sata_loop" is introduced to load files in runtime. Signed-off-by: Pavel Herrmann CC: Marek Vasut CC: Mike Frysinger --- Changes for v4: checkpatch fixes use NULLs

Re: [U-Boot] [PATCH v3 1/2] Loop block device for sandbox

2012-09-06 Thread Pavel Herrmann
On Thursday 06 of September 2012 03:08:42 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Wednesday 05 of September 2012 14:48:40 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > [...] > > > > > > > > besides, I think i

Re: [U-Boot] [PATCH v3 1/2] Loop block device for sandbox

2012-09-05 Thread Pavel Herrmann
On Wednesday 05 of September 2012 14:48:40 Marek Vasut wrote: > Dear Pavel Herrmann, > > [...] > > > > besides, I think it'd be much systematic to just scream at user to call > > > "sata rescan" and bail out instead of doing it for him. > > >

Re: [U-Boot] [PATCH v3 1/2] Loop block device for sandbox

2012-09-05 Thread Pavel Herrmann
second try... On Wednesday 05 September 2012 13:33:13 Marek Vasut wrote: > Dear Pavel Herrmann, > > > This driver uses files as block devices, can be used for testing disk > > operations on sandbox. > > A new command "sata_loop" is introduced to load files

Re: [U-Boot] [PATCH v3 1/2] Loop block device for sandbox

2012-09-05 Thread Pavel Herrmann
On Wednesday 05 September 2012 13:33:13 Marek Vasut wrote: > Dear Pavel Herrmann, > > > This driver uses files as block devices, can be used for testing disk > > operations on sandbox. > > A new command "sata_loop" is introduced to load files in runtime. >

[U-Boot] [PATCH v3 2/2] Use loop block device in sandbox board

2012-09-05 Thread Pavel Herrmann
Enable SATA_LOOP and a few disk-related commands for sandbox Signed-off-by: Pavel Herrmann --- Changes for v3: drop static names for loop devices Changes for v2: add a few words of description include/configs/sandbox.h | 8 1 file changed, 8 insertions(+) diff --git a/include

[U-Boot] [PATCH v3 1/2] Loop block device for sandbox

2012-09-05 Thread Pavel Herrmann
This driver uses files as block devices, can be used for testing disk operations on sandbox. A new command "sata_loop" is introduced to load files in runtime. Signed-off-by: Pavel Herrmann CC: Marek Vasut CC: Mike Frysinger --- Changes for v3: introduce sata_loop command Chan

Re: [U-Boot] [PATCH v2 1/2] Loop block device for sandbox

2012-09-03 Thread Pavel Herrmann
er), let sandbox uboot accept params > and supply these as params. or even make a command that would allow you to specify a filename in runtime, possibly with a dynamic number of ports. Pavel Herrmann ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 2/2] Use loop block device in sandbox board

2012-09-03 Thread Pavel Herrmann
Enable SATA_LOOP and a few disk-related commands for sandbox Signed-off-by: Pavel Herrmann --- changes for v2: add a few words of description include/configs/sandbox.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h index

Re: [U-Boot] [PATCH 2/2] Use loop block device in sandbox board

2012-09-03 Thread Pavel Herrmann
Hi On Saturday 01 of September 2012 16:20:12 Marek Vasut wrote: > Dear Pavel Herrmann, > > I don't understand what this patch does from the lacking description. Please > add proper description to the patch. ALWAYS! see $title perhaps? there is not much more to say. v2

[U-Boot] [PATCH v2 1/2] Loop block device for sandbox

2012-09-01 Thread Pavel Herrmann
This driver uses files as block devices, can be used for testing disk operations on sandbox. Port count and filenames are set in board config. Signed-off-by: Pavel Herrmann CC: Marek Vasut --- Changes for v2: split sandbox config off into separate patch (2/2) rename file to signify exported

[U-Boot] [PATCH 2/2] Use loop block device in sandbox board

2012-09-01 Thread Pavel Herrmann
Signed-off-by: Pavel Herrmann --- include/configs/sandbox.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h index 0220386..3126542 100644 --- a/include/configs/sandbox.h +++ b/include/configs/sandbox.h @@ -93,4 +93,13

Re: [U-Boot] [PATCH] Loop block device for sandbox

2012-08-31 Thread Pavel Herrmann
gt; > But are such data used somewhere further down the road? > > > > yes, "sata info" for example > > And how does it determine that the init failed? given that the only thing the init does is open a file and put the decriptor to ->priv, you can tell whethe

  1   2   >