On Friday 07 of September 2012 11:26:48 Marek Vasut wrote: > Dear Pavel Herrmann, > > > On Friday 07 of September 2012 01:29:55 Marek Vasut wrote: > > > Dear Pavel Herrmann, > > > > > > > This driver uses files as block devices, can be used for testing disk > > > > operations on sandbox. > > > > A new command "sata_loop" is introduced to load files in runtime. > > > > > > WARNING: externs should be avoided in .c files > > > #141: FILE: drivers/block/sata_loopback.c:39: > > > +extern block_dev_desc_t sata_dev_desc[]; > > > > > > total: 0 errors, 1 warnings, 231 lines checked > > > > > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX > > > MULTISTATEMENT_MACRO_USE_DO_WHILE > > > > Yes, i know about that, and chose to ignore it. > > Sorry, this is not how it works. > > > i will not create a header file for a single line that checkpatch doesnt > > like (with just a warning), especially when other drivers have such a line > > in them as well. > > So, implement proper accessor for this list? Or export the structure through > some sata-related header? How does other do it?
other drivers have the same line that i do, therefore ignore the checkpatch warning, same as i do see sata_dwc.c, ata_piix.c, fsl_sata.c, sata_sil3114.c Pavel Herrmann _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
