Re: [PATCH v1 1/1] rpi: Only add frame buffer node if CONFIG_FDT_SIMPLEFB is set

2024-10-28 Thread Martin Stolpe
On 24/10/2024 13:29, Peter Robinson wrote: > Hi Martin, > > Is this a follow up on the patch [1] you sent a month ago? If so it's > not really a v1, and you should add a chnagelog as to what's changed > as well as cc: the people that provided feedback. > > [1] https://lists.denx.de/pipermail/u-bo

[PATCH v1 1/1] rpi: Only add frame buffer node if CONFIG_FDT_SIMPLEFB is set

2024-10-23 Thread Martin Stolpe
The functions fdt_simplefb_add_node and fdt_simplefb_enable_and_mem_rsv are only available if CONFIG_FDT_SIMPLEFB is enabled. Signed-off-by: Martin Stolpe --- board/raspberrypi/rpi/rpi.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/board/raspberrypi/rpi

[PATCH v1 0/1] rpi: Cleanup conditional compilation of framebuffer

2024-10-23 Thread Martin Stolpe
If CONFIG_FDT_SIMPLEFB is not set fdt_simplefb.c will not be compiled which results in a compilation error if CONFIG_OF_BOARD_SETUP is enabled. This patch will fix this error by not trying to setup a framebuffer node in this case. Martin Stolpe (1): rpi: Only add frame buffer node if

Re: [PATCH 1/1] rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi

2024-10-11 Thread Martin Stolpe
Hi, Sorry if this is a stupid question but what do I have to do to add a " Reviewed-by" from myself to this patch series? BR Martin

Re: [PATCH 1/1] rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi

2024-10-07 Thread Martin Stolpe
Hi Devarsh, Am Do., 26. Sept. 2024 um 18:45 Uhr schrieb Devarsh Thakkar : > > Thanks for taking a look, I have posted them to the list [1], it would > be great if you could provide a Reviewed-by or Tested-by too. > I've tried to compile the project for am64x_evm_a53 with the patches applied and

Re: [PATCH 1/1] rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi

2024-09-26 Thread Martin Stolpe
These patches look good to me. If I understand the code correctly the frame buffer node should only be created if CONFIG_FDT_SIMPLEFB is enabled. Thus I would change the code like this: Signed-off-by: Martin Stolpe --- board/raspberrypi/rpi/rpi.c | 12 +++- 1 file changed, 7 insertio

Re: [PATCH 1/1] rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi

2024-09-24 Thread Martin Stolpe
Hi, Am Fr., 20. Sept. 2024 um 10:10 Uhr schrieb Ivan T. Ivanov : > Hi, > > On 09-20 08:32, Martin Stolpe wrote: > > > > When the CONFIG_VIDEO option is set to disabled for Raspberry Pi devices > > the build will fail with the following error message:

[PATCH 1/1] rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi

2024-09-20 Thread Martin Stolpe
When the CONFIG_VIDEO option is set to disabled for Raspberry Pi devices the build will fail with the following error message: "undefined reference to `fdt_simplefb_enable_and_mem_rsv'." Signed-off-by: Martin Stolpe --- board/raspberrypi/rpi/rpi.c | 2 +- boot/fdt_simplefb.c

[PATCH 0/1] rpi: Fix compilation when CONFIG_VIDEO is disabled

2024-09-20 Thread Martin Stolpe
This patch will fix a compilation error if CONFIG_VIDEO is set to disabled. Martin Stolpe (1): rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi board/raspberrypi/rpi/rpi.c | 2 +- boot/fdt_simplefb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH 0/1] rpi: Fix compilation when CONFIG_VIDEO is disabled

2024-09-20 Thread Martin Stolpe
This patch will fix a compilation error if CONFIG_VIDEO is set to disabled. Martin Stolpe (1): rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi board/raspberrypi/rpi/rpi.c | 2 +- boot/fdt_simplefb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions