Re: [U-Boot] [PATCH v4] PXE: FDT: Add support for fdt in PXE

2012-09-07 Thread Jason Hobbs
Chander, Looks good now. Acked-by: Jason Hobbs Thanks, Jason On Fri, Sep 07, 2012 at 01:36:31AM -0400, Chander Kashyap wrote: > Now DT support is becoming common for all new SoC's. Hence it is better > to have option for getting specific FDT from the remote server. > >

Re: [U-Boot] [PATCH v3] PXE: FDT: Add support for fdt in PXE

2012-09-06 Thread Jason Hobbs
Chander, Comments inline. On Thu, Sep 06, 2012 at 01:40:04AM -0400, Chander Kashyap wrote: > Now DT support is becomming common for all new SoC's. Hence it is better to > have option for getting specific FDT from the remote server. > > This patch adds support for new lable i.e. fdt. If fdt_addr

Re: [U-Boot] [PATCH v2] PXE: FDT: Add support for fdt in PXE

2012-09-05 Thread Jason Hobbs
Chander, You should add a description of the new label to doc/README.pxe. Otherwise, it looks good. Jason On Wed, Sep 05, 2012 at 05:26:17AM -0400, Chander Kashyap wrote: > Now DT support is becomming common for all new SoC's. Hence it is better to > have option for getting specific FDT from th

[U-Boot] [PATCH] cmd_pxe.c: fix strict-aliasing warnings

2012-03-05 Thread Jason Hobbs
Without this patch, some versions of gcc (at least ELDK 4.2) complain about dereferencing type-punned pointers. Reported-by: Marek Vasut Signed-off-by: Jason Hobbs Cc: Heiko Schocher Cc: Marek Vasut --- common/cmd_pxe.c | 16 1 files changed, 8 insertions(+), 8 deletions

Re: [U-Boot] cam_enc_4xx build failure

2012-03-05 Thread Jason Hobbs
get_relfile_envaddr': > > cmd_pxe.c:374: warning: dereferencing type-punned pointer will break strict- > > aliasing rules > > arm-linux-size: './u-boot': No such file > > added Jason Hobbs to Cc. > > Jason? Could you fix this? Yes - I'll send a p

Re: [U-Boot] [PATCH 3/3 v2] common, menu: show menu on startup if CONFIG_MENU_SHOW is defined

2012-01-17 Thread Jason Hobbs
Dear Heiko, On Tue, Jan 17, 2012 at 02:13:35AM -0500, Heiko Schocher wrote: > show a menu on startup instead running the shell. > > Signed-off-by: Heiko Schocher > Cc: Jason Hobbs > Cc: Mike Frysinger A couple of minor fixes in your README addition below, otherwise: Acked-

Re: [U-Boot] [PATCH] common, menu: do not trigger timeout again, if a line is read

2012-01-17 Thread Jason Hobbs
Dear Heiko, On Tue, Jan 17, 2012 at 03:24:29AM -0500, Heiko Schocher wrote: > Signed-off-by: Heiko Schocher > Cc: Jason Hobbs Acked-by: Jason Hobbs > --- > common/menu.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/common/menu.c b/

Re: [U-Boot] [PATCH 04/13] common/cmd_pxe.c: Fix compile warning

2011-12-13 Thread Jason Hobbs
On Fri, Dec 09, 2011 at 03:45:44PM -0500, Wolfgang Denk wrote: > Dear Jason, > > In message <20111209134819.GA26840@jhobbs-laptop> you wrote: > > > > > default: > > > printf("Ignoring malformed menu command: %.*s\n", > > > (int)(*c - s), s); > > > + e

Re: [U-Boot] [PATCH] common/cmd_pxe.c: Fix GCC 4.6 build warnings

2011-12-13 Thread Jason Hobbs
21:6: note: 'err' was declared here > > Signed-off-by: Heiko Schocher > Cc: Jason Hobbs Acked-by: Jason Hobbs > --- > common/cmd_pxe.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c &g

Re: [U-Boot] [PATCH 04/13] common/cmd_pxe.c: Fix compile warning

2011-12-09 Thread Jason Hobbs
rr' was declared here > > Signed-off-by: Wolfgang Denk > Cc: Jason Hobbs > --- > common/cmd_pxe.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c > index 9426f5b..eaf95bf 100644 > --- a/common/cmd

Re: [U-Boot] [STATUS] Getting ready for -rc1

2011-12-06 Thread Jason Hobbs
On Tue, Dec 06, 2011 at 06:12:22AM -0500, Wolfgang Denk wrote: > Second, I would like to get ready for the -rc1 pre-release. I'll wait > for the next ARM pull request from Albert, and then I will push -rc1 > out. > > If anybody has any unmerged patches pending that are supposed to go > in, please

[U-Boot] [PATCH] pxe: make the first label the implicit default

2011-11-07 Thread Jason Hobbs
If no default label is specified, but a situation arises where the default label should be used, treat the first label specified as the default label. Signed-off-by: Jason Hobbs Cc: Ricardo Salveti de Araujo Cc: Wolfgang Denk --- common/cmd_pxe.c | 17 ++--- 1 files changed, 14

Re: [U-Boot] [PATCH v5 00/13] Add PXE support

2011-09-08 Thread Jason Hobbs
Hi Wolfgang, On Wed, Aug 31, 2011 at 11:37:21AM -0400, Jason Hobbs wrote: > This patch series adds PXE booting support to U-boot. It adds aseries > of DHCP options to allow U-boot DHCP requests to be compliant with RFC > 4578, and a set of commands to provide PXELINUX like behavior. Hav

[U-Boot] [PATCH v5 13/13] arm: ca9x4_ct_vxp: enable PXE BOOTP options support

2011-08-31 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- changes for v2: - add armv7 architecture to VCI string changes for v4: - combine the PXE bootp options with the other bootp options changes for v5: - none include/configs/ca9x4_ct_vxp.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions

[U-Boot] [PATCH v5 12/13] arm: ca9x4_ct_vxp: enable pxe command support

2011-08-31 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- changes in v2: - use CONFIG_MENU to enable building the menu for pxecfg use changes in v4: - use CONFIG_CMD_PXE instead of CONFIG_CMD_PXECFG - update to standard environment variables changes for v5: - none include/configs/ca9x4_ct_vxp.h |4

[U-Boot] [PATCH v5 11/13] Convert ca9x4_ct_vxp to standard env variables

2011-08-31 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- new in v4 changes for v5: - none include/configs/ca9x4_ct_vxp.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 8c57eab..7e5dc66 100644

[U-Boot] [PATCH v5 10/13] net: bootp: add PXE/RFC 4578 DHCP options support

2011-08-31 Thread Jason Hobbs
These options are required to be present in RFC 4578 compliant DHCP requests. They give more information to DHCP servers to allow serving different DHCP responses to different systems based on client architecture, client capabilities, UUID, or vendor. Signed-off-by: Jason Hobbs --- changes for

[U-Boot] [PATCH v5 08/13] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-08-31 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes for v2: - Move uuid_str_to_bin's prototype from uuid. to common.h - Place uuid.o make rule in sorted order and conditionalize changes for v3: - check for NULL pointers in uuid conversion function changes for v4: - add a UUID string validator changes

[U-Boot] [PATCH v5 06/13] Replace space and tab checks with isblank

2011-08-31 Thread Jason Hobbs
These are various places I found that checked for conditions equivalent to isblank. Signed-off-by: Jason Hobbs --- new in v4 changes in v5: - none board/hymod/env.c|9 + common/command.c |9 + common/main.c

[U-Boot] [PATCH v5 07/13] README: document standard image variables

2011-08-31 Thread Jason Hobbs
With these documented, we can start pushing towards standardizing their use across boards. Signed-off-by: Jason Hobbs Cc: Mike Frysinger --- new in v4 changes in v5: - moved the doc into README alongside the other environment variables. README | 19 +++ 1 files changed, 19

[U-Boot] [PATCH v5 05/13] cosmetic: remove unneeded curly braces

2011-08-31 Thread Jason Hobbs
This prevents a checkpatch warning in the patch to use isblank Signed-off-by: Jason Hobbs --- new in v4 changes in v5: - none common/main.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/common/main.c b/common/main.c index 3adadfd..d812aa1 100644 --- a/common

[U-Boot] [PATCH v5 04/13] Add isblank

2011-08-31 Thread Jason Hobbs
- tab and space - this is a more reasonable approach than doubling the size of the lookup table to accommodate one more class. Signed-off-by: Jason Hobbs --- new in v4 changes in v5: - none include/linux/ctype.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a

[U-Boot] [PATCH v5 03/13] common: add run_command2 for running simple or hush commands

2011-08-31 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Mike Frysinger --- changes in v2: - whitespace correction changes in v4: - fix indention of a run_command2 line - make run_command2 static inline changes in v5: - return parse_string_outer value directly common/hush.c |2 +- common/main.c | 56

[U-Boot] [PATCH v5 02/13] common, menu: use abortboot for menu timeout

2011-08-31 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - expose abortboot externally instead of using a wrapper - expose abortboot externally when CONFIG_MENU is set changes in v3: - simplify the conditional export of abortboot - add timeout support for the menu in this patch - add doc for timeout

[U-Boot] [PATCH v5 01/13] Add generic, reusable menu code

2011-08-31 Thread Jason Hobbs
This will be used first by the pxe code, but is intended to be generic and reusable for other jobs in U-boot. Signed-off-by: Jason Hobbs --- changes in v2: - new in v2 changes in v3: - move timeout support to later patch - fix NULL case bug in menu_item_key_match - consistently use

[U-Boot] [PATCH v5 00/13] Add PXE support

2011-08-31 Thread Jason Hobbs
ca9x4_ct_vxp config. v5 of the patch series responds to a couple of comments from Mike Frysinger, and fixes a checkpatch simple_strtoul warning. Details are in the individual patch logs. Jason Hobbs (13): Add generic, reusable menu code common, menu: use abortboot for menu timeout common: add

Re: [U-Boot] [PATCH v4 07/13] Add standard environment variables README

2011-08-24 Thread Jason Hobbs
On Tue, Aug 23, 2011 at 05:45:07PM -0400, Mike Frysinger wrote: > this somewhat duplicates the "Environment Variables" section in the top level > README. can't we have just one location for this stuff ? Ah, you're right. When I searched for existing doc before adding this file, I didn't think to

Re: [U-Boot] [PATCH v4 06/13] Replace space and tab checks with isblank

2011-08-24 Thread Jason Hobbs
On Tue, Aug 23, 2011 at 05:42:59PM -0400, Mike Frysinger wrote: > On Tuesday, August 23, 2011 17:06:54 Jason Hobbs wrote: > > - while (*nn == ' ' || *nn == '\t') > > + while (isblank(*nn)) > > nn++; > > at least for these &quo

Re: [U-Boot] [PATCH v4 04/13] Add isblank

2011-08-24 Thread Jason Hobbs
On Tue, Aug 23, 2011 at 05:40:35PM -0400, Mike Frysinger wrote: > On Tuesday, August 23, 2011 17:06:52 Jason Hobbs wrote: > > Existing ctype checks are implemented using a 256 byte lookup table, > > allowing each character to be in any of 8 character classes. Since there >

[U-Boot] [PATCH v4 13/13] arm: ca9x4_ct_vxp: enable PXE BOOTP options support

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- changes for v2: - add armv7 architecture to VCI string changes for v4: - combine the PXE bootp options with the other bootp options include/configs/ca9x4_ct_vxp.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include

[U-Boot] [PATCH v4 12/13] arm: ca9x4_ct_vxp: enable pxe command support

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- changes in v2: - use CONFIG_MENU to enable building the menu for pxecfg use changes in v4: - use CONFIG_CMD_PXE instead of CONFIG_CMD_PXECFG - update to standard environment variables include/configs/ca9x4_ct_vxp.h |4 1 files changed, 4

[U-Boot] [PATCH v4 11/13] Convert ca9x4_ct_vxp to standard env variables

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs Cc: Matt Waddel --- new in v4 include/configs/ca9x4_ct_vxp.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 8c57eab..7e5dc66 100644 --- a/include/configs

[U-Boot] [PATCH v4 10/13] net: bootp: add PXE/RFC 4578 DHCP options support

2011-08-23 Thread Jason Hobbs
These options are required to be present in RFC 4578 compliant DHCP requests. They give more information to DHCP servers to allow serving different DHCP responses to different systems based on client architecture, client capabilities, UUID, or vendor. Signed-off-by: Jason Hobbs --- changes for

[U-Boot] [PATCH v4 08/13] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes for v2: - Move uuid_str_to_bin's prototype from uuid. to common.h - Place uuid.o make rule in sorted order and conditionalize changes for v3: - check for NULL pointers in uuid conversion function changes for v4: - add a UUID string validator in

[U-Boot] [PATCH v4 07/13] Add standard environment variables README

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- new in v4 doc/README.standard-env | 92 +++ 1 files changed, 92 insertions(+), 0 deletions(-) create mode 100644 doc/README.standard-env diff --git a/doc/README.standard-env b/doc/README.standard-env new file mode

[U-Boot] [PATCH v4 06/13] Replace space and tab checks with isblank

2011-08-23 Thread Jason Hobbs
These are various places I found that checked for conditions equivalent to isblank. Signed-off-by: Jason Hobbs --- new in v4 board/hymod/env.c|9 + common/command.c |9 + common/main.c|5 +++-- drivers

[U-Boot] [PATCH v4 04/13] Add isblank

2011-08-23 Thread Jason Hobbs
- tab and space - this is a more reasonable approach than doubling the size of the lookup table to accommodate one more class. Signed-off-by: Jason Hobbs --- new in v4 include/linux/ctype.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/linux/ctype.h b

[U-Boot] [PATCH v4 05/13] cosmetic: remove unneeded curly braces

2011-08-23 Thread Jason Hobbs
This prevents a checkpatch warning in the patch to use isblank Signed-off-by: Jason Hobbs --- new in v4 common/main.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/common/main.c b/common/main.c index e9e8350..bf5ddca 100644 --- a/common/main.c +++ b/common

[U-Boot] [PATCH v4 03/13] common: add run_command2 for running simple or hush commands

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - whitespace correction changes in v4: - fix indention of a run_command2 line - make run_command2 static inline common/hush.c |2 +- common/main.c | 50 +- include/hush.h |2 +- 3 files

[U-Boot] [PATCH v4 02/13] common, menu: use abortboot for menu timeout

2011-08-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - expose abortboot externally instead of using a wrapper - expose abortboot externally when CONFIG_MENU is set changes in v3: - simplify the conditional export of abortboot - add timeout support for the menu in this patch - add doc for timeout

[U-Boot] [PATCH v4 01/13] Add generic, reusable menu code

2011-08-23 Thread Jason Hobbs
This will be used first by the pxe code, but is intended to be generic and reusable for other jobs in U-boot. Signed-off-by: Jason Hobbs --- changes in v2: - new in v2 changes in v3: - move timeout support to later patch - fix NULL case bug in menu_item_key_match - consistently use

[U-Boot] [PATCH v4 00/13] Add PXE support

2011-08-23 Thread Jason Hobbs
o tested the patches and sent me bug reports and fixes. Jason Hobbs (13): Add generic, reusable menu code common, menu: use abortboot for menu timeout common: add run_command2 for running simple or hush commands Add isblank cosmetic: remove unneeded curly braces Replace space and tab

Re: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-22 Thread jason . hobbs
On Monday, August 22, 2011 12:11pm, "Mike Frysinger" said: > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > On Monday, August 22, 2011 12:45:06 Marek Vasut wrote: >> On Monday, August 22, 2011 06:42:33

Re: [U-Boot] [PATCH v3 1/3] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-07-26 Thread Jason Hobbs
On Mon, Jul 25, 2011 at 11:37:34PM +0200, Wolfgang Denk wrote: > > +void uuid_str_to_bin(const char *uuid, unsigned char *out) I will add a separate function to verify the format of a UUID string. It doesn't belong in this function, which otherwise only needs to read the string once. It will chec

Re: [U-Boot] [PATCH v3 1/7] Add generic, reusable menu code

2011-07-26 Thread Jason Hobbs
Dear Wolfgang, On Mon, Jul 25, 2011 at 11:18:15PM +0200, Wolfgang Denk wrote: > I am happy that you provide documentation in doc/README.menu, but I > really dislike that the code itself is basicly uncommented. It is a > major pain to have to switch between the README and the source files > when tr

Re: [U-Boot] [PATCH v3 6/7] Add pxecfg command

2011-07-26 Thread Jason Hobbs
Dear Wolfgang, On Mon, Jul 25, 2011 at 11:15:36PM +0200, Wolfgang Denk wrote: > > Add pxecfg command, which is intended to mimic PXELINUX > > functionality. > > After thinking a long while about this, I came to the conclusion that > my initial feeling that "pxecfg" is ugly was actually correct.

Re: [U-Boot] [PATCH v3 5/7] common: add run_command2 for running simple or hush commands

2011-07-26 Thread Jason Hobbs
On Mon, Jul 25, 2011 at 10:42:18PM +0200, Wolfgang Denk wrote: > Dear "Jason Hobbs", > > -# ifndef CONFIG_SYS_HUSH_PARSER - run_command (p, 0); -# > > else - parse_string_outer(p, FLAG_PARSE_SEMICOLON | - > > FLAG_EXIT_FROM_LOOP);

Re: [U-Boot] [PATCH v3 0/3] Support for PXE options in DHCP requests

2011-07-08 Thread Jason Hobbs
Dear Wolfgang, On Wed, Jun 29, 2011 at 11:58:27AM -0500, Jason Hobbs wrote: > This patch series adds support for RFC 4578 compliant DHCP request > options, which enhance the ability of DHCP servers to respond > differently to different clients. > > As an example, the last patch

Re: [U-Boot] [PATCH v3 0/7] Add support for pxecfg commands

2011-07-08 Thread Jason Hobbs
Dear Wolfgang, On Wed, Jun 29, 2011 at 11:25:12AM -0500, Jason Hobbs wrote: > The pxecfg commands provide a near subset of the functionality provided > by the PXELINUX boot loader. This allows U-boot based systems to be > controlled remotely using the same PXE based techniques that man

[U-Boot] [PATCH v3 3/3] arm: ca9x4_ct_vxp: enable CONFIG_BOOTP_PXE

2011-06-29 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- Changes for v2: - Add armv7 architecture to VCI string include/configs/ca9x4_ct_vxp.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 7f83249..fdf9a2a 100644 --- a

[U-Boot] [PATCH v3 1/3] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-06-29 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- Changes for v2: - Move uuid_str_to_bin's prototype from uuid. to common.h - Place uuid.o make rule in sorted order and conditionalize Changes for v3: - Check for NULL pointers in uuid conversion function include/common.h |3 +++ lib/Makefile |1 +

[U-Boot] [PATCH v3 2/3] net: bootp: add PXE/RFC 4578 DHCP options support

2011-06-29 Thread Jason Hobbs
These options are required to be present in RFC 4578 compliant DHCP requests. They give more information to DHCP servers to allow serving different DHCP responses to different systems based on client architecture, client capabilities, UUID, or vendor. Signed-off-by: Jason Hobbs --- Changes for

[U-Boot] [PATCH v3 0/3] Support for PXE options in DHCP requests

2011-06-29 Thread Jason Hobbs
: - drop uuid.h in favor of common.h - alphabetical order for build targets changes in v3: - add checks for NULL pointers in uuid conversion function Jason Hobbs (3): lib: add uuid_str_to_bin for use with bootp and PXE uuid net: bootp: add PXE/RFC 4578 DHCP options support arm: ca9x4_ct_vxp

[U-Boot] [PATCH v3 6/7] Add pxecfg command

2011-06-29 Thread Jason Hobbs
nd line. This patch also adds a README.pxecfg file - see it for more details on the pxecfg command. Signed-off-by: Jason Hobbs --- changes in v2: - call abortboot directly instead of via a wrapper - change the license to GPLv2+ - cleanup brace usage in multiline statements, conditionals - allow b

[U-Boot] [PATCH v3 7/7] arm: ca9x4_ct_vxp: enable pxecfg support

2011-06-29 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - use CONFIG_MENU to enable building the menu for pxecfg use include/configs/ca9x4_ct_vxp.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 7f83249

[U-Boot] [PATCH v3 5/7] common: add run_command2 for running simple or hush commands

2011-06-29 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - whitespace correction common/hush.c|2 +- common/main.c| 46 +++--- include/common.h |1 + include/hush.h |2 +- 4 files changed, 22 insertions(+), 29 deletions(-) diff --git a

[U-Boot] [PATCH v3 3/7] common, menu: use abortboot for menu timeout

2011-06-29 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - expose abortboot externally instead of using a wrapper - expose abortboot externally when CONFIG_MENU is set changes in v3: - simplify the conditional export of abortboot - add timeout support for the menu in this patch - add doc for timeout

[U-Boot] [PATCH v3 4/7] cosmetic, main: correct indentation/spacing issues

2011-06-29 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - new in v2 common/main.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/common/main.c b/common/main.c index 1a371b1..489c9e9 100644 --- a/common/main.c +++ b/common/main.c @@ -397,15 +397,15 @@ void main_loop

[U-Boot] [PATCH v3 2/7] cosmetic, main: clean up declarations of abortboot

2011-06-29 Thread Jason Hobbs
Remove an unneeded prototype declaration from the top of main.c, and use plain inline instead of __inline__ to please checkpatch. Signed-off-by: Jason Hobbs --- changes in v3: - new in v3 common/main.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/common

[U-Boot] [PATCH v3 1/7] Add generic, reusable menu code

2011-06-29 Thread Jason Hobbs
This will be used first by the pxecfg code, but is intended to be generic and reusable for other jobs in U-boot. Signed-off-by: Jason Hobbs --- changes in v2: - new in v2 changes in v3: - move timeout support to later patch - fix NULL case bug in menu_item_key_match - consistently use

[U-Boot] [PATCH v3 0/7] Add support for pxecfg commands

2011-06-29 Thread Jason Hobbs
he patches. The order of patches also changes, with all of the menu support being added first, followed by the pxecfg specific patches. Jason Hobbs (7): Add generic, reusable menu code cosmetic, main: clean up declarations of abortboot common, menu: use abortboot for menu timeout cosm

Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

2011-06-24 Thread Jason Hobbs
Dear Wolfgang, On Fri, Jun 24, 2011 at 07:18:55AM +0200, Wolfgang Denk wrote: > > +#ifdef CONFIG_MENU > > This being a new CONFIG_ variable, it must be documented in the > README. But as is this makes little sense, so I suggest you change > the order of your patches and add the abortboot support

Re: [U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

2011-06-24 Thread Jason Hobbs
Mike, On Thu, Jun 23, 2011 at 06:59:40PM -0400, Mike Frysinger wrote: > more ifdef trickery here than necessary: > #ifndef CONFIG_MENU > static inline > #endif > int abortboot(int bootdelay) > { Thanks - I'll change this in the next version of the patch. Jason _

Re: [U-Boot] [PATCH v2 4/6] Add generic, reusable menu code

2011-06-24 Thread Jason Hobbs
On Thu, Jun 23, 2011 at 10:03:12PM +0200, Wolfgang Denk wrote: > Dear "Jason Hobbs", > Is this all new code, or was it copied from some other project? If > so, reference would be needed. All new code. > Then, we need documentation how this is going to be used. Plea

Re: [U-Boot] [PATCH] ARM: versatile: fix board support

2011-06-24 Thread Jason Hobbs
Hi Stefano, On Fri, Jun 24, 2011 at 06:53:31PM +0200, stefano babic wrote: > Probably we need some feedback from ML to know if we have to save the > vexpress board or we have simply to drop it, because nobody seems to > have interest on it. The versatile is the well known example to run > the boot

[U-Boot] [PATCH v2 6/6] arm: ca9x4_ct_vxp: enable pxecfg support

2011-06-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - use CONFIG_MENU to enable building the menu for pxecfg use include/configs/ca9x4_ct_vxp.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 7f83249

[U-Boot] [PATCH v2 3/6] common: make abortboot available for menu use

2011-06-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - expose abortboot externally instead of using a wrapper - expose abortboot externally when CONFIG_MENU is set common/main.c| 12 include/common.h |3 +++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/common

[U-Boot] [PATCH v2 2/6] common: add run_command2 for running simple or hush commands

2011-06-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - whitespace correction common/hush.c|2 +- common/main.c| 46 +++--- include/common.h |1 + include/hush.h |2 +- 4 files changed, 22 insertions(+), 29 deletions(-) diff --git a

[U-Boot] [PATCH v2 0/6] Add support for pxecfg commands

2011-06-23 Thread Jason Hobbs
the pxecfg code, giving a reusable menu implementation. It also contains various smaller changes documented in the comment section of the patches. Jason Hobbs (6): cosmetic, main: correct indentation/spacing issues common: add run_command2 for running simple or hush commands common: make

[U-Boot] [PATCH v2 5/6] Add pxecfg command

2011-06-23 Thread Jason Hobbs
nd line. This patch also adds a README.pxecfg file - see it for more details on the pxecfg command. Signed-off-by: Jason Hobbs --- changes in v2: - call abortboot directly instead of via a wrapper - change the license to GPLv2+ - cleanup brace usage in multiline statements, conditionals - allow b

[U-Boot] [PATCH v2 4/6] Add generic, reusable menu code

2011-06-23 Thread Jason Hobbs
This will be used first by the pxecfg code, but is intended to be generic and reusable for other jobs in U-boot. Signed-off-by: Jason Hobbs --- changes in v2: - new in v2 common/Makefile |1 + common/menu.c | 338 +++ include/menu.h

[U-Boot] [PATCH v2 1/6] cosmetic, main: correct indentation/spacing issues

2011-06-23 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- changes in v2: - new in v2 common/main.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/common/main.c b/common/main.c index dcbacc9..f05ee53 100644 --- a/common/main.c +++ b/common/main.c @@ -406,15 +406,15 @@ void main_loop

Re: [U-Boot] [PATCH 3/4] Add pxecfg command

2011-06-20 Thread Jason Hobbs
Dear Wolfgang, I've prepared a new series of patches that I believe adresses most of your comments, but I have a few responses and a question before sending the new patch series out. On Mon, Jun 06, 2011 at 09:45:22PM +0200, Wolfgang Denk wrote: > > Add pxecfg command, which is intended to mimic

[U-Boot] [PATCH v2 1/3] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-06-10 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- Changes for v2: - Move uuid_str_to_bin's prototype from uuid. to common.h - Place uuid.o make rule in sorted order and conditionalize --- include/common.h |3 +++ lib/Makefile |1 + lib/uuid.c |

[U-Boot] [PATCH v2 3/3] arm: ca9x4_ct_vxp: enable CONFIG_BOOTP_PXE

2011-06-10 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- Changes for v2: - Add armv7 architecture to VCI string --- include/configs/ca9x4_ct_vxp.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 7f83249..fdf9a2a 100644

[U-Boot] [PATCH v2 2/3] net: bootp: add PXE/RFC 4578 DHCP options support

2011-06-10 Thread Jason Hobbs
These options are required to be present in RFC 4578 compliant DHCP requests. They give more information to DHCP servers to allow serving different DHCP responses to different systems based on client architecture, client capabilities, UUID, or vendor. Signed-off-by: Jason Hobbs --- Changes for

Re: [U-Boot] [PATCH 1/3] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-06-06 Thread Jason Hobbs
On Mon, Jun 06, 2011 at 11:30:59PM +0200, Wolfgang Denk wrote: > Dear "Jason Hobbs", > > In message <1307386157-3660-2-git-send-email-jason.ho...@calxeda.com> you > wrote: > > Signed-off-by: Jason Hobbs > > --- > > include/uuid.h | 28 +

Re: [U-Boot] [PATCH 2/4] common: make abortboot available for pxecfg use

2011-06-06 Thread Jason Hobbs
Dear Wolfgang, On Mon, Jun 06, 2011 at 09:23:06PM +0200, Wolfgang Denk wrote: > > diff --git a/include/common.h b/include/common.h > > index e659630..fd389e7 100644 > > --- a/include/common.h > > +++ b/include/common.h > > @@ -234,6 +234,7 @@ int readline_into_buffer(const char *const > >

Re: [U-Boot] [PATCH 1/4] common: add run_command2 for running simple or hush commands

2011-06-06 Thread Jason Hobbs
Dear Wolfgang, On Mon, Jun 06, 2011 at 09:16:00PM +0200, Wolfgang Denk wrote: > > -# ifndef CONFIG_SYS_HUSH_PARSER > > - run_command (p, 0); > > -# else > > - parse_string_outer(p, FLAG_PARSE_SEMICOLON | > > - FLAG_EXIT_FROM_LOOP); > > -# endif > >

[U-Boot] [PATCH 3/4] Add pxecfg command

2011-06-06 Thread Jason Hobbs
nd line. This patch also adds a README.pxecfg file - see it for more details on the pxecfg command. Signed-off-by: Jason Hobbs --- common/Makefile |1 + common/cmd_pxecfg.c | 1070 +++ doc/README.pxecfg | 238 include/com

[U-Boot] [PATCH 4/4] arm: ca9x4_ct_vxp: enable pxecfg support

2011-06-06 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- include/configs/ca9x4_ct_vxp.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 7f83249..dd803ac 100644 --- a/include/configs/ca9x4_ct_vxp.h +++ b/include/configs

[U-Boot] [PATCH 1/4] common: add run_command2 for running simple or hush commands

2011-06-06 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- common/hush.c|2 +- common/main.c| 46 +++--- include/common.h |1 + include/hush.h |2 +- 4 files changed, 22 insertions(+), 29 deletions(-) diff --git a/common/hush.c b/common/hush.c index 85a6030

[U-Boot] [PATCH 2/4] common: make abortboot available for pxecfg use

2011-06-06 Thread Jason Hobbs
From: Rob Herring Signed-off-by: Jason Hobbs --- common/main.c|7 +++ include/common.h |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/common/main.c b/common/main.c index 7da6604..4185bfd 100644 --- a/common/main.c +++ b/common/main.c @@ -263,6 +263,13

[U-Boot] [PATCH 0/4] Add support for pxecfg commands

2011-06-06 Thread Jason Hobbs
behavior is identical, we call this feature 'pxecfg'. As an example, support for the pxecfg commands is enabled for the ca9x4_ct_vxp config. Additional details are available in the README file added as part of this patch series. Jason Hobbs (3): common: add run_command2 for running

[U-Boot] [PATCH 0/3] Support for PXE options in DHCP requests

2011-06-06 Thread Jason Hobbs
These options are required to be present in RFC 4578 compliant DHCP requests. They give more information to DHCP servers to allow serving different DHCP responses to different systems based on client architecture, client capabilities, UUID, or vendor. Jason Hobbs (3): lib: add uuid_str_to_bin

[U-Boot] [PATCH 2/3] net: bootp: add PXE/RFC 4578 DHCP options support

2011-06-06 Thread Jason Hobbs
These options are required to be present in RFC 4578 compliant DHCP requests. They give more information to DHCP servers to allow serving different DHCP responses to different systems based on client architecture, client capabilities, UUID, or vendor. Signed-off-by: Jason Hobbs --- net/bootp.c

[U-Boot] [PATCH 1/3] lib: add uuid_str_to_bin for use with bootp and PXE uuid

2011-06-06 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- include/uuid.h | 28 lib/Makefile |1 + lib/uuid.c | 50 ++ 3 files changed, 79 insertions(+), 0 deletions(-) create mode 100644 include/uuid.h create mode 100644 lib

[U-Boot] [PATCH 3/3] arm: ca9x4_ct_vxp: enable CONFIG_BOOTP_PXE

2011-06-06 Thread Jason Hobbs
Signed-off-by: Jason Hobbs --- include/configs/ca9x4_ct_vxp.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 7f83249..881dfb3 100644 --- a/include/configs/ca9x4_ct_vxp.h +++ b/include/configs