Re: [PATCH] disk: Use part_driver_lookup_type() to valid downloaded image

2025-08-05 Thread Ilias Apalodimas
Hi Javier On Fri, 1 Aug 2025 at 00:35, Javier Tia wrote: > > The part_driver_lookup_type() function was made public to be used in the > EFI loader. This function is used to look up the partition type for a > block device. > > This change allows the EFI loader to detect disk images by using the >

Re: U-Boot support for wolfTPM and firmware update for SLB9672/SLB9673

2025-08-05 Thread Ilias Apalodimas
Hi Aidan, On Sat, 2 Aug 2025 at 01:59, Aidan Garske wrote: > > Hi Simon and Ilias, > > Thank you for the great feedback. Currently I am working in the refactor you > suggested and I wanted to ask a question about some of your comments. > > 1. What exactly is the "driver code" you are referring

Re: [PATCH v2 1/1] efi_loader: Support loading a ramdisk with bootefi

2025-08-05 Thread Ilias Apalodimas
On Tue, 5 Aug 2025 at 10:33, Heinrich Schuchardt wrote: > > On 05.08.25 08:56, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > > > On Tue, 5 Aug 2025 at 08:46, Heinrich Schuchardt > > > <mailto:heinrich.schucha...@canonical.com>> wrote: > &

Re: [PATCH v1 1/2] efi_loader: improve device path matching for partition lookup

2025-08-05 Thread Ilias Apalodimas
Hi Balaji On Thu, 24 Jul 2025 at 12:00, Balaji Selvanathan wrote: > > - Refactor find_handle() to improve device path comparison logic. > - Original logic only compared paths when len_current <= len. > - This fails when searching for ESP inside a larger boot device. > - ESP partition path is long

Re: [PATCH v2 1/1] efi_loader: Support loading a ramdisk with bootefi

2025-08-04 Thread Ilias Apalodimas
Hi Heinrich, On Tue, 5 Aug 2025 at 08:46, Heinrich Schuchardt < heinrich.schucha...@canonical.com> wrote: > From: Simon Glass > > It is sometimes useful to be able to boot via EFI using a Linux initrd. > Add support for this. > > Overall I don't mind adding this to bootefi. Fix a 'specifiy' ty

Re: [BUG] test_efi_capsule/conftest.py fails

2025-08-04 Thread Ilias Apalodimas
Hi Heinrich, On Mon, 28 Jul 2025 at 11:25, Heinrich Schuchardt < heinrich.schucha...@canonical.com> wrote: > Hello Ilias, > > Simon pointed me to this problem: > > https://source.denx.de/u-boot/u-boot/-/jobs/1208907 has this line: > > SKIPPED [9] test/py/tests/test_efi_capsule/conftest.py:103:

Re: [PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-07-21 Thread Ilias Apalodimas
Hi Sudeep On Fri, 18 Jul 2025 at 11:30, Sudeep Holla wrote: > > On Thu, Jul 17, 2025 at 11:41:48AM -0600, Tom Rini wrote: > > On Thu, Jul 17, 2025 at 06:03:09PM +0100, Sudeep Holla wrote: > > > > > Hi, > > > > > > I see build break with clang after the commit 5f520875bdf0 ("kbuild: > > > Bump the

Re: [PATCH] kbuild: Don't mandate gcc as the host compiler

2025-07-20 Thread Ilias Apalodimas
I was on PTO but fwiw this looks ok to me Cheers /Ilias On Fri, 18 Jul 2025 at 22:43, Tom Rini wrote: > > On Sat, 12 Jul 2025 12:45:58 +0200, Mark Kettenis wrote: > > > Systems that use clang may not have gcc installed. Set > > HOSTCC to cc and HOSTCXX to c++ like we did before to make those >

Re: [PATCH] vexpress_ca9x4: Disable EFI_LOADER on this platform

2025-07-11 Thread Ilias Apalodimas
led, so I think yes. I thought about disabling it, but that's too strict. Perhaps someone that uses v7 and *needs* EFI can look at enabling the MMU with a simple identity mapping. > It would be good if somebody at ARM could find out if they ever delivered > designs that match QEMU&

Re: [PATCH] kbuild: Avoid including architecture-specific Makefile twice

2025-07-11 Thread Ilias Apalodimas
Hi Yao, On Fri, 11 Jul 2025 at 10:28, Yao Zi wrote: > > On Fri, Jul 11, 2025 at 08:11:03AM +0300, Ilias Apalodimas wrote: > > Hi Yao, > > > > > > On Wed, 9 Jul 2025 at 19:15, Yao Zi wrote: > > > > > > Stranges errors are observed when building

Re: [PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-07-11 Thread Ilias Apalodimas
> > Hi Ilias, > > > > > > > > On Thu, Jul 10, 2025 at 11:28 AM Ilias Apalodimas > > > > wrote: > > > > > > > > > Thanks I'll try to reproduce it later today and let you know. Do you > > > > > know if we build t

Re: [PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-07-10 Thread Ilias Apalodimas
Hi Francesco, On Fri, 11 Jul 2025 at 08:27, Francesco Dolcini wrote: > > Hi > > On Fri, Jul 11, 2025 at 08:15:25AM +0300, Ilias Apalodimas wrote: > > I can't reproduce this on my Ubuntu and Debian boxes. > > Can you paste your Ubuntu, make & gcc versions?

Re: [PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-07-10 Thread Ilias Apalodimas
/10/25 16:34, Fabio Estevam wrote: > > > Hi Ilias, > > > > > > On Thu, Jul 10, 2025 at 11:28 AM Ilias Apalodimas > > > wrote: > > > > > > > Thanks I'll try to reproduce it later today and let you know. Do you > > > > know if we

Re: [PATCH] kbuild: Avoid including architecture-specific Makefile twice

2025-07-10 Thread Ilias Apalodimas
Hi Yao, On Wed, 9 Jul 2025 at 19:15, Yao Zi wrote: > > Stranges errors are observed when building U-Boot master for almost any > RISC-V board, the messages are in two types, one is about duplicated > symbols, > > u-boot/arch/riscv/cpu//mtrap.S:32: multiple definition of > `trap_entry';

Re: [PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-07-10 Thread Ilias Apalodimas
Hi Fabio On Thu, 10 Jul 2025 at 17:16, Fabio Estevam wrote: > > Hi Ilias, > > On Fri, Jun 27, 2025 at 3:57 PM Ilias Apalodimas > wrote: > > > > Our last sync with the kernel was 5.1. Even that was a partial one > > as some patches from 4.x kernels were already

Re: [PATCH v4 1/3] Makefile: Add size check for u-boot-with-spl.bin

2025-07-10 Thread Ilias Apalodimas
Hi Philip On Tue, 8 Jul 2025 at 17:34, Philip Oberfichtner wrote: > > Hi Ilias, > > Thanks for having a look at this! > > On Tue, Jul 08, 2025 at 02:31:37PM +0300, Ilias Apalodimas wrote: > > > diff --git a/Makefile b/Makefile > > > index fa9ce756083..791

Re: [PATCH 1/1] efi_loader: add missing check in FMP.GetImageInfo()

2025-07-08 Thread Ilias Apalodimas
On Tue, 8 Jul 2025 at 15:20, Heinrich Schuchardt wrote: > > On 08.07.25 13:56, Ilias Apalodimas wrote: > > Hi Heinrich > > > > On Tue, 8 Jul 2025 at 14:48, Heinrich Schuchardt > > wrote: > >> > >> The

Re: [PATCH 1/1] lmb: add missing fallthrough in lmb_alloc_mem()

2025-07-08 Thread Ilias Apalodimas
On Tue, 8 Jul 2025 at 15:13, Heinrich Schuchardt wrote: > > Add fallthrough to clarify the intent. > > Addresses-Coverity-ID: CID 569481: Control flow issues (MISSING_BREAK) > Signed-off-by: Heinrich Schuchardt > --- Reviewed-by: Ilias Apalodimas > lib/lmb.c | 1 +

Re: [PATCH 1/1] efi_loader: add missing check in FMP.GetImageInfo()

2025-07-08 Thread Ilias Apalodimas
; Fixes: f27c20148511 ("efi_loader: add firmware management protocol for FIT > image") > Signed-off-by: Heinrich Schuchardt > --- Reviewed-by: Ilias Apalodimas That being said, we need to double check the FIT capsule users. I think we can probably remove it in the future. Are

Re: [PATCH v4 1/3] Makefile: Add size check for u-boot-with-spl.bin

2025-07-08 Thread Ilias Apalodimas
Hi Philip, On Tue, 8 Jul 2025 at 13:40, Philip Oberfichtner wrote: > > Like other images, u-boot-with-spl.bin may be subject to size > restrictions. Extend CONFIG_SPL_SIZE_LIMIT to handle this case. > > Signed-off-by: Philip Oberfichtner > --- > > Notes: > Changes in v4: none > > Changes

Re: [PATCH 1/1] efi_loader: correct EFI_DEBUG_TABLE_ENTRY_SIZE

2025-07-08 Thread Ilias Apalodimas
be the size of an entry in the > EFI_DEBUG_INFO_TABLE, not the size of a pointer. > > Fixes: 146546138af5 ("efi: add EFI_DEBUG_IMAGE_INFO for debug") > Addresses-Coverity-ID: CID 569498: Code maintainability issues > (SIZEOF_MISMATCH) > Signed-off-by: Heinrich Sc

Re: [PATCH 1/1] efi_loader: efi_realloc() must check efi_alloc() return value

2025-07-08 Thread Ilias Apalodimas
ULL_RETURNS) > Signed-off-by: Heinrich Schuchardt > --- Reviewed-by: Ilias Apalodimas > lib/efi_loader/efi_memory.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c > index 6dfc698a247..b77c2f980cc 100644 > ---

Re: [PATCH 1/1] efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target

2025-07-08 Thread Ilias Apalodimas
On Tue, 8 Jul 2025 at 12:55, Heinrich Schuchardt wrote: > > On 08.07.25 09:36, Ilias Apalodimas wrote: > > Hi Heinrich > > > > On Tue, 8 Jul 2025 at 06:38, Heinrich Schuchardt wrote: > >> > >> Am 7. Juli 2025 11:53:22 MESZ schrieb "Yi

Re: [PATCH 1/1] efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target

2025-07-08 Thread Ilias Apalodimas
t we could only enable it for QEMU to test it. If you want that on for risc-v we can turn it on for QEMU as well? Thanks /Ilias > > Best regards > > Heinrich > > > > > >Signed-off-by: Ying-Chun Liu (PaulLiu) > >Cc: Heinrich Schuchardt > >Cc: I

Re: [PATCH v5 2/4] mach-k3: add runtime configuration of MMU table

2025-07-07 Thread Ilias Apalodimas
Hi Anshul, On Thu Jul 3, 2025 at 4:35 PM EEST, Anshul Dalal wrote: > k3_mem_map is used by u-boot to configure the MMU on k3 devices but > currently it's a static array which does not scale for platforms with > non-standard load addresses for ATF and OP-TEE. Additionally on systems > with limited

Re: [PATCH v5 3/4] mach-k3: add dynamic mmu fixups for SPL stage

2025-07-07 Thread Ilias Apalodimas
Hi Anshul, On Thu Jul 3, 2025 at 4:35 PM EEST, Anshul Dalal wrote: > On platforms with spl splash support such as 62p and 62x > (CONFIG_VIDEO=y), the top of DDR is reserved for the framebuffer. > > The size of the framebuffer is computed at runtime by video_reserve. > During the MMU configuration

Re: [PATCH 1/1] efi: turn on EFI_DEBUG_SUPPORT for qemu arm and arm64 target

2025-07-07 Thread Ilias Apalodimas
ficient for our current needs. > > Signed-off-by: Ying-Chun Liu (PaulLiu) > Cc: Heinrich Schuchardt > Cc: Ilias Apalodimas > Cc: Tom Rini > --- Reviewed-by: Ilias Apalodimas > configs/qemu_arm64_defconfig | 1 + > configs/qemu_arm_defconfig | 1 + > lib/efi_loa

[PATCH] tools: gen_ethaddr_crc: Make functions static

2025-07-07 Thread Ilias Apalodimas
These functions are only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark them as static. Signed-off-by: Ilias Apalodimas --- tools/gen_ethaddr_crc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/gen_ethaddr_crc.c b/tools/gen_ethaddr_crc.c

[PATCH] tools: ublimage: Make ublimage_check_params() static

2025-07-07 Thread Ilias Apalodimas
This functions is only used locally and triggers a warning when compiling with -Wmissing-prototypes. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/ublimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ublimage.c b/tools/ublimage.c index a1bd807bfa03

[PATCH] tools: mkenvimage: Make xstrtol() static

2025-07-07 Thread Ilias Apalodimas
This function is only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark it as static. Signed-off-by: Ilias Apalodimas --- tools/mkenvimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index 885cdb1390ef

[PATCH] tools: bmp_logo: Mark local functions with static

2025-07-07 Thread Ilias Apalodimas
These functions are only used locally. Enabling -Wmissing-prototypes triggers a warning. Mark them as static. Signed-off-by: Ilias Apalodimas --- tools/bmp_logo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/bmp_logo.c b/tools/bmp_logo.c index

Re: [PATCH 1/1] efi_selftest: check system table pointer

2025-07-07 Thread Ilias Apalodimas
On Fri, 4 Jul 2025 at 17:22, Heinrich Schuchardt wrote: > > Enhance the debug support unit test. > > Signed-off-by: Heinrich Schuchardt > -- Acked-by: Ilias Apalodimas > lib/efi_selftest/efi_selftest_debug_support.c | 68 ++- > 1 file changed, 67 inse

Re: [PATCH 5/5] arm64: simplify interrupt code

2025-07-03 Thread Ilias Apalodimas
-by: Heinrich Schuchardt > --- Reviewed-by: Ilias Apalodimas > arch/arm/lib/interrupts_64.c | 72 > 1 file changed, 24 insertions(+), 48 deletions(-) > > diff --git a/arch/arm/lib/interrupts_64.c b/arch/arm/lib/interrupts_64.c > index 970f8b

Re: [PATCH 1/5] cmd/exception: missing include string.h

2025-07-03 Thread Ilias Apalodimas
ion.h:41:23: error: implicit declaration of > function ‘strlen’ [-Wimplicit-function-declaration] >41 | len = strlen(argv[1]); > | ^~ > > Add the missing include. > > Signed-off-by: Heinrich Schuchardt Reviewed

Re: [PATCH 2/5] arm64: initialize the frame pointer register

2025-07-03 Thread Ilias Apalodimas
; pointer register is 0. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas > --- > arch/arm/lib/crt0_64.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/lib/crt0_64.S b/arch/arm/lib/crt0_64.S > index f3f279f2c39..3ff0577e9c8 100644 &

Pull request for efi-next-03072025

2025-07-03 Thread Ilias Apalodimas
Hi Tom A pull request for EFI coming from the TPM tree. New protocols are added to the EFI subsystem - Android Generic Bootloader (an EFI app loading Android) needs EFI Debug Support Table for hardware assisting debugging. - EFI_PARTITION_INFO_PROTOCOL is needed by a new OS Loader Redhat is wor

Re: [PATCH v8 3/5] lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory

2025-07-03 Thread Ilias Apalodimas
On Thu, 3 Jul 2025 at 12:10, Ilias Apalodimas wrote: > > Hi Paul > > > On Thu, 3 Jul 2025 at 09:28, Ying-Chun Liu (PaulLiu) > wrote: > > > > From: "Ying-Chun Liu (PaulLiu)" > > > > Add efi_realloc() for realloc memory that previously alloc

Re: [PATCH v8 3/5] lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory

2025-07-03 Thread Ilias Apalodimas
Hi Paul On Thu, 3 Jul 2025 at 09:28, Ying-Chun Liu (PaulLiu) wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > Add efi_realloc() for realloc memory that previously alloc by efi_alloc(). > > Signed-off-by: Ying-Chun Liu (PaulLiu) > Cc: Heinrich Schuchardt >

Re: [PATCH v8 5/5] efi: selftest: add selftest for EFI_DEBUG_SUPPORT

2025-07-03 Thread Ilias Apalodimas
On Thu, 3 Jul 2025 at 09:28, Ying-Chun Liu (PaulLiu) wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > Add selftest to check the installed configuration table that has > the correct GUID. > > Signed-off-by: Ying-Chun Liu (PaulLiu) > Cc: Heinrich Schuchardt >

Re: [PATCH v8 4/5] efi: add EFI_DEBUG_IMAGE_INFO for debug

2025-07-03 Thread Ilias Apalodimas
The implementation ensures support for hardware-assisted debugging and > provides a standardized mechanism for debuggers to discover the load > address of an EFI application. > > Signed-off-by: Ying-Chun Liu (PaulLiu) > Tested-by: Heinrich Schuchardt > Cc: Ilias Apalodimas >

Re: [PATCH v8 1/5] efi: add EFI_SYSTEM_TABLE_POINTER for debug

2025-07-03 Thread Ilias Apalodimas
LE. > > > > This feature is described in UEFI SPEC version 2.10. Section 18.4.2. > > The implementation ensures support for hardware-assisted debugging and > > provides a standardized mechanism for debuggers to discover the EFI > > system table. > > > > Sig

Re: [PATCH v5 1/2] cmd: eficonfig: add support for URI device path based boot options

2025-07-03 Thread Ilias Apalodimas
or adding a URI based boot > option. This boot option can then be used for HTTP boot. > > Signed-off-by: Sughosh Ganu Reviewed-by: Ilias Apalodimas Tested-by: Ilias Apalodimas > --- > Changes since V4: > * Clear out the URI string in eficonfig_process_clear_file_selection(

Re: [PATCH v2 2/3] efi_loader: Prevent dereference of uninitialised variable

2025-07-02 Thread Ilias Apalodimas
eliminate the use of the variable protocol_interface as it is not > needed. > > Signed-off-by: Andrew Goodbody > --- Reviewed-by: Ilias Apalodimas > lib/efi_loader/efi_http.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/lib/efi_loade

Re: [PATCH v3] arm64: zynqmp: Enable rng-seed generation

2025-07-02 Thread Ilias Apalodimas
On Wed, 2 Jul 2025 at 10:44, Michal Simek wrote: > > SOM has TPM with RNG in it that's why enable rng-seed generation. > > Signed-off-by: Michal Simek > --- > Acked-by: Ilias Apalodimas > Changes in v3: > - Move malloc allocation before rng_read > > Changes

Re: [PATCH v2] arm64: zynqmp: Enable rng-seed generation

2025-07-01 Thread Ilias Apalodimas
Hi Michal On Wed, 2 Jul 2025 at 09:34, Michal Simek wrote: > > SOM has TPM with RNG in it that's why enable rng-seed generation. > > Signed-off-by: Michal Simek > --- > > Changes in v2: > - Free alloc area in case of error > > board/xilinx/common/board.c | 34 ++

Re: [PATCH 3/3] efi_loader: Prevent free of uninitialised pointer

2025-07-01 Thread Ilias Apalodimas
; > This issue was found by Smatch. > > Signed-off-by: Andrew Goodbody Reviewed-by: Ilias Apalodimas > --- > lib/efi_loader/efi_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c > inde

Re: [PATCH 2/3] efi_loader: Prevent dereference of uninitialised variable

2025-07-01 Thread Ilias Apalodimas
Hi Andrew, On Tue, 1 Jul 2025 at 16:38, Andrew Goodbody wrote: > > If phandler is returned as NULL from efi_search_protocol then > protocol_interface is never assigned to. Add a check to prevent > protocol_interface being dereferenced in this case. Small refactor to > coalesce the two identical

Re: [PATCH 1/3] efi_loader: Prevent dereferencing NULL pointer

2025-07-01 Thread Ilias Apalodimas
ssing path to free instead of fh->path. > > This issue found by Smatch. > > Signed-off-by: Andrew Goodbody Reviewed-by: Ilias Apalodimas > --- > lib/efi_loader/efi_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loade

Re: [PATCH v4 0/2] eficonfig: add support for URI based boot option

2025-07-01 Thread Ilias Apalodimas
Hi Sughosh, On Tue, 1 Jul 2025 at 13:43, Sughosh Ganu wrote: > > > Add support for adding URI based boot option through the eficonfig > command. Also add a basic test case for checking validity of the URI's > being passed to the wget function. > > Changes since V3: > * Do away with boot_file_opt

Re: AARCH64 clean bss bug

2025-07-01 Thread Ilias Apalodimas
Hi Brock On Sun Jun 29, 2025 at 7:37 AM EEST, brock_zheng wrote: > > Hi, all > > I found a bug on AARCH64 platform about clean .bss section after > relocating. > > In crt0_64.S, it use instruction 'ldr' to load the start/stop > address of BSS after relocating. My testing shows that >

Re: [PATCH v3 2/2] test: wget: add a test case for validating URI

2025-07-01 Thread Ilias Apalodimas
false, wget_validate_uri("https://foo/ba > r.html")); > + ut_asserteq(false, wget_validate_uri("https://";)); > + } > + > + return 0; > +} > +CMD_TEST(net_test_wget_uri_validate, UTF_CONSOLE); > -- > 2.34.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v3 1/2] cmd: eficonfig: add support for URI device path based boot options

2025-07-01 Thread Ilias Apalodimas
Hi Sughosh [...] > + > static struct eficonfig_item select_file_menu_items[] = { > {"Select File", eficonfig_process_select_file}, > {"Clear", eficonfig_process_clear_file_selection}, > @@ -1042,16 +1101,30 @@ static struct eficonfig_item select_file_menu_items[] > = { > efi_st

Pull request for tpm-next-01072025

2025-07-01 Thread Ilias Apalodimas
Some minor smatch reported issues from Andrew The following changes since commit 490ae8ceae2d5999c9de863e014e463f5c1495a6: Revert the last two mach-k3 changes (2025-06-27 13:07:43 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-ne

Re: [PATCH v3 1/2] cmd: tpm: Fix attempt to return value not in enum

2025-06-30 Thread Ilias Apalodimas
ror to the enum so that it can be returned. > > This issue was reported by Smatch. > > Signed-off-by: Andrew Goodbody Reviewed-by: Ilias Apalodimas > --- > include/tpm-v2.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/tpm-v2.h b/include/tpm-v2

Re: [PATCH v2 1/2] cmd: tpm: Fix attempt to return value not in enum

2025-06-30 Thread Ilias Apalodimas
Hi Andrew On Fri, 27 Jun 2025 at 12:37, Andrew Goodbody wrote: > > The function tpm2_name_to_algorithm is defined as returning an > enum for the algorithm specified but it also attempts to return > an error on failure, but that error is not included in the enum. > Add the error to the enum so t

Re: [PATCH v2 2/2] tpm: Make use of TPM2_ALG_INVAL from enum

2025-06-30 Thread Ilias Apalodimas
On Fri, 27 Jun 2025 at 12:37, Andrew Goodbody wrote: > > Now that the enum includes TPM2_ALG_INVAL, use that name in the > code. > > Signed-off-by: Andrew Goodbody Reviewed-by: Ilias Apalodimas > --- > cmd/tpm-v2.c | 6 +++--- > lib/tpm-v2.c | 2 +- > 2 files

[PATCH v2 2/2] kbuild: Bump the build system to 5.1

2025-06-27 Thread Ilias Apalodimas
ny of them around to test, but the objdump of the resulting files -- arch/powerpc/lib/built-in.[oa] looks identical. Signed-off-by: Ilias Apalodimas --- Changes since v1: - Bring back -std=gnu11 which was accidentally dropped - Don't simplify our 'silent' rules since they mame m

Re: [PATCH] cmd: tpm: Fix attempt to return value not in enum

2025-06-27 Thread Ilias Apalodimas
Hi Andrew, On Thu, 26 Jun 2025 at 12:57, Andrew Goodbody wrote: > > The function tpm2_name_to_algorithm is defined as returning an > enum for the algorithm specified but it also attempts to return > an error on failure, but that error is not included in the enum. > Add the error to the enum so th

Re: [PATCH] cmd: ufetch: Initialise size before first use

2025-06-27 Thread Ilias Apalodimas
body > --- Reviewed-by: Ilias Apalodimas > cmd/ufetch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/ufetch.c b/cmd/ufetch.c > index 46bd16824e6..bc5db08eee1 100644 > --- a/cmd/ufetch.c > +++ b/cmd/ufetch.c > @@ -93,7 +93,7 @@ static

Re: [PATCH] efi_loader: initialize 'total' variable

2025-06-26 Thread Ilias Apalodimas
On Thu, 26 Jun 2025 at 11:05, Heinrich Schuchardt wrote: > > On 25.06.25 19:15, Ilias Apalodimas wrote: > > This variable might end up being uninitialized if we exit early. > > > > Signed-off-by: Ilias Apalodimas > > --- > > lib/efi_loader/efi_bootmgr.c | 2

[PATCH] efi_loader: initialize 'total' variable

2025-06-25 Thread Ilias Apalodimas
This variable might end up being uninitialized if we exit early. Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_bootmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_bootmgr.c b/lib/efi_loader/efi_bootmgr.c index b9437a81c642..662993fb8095

Re: [PATCH v2 0/4] efi_loader: add EFI_PARTITION_INFO_PROTOCOL support

2025-06-18 Thread Ilias Apalodimas
Hi Javier no worries On Wed, 18 Jun 2025 at 22:49, Javier Martinez Canillas wrote: > > Ilias Apalodimas writes: > > Hello Ilias, > > > Javier I reviewed the patches but I probably missed something. > > > > I am getting a compilation error with the selftests a

Re: [PATCH v2 0/4] efi_loader: add EFI_PARTITION_INFO_PROTOCOL support

2025-06-18 Thread Ilias Apalodimas
Javier I reviewed the patches but I probably missed something. I am getting a compilation error with the selftests applied. #include seems to be missing. Thanks /Ilias On Wed, 18 Jun 2025 at 18:10, Javier Martinez Canillas wrote: > > Tom Rini writes: > > Hello Tom, > > > On Wed, Jun 18, 2025

Re: [PATCH v2 0/3] Fix io accessors for KVM

2025-06-18 Thread Ilias Apalodimas
Hi Jerome, On Wed, 18 Jun 2025 at 14:03, Jerome Forissier wrote: > > > > On 6/18/25 08:58, Ilias Apalodimas wrote: > > Instructions that lead ito an exception in the hypervisor can't modify two > > CPU registers at once for the ARM ISA. > > > > These

Re: [PATCH v2 4/4] efi_selftest: Add basic partition info check to block io test

2025-06-18 Thread Ilias Apalodimas
n type instead. > > Suggested-by: Tom Rini > Signed-off-by: Javier Martinez Canillas > --- Reviewed-by: Ilias Apalodimas > > Changes in v2: > - Add a test for the EFI partition information protocol (Tom Rini). > > lib/efi_selftest/efi_selftest_block_device.c | 29 +

Re: [PATCH v2 3/4] efi_loader: disk: add EFI_PARTITION_INFO_PROTOCOL support

2025-06-18 Thread Ilias Apalodimas
ements support for GPT partition types. The legacy MBR > partition types is only needed for backward compatibility and can be added > as a follow-up if needed, to make it fully compliant with the EFI spec. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Ilias Apalodimas

[PATCH v2 1/3] nxp: Prepare macros for KVM changes

2025-06-17 Thread Ilias Apalodimas
l); | ^~~~ So adjust the current macros and code to be compatible with the upcoming change. Signed-off-by: Ilias Apalodimas --- drivers/spi/fsl_dspi.c | 6 -- include/fsl_ifc.h | 24 2 files changed, 16 insertions(+), 14 deletions(-) diff

[PATCH 2/2] kbuild: Bump the build system to 5.1

2025-06-17 Thread Ilias Apalodimas
ny of them around to test, but the objdump of the resulting files -- arch/powerpc/lib/built-in.[oa] looks identical. Signed-off-by: Ilias Apalodimas --- Makefile| 864 board/congatec/common/Makefile | 4 +- board/cssi/cmpc885/u-boot.lds

[PATCH 1/2] kbuild: Update Makefile.extrawarn to 5.1

2025-06-17 Thread Ilias Apalodimas
Since we are updating our kbuild system to 5.1, add the relevant clang changes from upstream Signed-off-by: Ilias Apalodimas --- scripts/Makefile.extrawarn | 9 + 1 file changed, 9 insertions(+) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index f687515fc799

Re: [PATCH] disable VBE by default

2025-06-16 Thread Ilias Apalodimas
> explicitly opt in to it like all other large features > in U-Boot. > > Signed-off-by: Peter Robinson Acked-by: Ilias Apalodimas > --- > boot/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/boot/Kconfig b/boot/Kconfig > index 30eb5b328d7..e8c3f

Re: [PATCH] cmd: eficonfig: add support for URI device path based boot options

2025-06-16 Thread Ilias Apalodimas
Hi Heinrich, Sughosh On Tue, 17 Jun 2025 at 00:53, Heinrich Schuchardt wrote: > > On 6/16/25 12:23, Sughosh Ganu wrote: > > The eficonfig command provides a menu based interface for maintenance > > of the EFI boot options. Add support for adding a URI based boot > > option. This boot option can t

Re: [PATCH 2/2] sandbox: enable CONFIG_CMD_BOOTEFI_SELFTEST by default

2025-06-16 Thread Ilias Apalodimas
+ imply CMD_BOOTEFI_SELFTEST > imply CMD_DM > imply CMD_EXCEPTION > imply CMD_GETTIME > -- > 2.48.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH 1/2] test: disable TCG test on sandbox

2025-06-16 Thread Ilias Apalodimas
pec('sandbox') > def test_efi_selftest_tcg2(ubman): > """Test the EFI_TCG2 PROTOCOL > > -- > 2.48.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH] arm: io.h: Fix io accessors for KVM

2025-06-16 Thread Ilias Apalodimas
On Mon, 16 Jun 2025 at 19:42, Tom Rini wrote: > > On Mon, Jun 16, 2025 at 04:11:32PM +0300, Ilias Apalodimas wrote: > > Hi Jerome, > > > > [...] > > > > > > > > If I'm not mistaken, this patch is doing two things that are unrelated: > > &

Re: [PATCH v5 3/4] lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory

2025-06-16 Thread Ilias Apalodimas
On Mon, 16 Jun 2025 at 16:46, Heinrich Schuchardt wrote: > > On 16.06.25 15:09, Ilias Apalodimas wrote: > > Hi Paul > > > > [...] > > > >> +/** > >> + * efi_realloc() - reallocate boot services data pool memory > >> + * > >> + *

Re: [PATCH 1/3] disk: efi: Move logic to get a GPT entry into a helper function

2025-06-16 Thread Ilias Apalodimas
On Mon, 16 Jun 2025 at 17:08, Javier Martinez Canillas wrote: > > Heinrich Schuchardt writes: > > Thanks Ilias and Heinrich for your review / feedback. > > > On 16.06.25 15:32, Ilias Apalodimas wrote: > >> On Fri, 13 Jun 2025 at 11:58, Javier Martinez Canillas >

Re: [PATCH 1/3] disk: efi: Move logic to get a GPT entry into a helper function

2025-06-16 Thread Ilias Apalodimas
On Fri, 13 Jun 2025 at 11:58, Javier Martinez Canillas wrote: > > Factor out the logic to get the Partition Table Entry (PTE) of a given > partition into a helper function, since it could be used by other code. > > Signed-off-by: Javier Martinez Canillas > --- > > disk/part_efi.c | 67 ++

Re: [PATCH 2/3] disk: efi: expose the part_get_gpt_pte() helper function

2025-06-16 Thread Ilias Apalodimas
Thanks Javier, On Fri, 13 Jun 2025 at 11:58, Javier Martinez Canillas wrote: > > This function will be used by the EFI application disk support code > to provide data required by the EFI_PARTITION_INFORMATION_PROTOCOL. > > Signed-off-by: Javier Martinez Canillas > ---

Re: [PATCH v5 4/4] efi: add EFI_DEBUG_IMAGE_INFO for debug

2025-06-16 Thread Ilias Apalodimas
[...] > } > + > + if (IS_ENABLED(CONFIG_EFI_DEBUG_SUPPORT)) { > + if (*image_handle) { Can you fold this in a single line if? > + > efi_core_new_debug_image_info_entry(EFI_DEBUG_IMAGE_INFO_TYPE_NORMAL, > +

Re: [PATCH] arm: io.h: Fix io accessors for KVM

2025-06-16 Thread Ilias Apalodimas
Hi Jerome, [...] > > If I'm not mistaken, this patch is doing two things that are unrelated: > (1) fix the KVM issue and > (2) get rid of the __arch_*() macros in favor of the __raw_*() macros I can split it, but I don't see much point since we redefine the raw_macros. > > IMO this should be tw

Re: [PATCH v5 3/4] lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory

2025-06-16 Thread Ilias Apalodimas
Hi Paul [...] > +/** > + * efi_realloc() - reallocate boot services data pool memory > + * > + * Reallocate memory from pool for a new size and copy the data from old one. > + * > + * @ptr: pointer to old buffer > + * @size: number of bytes to allocate > + * Return: EFI status to i

Re: [PATCH v5 2/4] efi: add EFI_DEBUG_IMAGE_INFO_TABLE for debug

2025-06-16 Thread Ilias Apalodimas
described in UEFI Spec version 2.10. Section 18.4. > The implementation ensures support for hardware-assisted debugging and > provides a standardized mechanism for debuggers to discover and interact > with system-level debug resources. > > Signed-off-by: Ying-Chun Liu (PaulLiu) >

Re: [PATCH v5 1/4] efi: add EFI_SYSTEM_TABLE_POINTER for debug

2025-06-16 Thread Ilias Apalodimas
EC version 2.10. Section 18.4.2. > The implementation ensures support for hardware-assisted debugging and > provides a standardized mechanism for debuggers to discover the EFI > system table. > > Signed-off-by: Ying-Chun Liu (PaulLiu) > Cc: Heinrich Schuchardt > Cc: Ilias

Re: [PATCH v4 2/7] lmb: replace the lmb_alloc() and lmb_alloc_base() API's

2025-06-16 Thread Ilias Apalodimas
function which does the > actual allocation is the same. Use the earlier introduced API > lmb_alloc_mem() for both types of allocation requests. > > Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas Cheers /Ilias > --- > Changes since V3: > * mach-apple: Check the ret

Re: [PATCH v4 1/7] lmb: replace lmb_reserve() and lmb_alloc_addr() API's

2025-06-16 Thread Ilias Apalodimas
lmb_memory[rgn].size, > - base + size - 1, 1)) { > + base + size - 1, 1)) > /* ok, reserve the memory */ > - if (!lmb_reserve(base, size, flags)) > - return 0; > - } > + return lmb_reserve(base, size, flags); > + else > + return -EINVAL; You don't need the else here > + } > + > + return -EINVAL; > +} [...] Other than that Acked-by: Ilias Apalodimas

Re: [RFC PATCH v1] usb: xhci: fix crash with arm64 QEMU and KVM

2025-06-16 Thread Ilias Apalodimas
Hi Jerome, On Tue Jun 10, 2025 at 3:17 PM EEST, Jerome Forissier wrote: > Add a xhci_flush_cache() call to xhci_start() to fix the following > issue when running arm64 QEMU with KVM support (on a arm64 host): > > $ make qemu_arm64_defconfig > $ sed -i 's/CONFIG_BLOBLIST=y/# CONFIG_BLOBLIST is no

[PATCH] arm: io.h: Fix io accessors for KVM

2025-06-16 Thread Ilias Apalodimas
ymore. So let's add proper I/O accessors for arvm8 only and add a Kconfig option to turn it off by default if TPL is selected. [0] https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/26673 Reported-by: Mikko Rapeli Signed-off-by: Ilias Apalodimas --- arch/a

Re: [PATCH] tpm: Export the function to set up the TPM log

2025-06-11 Thread Ilias Apalodimas
Hi Simon, On Thu, 5 Jun 2025 at 20:29, Simon Glass wrote: > Hi Ilias, > > On Sat, 24 May 2025 at 12:24, Ilias Apalodimas > wrote: > > > > On Sat, 24 May 2025 at 20:59, Ilias Apalodimas > > wrote: > > > > > > Thanks Tom > >

[PATCH v2 00/13] Update the kbuild system to 5.1

2025-06-11 Thread Ilias Apalodimas
of next Ilias Apalodimas (13): kbuild: add -fno-PIE flag unconditionally kbuild: add -Werror=implicit-int flag unconditionally kbuild: use assignment instead of define ... endef for filechk_* rules kbuild: clang: choose GCC_TOOLCHAIN_DIR not on LD kbuild: use -Werror=implicit-... instead

[PATCH v2 02/13] kbuild: add -Werror=implicit-int flag unconditionally

2025-06-11 Thread Ilias Apalodimas
Backported from kernel commit 61a0902a06d6a ("kbuild: add -Werror=implicit-int flag unconditionally") Signed-off-by: Ilias Apalodimas --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6c01ccfcb97d..7e1b36e78b93 100644 ---

[PATCH v2 08/13] gcc-9: silence 'address-of-packed-member' warning

2025-06-11 Thread Ilias Apalodimas
Backported from kernel commit 6f303d60534c ("gcc-9: silence 'address-of-packed-member' warning") Signed-off-by: Ilias Apalodimas --- Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile b/Makefile index bd0866dc4579..f05c70073b85 100644 --- a/Makefile +++

[PATCH v2 04/13] kbuild: clang: choose GCC_TOOLCHAIN_DIR not on LD

2025-06-11 Thread Ilias Apalodimas
Backported from kernel commit ad15006cc784 ("kbuild: clang: choose GCC_TOOLCHAIN_DIR not on LD") Signed-off-by: Ilias Apalodimas --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 7e1b36e78b93..e648f4920cfb 100644 --- a/Make

[PATCH v2 11/13] kbuild: mark prepare0 as PHONY to fix external module build

2025-06-11 Thread Ilias Apalodimas
Backported from kernel commit e00d88804814 ("kbuild: mark prepare0 as PHONY to fix external module build") Signed-off-by: Ilias Apalodimas --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4e339ef4bb9c..a31e89d77490 10

[PATCH v2 10/13] kbuild: skip parsing pre sub-make code for recursion

2025-06-11 Thread Ilias Apalodimas
Backported from kernel commit 221cc2d27ddc ("kbuild: skip parsing pre sub-make code for recursion") Signed-off-by: Ilias Apalodimas --- Makefile | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 5dad1aa57f70..4e339ef4bb9c 10

[PATCH v2 07/13] kbuild: remove meaningless prepare2 target

2025-06-11 Thread Ilias Apalodimas
Backported from kernel commit 4f1c1008e786 ("kbuild: remove meaningless prepare2 target") Signed-off-by: Ilias Apalodimas --- Makefile | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 2b9516bf4ff7..bd0866dc4579 100644 --- a/Make

[PATCH v2 06/13] kbuild: gitignore output directory

2025-06-11 Thread Ilias Apalodimas
Backported from kernel commit 3a51ff344204 ("kbuild: gitignore output directory" Signed-off-by: Ilias Apalodimas --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 00c0d76e1954..2b9516bf4ff7 100644 --- a/Makefile +++ b/Makefile @@ -513,

[PATCH v2 01/13] kbuild: add -fno-PIE flag unconditionally

2025-06-11 Thread Ilias Apalodimas
Backport from kernel commit 42a92bccd213 ("kbuild: add -fno-PIE flag unconditionally") Signed-off-by: Ilias Apalodimas --- Makefile | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index e1ac2d9cec30..6c01ccfcb97d 100644 --- a/Make

Pull request for tpm-next-10062025

2025-06-10 Thread Ilias Apalodimas
Hi Tom, Small updates for testing TPMs for -next The following changes since commit 59d00e20fced23e6463aa09db889dd548baee677: Merge tag 'v2025.07-rc4' into next (2025-06-09 16:28:28 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm

Re: [PATCH v2 2/3] cmd: remove duplicate DHCPv6 Kconfig definitions

2025-06-10 Thread Ilias Apalodimas
On Sun, 8 Jun 2025 at 10:42, Heinrich Schuchardt wrote: > > Remove duplicate definition of > > * DHCP6_PXE_CLIENTARCH > * DHCP6_PXE_DHCP_OPTION > * DHCP6_ENTERPRISE_ID > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas > --- > cmd/Kconfig |

Re: [PATCH v2 1/3] sandbox: fix dram_init()

2025-06-10 Thread Ilias Apalodimas
On Sun, 8 Jun 2025 at 10:54, Heinrich Schuchardt wrote: > > dram_init() must not overwrite the value of gd->ram_buf set by > setup_ram_buf() for main U-Boot or board_init_f() for SPL. > > Signed-off-by: Heinrich Schuchardt I am not an expert in sandbox, but this looks

  1   2   3   4   5   6   7   8   9   10   >