Thanks Heinrich
On Tue, 8 Jul 2025 at 14:14, Heinrich Schuchardt
<heinrich.schucha...@canonical.com> wrote:
>
> With the current code we allocate to little memory when adding entries to
> the EFI_DEBUG_INFO_TABLE and we fail to correctly move entries when an
> entry is removed.
>
> EFI_DEBUG_TABLE_ENTRY_SIZE must be the size of an entry in the
> EFI_DEBUG_INFO_TABLE, not the size of a pointer.
>
> Fixes: 146546138af5 ("efi: add EFI_DEBUG_IMAGE_INFO for debug")
> Addresses-Coverity-ID: CID 569498: Code maintainability issues
> (SIZEOF_MISMATCH)
> Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
> ---
Reviewed-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
> lib/efi_loader/efi_debug_support.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/efi_debug_support.c
> b/lib/efi_loader/efi_debug_support.c
> index 186bdbce750..490b0bb7088 100644
> --- a/lib/efi_loader/efi_debug_support.c
> +++ b/lib/efi_loader/efi_debug_support.c
> @@ -22,7 +22,7 @@ struct efi_debug_image_info_table_header
> efi_m_debug_info_table_header = {
> */
> static u32 efi_m_max_table_entries;
>
> -#define EFI_DEBUG_TABLE_ENTRY_SIZE (sizeof(union efi_debug_image_info *))
> +#define EFI_DEBUG_TABLE_ENTRY_SIZE (sizeof(union efi_debug_image_info))
>
> /**
> * efi_initialize_system_table_pointer() - Initialize system table pointer
> --
> 2.48.1
>
