On Tue, 8 Jul 2025 at 12:55, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > On 08.07.25 09:36, Ilias Apalodimas wrote: > > Hi Heinrich > > > > On Tue, 8 Jul 2025 at 06:38, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > >> > >> Am 7. Juli 2025 11:53:22 MESZ schrieb "Ying-Chun Liu (PaulLiu)" > >> <paul...@debian.org>: > >>> Previously, EFI_DEBUG_SUPPORT was enabled across all platforms for > >>> CI build testing. With this commit, we are limiting its activation > >>> to qemu_arm64_defconfig and qemu_arm_defconfig only, which is > >>> sufficient for our current needs. > >> > >> Was there a request to turn it off on other platforms? > > > > I asked Paul to send this, because it grows the binary size a bit. > > Since it a debug protocol, I thought we could only enable it for QEMU > > to test it. > > If you want that on for risc-v we can turn it on for QEMU as well? > > The protocol is typically needed when things fail on real hardware. > Having to reflash U-Boot may not be desired especially if the U-Boot > binary is signed. Isn't !HAS_BOARD_SIZE_LIMIT is enough of a safeguard > for now?
Well I assume that people use it for debugging and not production, so refreshing shouldn't be a big deal. I don't mind if you prefer it as is. I just assumed we wanted it off by default, since it's a debug protocol Regards /Ilias > > Best regards > > Heinrich > > > > > Thanks > > /Ilias > >> > >> Best regards > >> > >> Heinrich > >> > >> > >>> > >>> Signed-off-by: Ying-Chun Liu (PaulLiu) <paul...@debian.org> > >>> Cc: Heinrich Schuchardt <xypron.g...@gmx.de> > >>> Cc: Ilias Apalodimas <ilias.apalodi...@linaro.org> > >>> Cc: Tom Rini <tr...@konsulko.com> > >>> --- > >>> configs/qemu_arm64_defconfig | 1 + > >>> configs/qemu_arm_defconfig | 1 + > >>> lib/efi_loader/Kconfig | 1 - > >>> 3 files changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig > >>> index 39afb837e41..54bf4646382 100644 > >>> --- a/configs/qemu_arm64_defconfig > >>> +++ b/configs/qemu_arm64_defconfig > >>> @@ -15,6 +15,7 @@ CONFIG_ENV_ADDR=0x4000000 > >>> CONFIG_PCI=y > >>> CONFIG_DEBUG_UART=y > >>> CONFIG_AHCI=y > >>> +CONFIG_EFI_DEBUG_SUPPORT=y > >>> CONFIG_EFI_HTTP_BOOT=y > >>> CONFIG_FIT=y > >>> CONFIG_FIT_SIGNATURE=y > >>> diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig > >>> index 92ba48f6af9..b1c277a86c0 100644 > >>> --- a/configs/qemu_arm_defconfig > >>> +++ b/configs/qemu_arm_defconfig > >>> @@ -18,6 +18,7 @@ CONFIG_ENV_ADDR=0x4000000 > >>> CONFIG_PCI=y > >>> CONFIG_DEBUG_UART=y > >>> CONFIG_AHCI=y > >>> +CONFIG_EFI_DEBUG_SUPPORT=y > >>> CONFIG_FIT=y > >>> CONFIG_FIT_SIGNATURE=y > >>> CONFIG_FIT_VERBOSE=y > >>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > >>> index 077466f01f0..fdabe9cc278 100644 > >>> --- a/lib/efi_loader/Kconfig > >>> +++ b/lib/efi_loader/Kconfig > >>> @@ -73,7 +73,6 @@ config EFI_SIGNATURE_SUPPORT > >>> > >>> config EFI_DEBUG_SUPPORT > >>> bool "EFI Debug Support" > >>> - default y if !HAS_BOARD_SIZE_LIMIT > >>> help > >>> Select this option if you want to setup the EFI Debug Support > >>> Table and the EFI_SYSTEM_TABLE_POINTER which is used by the debug > >> >
