Re: [PATCH tiU2025.01 2/2] binman: openssl: disable JTAG access by default

2025-06-02 Thread Andrew Davis
On 6/2/25 12:28 PM, Andrew Davis wrote: On 6/2/25 11:56 AM, Bryan Brattlof wrote: Typically for boards operating in production environments will not be monitored and so will not need JTAG access unlocked. Disable the debug extension unless asked for in the binman configs. Signed-off-by: Bryan

Re: [PATCH tiU2025.01 2/2] binman: openssl: disable JTAG access by default

2025-06-02 Thread Andrew Davis
On 6/2/25 11:56 AM, Bryan Brattlof wrote: Typically for boards operating in production environments will not be monitored and so will not need JTAG access unlocked. Disable the debug extension unless asked for in the binman configs. Signed-off-by: Bryan Brattlof --- tools/binman/btool/openssl

Re: [PATCH tiU2025.01 1/2] binman: openssl: remove unused encryption extension

2025-06-02 Thread Andrew Davis
On 6/2/25 11:56 AM, Bryan Brattlof wrote: We currently do not have a way for binman to encrypt any component it packages. Remove this to avoid any confusion. From the subject tag, was this meant to be sent to our internal list for inclusion in our evil vendor tree only? I think these patches w

Re: [PATCH v6 1/9] spl: Kconfig: allow K3 devices to use falcon mode

2025-05-28 Thread Andrew Davis
On 5/28/25 8:08 PM, Anshul Dalal wrote: On Wed May 28, 2025 at 9:09 PM IST, Andrew Davis wrote: On 5/8/25 6:37 AM, Anshul Dalal wrote: On Thu May 8, 2025 at 9:32 AM IST, Vignesh Raghavendra wrote: On 5/8/2025 8:42 AM, Anshul Dalal wrote: On Wed May 7, 2025 at 11:36 PM IST, Andrew Davis

Re: [PATCH v6 1/9] spl: Kconfig: allow K3 devices to use falcon mode

2025-05-28 Thread Andrew Davis
On 5/8/25 6:37 AM, Anshul Dalal wrote: On Thu May 8, 2025 at 9:32 AM IST, Vignesh Raghavendra wrote: On 5/8/2025 8:42 AM, Anshul Dalal wrote: On Wed May 7, 2025 at 11:36 PM IST, Andrew Davis wrote: On 5/6/25 10:33 PM, Anshul Dalal wrote: On Tue May 6, 2025 at 8:03 PM IST, Andrew Davis

[PATCH] board: ti: am62ax: env: Use default MMC related args

2025-05-22 Thread Andrew Davis
AM62A file was available hence the fixes tag. Reported-by: Chirag Shilwant Fixes: 3709b529156e ("env: ti: mmc.env: Move mmc related args to common place") Signed-off-by: Andrew Davis --- board/ti/am62ax/am62ax.env | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) di

Re: [PATCH v2 4/7] arm: dts: k3-{j721s2/j784s4}-binman: Pack HSM firmware inside tispl.bin

2025-05-08 Thread Andrew Davis
On 5/8/25 10:03 AM, Beleswar Prasad Padhi wrote: On 5/8/2025 5:29 PM, Anshul Dalal wrote: On Wed May 7, 2025 at 8:53 PM IST, Andrew Davis wrote: On 5/7/25 9:56 AM, Beleswar Prasad Padhi wrote: On 5/7/2025 3:09 PM, Anshul Dalal wrote: On Tue May 6, 2025 at 4:11 PM IST, Beleswar Padhi wrote

Re: [PATCH v6 1/9] spl: Kconfig: allow K3 devices to use falcon mode

2025-05-07 Thread Andrew Davis
On 5/6/25 10:33 PM, Anshul Dalal wrote: On Tue May 6, 2025 at 8:03 PM IST, Andrew Davis wrote: On 4/28/25 9:12 AM, Anshul Dalal wrote: Falcon mode was disabled for TI_SECURE_DEVICE at commit e95b9b4437bc ("ti_armv7_common: Disable Falcon Mode on HS devices") for older 32-bit HS devic

Re: [PATCH v2 0/7] Add support to boot TI K3 HSM M4 core

2025-05-07 Thread Andrew Davis
On 5/7/25 5:28 AM, Beleswar Prasad Padhi wrote: Hi Andrew, On 06/05/25 23:42, Andrew Davis wrote: On 5/6/25 12:19 PM, Tom Rini wrote: On Tue, May 06, 2025 at 10:47:57PM +0530, Kumar, Udit wrote: On 5/6/2025 8:38 PM, Andrew Davis wrote: On 5/6/25 9:51 AM, Beleswar Prasad Padhi wrote: Hi

Re: [PATCH v2 4/7] arm: dts: k3-{j721s2/j784s4}-binman: Pack HSM firmware inside tispl.bin

2025-05-07 Thread Andrew Davis
On 5/7/25 9:56 AM, Beleswar Prasad Padhi wrote: On 5/7/2025 3:09 PM, Anshul Dalal wrote: On Tue May 6, 2025 at 4:11 PM IST, Beleswar Padhi wrote: Pack the HSM firmware in tispl.bin fit image so that it can be unloaded and used by R5 SPL to boot the HSM core. By default, point to the firmware f

Re: [PATCH v2 0/7] Add support to boot TI K3 HSM M4 core

2025-05-06 Thread Andrew Davis
On 5/6/25 12:19 PM, Tom Rini wrote: On Tue, May 06, 2025 at 10:47:57PM +0530, Kumar, Udit wrote: On 5/6/2025 8:38 PM, Andrew Davis wrote: On 5/6/25 9:51 AM, Beleswar Prasad Padhi wrote: Hi Andrew, On 5/6/2025 4:38 PM, Andrew Davis wrote: On 5/6/25 5:41 AM, Beleswar Padhi wrote: Some TI K3

Re: [PATCH v2 0/7] Add support to boot TI K3 HSM M4 core

2025-05-06 Thread Andrew Davis
On 5/6/25 9:51 AM, Beleswar Prasad Padhi wrote: Hi Andrew, On 5/6/2025 4:38 PM, Andrew Davis wrote: On 5/6/25 5:41 AM, Beleswar Padhi wrote: Some TI K3 SoCs like J721S2, and J784S4 have a HSM (High Security Module) M4F core in the Wakeup Voltage Domain which could be used to run secure

Re: [PATCH v6 1/9] spl: Kconfig: allow K3 devices to use falcon mode

2025-05-06 Thread Andrew Davis
On 4/28/25 9:12 AM, Anshul Dalal wrote: Falcon mode was disabled for TI_SECURE_DEVICE at commit e95b9b4437bc ("ti_armv7_common: Disable Falcon Mode on HS devices") for older 32-bit HS devices and can be enabled on K3 devices. For secure boot, the kernel with x509 headers can be packaged in a fit

Re: [PATCH v2 0/7] Add support to boot TI K3 HSM M4 core

2025-05-06 Thread Andrew Davis
On 5/6/25 5:41 AM, Beleswar Padhi wrote: Some TI K3 SoCs like J721S2, and J784S4 have a HSM (High Security Module) M4F core in the Wakeup Voltage Domain which could be used to run secure services like Authentication. Boot flow for HSM M4 core is different than the general purpose M4F cores, and i

Re: [PATCH v2 7/7] arm: mach-k3: r5: common: Add support to boot HSM M4 core

2025-05-06 Thread Andrew Davis
On 5/6/25 5:42 AM, Beleswar Padhi wrote: The tispl.bin fit image is packed with the HSM firmware image. Populate the "os" info of the image so that it can be detected and used to load the HSM core. Further, invoke the load and boot of HSM core at R5 SPL stage. Boot flow for HSM M4 core is as belo

Re: [PATCH] arm: dts: k3-am62a-*-binman: Update ti-dm blob

2025-05-05 Thread Andrew Davis
On 5/2/25 10:55 AM, Bryan Brattlof wrote: On May 2, 2025 thus sayeth Daniel Schultz: With [1], TI changed the Device Manager for the AM62Ax to an EdgeAI based firmware. Update all binman device-tree files to match the It wasn't changed, this is a new firmware that does new things, the other f

[PATCH] board: ti: sec-cfg.yaml: Fix OTP write_host_id order

2025-05-05 Thread Andrew Davis
-by: Prashant Shivhare Signed-off-by: Andrew Davis --- board/beagle/beagleplay/sec-cfg.yaml | 2 +- board/beagle/beagley-ai/sec-cfg.yaml | 2 +- board/phytec/phycore_am62ax/sec-cfg.yaml | 2 +- board/phytec/phycore_am62x/sec-cfg.yaml | 2 +- board/phytec/phycore_am64x/sec-cfg.yaml | 2

Re: [PATCH] arm: dts: k3: binman: Fix DM firmware selection

2025-04-28 Thread Andrew Davis
On 4/28/25 8:36 AM, Bryan Brattlof wrote: On April 25, 2025 thus sayeth Andrew Davis: Just like TF-A and OP-TEE, the documentation states a custom path for DM can be provided at build time by setting TI_DM. This should then set ti-dm-path which updates ti-dm node filenames in binman. Two

[PATCH] arm: dts: k3: binman: Fix DM firmware selection

2025-04-25 Thread Andrew Davis
the updated ti-dm file does exist. Fix both of these for all K3 by removing any indirect ti-dm nodes and making sure all DM nodes are labeled with "ti-dm". Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 11 ++- arch/arm/dts/k3-am625-phycore-som-binman

Re: [PATCH 0/9] board: beagle: beagley-ai: Cleanups and stdboot

2025-04-25 Thread Andrew Davis
based off: master 9d3f1ebaf875 ("tools/make_pip: Use venv when invoking pip") BootLog: https://gist.github.com/nmenon/d5d761371515ce0e9cc77021533c34d7 (nothing interesting changed, so same bootlog) For the series, Reviewed-by: Andrew Davis Changes since v2: - Dropped override

Re: [PATCH 2/4] arm: dts: k3-binman: Add template for packing HSM firmware

2025-04-24 Thread Andrew Davis
On 4/24/25 12:21 AM, Beleswar Prasad Padhi wrote: Hi Andrew, On 22/04/25 20:04, Andrew Davis wrote: On 4/22/25 4:54 AM, Beleswar Padhi wrote: The HSM M4 core needs to be booted at R5 SPL stage so that it can be used for further Authentication and security services. Therefore, the firmware for

Re: [PATCH 4/4] arm: mach-k3: r5: common: Add support to boot HSM M4 core

2025-04-22 Thread Andrew Davis
On 4/22/25 4:54 AM, Beleswar Padhi wrote: The tispl.bin fit image is packed with the HSM firmware image. Populate the "os" info of the image so that it can be detected and loaded at corresponding DDR address. Further, invoke the load and boot of HSM core at R5 SPL stage. Boot flow for HSM M4 core

Re: [PATCH 3/4] arm: dts: k3-{j721s2/j784s4}-binman: Pack HSM firmware inside tispl.bin

2025-04-22 Thread Andrew Davis
On 4/22/25 4:54 AM, Beleswar Padhi wrote: Pack the HSM firmware in tispl.bin fit image so that it can be unloaded and used by R5 SPL to boot the HSM core. By default, point to the firmware for HS-SE device type. This needs to be changed to point to appropriate firmware when using a different devi

Re: [PATCH 2/4] arm: dts: k3-binman: Add template for packing HSM firmware

2025-04-22 Thread Andrew Davis
On 4/22/25 4:54 AM, Beleswar Padhi wrote: The HSM M4 core needs to be booted at R5 SPL stage so that it can be used for further Authentication and security services. Therefore, the firmware for the HSM core needs to be packed in tispl.bin fit image so that it can be used by R5 SPL to boot the HSM

Re: [PATCH 1/4] arm: mach-k3: Add config option for booting HSM core

2025-04-22 Thread Andrew Davis
On 4/22/25 4:54 AM, Beleswar Padhi wrote: Some K3 SoCs like J721S2, and J784S4 have a HSM (High Security Module) M4F core in the Wakeup Voltage Domain which could be used to run secure services like Authentication. Add a config option which indicates that the SoC has a HSM core and the firmware f

Re: [PATCH v1 0/4] k3: migrate SPL_TEXT_BASE to new address

2025-04-16 Thread Andrew Davis
On 4/16/25 10:05 AM, Nishanth Menon wrote: On 19:18-20250416, Anshul Dalal wrote: On Wed Apr 16, 2025 at 4:54 PM IST, Nishanth Menon wrote: On 13:00-20250416, Anshul Dalal wrote: The change to ATF's PRELOADED_BL33_BASE[1] requires respective changes to SPL_TEXT_BASE on u-boot side. This is nec

Re: [PATCH 6/9] configs: am67a_beagley_ai*: Use saveddefconfig

2025-04-14 Thread Andrew Davis
J722S. That way both these board's defconfig files could be much shorter and we don't end up fixing things for one, but forgetting to fix in the other. Until then for this patch, Acked-by: Andrew Davis Instead of doing that, just split up BeagleY's configuration independently ou

Re: [PATCH 9/9] doc: beagle: Add BeagleY-AI documentation

2025-04-14 Thread Andrew Davis
On 4/11/25 5:57 PM, Nishanth Menon wrote: Document the BeagleY-AI usage, build and basic debug hints Signed-off-by: Nishanth Menon --- doc/board/beagle/am67a_beagley_ai.rst | 228 ++ doc/board/beagle/index.rst| 1 + doc/board/ti/k3.rst

Re: [PATCH 8/9] configs: am67a_beagley_ai_a53: Enable additional features

2025-04-14 Thread Andrew Davis
o_bootcmd" +CONFIG_BOOTCOMMAND="run set_led_state_start_load; run envboot; bootflow scan -lb;run set_led_state_fail_load" nit: should be space after all the last ";" char Acked-by: Andrew Davis CONFIG_BOARD_LATE_INIT=y CONFIG_SPL_MAX_SIZE=0x58000 CONFIG_SPL_PAD_TO=0x0 @@ -

[PATCH 2/3] arm: mach-k3: Enable BINMAN Kconfig symbol for all ARCH_K3

2025-04-05 Thread Andrew Davis
All K3 build need BINMAN support so select it under ARCH_K3, not individually for each board target. Signed-off-by: Andrew Davis --- arch/arm/Kconfig| 1 + arch/arm/mach-k3/am62ax/Kconfig | 4 arch/arm/mach-k3/am62px/Kconfig | 2 -- arch/arm/mach-k3/am62x

[PATCH] doc: Fix typo bootfloe to bootflow

2025-03-28 Thread Andrew Davis
Signed-off-by: Andrew Davis --- doc/usage/cmd/bootflow.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/usage/cmd/bootflow.rst b/doc/usage/cmd/bootflow.rst index 5d41fe37a7a..01e7eff300b 100644 --- a/doc/usage/cmd/bootflow.rst +++ b/doc/usage/cmd/bootflow.rst @@ -18,7

[PATCH 3/3] arm: mach-k3: Make K3_LOAD_SYSFW and SYS_K3_SPL_ATF default enabled

2025-03-19 Thread Andrew Davis
These two symbols are always selected by default for R5 builds. These symbols already depend on R5 builds, so make it default at their definition to remove select/imply at each board target site. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62ax/Kconfig | 4 arch/arm/mach-k3

[PATCH 1/3] arm: mach-k3: Remove undefined Kconfig symbols BOARD and SPL_BOARD

2025-03-19 Thread Andrew Davis
These are not defined nor used, they seem to be leftover or a typo, remove them. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62ax/Kconfig | 2 -- arch/arm/mach-k3/am64x/Kconfig | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/arm/mach-k3/am62ax/Kconfig b/arch/arm/mach-k3

[PATCH] arm: mach-k3: j721e: Split out J7200 SoC support from J721e

2025-03-19 Thread Andrew Davis
make use of it in all spots that once used the combined SOC_K3_J721E so we can turn off SOC_K3_J721E when building for J7200 boards. Signed-off-by: Andrew Davis --- arch/arm/dts/Makefile | 3 +- arch/arm/dts/k3-j7200-binman.dtsi | 40 --- arc

[PATCH] arm: dts: k3: Remove leftover file after OF_UPSTREAM

2025-03-19 Thread Andrew Davis
The file k3-am62a7.dtsi is part of upstream DT and should have been removed when migrating to OF_UPSTREAM but must have been missed. Do this here. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am62a7.dtsi | 104 1 file changed, 104 deletions(-) delete

Re: [PATCH] mach-k3: common_fdt: create a reserved memory node

2025-02-27 Thread Andrew Davis
*/ ... } Might make the intention a bit much, so either way is fine with me, Acked-by: Andrew Davis + goto add_carveout; /* Find existing matching subnode and remove it */ fdt_for_each_subnode(subnode, blob, nodeoffset) { @@ -154,6 +152,7 @@ int fdt_fixup_reserved

Re: [PATCH v2 06/13] configs: am68: Add configs for enabling Ethboot in R5SPL

2025-02-19 Thread Andrew Davis
On 2/19/25 4:48 AM, Chintan Vankar wrote: Add configs for enabling Ethernet boot in R5SPL, also disable not required configs to avoid memory limitation. Signed-off-by: Chintan Vankar --- Link to v1: https://lore.kernel.org/r/20250107093840.2211381-6-c-van...@ti.com/ Changes from v1 to v2: - U

Re: [PATCH RFC v2 2/8] arm: dts: k3-j784s4-binman.dtsi: Clean up and templatize boot binaries

2025-02-07 Thread Andrew Davis
On 2/6/25 4:52 AM, Manorit Chawdhry wrote: Hi Andrew, On 09:35-20250205, Andrew Davis wrote: On 2/4/25 11:50 PM, Manorit Chawdhry wrote: Hi Andrew, On 09:43-20250204, Andrew Davis wrote: On 2/3/25 10:43 PM, Manorit Chawdhry wrote: Hi Andrew, On 14:44-20250203, Andrew Davis wrote: On 1/6

Re: [PATCH 1/4] board: phytec: common: k3: Introduce Configs to Sign Images

2025-02-07 Thread Andrew Davis
On 2/7/25 12:51 AM, Daniel Schultz wrote: Private keys to sign bootloader images shouldn't be commit or part of this repository. Add config entries to use keys located outside of U-Boot to sign images. The custMpk.pem was always a placeholder, we fill it with the TI Dummy key as an example. Th

Re: [PATCH v4 6/6] configs: am6*_evm_a53_defconfig: Enable remoteproc support

2025-02-06 Thread Andrew Davis
defconfig? Otherwise whole series looks fine to me, Reviewed-by: Andrew Davis CONFIG_REMOTEPROC_TI_PRU=y -CONFIG_CMD_REMOTEPROC=y CONFIG_RESET_TI_SCI=y CONFIG_DM_RTC=y CONFIG_RTC_EMULATION=y

Re: [PATCH RFC v2 2/8] arm: dts: k3-j784s4-binman.dtsi: Clean up and templatize boot binaries

2025-02-05 Thread Andrew Davis
On 2/4/25 11:50 PM, Manorit Chawdhry wrote: Hi Andrew, On 09:43-20250204, Andrew Davis wrote: On 2/3/25 10:43 PM, Manorit Chawdhry wrote: Hi Andrew, On 14:44-20250203, Andrew Davis wrote: On 1/6/25 3:34 AM, Manorit Chawdhry wrote: From: Neha Malcom Francis Clean up templatized boot

Re: [PATCH RFC v2 2/8] arm: dts: k3-j784s4-binman.dtsi: Clean up and templatize boot binaries

2025-02-04 Thread Andrew Davis
On 2/3/25 10:43 PM, Manorit Chawdhry wrote: Hi Andrew, On 14:44-20250203, Andrew Davis wrote: On 1/6/25 3:34 AM, Manorit Chawdhry wrote: From: Neha Malcom Francis Clean up templatized boot binaries for j784s4 soc. This includes modifying the k3-j784s4-binman.dtsi to use SPL_BOARD_DTB

Re: [PATCH RFC v2 2/8] arm: dts: k3-j784s4-binman.dtsi: Clean up and templatize boot binaries

2025-02-03 Thread Andrew Davis
On 1/6/25 3:34 AM, Manorit Chawdhry wrote: From: Neha Malcom Francis Clean up templatized boot binaries for j784s4 soc. This includes modifying the k3-j784s4-binman.dtsi to use SPL_BOARD_DTB, BOARD_DESCRIPTION and UBOOT_BOARD_DESCRIPTION from the files that include it to further reuse code. k3

Re: [PATCH v2 1/4] remoteproc: k3-m4: Introduce K3 remote proc driver for M4 subsystem

2025-01-29 Thread Andrew Davis
On 1/29/25 4:52 PM, Judith Mendez wrote: From: Hari Nagalla Some K3 devices like AM64, AM62 devices have a M4 processor in MCU voltage domain. Add a remote proc driver to support this subsystem to be able to load and boot the M4 core. Signed-off-by: Hari Nagalla [Judith: Fixed comments and c

Re: [PATCH] arch: arm: mach-k3: j784s4_init: Set CTRL_MMR for AUDIO_REFCLK1 clk_sel

2025-01-06 Thread Andrew Davis
On 1/6/25 4:04 AM, Jayesh Choudhary wrote: The default value for the mux to select the parent clock, AUDIO_REFCLK1_CTRL_CLK_SEL is '1' (31) but the mux input for 31 is marked as 'Reserved' so the ti-sci-clk call for get-parent fails. Mark it to a valid value, '11100' (28) for MAIN_PLL4_HSDIV2

Re: [PATCH v2] arm: mach-k3: am62a7: Provide a way to obtain boot device for non SPLs

2024-10-31 Thread Andrew Davis
what has been done already for AM64x, might be good at some point to just do this for all the K3 SoCs. I wonder how much of the contents of these functions are common across them all.. For now, LGTM, Reviewed-by: Andrew Davis v2: - Drop duplicate CONFIG_SOC_K3_AM62A7 entry from arch/arm

Re: [PATCH] boardf: Modify DRAM message

2024-10-10 Thread Andrew Davis
On 10/10/24 1:50 PM, Simon Glass wrote: Hi Neha, On Thu, 10 Oct 2024 at 01:09, Neha Malcom Francis wrote: The message "DRAM: 2 GiB (effective 32 GiB)" can be a little confusing, modify the message to show exactly what is meant: "DRAM: 2 GiB (available for U-Boot out of total 32 GiB)" Sign

Re: [PATCH v4 06/10] arm: mach-k3: am62x: am625_init: Probe AM65 CPSW NUSS

2024-08-14 Thread Andrew Davis
On 8/14/24 12:17 AM, Chintan Vankar wrote: On 13/08/24 23:57, Andrew Davis wrote: On 8/12/24 6:48 AM, Chintan Vankar wrote: From: Kishon Vijay Abraham I In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in board_init_f(). Signed-off-by: Kishon Vijay Abraham I Signed

Re: [PATCH v4 06/10] arm: mach-k3: am62x: am625_init: Probe AM65 CPSW NUSS

2024-08-13 Thread Andrew Davis
On 8/12/24 6:48 AM, Chintan Vankar wrote: From: Kishon Vijay Abraham I In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in board_init_f(). Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Siddharth Vadapalli Signed-off-by: Chintan Vankar --- Link to v4: https://l

Re: [PATCH v2 1/5] arch: arm: dts: k3-j784s4-r5-evm: Add missing fss range

2024-08-09 Thread Andrew Davis
commit, and the name does not linewrap, even if it is more than 80 chars. repo [1] into dts/upstream) No newline. Signed-off-by: Jonathan Humphreys Reviewed-by: Andrew Davis --- arch/arm/dts/k3-j784s4-r5-evm.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/dts/k3-j784s

Re: [PATCH v2] remoteproc: uclass: Modify uc_pdata->name to use combination of device name and device's parent name

2024-08-09 Thread Andrew Davis
to uc_pdata->name not being unique and rproc_init() will fail. Fix this by using combination of dev->name and dev->parent->name instead of using just the dev->name to populate uc_pdata->name. Signed-off-by: MD Danish Anwar --- Reviewed-by: Andrew Davis Cc: Andrew Davis F

Re: [PATCH 1/5] arch: arm: dts: k3-j784s4-r5-evm: Add missing fss range

2024-08-08 Thread Andrew Davis
Looks like way too many tabs, do you have your editor set to 8 space tabs for DTS files? Otherwise, LGTM, Reviewed-by: Andrew Davis +}; + &mcu_ringacc { ti,sci = <&dm_tifs>; };

[PATCH] defconfig: Add a config for AM335x High Security EVM with SPI Boot support

2024-08-07 Thread Andrew Davis
Add a new defconfig file for the AM335x High Security EVM. This config is specific for the case of SPI booting. Signed-off-by: Andrew Davis --- configs/am335x_hs_evm_spi_defconfig | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 configs

[PATCH] arm: dts: keystone: Move to OF_UPSTREAM

2024-08-07 Thread Andrew Davis
Enable OF_UPSTREAM for Keystone boards. Remove DT files that are now available in dts/upstream. Signed-off-by: Andrew Davis --- arch/arm/dts/Makefile | 7 - arch/arm/dts/keystone-clocks.dtsi | 411 - arch/arm/dts/keystone-k2e-clocks.dtsi

Re: [PATCH] board: beagle: beagleplay: enable OF_SYSTEM_SETUP

2024-06-19 Thread Andrew Davis
nel's FDT to inform it of the actual location of the firmware CC: Andrew Davis CC: Nishanth Menon CC: Robert Nelson Reported-by: Dhruva Gole Signed-off-by: Bryan Brattlof --- Acked-by: Andrew Davis Hello everyone, Fair warning, this may turn into a philosophical discussion about t

Re: [PATCH 1/6] arm: mach-k3: Add default ATF location for AM62/AM62a

2024-06-19 Thread Andrew Davis
On 6/19/24 1:20 PM, Nishanth Menon wrote: On 17:19-20240619, Dhruva Gole wrote: Hi, On Feb 14, 2024 at 10:30:04 -0600, Andrew Davis wrote: There is a default ATF load address that is used for devices that have ATF running in SRAM. For AM62 and AM62a, ATF runs from DRAM. Instead of having to

Re: [PATCH v2 3/8] arm: mach-k3: j721e: Enable QoS for DSS

2024-06-14 Thread Andrew Davis
v/null +++ b/arch/arm/mach-k3/r5/j721e/j721e_qos.h @@ -0,0 +1,96 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Keystone3 Quality of service endpoint definitions Our marketing folks claim it is "K3" not "Keystone3" :), otherwise lgtm, Reviewed-by: Andrew Davis + * Auto

Re: [PATCH v2 2/8] arm: mach-k3: am62a: Simplify the logic for QOS reg and val propagation

2024-06-14 Thread Andrew Davis
and make the corresponding changes for am62a_qos_uboot file. Suggested-by: Andrew Davis Signed-off-by: Jayesh Choudhary --- Looks a bit better IMHO, Acked-by: Andrew Davis arch/arm/mach-k3/include/mach/k3-qos.h | 86 arch/arm/mach-k3/r5/am62ax/am62a_qos_uboot.c

Re: [PATCH 1/3] arm: dts: k3-am642-evm-u-boot: Add remoteproc-name for PRU cores

2024-06-07 Thread Andrew Davis
On 5/23/24 1:33 AM, Anwar, Md Danish wrote: Hi Andrew, On 5/22/2024 9:38 PM, Andrew Davis wrote: On 5/22/24 1:36 AM, MD Danish Anwar wrote: Add remoteproc-name property for PRU cores. Signed-off-by: MD Danish Anwar ---   arch/arm/dts/k3-am642-evm-u-boot.dtsi | 44

Re: [PATCH 09/14] arch: mach-k3: Introduce basic files to support J722S SoC family

2024-05-29 Thread Andrew Davis
On 5/29/24 8:24 AM, Jayesh Choudhary wrote: Introduce the basic functions and definitions needed to properly initialize TI J722S family of SoCs. Co-developed-by: Vaishnav Achath Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/Kconfig

Re: [PATCH 03/14] soc: add info to identify the J722S SoC family

2024-05-29 Thread Andrew Davis
On 5/29/24 8:24 AM, Jayesh Choudhary wrote: Include the part number for TI's j722s family of SoC to identify it during boot. Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/hardware.h | 2 ++ drivers/soc/soc_ti_k3.c | 3 +++

Re: [PATCH 01/14] arm: mach-k3: Sort CONFIG_SOC* and K3_SOC_ID entries

2024-05-29 Thread Andrew Davis
have it, etc.. No issue with alphabetical either, just looking for a "why" in the commit message, otherwise, Reviewed-by: Andrew Davis Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/hardware.h | 37 1 file changed, 19 insertions(+), 18

Re: [PATCH] arm: mach-k3: am62p: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-05-23 Thread Andrew Davis
{} nodes when the loaded address does not match the address in DT. Reported-by: Andrew Davis Signed-off-by: Bryan Brattlof --- Hello everyone, This is a little fixup to avoid any confusion once we're in the kernel. Because TF-A can be configured in U-Boot to be anywhere we want, we need up u

Re: [PATCH 1/3] arm: dts: k3-am642-evm-u-boot: Add remoteproc-name for PRU cores

2024-05-22 Thread Andrew Davis
On 5/22/24 1:36 AM, MD Danish Anwar wrote: Add remoteproc-name property for PRU cores. Signed-off-by: MD Danish Anwar --- arch/arm/dts/k3-am642-evm-u-boot.dtsi | 44 +++ 1 file changed, 44 insertions(+) diff --git a/arch/arm/dts/k3-am642-evm-u-boot.dtsi b/arch/arm/d

Re: [PATCH 2/7] arm: mach-k3: j721e: Enable QoS for DSS

2024-05-22 Thread Andrew Davis
On 5/22/24 6:37 AM, Jayesh Choudhary wrote: Enable Quality of Service (QoS) blocks for Display SubSystem (DSS), by servicing the DSS - DDR traffic from the Real-Time (RT) queue. This is done by setting the DSS DMA orderID to greater than 7. ATYPE 3 is selected so that the traffic takes non-cohere

Re: [PATCH 1/7] arm: mach-k3: am62a_qos: Move common bit MACROS to k3_qos header file

2024-05-22 Thread Andrew Davis
On 5/22/24 6:37 AM, Jayesh Choudhary wrote: QoS bit mapping are common across all K3 SoCs so move those defines to common header file (k3_qos.h). This ensures that we do not define these for each SoC. Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/k3-qos.h | 74

Re: [PATCH v3 2/2] configs: add defconfigs for the am625-lp-sk

2024-05-15 Thread Andrew Davis
On 5/15/24 1:21 PM, Tom Rini wrote: On Fri, May 03, 2024 at 11:44:29AM -0500, Bryan Brattlof wrote: The am62x-lp-sk is a package and reference board spin of the am62x-sk to showcase the low-power features of the am62x SoC family. Because it so closely resembles the am62x-sk board, use the prepr

Re: [PATCH v2 5/8] drivers: ram: Kconfig: Add CONFIG_K3_INLINE_ECC

2024-05-15 Thread Andrew Davis
On 5/10/24 3:47 AM, Santhosh Kumar K wrote: From: Neha Malcom Francis Add CONFIG_K3_INLINE_ECC so that ECC functions can be compiled into R5 SPL only when the config has been enabled. Signed-off-by: Neha Malcom Francis --- drivers/ram/Kconfig | 11 +++ 1 file changed, 11 insertions

[PATCH v2] arm: mach-k3: Move code specific to a SoC into that SoC's directory

2024-05-10 Thread Andrew Davis
Each SoC now has a directory in mach-k3, let's move the SoC specific files into their respective directories. Signed-off-by: Andrew Davis --- Changes for v2: - Rebased on latest -next arch/arm/mach-k3/Makefile | 24 ++--- arch/arm/mach-k3/am62ax/Mak

Re: [PATCH v2 2/2] arm: dts: k3-j7200-binman: Add support for HSSE1.0 and HSFS1.0

2024-05-09 Thread Andrew Davis
release (IIRC), but for completeness this is fine to have supported, Reviewed-by: Andrew Davis Reported-by: Suman Anna Reported-by: Aniket Limaye Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-j7200-binman.dtsi | 95 ++- 1 file changed, 94 insertions(+), 1

Re: [PATCH v2 1/2] arm: dts: k3-j721e-binman: Add support for HSFS1.1

2024-05-09 Thread Andrew Davis
HS-SE SR2.0 generation Looks good to me now, Reviewed-by: Andrew Davis arch/arm/dts/k3-j721e-binman.dtsi | 90 ++- 1 file changed, 89 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/k3-j721e-binman.dtsi b/arch/arm/dts/k3-j721e-binman.dtsi index

[PATCH] arm: mach-k3: am62ax: Fix typo in ROM data macro name

2024-04-26 Thread Andrew Davis
s/ENTENDED/EXTENDED Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62a7_init.c | 2 +- arch/arm/mach-k3/include/mach/am62a_hardware.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-k3/am62a7_init.c b/arch/arm/mach-k3/am62a7_init.c index

[PATCH] arm: mach-k3: Move code specific to a SoC into that SoC's directory

2024-04-25 Thread Andrew Davis
Each SoC now has a directory in mach-k3, let's move the SoC specific files into their respective directories. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Makefile | 27 ++--- arch/arm/mach-k3/am62ax/Makefile| 7 ++ arch/arm/ma

Re: [PATCH 1/2] arm: dts: k3-j721e-binman: Add support for HSSE2.0 and HSFS1.1

2024-04-22 Thread Andrew Davis
On 4/22/24 4:40 PM, Neha Malcom Francis wrote: J721E has SR1.1 and SR2.0 having three variants of each GP, HS-FS and HS-SE. Current build does not generate HS-SE SR2.0 and HS-FS SR1.1 so add support for them. Reported-by: Suman Anna Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-j721

[PATCH] arm: mach-k3: am642: Fix reset for workaround errata ID i2331

2024-04-18 Thread Andrew Davis
driver allowing do_reset() to again function as expected. Reported-by: Jonathan Humphreys Fixes: fc5d40283483 ("firmware: ti_sci: Bind sysreset driver when enabled") Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] arm: mach-k3: security: Lower verbosity of cert message for GP

2024-04-10 Thread Andrew Davis
When we find a certificate on an image to be booted on a GP device we print out a message explaining that the certificate is being skipped. This message is rather long and is printed for every image. Shorten the message and make the long version into a debug message. Signed-off-by: Andrew Davis

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-10 Thread Andrew Davis
On 4/10/24 1:24 PM, Jon Humphreys wrote: Andrew Davis writes: On 4/8/24 5:17 PM, Jonathan Humphreys wrote: Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-j721e-binman.dtsi | 32 +++ 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-10 Thread Andrew Davis
On 4/10/24 4:38 AM, Ilias Apalodimas wrote: On Tue, 9 Apr 2024 at 23:14, Andrew Davis wrote: On 4/9/24 2:26 PM, Heinrich Schuchardt wrote: On 4/9/24 14:14, Andrew Davis wrote: On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-09 Thread Andrew Davis
On 4/8/24 5:17 PM, Jonathan Humphreys wrote: Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-j721e-binman.dtsi | 32 +++ 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e-binman.dtsi b/arch/arm/dts/k3-j721e-binman.dtsi index 75a6e9599b9..9

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-09 Thread Andrew Davis
On 4/9/24 2:26 PM, Heinrich Schuchardt wrote: On 4/9/24 14:14, Andrew Davis wrote: On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list using TI dummy keys. Adding vendor public keys into the code base to lock down generated binaries

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-09 Thread Andrew Davis
On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list using TI dummy keys. Adding vendor public keys into the code base to lock down generated binaries to the vendors unpublished private key does not match well with the intent of the GNU p

Re: [RFC PATCH 13/15] arm: dts: Introduce J722S U-Boot dts files

2024-04-05 Thread Andrew Davis
On 4/5/24 2:18 AM, Jayesh Choudhary wrote: Hi, On 04/04/24 20:59, Andrew Davis wrote: On 4/4/24 4:00 AM, Jayesh Choudhary wrote: Include the uboot device tree files needed to boot the board. Co-developed-by: Vaishnav Achath Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary

Re: [PATCH 1/1] net: nfs: fix file handle length in NFSv3

2024-04-04 Thread Andrew Davis
Fix this by using a variable length file handle for dirfh. [1] https://www.rfc-editor.org/rfc/rfc1813.html#page-106 Fixes: b0baca982048 ("net: NFS: Add NFSv3 support") Signed-off-by: Sébastien Szymanski --- Fixes NFS boot for me, thanks! Tested-by: Andrew Davis net/nfs.c | 18 ++

Re: [RFC PATCH 15/15] doc: board: ti: Add J722S-EVM documentation

2024-04-04 Thread Andrew Davis
On 4/4/24 4:00 AM, Jayesh Choudhary wrote: Introduce basic documentation for the J722S-EVM. Signed-off-by: Jayesh Choudhary --- doc/board/ti/j722s_evm.rst | 262 + doc/board/ti/k3.rst| 1 + 2 files changed, 263 insertions(+) create mode 100644

Re: [RFC PATCH 13/15] arm: dts: Introduce J722S U-Boot dts files

2024-04-04 Thread Andrew Davis
On 4/4/24 4:00 AM, Jayesh Choudhary wrote: Include the uboot device tree files needed to boot the board. Co-developed-by: Vaishnav Achath Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary --- arch/arm/dts/Makefile |2 + arch/arm/dts/k3-j722s-binman.dts

Re: [PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-03 Thread Andrew Davis
On 4/3/24 1:37 AM, Neha Malcom Francis wrote: Hi Andrew, On 02/04/24 21:39, Andrew Davis wrote: This extra binding is non-standard and now unneeded as we bind the sysreset driver automatically. This matches what is done in Linux and allows us to more closely match the DTBs. Remove the binding

[PATCH 1/2] firmware: ti_sci: Bind sysreset driver when enabled

2024-04-02 Thread Andrew Davis
The sysreset TI-SCI API is available with TI-SCI always, there is no need for a DT node to describe the availability of this. If the sysreset driver is available then bind it during ti-sci probe. Remove the unneeded device tree matching. Signed-off-by: Andrew Davis --- drivers/firmware

[PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-02 Thread Andrew Davis
This extra binding is non-standard and now unneeded as we bind the sysreset driver automatically. This matches what is done in Linux and allows us to more closely match the DTBs. Remove the binding and all users. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 7

[PATCH 0/2] Remove ti,sci-sysreset

2024-04-02 Thread Andrew Davis
w [0] https://lore.kernel.org/lkml/20240326223730.54639-1-...@ti.com/ Andrew Davis (2): firmware: ti_sci: Bind sysreset driver when enabled arm: dts: k3: Remove unneeded ti,sci-sysreset binding and nodes arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 7 - .../k3-am625-phyboard-lyra-

Re: [PATCH] am625x_evm_a53: Tweak boot command to set fdt

2024-03-26 Thread Andrew Davis
On 3/26/24 9:26 AM, Martyn Welch wrote: With the current config for tha SK-AM62, fdtfile isn't set in the U-Boot environment. When using bootflow to boot from a block device, where the extlinux.conf file specifies `fdtdir`, a fallback device tree is being constructed from the `soc` (`k3`) and `bo

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-23 Thread Andrew Davis
On 3/22/24 8:10 AM, Neha Malcom Francis wrote: Clean up templatized boot binaries for all K3 boards. This includes modifying the k3-binman.dtsi to use SPL_BOARD_DTB, BOARD_DESCRIPTION and UBOOT_BOARD_DESCRIPTION from the files that include it to further reuse code. All k3--binman.dtsi will conta

Re: [PATCH] Makefile: Improve generated_defconfig file handling

2024-03-08 Thread Andrew Davis
an that up on `make clean'. Also we probably want to hide it in `git status' list. This patch makes the described changes, and also adds `-P' parameter to the CPP command that produces the `generated_defconfig' to avoid generating linemarkers. All look like sensible improvem

Re: [PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-03-06 Thread Andrew Davis
On 3/6/24 7:35 AM, Bryan Brattlof wrote: On February 14, 2024 thus sayeth Andrew Davis: The address we load TF-A and OP-TEE to is configurable by Kconfig CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are often statically defined. As these binaries are dynamically

Re: [PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-03-06 Thread Andrew Davis
On 2/28/24 12:24 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:30-20240214, Andrew Davis wrote: The address we load TF-A and OP-TEE to is configurable by Kconfig CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are often statically defined. As these binaries are

Re: [PATCH 2/6] arm: mach-k3: Add config option for setting OP-TEE address

2024-03-06 Thread Andrew Davis
On 2/28/24 12:21 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:30-20240214, Andrew Davis wrote: Much like we have for ATF, OP-TEE has a standard address that we load it too and run it from. Add a Kconfig item for this to remove some hard-coding and allow this address to be more easily changed

[PATCH v2] arm: dts: k3-am64: Move to OF_UPSTREAM

2024-03-05 Thread Andrew Davis
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.7-rc7). Signed-off-by: Andrew Davis --- Changes for v2: - Rebased on latest -next to fix merge conflict

[PATCH] arm: dts: k3-am64: Move to OF_UPSTREAM

2024-03-04 Thread Andrew Davis
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.7-rc7). Signed-off-by: Andrew Davis --- As suggested here[0]. Based on Mar 4 -next. [0] https

Re: [PATCH v10 14/15] configs: am69_sk: Add defconfig for AM69 SK board

2024-02-29 Thread Andrew Davis
snavis Sabiya Signed-off-by: Apurva Nandan --- Reviewed-by: Andrew Davis board/ti/j784s4/MAINTAINERS | 2 ++ configs/am69_sk_a72_defconfig | 9 + configs/am69_sk_r5_defconfig | 10 ++ 3 files changed, 21 insertions(+) create mode 100644 configs/am69_sk_a72_def

Re: [RFC PATCH 1/4] configs: j721e_sk: Move to separate defconfig for J721E SK board

2024-02-28 Thread Andrew Davis
On 2/28/24 5:20 AM, Neha Malcom Francis wrote: Add defconfig for J721E SK R5 and A72 configuration. This includes and modifies the J721E EVM defconfigs: j721e_evm_r5_defconfig -> j721e_sk_r5_defconfig j721e_evm_a72_defconfig -> j721e_sk_a72_defconfig Signed-off-by: Neha Malcom Francis --- bo

Re: [PATCH 6/6] arm: mach-k3: Move DRAM address of ATF for AM62/AM62a

2024-02-15 Thread Andrew Davis
On 2/15/24 2:06 AM, Francesco Dolcini wrote: Hello Andrew, thanks for this series. On Wed, Feb 14, 2024 at 10:30:09AM -0600, Andrew Davis wrote: The current address of TF-A in DRAM is just below the 512MB address line. This means if the DRAM in a system is 512MB then TF-A is right at the end

  1   2   3   4   5   >