Re: [PATCH v2 15/22] liebherr: Include env.h to permit reading the environment

2025-04-30 Thread Lukasz Majewski
On Wed, 30 Apr 2025 19:04:40 -0600 Simon Glass wrote: > This file reads from the environment but does not include the correct > header. Update it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > board/liebherr/xea/xea.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [PATCH v3 00/22] passage: Define a standard for firmware data flow

2025-04-30 Thread Simon Glass
Hi Tom, On Wed, 30 Apr 2025 at 09:21, Tom Rini wrote: > > On Wed, Apr 30, 2025 at 08:51:53AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 30 Apr 2025 at 08:29, Tom Rini wrote: > > > > > > On Wed, Apr 30, 2025 at 07:55:01AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue

[PATCH v2 00/22] Deal with exfat versus byteorder

2025-04-30 Thread Simon Glass
Since exfat has its own byteorder functions we need to be careful about including the normal U-Boot byteorder headers in code included by exfat. One chain for include/linux/byteorder/little_endian.h is like this: In file included from arch/sandbox/include/asm/byteorder.h:19, from

Re: [PATCH 2/2] efi_loader: fix typo initd_sz to initrd_sz

2025-04-30 Thread Heinrich Schuchardt
On 5/1/25 03:15, Adriano Cordova wrote: Signed-off-by: Adriano Cordova This is just the same patch as already reviewed by Ilias and me in your v3 series. Reviewed-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/efi_bootbin.c | 4 ++-- 1 file changed, 2 insert

Re: [PATCH v2 11/22] synology: Include env.h to permit reading the environment

2025-04-30 Thread Tony Dinh
On Wed, Apr 30, 2025 at 6:05 PM Simon Glass wrote: > > This file reads from the environment but does not include the correct > header. Update it. > > Signed-off-by: Simon Glass Reviewed-by: Tony Dinh Thanks, Tony > --- > > (no changes since v1) > > board/Synology/ds414/ds414.c | 1 + > 1 file

Re: [PATCH v2 00/22] Deal with exfat versus byteorder

2025-04-30 Thread Marek Vasut
On 5/1/25 3:04 AM, Simon Glass wrote: Since exfat has its own byteorder functions we need to be careful about including the normal U-Boot byteorder headers in code included by exfat. ... net: Use a forward declaration for cmd_tbl in net-common.h congatec: Include env.h to permit reading

[PATCH v2 20/22] net: Include env.h in pcap.c

2025-04-30 Thread Simon Glass
This file uses the environment but does not include the header file. Update it. Signed-off-by: Simon Glass --- (no changes since v1) net/pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/pcap.c b/net/pcap.c index c959e3e4e51..d1d6f705cda 100644 --- a/net/pcap.c +++ b/net/pcap.c @@

[PATCH] CI: Update the CI lab

2025-04-30 Thread Simon Glass
Update the boards in the lab to match the current situation: - bbb and pin64 are working again - samus and c4 are still broken, with no end in sight - new boards for colibrimx8, rockpro64, rock3a/5b, rpi5, zybo Signed-off-by: Simon Glass --- .gitlab-ci.yml | 48

[PATCH 1/2] efi_loader: bootbin: split initrd registration and installation

2025-04-30 Thread Adriano Cordova
Current support for initrd in EFI booting has two flaws: 1. Installs a NULL initrd via LoadFile2 protocol if `efi_binary_run_dp` does not provide an initrd. In this case, a LoadFile2 should not be installed at all. 2. Initrd is not properly uninstalled if booting fails at some point between

[PATCH 2/2] efi_loader: fix typo initd_sz to initrd_sz

2025-04-30 Thread Adriano Cordova
Signed-off-by: Adriano Cordova --- lib/efi_loader/efi_bootbin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_bootbin.c b/lib/efi_loader/efi_bootbin.c index 637f2c0d195..db4478ee0bf 100644 --- a/lib/efi_loader/efi_bootbin.c +++ b/lib/efi_loader/efi_boo

[PATCH 0/2] efi_loader: fix initrd loading

2025-04-30 Thread Adriano Cordova
This series replaces the series "Fix initrd loading in efi_bootbin". This series consists on a couple of fixes for initrd loading when booting an EFI binary. The first patch fixes 36835a9105c ("efi_loader: binary_run: register an initrd") and also fixes the error handling of the initrd LoadFile2 pr

[PATCH v2 22/22] net: Move env_get_ip() out of the header file

2025-04-30 Thread Simon Glass
This function requires access to env.h but it is a lot to include just for the env_get() function. It eventually pulls in linux/byteorder which causes a conflict with exfat which has its own byteorder functions. Move the function to a C file instead. Add includes to some other files to keep the b

[PATCH v2 21/22] net: dc2114x: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file uses the environment but does not include the header file. Update it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/net/dc2114x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dc2114x.c b/drivers/net/dc2114x.c index 7c0665faa8e..8fa549280aa 100644 ---

[PATCH v2 19/22] net: Include string.h in net-legacy.h

2025-04-30 Thread Simon Glass
This file uses memcpy() but does not include the header file. Update it. Signed-off-by: Simon Glass --- (no changes since v1) include/net-legacy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net-legacy.h b/include/net-legacy.h index 1f62ebff51d..a43ab9db589 100644 --- a/include

[PATCH v2 18/22] net: Include byteorder in net6.h

2025-04-30 Thread Simon Glass
This file uses byteorder but does not include the header file. Update it. Signed-off-by: Simon Glass --- (no changes since v1) include/net6.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net6.h b/include/net6.h index 1ed989e584a..2709fe9c4dc 100644 --- a/include/net6.h +++ b/inc

[PATCH v2 17/22] elf: Only use network environment-variables if net enabled

2025-04-30 Thread Simon Glass
If there is no network support it doesn't make sense to try to read these variables. Add a condition to handle this. This is needed so that env_get_ip() is not called when it is no-longer a static inline, but included in net/ code. Signed-off-by: Simon Glass --- (no changes since v1) cmd/elf.

[PATCH v2 14/22] google: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/google/chameleonv3/board.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/google/chameleonv3/board.c b/board/google/chameleonv3/board

[PATCH v2 12/22] amlogic: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/amlogic/jethub-j100/jethub-j100.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/amlogic/jethub-j100/jethub-j100.c b/board/amlogic/jet

[PATCH v2 16/22] technexion: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/technexion/pico-imx7d/pico-imx7d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexio

[PATCH v2 15/22] liebherr: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/liebherr/xea/xea.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c index 1d4f165fd13..9630

[PATCH v2 13/22] freescale: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/freescale/mx7dsabresd/mx7dsabresd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freesca

[PATCH v2 11/22] synology: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/Synology/ds414/ds414.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/Synology/ds414/ds414.c b/board/Synology/ds414/ds414.c index 1a4ce

[PATCH v2 10/22] tegra: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/mach-tegra/dt-setup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-tegra/dt-setup.c b/arch/arm/mach-tegra/dt-setup.c index

[PATCH v2 09/22] advantech: Include env.h in imx8qm_dmsse20_a1

2025-04-30 Thread Simon Glass
This file uses the environment but does not include the header file. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/advantech/imx8qm_dmsse20_a1/imx8qm_dmsse20_a1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/advantech/imx8qm_dmsse20_a1/imx8qm_dmsse20_a1.c

[PATCH v2 08/22] toradex: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
Two files read from the environment but don't not include the correct header. Update them. Signed-off-by: Simon Glass --- (no changes since v1) board/toradex/colibri_imx7/colibri_imx7.c | 1 + board/toradex/verdin-imx8mm/verdin-imx8mm.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)

[PATCH v2 07/22] ronetix: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/ronetix/imx8mq-cm/imx8mq_cm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/ronetix/imx8mq-cm/imx8mq_cm.c b/board/ronetix/imx8mq-cm/i

[PATCH v2 06/22] phytec: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/phytec/common/phytec_som_detection_blocks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/phytec/common/phytec_som_detection_blocks.c

[PATCH v2 05/22] venice: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/gateworks/venice/venice.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/gateworks/venice/venice.c b/board/gateworks/venice/venice.c in

[PATCH v2 02/22] congatec: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Drop the unnecessary config.h while we are here. Signed-off-by: Simon Glass --- (no changes since v1) board/congatec/cgtqmx8/cgtqmx8.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 04/22] imx8ulp_evk: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/freescale/imx8ulp_evk/imx8ulp_evk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/freescale/imx8ulp_evk/imx8ulp_evk.c b/board/freesca

[PATCH v2 03/22] dhelectronics: Include env.h to permit reading the environment

2025-04-30 Thread Simon Glass
This file reads from the environment but does not include the correct header. Update it. Signed-off-by: Simon Glass --- (no changes since v1) board/dhelectronics/common/dh_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/dhelectronics/common/dh_common.c b/board/dhelectronics

[PATCH v2 01/22] net: Use a forward declaration for cmd_tbl in net-common.h

2025-04-30 Thread Simon Glass
We don't need to include command.h just for this declaration. It eventually pulls in linux/byteorder which causes a conflict with exfat which has its own byteorder functions. Use a forward declaration instead. Signed-off-by: Simon Glass Reviewed-by: Jerome Forissier --- (no changes since v1)

Re: [PATCH] configs: rpi: set NR_DRAM_BANKS to 8 to accommodate RAM on 16GB models

2025-04-30 Thread Matthias Brugger
On 4/30/25 19:15, Jan Čermák wrote: Raspberry Pi 5 can now have up to 16 GiB of RAM where the memory spans 8 DRAM banks in total. Increase the config value to 8 to initialize the whole RAM. Without this change, kernel only sees 8 GiB of RAM on the 16 GiB CM5 as reported in [1]. [1] https://gi

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 02:31:49PM -0500, Bryan Brattlof wrote: > On April 30, 2025 thus sayeth Bryan Brattlof: > > On April 30, 2025 thus sayeth Tom Rini: > > > On Wed, Apr 30, 2025 at 10:56:27PM +0530, Raghavendra, Vignesh wrote: > > > > > > > > > > > > On 4/30/2025 10:01 PM, Tom Rini wrote: >

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 02:26:04PM -0500, Bryan Brattlof wrote: > On April 30, 2025 thus sayeth Tom Rini: > > On Wed, Apr 30, 2025 at 10:56:27PM +0530, Raghavendra, Vignesh wrote: > > > > > > > > > On 4/30/2025 10:01 PM, Tom Rini wrote: > > > > On Wed, Apr 30, 2025 at 11:29:04AM -0500, Bryan Brat

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Bryan Brattlof
On April 30, 2025 thus sayeth Bryan Brattlof: > On April 30, 2025 thus sayeth Tom Rini: > > On Wed, Apr 30, 2025 at 10:56:27PM +0530, Raghavendra, Vignesh wrote: > > > > > > > > > On 4/30/2025 10:01 PM, Tom Rini wrote: > > > > On Wed, Apr 30, 2025 at 11:29:04AM -0500, Bryan Brattlof wrote: > > >

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Bryan Brattlof
On April 30, 2025 thus sayeth Tom Rini: > On Wed, Apr 30, 2025 at 10:56:27PM +0530, Raghavendra, Vignesh wrote: > > > > > > On 4/30/2025 10:01 PM, Tom Rini wrote: > > > On Wed, Apr 30, 2025 at 11:29:04AM -0500, Bryan Brattlof wrote: > > >> On April 30, 2025 thus sayeth Anshul Dalal: > > >>> As di

Re: [PATCH 1/1] bootm: pass kernel load address not entry point for IH_OS_EFI

2025-04-30 Thread Simon Glass
Hi Heinrich, On Wed, 30 Apr 2025 at 09:17, Heinrich Schuchardt wrote: > > On 30.04.25 17:01, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 30 Apr 2025 at 08:04, Heinrich Schuchardt > > wrote: > >> > >> On 30.04.25 15:54, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Wed, 30 Apr 2025

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 08:23:29PM +0200, Heinrich Schuchardt wrote: > On 28.04.25 23:59, Tom Rini wrote: > > Hey all, > > > > Here's the latest set of Coverity defects. Please let me know if some of > > these are false positives for example, thanks. > > Hello Tom, > > I have marked the acpi_upd

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2025-04-30 Thread Heinrich Schuchardt
On 28.04.25 23:59, Tom Rini wrote: Hey all, Here's the latest set of Coverity defects. Please let me know if some of these are false positives for example, thanks. Hello Tom, I have marked the acpi_update_header() items as "intentional" in Coverity: 550301 550291 550288 550287 We could chan

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 10:56:27PM +0530, Raghavendra, Vignesh wrote: > > > On 4/30/2025 10:01 PM, Tom Rini wrote: > > On Wed, Apr 30, 2025 at 11:29:04AM -0500, Bryan Brattlof wrote: > >> On April 30, 2025 thus sayeth Anshul Dalal: > >>> As discussed here[1], the go command causes undefined behav

[PATCH] configs: rpi: set NR_DRAM_BANKS to 8 to accommodate RAM on 16GB models

2025-04-30 Thread Jan Čermák
Raspberry Pi 5 can now have up to 16 GiB of RAM where the memory spans 8 DRAM banks in total. Increase the config value to 8 to initialize the whole RAM. Without this change, kernel only sees 8 GiB of RAM on the 16 GiB CM5 as reported in [1]. [1] https://github.com/home-assistant/operating-system/

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Raghavendra, Vignesh
On 4/30/2025 10:01 PM, Tom Rini wrote: > On Wed, Apr 30, 2025 at 11:29:04AM -0500, Bryan Brattlof wrote: >> On April 30, 2025 thus sayeth Anshul Dalal: >>> As discussed here[1], the go command causes undefined behavior when used >>> for running custom OSes since the icache might hold outdated da

Re: [PATCH] bloblist: Drop BSD license

2025-04-30 Thread Tom Rini
On Thu, Jan 02, 2025 at 08:58:15AM +1300, Simon Glass wrote: > Linaro has decided to write their own version of bloblist from scratch, > so there is no point in having a non-GPL license on this file. Change > it, to better fit with the U-Boot project. > > Signed-off-by: Simon Glass > Link: https

Re: [RESEND PATCH] clk: fix crash on clk_set_rate clean rate cache

2025-04-30 Thread Tom Rini
On Sat, 15 Mar 2025 10:24:14 +0100, Christian Marangi wrote: > It's currently possible to make the bootloader crash on calling > clk_set_rate caused by the loop in clk_clean_rate_cache. > > The loop assume that every child of the clock node are also clock > device but this is not always the case.

Re: [PATCH] common: board: fix build condition of noncached memory initcall

2025-04-30 Thread Tom Rini
On Tue, 29 Apr 2025 10:04:24 +0800, Weijie Gao wrote: > CONFIG_SYS_NONCACHED_MEMORY is defined as hex, not bool. It should be > replaced with CONFIG_SYS_HAS_NONCACHED_MEMORY when switched from #ifdef to > CONFIG_IS_ENABLED(). > > Applied to u-boot/master, thanks! [1/1] common: board: fix build

Re: [PATCH] drivers: spi: Fix data loss issue in QSPI

2025-04-30 Thread Tom Rini
On Fri, 07 Mar 2025 01:38:26 -0800, Naresh Kumar Ravulapalli wrote: > QSPI driver performs chip select operation before every read/write > access. During this operation, driver needs to enable and disable > the QSPI controller. This may cause data loss if there is inadvertent > halting of any ongo

Re: [2nd RESEND PATCH 0/2] Add support for Infineon S28HL256T and S28HL02GT

2025-04-30 Thread Tom Rini
On Wed, 02 Apr 2025 15:26:39 +0900, tkuw584...@gmail.com wrote: > From: Takahiro Kuwano > > Those are 3.0V, 256Mb/2Gb NOR Flash devices with Octal interface. > Same fanctionalities with 1.8V version that are already supported. > > Takahiro Kuwano (2): > mtd: spi-nor-ids: Add support for S28HL

Re: [PATCH] Revert "mtd: spi-nor: Remove recently added SST special case"

2025-04-30 Thread Tom Rini
On Fri, 28 Feb 2025 14:47:24 +0530, Prasad Kummari wrote: > SST(sst26wf016) flashes have multiple erase block sizes, including > 8 KB, 32 KB, and 64 KB. Since a 64 KB sector erase cannot be performed > on all blocks, the 4 KB sector erase command should be used instead. > Enabling the SPI_FLASH_US

Re: [PATCH] mtd: spi-nor: Use CONFIG_IS_ENABLED for CONFIG_SPI_FLASH_BAR defines

2025-04-30 Thread Tom Rini
On Fri, 04 Apr 2025 11:56:07 +0200, Bernhard Messerklinger wrote: > At the moment a mixture of ifdef(CONFIG_IS_ENABLED) and > CONFIG_IS_ENABLED(SPI_FLASH_BAR) is used in the spi-nor framework. > This leads to misbehaviour in the SPL as there is no Kconfig option > CONFIG_SPL_SPI_FLASH_BAR. This co

Re: [PATCH] mtd: spi-nor: Add NO_CHIP_ERASE flag for mt35xu01g/2g

2025-04-30 Thread Tom Rini
On Thu, 27 Mar 2025 12:34:43 +0530, Venkatesh Yadav Abbarapu wrote: > Since the opcode SPINOR_OP_CHIP_ERASE (0xc7) is not supported > for the mt35xu01g/2g flashes, the NO_CHIP_ERASE flag has been added > to enable sector erase functionality instead. > > Applied to u-boot/master, thanks! [1/1]

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 06:50:50PM +0200, Marek Vasut wrote: > On 4/28/25 11:59 PM, Tom Rini wrote: > > > > > *** CID 550306: Control flow issues (DEADCODE) > > /fs/exfat/io.c: 547 in exfat_

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2025-04-30 Thread Marek Vasut
On 4/28/25 11:59 PM, Tom Rini wrote: > *** CID 550306: Control flow issues (DEADCODE) /fs/exfat/io.c: 547 in exfat_generic_pwrite() 541 int rc; 542 cluster_t cluste

[PATCH 1/2] fs: exfat: Use strncpy() and bail on too long filenames

2025-04-30 Thread Marek Vasut
In case the filename is too long, longer than PATH_MAX - 1, it would overflow dirs->dirname array. Add missing check and also use strncpy() to prevent the overflow in any case. Fixes CID 550305: Security best practices violations (STRING_OVERFLOW) Signed-off-by: Marek Vasut --- Cc: Tom Rini C

[PATCH 2/2] fs: exfat: Inhibit unused exfat_humanize_bytes() and exfat_print_info()

2025-04-30 Thread Marek Vasut
Make sure unused exfat_humanize_bytes() and exfat_print_info() functions are not compiled into U-Boot code base. This also removes CID 550300: Integer handling issues (INTEGER_OVERFLOW) in exfat_humanize_bytes() , which is now surely unreachable. Signed-off-by: Marek Vasut --- Cc: Tom Rini Cc:

Re: [PATCH v3 00/22] passage: Define a standard for firmware data flow

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 08:51:53AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Apr 2025 at 08:29, Tom Rini wrote: > > > > On Wed, Apr 30, 2025 at 07:55:01AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 29 Apr 2025 at 11:11, Tom Rini wrote: > > > > > > > > On Mon, Apr 28, 20

Re: [PATCH 0/3] u-boot chain-loading LineageOS bootimg

2025-04-30 Thread george chan
Hi Mattijs, Thx for reply. I like your attitude and appreciate it. There are many topic get silent in the end. > >> It's a bit unclear to me why it's impractical to repack the boot.img and > >> specify the appropriate address. Could you elaborate ? > > > > > > It is hard to ask less experience p

Re: [PATCH v3 00/22] passage: Define a standard for firmware data flow

2025-04-30 Thread Simon Glass
Hi Tom, On Wed, 30 Apr 2025 at 08:29, Tom Rini wrote: > > On Wed, Apr 30, 2025 at 07:55:01AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 29 Apr 2025 at 11:11, Tom Rini wrote: > > > > > > On Mon, Apr 28, 2025 at 10:41:25AM -0400, Raymond Mao wrote: > > > > Hi Simon, > > > > > > > > On T

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 11:29:04AM -0500, Bryan Brattlof wrote: > On April 30, 2025 thus sayeth Anshul Dalal: > > As discussed here[1], the go command causes undefined behavior when used > > for running custom OSes since the icache might hold outdated data. OSes > > usually also expect the MMU to b

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Bryan Brattlof
On April 30, 2025 thus sayeth Anshul Dalal: > As discussed here[1], the go command causes undefined behavior when used > for running custom OSes since the icache might hold outdated data. OSes > usually also expect the MMU to be disabled upon execution. > > Therefore this patch adds a call to clea

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 09:27:30PM +0530, Anshul Dalal wrote: > On Wed Apr 30, 2025 at 7:46 PM IST, Tom Rini wrote: > > On Wed, Apr 30, 2025 at 07:27:50PM +0530, Anshul Dalal wrote: > > > >> As discussed here[1], the go command causes undefined behavior when used > >> for running custom OSes since

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Anshul Dalal
On Wed Apr 30, 2025 at 7:46 PM IST, Tom Rini wrote: > On Wed, Apr 30, 2025 at 07:27:50PM +0530, Anshul Dalal wrote: > >> As discussed here[1], the go command causes undefined behavior when used >> for running custom OSes since the icache might hold outdated data. OSes >> usually also expect the MMU

Re: [PATCH v3] watchdog: qcom: introduce qcom-wdt driver

2025-04-30 Thread Yang Xiwen
On 4/23/2025 10:19 AM, Paul Sajna wrote: From: Casey Connolly Some Qualcomm device vendors decide to turn the watchdog on in the bootloader, resulting in the device being reset if it isn't petted every ~30 seconds. Introduce a driver to keep the watchdog happy and prevent this annoying behaviou

Re: [REGRESSION] [PATCH v6 0/3] Static initcalls

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 09:00:40AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 30 Apr 2025 at 08:15, Tom Rini wrote: > > > > On Wed, Apr 30, 2025 at 07:54:46AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 29 Apr 2025 at 16:32, Marcel Ziswiler > > > wrote: > > > > > > > > Hi Je

Re: [PATCH 0/3] Add fdt-fixups for AM62A variants

2025-04-30 Thread Bryan Brattlof
On April 30, 2025 thus sayeth Aparna Patra: > This series implements fdt fixups, by reading hardware > information from registers and accordingly delete/modify > the DT nodes, at run-time. > > Aparna Patra (3): > arm: mach-k3: am62a: Fixup CPU core, DSS, CAN-FD and Video-codec nodes > in fdt

Re: [PATCH 1/3] arm: mach-k3: am62a: Fixup CPU core, DSS, CAN-FD and Video-codec nodes in fdt

2025-04-30 Thread Bryan Brattlof
On April 30, 2025 thus sayeth Aparna Patra: > AM62A SOC is available in multiple variants: > -CPU cores (Cortex-A) AM62Ax1 (1 core), > AM62Ax2 (2 cores), AM62Ax4 (4 cores) > -With and without DSS, CAN-FD & Video-codec support > > Remove the relevant FDT nodes by reading the actual configuration >

Re: [PATCH 1/1] bootm: pass kernel load address not entry point for IH_OS_EFI

2025-04-30 Thread Heinrich Schuchardt
On 30.04.25 17:01, Simon Glass wrote: Hi Heinrich, On Wed, 30 Apr 2025 at 08:04, Heinrich Schuchardt wrote: On 30.04.25 15:54, Simon Glass wrote: Hi Heinrich, On Wed, 30 Apr 2025 at 04:55, Heinrich Schuchardt wrote: The EFI sub-system needs the load address and not the entry point to boo

Re: [PATCH 1/1] bootm: pass kernel load address not entry point for IH_OS_EFI

2025-04-30 Thread Simon Glass
Hi Heinrich, On Wed, 30 Apr 2025 at 08:04, Heinrich Schuchardt wrote: > > On 30.04.25 15:54, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 30 Apr 2025 at 04:55, Heinrich Schuchardt > > wrote: > >> > >> The EFI sub-system needs the load address and not the entry point > >> to boot the binar

Re: [REGRESSION] [PATCH v6 0/3] Static initcalls

2025-04-30 Thread Simon Glass
Hi Tom, On Wed, 30 Apr 2025 at 08:15, Tom Rini wrote: > > On Wed, Apr 30, 2025 at 07:54:46AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 29 Apr 2025 at 16:32, Marcel Ziswiler > > wrote: > > > > > > Hi Jerome > > > > > > On Fri, 2025-04-04 at 15:50 +0200, Jerome Forissier wrote: > > > >

Re: [PATCH 1/1] boot/image-fit: improve 'No Image' message

2025-04-30 Thread Simon Glass
Hi Heinrich, On Wed, 30 Apr 2025 at 08:34, Heinrich Schuchardt wrote: > > On 30.04.25 15:54, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 30 Apr 2025 at 01:16, Heinrich Schuchardt > > wrote: > >> > >> If an initrd is invalid, we see output like > >> > >> No Unknown OS RISC-V RAMDisk

Re: [PATCH 1/2] net: Use a forward declaration for cmd_tbl in net-common.h

2025-04-30 Thread Jerome Forissier
On 4/30/25 16:40, Simon Glass wrote: > We don't need to include command.h just for this declaration. It > eventually pulls in linux/byteorder which causes a conflict with exfat > which has its own byteorder functions. > > Use a forward declaration instead. > > Signed-off-by: Simon Glass > ---

Re: [PATCH 00/30] patman: Move to asyncio and other updates

2025-04-30 Thread Simon Glass
Hi Tom, On Wed, 30 Apr 2025 at 08:21, Tom Rini wrote: > > On Wed, Apr 30, 2025 at 07:54:11AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 29 Apr 2025 at 08:53, Tom Rini wrote: > > > > > > On Tue, Apr 29, 2025 at 08:35:24AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue

Re: [PATCH v2 1/1] bootm: improve error message when gzip decompression buffer is too small

2025-04-30 Thread Mattijs Korpershoek
Hi Aristo, Thank you for the patch. On mer., avril 30, 2025 at 10:23, Aristo Chen wrote: > Currently, when decompressing a gzip-compressed image during bootm, a > generic error such as "inflate() returned -5" is shown when the buffer is > too small. However, it is not immediately clear that thi

Re: [PATCH 2/2] net: Move env_get_ip() out of the header file

2025-04-30 Thread Jerome Forissier
On 4/30/25 16:40, Simon Glass wrote: > This function requires access to env.h but it is a lot to include just > for the env_get() function. It eventually pulls in linux/byteorder which > causes a conflict with exfat which has its own byteorder functions. > > Move the function to a C file instea

Re: [PATCH v3 00/22] passage: Define a standard for firmware data flow

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 07:55:01AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 29 Apr 2025 at 11:11, Tom Rini wrote: > > > > On Mon, Apr 28, 2025 at 10:41:25AM -0400, Raymond Mao wrote: > > > Hi Simon, > > > > > > On Thu, 17 Apr 2025 at 14:16, Simon Glass wrote: > > > > > > > > > > > > This

Re: [PATCH 1/1] boot: print the boot stage id in the report

2025-04-30 Thread Simon Glass
Hi Heinrich, On Wed, 30 Apr 2025 at 08:25, Heinrich Schuchardt wrote: > > On 30.04.25 15:54, Simon Glass wrote: > > +Michal Simek > > > > Hi Heinrich, > > > > On Wed, 30 Apr 2025 at 03:11, Heinrich Schuchardt > > wrote: > >> > >> An output like the following is not helpful: > >> > >> Timer

Re: [PATCH v3 00/22] passage: Define a standard for firmware data flow

2025-04-30 Thread Simon Glass
Hi Tom, On Tue, 29 Apr 2025 at 11:11, Tom Rini wrote: > > On Mon, Apr 28, 2025 at 10:41:25AM -0400, Raymond Mao wrote: > > Hi Simon, > > > > On Thu, 17 Apr 2025 at 14:16, Simon Glass wrote: > > > > > > > > > This series adds a standard way of passing information between different > > > firmware

[PATCH 2/2] net: Move env_get_ip() out of the header file

2025-04-30 Thread Simon Glass
This function requires access to env.h but it is a lot to include just for the env_get() function. It eventually pulls in linux/byteorder which causes a conflict with exfat which has its own byteorder functions. Move the function to a C file instead. Signed-off-by: Simon Glass --- include/net-

[PATCH 1/2] net: Use a forward declaration for cmd_tbl in net-common.h

2025-04-30 Thread Simon Glass
We don't need to include command.h just for this declaration. It eventually pulls in linux/byteorder which causes a conflict with exfat which has its own byteorder functions. Use a forward declaration instead. Signed-off-by: Simon Glass --- include/net-common.h | 3 ++- 1 file changed, 2 inser

Re: [PATCH v2 1/1] bootm: improve error message when gzip decompression buffer is too small

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 10:23:25AM +0800, Aristo Chen wrote: > Currently, when decompressing a gzip-compressed image during bootm, a > generic error such as "inflate() returned -5" is shown when the buffer is > too small. However, it is not immediately clear that this is caused by > CONFIG_SYS_BOO

Re: [PATCH 1/1] boot/image-fit: improve 'No Image' message

2025-04-30 Thread Heinrich Schuchardt
On 30.04.25 15:54, Simon Glass wrote: Hi Heinrich, On Wed, 30 Apr 2025 at 01:16, Heinrich Schuchardt wrote: If an initrd is invalid, we see output like No Unknown OS RISC-V RAMDisk Image Image Ramdisk image is corrupt or invalid As most image type descriptions end on Image, we sho

Re: [PATCH 1/1] boot: print the boot stage id in the report

2025-04-30 Thread Heinrich Schuchardt
On 30.04.25 15:54, Simon Glass wrote: +Michal Simek Hi Heinrich, On Wed, 30 Apr 2025 at 03:11, Heinrich Schuchardt wrote: An output like the following is not helpful: Timer summary in microseconds (40 records): MarkElapsed Stage 0 0 reset

Re: [PATCH 00/30] patman: Move to asyncio and other updates

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 07:54:11AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 29 Apr 2025 at 08:53, Tom Rini wrote: > > > > On Tue, Apr 29, 2025 at 08:35:24AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 29 Apr 2025 at 07:48, Tom Rini wrote: > > > > > > > > On Tue, Apr 29, 20

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

2025-04-30 Thread Ilias Apalodimas
On Wed, 30 Apr 2025 at 10:34, Heinrich Schuchardt wrote: > > BOOTSTAGE_RECORD_COUNT=30 is too small to record booting a FIT image > with EFI kernel, initrd, dtb as seen on the StarFive VisionFive 2 > board. > > Increase the default for BOOTSTAGE_RECORD_COUNT to 50. > > Signed-off-by: Heinrich Schu

Re: [PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 07:27:50PM +0530, Anshul Dalal wrote: > As discussed here[1], the go command causes undefined behavior when used > for running custom OSes since the icache might hold outdated data. OSes > usually also expect the MMU to be disabled upon execution. > > Therefore this patch

Re: [REGRESSION] [PATCH v6 0/3] Static initcalls

2025-04-30 Thread Tom Rini
On Wed, Apr 30, 2025 at 07:54:46AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 29 Apr 2025 at 16:32, Marcel Ziswiler > wrote: > > > > Hi Jerome > > > > On Fri, 2025-04-04 at 15:50 +0200, Jerome Forissier wrote: > > > This series replaces the dynamic initcalls (with function pointers) with > >

Re: [PATCH 1/1] bootm: pass kernel load address not entry point for IH_OS_EFI

2025-04-30 Thread Heinrich Schuchardt
On 30.04.25 15:54, Simon Glass wrote: Hi Heinrich, On Wed, 30 Apr 2025 at 04:55, Heinrich Schuchardt wrote: The EFI sub-system needs the load address and not the entry point to boot the binary passed from the bootm command. The entry point is derived from the PE-COFF header of the binary. Fi

Re: [PATCH 1/1] bootm: pass kernel load address not entry point for IH_OS_EFI

2025-04-30 Thread Ilias Apalodimas
Hi Simon On Wed, 30 Apr 2025 at 16:54, Simon Glass wrote: > > Hi Heinrich, > > On Wed, 30 Apr 2025 at 04:55, Heinrich Schuchardt > wrote: > > > > The EFI sub-system needs the load address and not the entry point > > to boot the binary passed from the bootm command. The entry point > > is derived

[PATCH v1] arm: add call to cleanup_before_linux for go command

2025-04-30 Thread Anshul Dalal
As discussed here[1], the go command causes undefined behavior when used for running custom OSes since the icache might hold outdated data. OSes usually also expect the MMU to be disabled upon execution. Therefore this patch adds a call to cleanup_before_linux before we jump to the loaded program/

Re: [REGRESSION] [PATCH v6 0/3] Static initcalls

2025-04-30 Thread Simon Glass
Hi Tom, On Tue, 29 Apr 2025 at 16:32, Marcel Ziswiler wrote: > > Hi Jerome > > On Fri, 2025-04-04 at 15:50 +0200, Jerome Forissier wrote: > > This series replaces the dynamic initcalls (with function pointers) with > > static calls, and gets rid of initcall_run_list(), init_sequence_f, > > init_s

Re: [PATCH 1/1] boot: let BOOTSTAGE_RECORD_COUNT default to 50

2025-04-30 Thread Simon Glass
On Wed, 30 Apr 2025 at 02:32, Heinrich Schuchardt wrote: > > On 30.04.25 09:34, Heinrich Schuchardt wrote: > > BOOTSTAGE_RECORD_COUNT=30 is too small to record booting a FIT image > > with EFI kernel, initrd, dtb as seen on the StarFive VisionFive 2 > > board. > > > > Increase the default for BOOT

Re: [PATCH 1/1] boot: print the boot stage id in the report

2025-04-30 Thread Simon Glass
+Michal Simek Hi Heinrich, On Wed, 30 Apr 2025 at 03:11, Heinrich Schuchardt wrote: > > An output like the following is not helpful: > > Timer summary in microseconds (40 records): >MarkElapsed Stage > 0 0 reset > ... > 56,448,158 4,845

Re: [PATCH 1/1] boot/image-fit: improve 'No Image' message

2025-04-30 Thread Simon Glass
Hi Heinrich, On Wed, 30 Apr 2025 at 01:16, Heinrich Schuchardt wrote: > > If an initrd is invalid, we see output like > > No Unknown OS RISC-V RAMDisk Image Image > Ramdisk image is corrupt or invalid > > As most image type descriptions end on Image, we should not repeat that > word. Ins

Re: [PATCH 1/1] bootm: pass kernel load address not entry point for IH_OS_EFI

2025-04-30 Thread Simon Glass
Hi Heinrich, On Wed, 30 Apr 2025 at 04:55, Heinrich Schuchardt wrote: > > The EFI sub-system needs the load address and not the entry point > to boot the binary passed from the bootm command. The entry point > is derived from the PE-COFF header of the binary. > > Fixes: ecc7fdaa9ef1 ("bootm: Add

Re: [PATCH 00/30] patman: Move to asyncio and other updates

2025-04-30 Thread Simon Glass
Hi Tom, On Tue, 29 Apr 2025 at 08:53, Tom Rini wrote: > > On Tue, Apr 29, 2025 at 08:35:24AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 29 Apr 2025 at 07:48, Tom Rini wrote: > > > > > > On Tue, Apr 29, 2025 at 07:21:57AM -0600, Simon Glass wrote: > > > > > > > This series moves patman

Re: [PATCH 0/3] u-boot chain-loading LineageOS bootimg

2025-04-30 Thread Mattijs Korpershoek
Hi George, On mer., avril 30, 2025 at 11:58, george chan wrote: > Hi Mattijs, > CC: Casey, > > Thx for your reply. > > > 在 2025年4月29日週二 16:30,Mattijs Korpershoek 寫道: > >> Hi George, >> >> Thank you for contributing. >> >> On lun., avril 28, 2025 at 15:53, Casey Connolly < >> casey.conno...@lina

Re: [SPAM][REGRESSION] [PATCH v6 0/3] Static initcalls

2025-04-30 Thread Marcel Ziswiler
Hi Weijie On Wed, 2025-04-30 at 15:11 +0800, Weijie Gao wrote: > Hi Marcel, > > This regression is also found with mtk_eth driver and I've sent a patch > to fix it: > > > https://patchwork.ozlabs.org/project/uboot/patch/20250429020424.48795-1-weijie@mediatek.com/ > > This patch should also

Re: [PATCH] common: board: fix build condition of noncached memory initcall

2025-04-30 Thread Marcel Ziswiler
Hi Weijie Thanks for fixing this :) On Tue, 2025-04-29 at 10:04 +0800, Weijie Gao wrote: > CONFIG_SYS_NONCACHED_MEMORY is defined as hex, not bool. It should be > replaced with CONFIG_SYS_HAS_NONCACHED_MEMORY when switched from #ifdef to > CONFIG_IS_ENABLED(). > > Fixes: 6c171f7a184 (common: boa

Re: [PATCH 1/1] bootm: pass kernel load address not entry point for IH_OS_EFI

2025-04-30 Thread Ilias Apalodimas
On Wed, 30 Apr 2025 at 13:55, Heinrich Schuchardt wrote: > > The EFI sub-system needs the load address and not the entry point > to boot the binary passed from the bootm command. The entry point > is derived from the PE-COFF header of the binary. > > Fixes: ecc7fdaa9ef1 ("bootm: Add a bootm comman

Re: [PATCH] configs: mvebu_espressobin_ultra-88f3720_defconfig: enable hwrng

2025-04-30 Thread Stefan Roese
On 17.04.25 21:37, Benjamin Schneider wrote: This device has a hardware random number generator. Linux can use this feature to randomize the location of the kernel in memory for better security. However, that functionality is only available if the bootloader firmware provides it. Enable support f

  1   2   >