Re: [PATCH 32/38] fs: fat: Shrink the size of a few strings

2023-03-30 Thread Heinrich Schuchardt
Am 31. März 2023 03:16:13 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Fri, 31 Mar 2023 at 13:05, Heinrich Schuchardt wrote: >> >> >> >> Am 31. März 2023 01:49:35 MESZ schrieb Simon Glass : >> >Hi Heinrich, >> > >> >On Fri, 31 Mar 2023 at 11:48, Heinrich Schuchardt >> >wrote: >> >> >> >> >>

Re: [PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-03-30 Thread Heinrich Schuchardt
Am 31. März 2023 03:16:06 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Fri, 31 Mar 2023 at 13:27, Heinrich Schuchardt wrote: >> >> >> >> Am 31. März 2023 01:48:57 MESZ schrieb Simon Glass : >> >Hi Heinrich, >> > >> >On Fri, 31 Mar 2023 at 11:38, Heinrich Schuchardt >> >wrote: >> >> >> >> >>

[PATCH] arm: dts: k3-j721e-sk-u-boot: Resync dts file and binding with Linux Kernel

2023-03-30 Thread Sinthu Raja
From: Sinthu Raja This resyncs the dts file of j721e-sk with the currently in-tree K3 platforms. Of note are that the main-navss/mcu-navss nodes were renamed to main_navss / mcu_navss and so the u-boot.dtsi file needed to be updated to match. Also, disable the HBMC which is not supported in the

Re: RISC-V FIT image type

2023-03-30 Thread Bin Meng
On Fri, Mar 31, 2023 at 5:36 AM Simon Glass wrote: > > Hi, > > I notice that in image.h we have IH_ARCH_RISCV but no mention of > IH_ARCH_RISCV64. Should we not have two separate image types, as we do > with ARM and x86? Otherwise, how would a loader know the word size of > the target machine? I

Re: [PATCH v4 08/15] cmd: bmp: Split bmp commands and functions

2023-03-30 Thread Nikhil M Jain
Hi Simon, On 31/03/23 01:44, Simon Glass wrote: Hi Nikhil, On Thu, 30 Mar 2023 at 01:02, Nikhil M Jain wrote: To enable splash screen at spl, need to compile cmd/bmp.c which also includes bmp commands, since SPL can't have commands split bmp.c into common/bmp.c which includes all bmp functio

Re: [PATCH v4 04/15] drivers: video: Makefile: Rule to compile necessary video driver files.

2023-03-30 Thread Nikhil M Jain
Hi Simon On 31/03/23 01:44, Simon Glass wrote: Hi Nikhil, On Thu, 30 Mar 2023 at 01:01, Nikhil M Jain wrote: To enable video driver at SPL, need to compile video-uclass, vidconsole-uclass, backlight-uclass, panel-uclass, simple-panel, add rules to compile them at SPL only. To support splash_

Re: [PATCH v4 00/15] Add splash screen support at u-boot SPL

2023-03-30 Thread Nikhil M Jain
Hi Simon On 31/03/23 01:44, Simon Glass wrote: Hi Nikhil, On Thu, 30 Mar 2023 at 01:01, Nikhil M Jain wrote: To enable splash screen at SPL stage move video driver and splash screen framework at SPL, which will bring up image on display very quickly and thus have early display support in SPL

Re: [PATCH 2/6] serial: msm-geni: remove redundant includes

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > For whatever reason, likely a driver stub was copied from another > driver, the driver contains a bunch of unnecessary and confusing > includes like watchdog.h etc., the change reduces the list. > > Signed-off-by: Vladimir Zapolskiy > --- Review

Re: [PATCH 6/6] serial: msm-geni: correct oversampling value based on QUP hardware revision

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > Starting from QUP v2.5 the value of oversampling is changed from 32 > to 16, keeping the old value on newer platforms results on wrong set > UART IP clock divider, thus the asked baudrate does not correspond to > the actually set with all the cons

Re: [PATCH 5/6] serial: msm-geni: fix a compile time warning from msm_serial_setbrg()

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > A compiler warns about a missing function prototype, which is valid > and fixed by converting the function into static one, also fix > interleaved local variable declarations and assignments. > > Signed-off-by: Vladimir Zapolskiy > --- Fixes: 3

Re: [PATCH 4/6] serial: msm-geni: fix code indentation

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > This a cosmetic change, which corrects code indentation in a few places. > > Signed-off-by: Vladimir Zapolskiy > --- Reviewed-by: Konrad Dybcio Konrad > drivers/serial/serial_msm_geni.c | 11 +-- > 1 file changed, 5 insertions(+), 6 d

Re: [PATCH 3/6] serial: msm-geni: remove invalid se-clk clock name

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > There is only one clock supplier to the serial IP, thus getting it by > name is not needed, also note that "clock-names" property is not listed > under doc/device-tree-bindings/serial/msm-geni-serial.txt, and finally > "se-clk" clock name is inval

Re: [PATCH 1/6] misc: add Qualcomm GENI SE QUP device driver

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > This change adds a Qualcomm GENI SE QUP device driver as a wrapper for > actually enabled and used serial devices found on a board. > > At the moment the driver is pretty simple, its intention is to populate > childred devices and provide I/O mem

Re: [PATCH 32/38] fs: fat: Shrink the size of a few strings

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 13:05, Heinrich Schuchardt wrote: > > > > Am 31. März 2023 01:49:35 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Fri, 31 Mar 2023 at 11:48, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 30. März 2023 23:32:21 MESZ schrieb Simon Glass : > >> >To sav

Re: [PATCH 13/38] part: Allow setting the partition-table type

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 13:17, Heinrich Schuchardt wrote: > > > > Am 31. März 2023 01:49:05 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Fri, 31 Mar 2023 at 11:33, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 30. März 2023 23:32:02 MESZ schrieb Simon Glass : > >> >Some d

Re: [PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 13:27, Heinrich Schuchardt wrote: > > > > Am 31. März 2023 01:48:57 MESZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Fri, 31 Mar 2023 at 11:38, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 30. März 2023 23:32:07 MESZ schrieb Simon Glass : > >> >The CM

Re: [PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-03-30 Thread Heinrich Schuchardt
Am 31. März 2023 01:48:57 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Fri, 31 Mar 2023 at 11:38, Heinrich Schuchardt wrote: >> >> >> >> Am 30. März 2023 23:32:07 MESZ schrieb Simon Glass : >> >The CMD_EFIDEBUG option enables debugging so it is reasonable to assume >> >that all effects should

Re: [PATCH 13/38] part: Allow setting the partition-table type

2023-03-30 Thread Heinrich Schuchardt
Am 31. März 2023 01:49:05 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Fri, 31 Mar 2023 at 11:33, Heinrich Schuchardt wrote: >> >> >> >> Am 30. März 2023 23:32:02 MESZ schrieb Simon Glass : >> >Some devices have multiple partition types available on the same media. >> >It is sometimes useful

Re: [PATCH 32/38] fs: fat: Shrink the size of a few strings

2023-03-30 Thread Heinrich Schuchardt
Am 31. März 2023 01:49:35 MESZ schrieb Simon Glass : >Hi Heinrich, > >On Fri, 31 Mar 2023 at 11:48, Heinrich Schuchardt wrote: >> >> >> >> Am 30. März 2023 23:32:21 MESZ schrieb Simon Glass : >> >To save a few bytes, replace Error with ** and try to use the same string >> >for multiple messages

Re: [PATCH 32/38] fs: fat: Shrink the size of a few strings

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 11:48, Heinrich Schuchardt wrote: > > > > Am 30. März 2023 23:32:21 MESZ schrieb Simon Glass : > >To save a few bytes, replace Error with ** and try to use the same string > >for multiple messages where possible. > > > >Signed-off-by: Simon Glass > >--- > > >

Re: [PATCH 13/38] part: Allow setting the partition-table type

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 11:33, Heinrich Schuchardt wrote: > > > > Am 30. März 2023 23:32:02 MESZ schrieb Simon Glass : > >Some devices have multiple partition types available on the same media. > >It is sometimes useful to see these to check that everything is working > >correctly. >

Re: [PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 11:38, Heinrich Schuchardt wrote: > > > > Am 30. März 2023 23:32:07 MESZ schrieb Simon Glass : > >The CMD_EFIDEBUG option enables debugging so it is reasonable to assume > >that all effects should be made to decode the dreaded UUIDs favoured by > >UEFI. > > > >

Re: [PATCH 38/38] efi: Use the installed ACPI tables

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 10:53, Heinrich Schuchardt wrote: > > > > Am 30. März 2023 23:32:27 MESZ schrieb Simon Glass : > >U-Boot sets up the ACPI tables during startup. Rather than creating a > >new set, install the existing ones. Create a memory-map record to cover > >the tables. > >

Re: [PATCH 14/38] qfw: Show the file address if available

2023-03-30 Thread Simon Glass
Hi Heinrich, On Fri, 31 Mar 2023 at 11:31, Heinrich Schuchardt wrote: > > > > Am 30. März 2023 23:32:03 MESZ schrieb Simon Glass : > >Some files have an associated address. Show this with the 'qfw list' > >command so that it is possible to dump the data. > > > >Signed-off-by: Simon Glass > >---

Re: [PATCH 1/1] rockchip: Fix incorrect constant name in RAM init code

2023-03-30 Thread Simon Glass
On Fri, 31 Mar 2023 at 10:53, David Sebek wrote: > > A condition in the rk3399 RAM initialization code used the old > CONFIG_RAM_RK3399_LPDDR4 constant name. This commit changes the > condition to use the correct CONFIG_RAM_ROCKCHIP_LPDDR4 constant. > --- > drivers/ram/rockchip/sdram_rk3399.c | 2

Re: [PATCH 33/38] fs: fat: Support reading from a larger block size

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:32:22 MESZ schrieb Simon Glass : >At present it is not possible to read from some CDROM drives since the >FAT sector size does not match the media's block size. Add a conversion >option for this, so that reading is possible. > >This does increase SPL size for read-only FAT su

Re: [PATCH 32/38] fs: fat: Shrink the size of a few strings

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:32:21 MESZ schrieb Simon Glass : >To save a few bytes, replace Error with ** and try to use the same string >for multiple messages where possible. > >Signed-off-by: Simon Glass >--- > > fs/fat/fat.c | 12 ++-- > fs/fat/fat_write.c | 14 -- > 2 files c

Re: [PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:32:07 MESZ schrieb Simon Glass : >The CMD_EFIDEBUG option enables debugging so it is reasonable to assume >that all effects should be made to decode the dreaded UUIDs favoured by >UEFI. > >Update the table to show them all when CONFIG_CMD_EFIDEBUG is enabled. > >Signed-off-by

Re: [PATCH 14/38] qfw: Show the file address if available

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:32:03 MESZ schrieb Simon Glass : >Some files have an associated address. Show this with the 'qfw list' >command so that it is possible to dump the data. > >Signed-off-by: Simon Glass >--- > > cmd/qfw.c | 2 +- > doc/usage/cmd/qfw.rst | 28

Re: [PATCH 13/38] part: Allow setting the partition-table type

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:32:02 MESZ schrieb Simon Glass : >Some devices have multiple partition types available on the same media. >It is sometimes useful to see these to check that everything is working >correctly. > >Provide a way to manually set the partition-table type, avoiding the >auto-detecti

Re: [PATCH 10/38] x86: Show an error when a BINS exception occurs

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:31:59 MESZ schrieb Simon Glass : >Rather than silently hanging, show an error first. This can happen when >there is something wrong with the video BIOS. > >Signed-off-by: Simon Glass >--- > > arch/x86/lib/bios.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >dif

Re: [PATCH 07/38] x86: Add a comment for board_init_f_r_trampoline()

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:31:56 MESZ schrieb Simon Glass : >Add a comment for this function in the header. > >Change the function (and the one after) to use __noreturn to keep >checkpatch happy. > >Signed-off-by: Simon Glass >--- > > arch/x86/include/asm/u-boot-x86.h | 10 -- > 1 file changed,

Re: [RFC PATCH v7 23/23] DO NOT MERGE: only to make CI happy

2023-03-30 Thread Francis Laniel
Hi. Le jeudi 30 mars 2023, 21:17:33 WEST Tony Dinh a écrit : > Hi Francis, > > On Thu, Mar 30, 2023 at 12:50 PM Francis Laniel > > wrote: > > This commit set CONFIG_HUSH_PARSER_2021 as the default to trigger the CI > > with this parser. > > > > Nonetheless, the keymile (i.e. VENDOR_KM) board f

Re: [PATCH 02/38] x86: Allow listing MTRRs in SPL

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:31:51 MESZ schrieb Simon Glass : >When using video in SPL it is useful to see the values of the MTRR >registers. Move this code into a shared file, so it can be called from >SPL easily. > >Signed-off-by: Simon Glass >--- > > arch/x86/cpu/mtrr.c | 61 +

Re: [PATCH 38/38] efi: Use the installed ACPI tables

2023-03-30 Thread Heinrich Schuchardt
Am 30. März 2023 23:32:27 MESZ schrieb Simon Glass : >U-Boot sets up the ACPI tables during startup. Rather than creating a >new set, install the existing ones. Create a memory-map record to cover >the tables. I understand that this works on QEMU which provides ACPI tables. But on all other sy

[PATCH 1/1] rockchip: Fix incorrect constant name in RAM init code

2023-03-30 Thread David Sebek
A condition in the rk3399 RAM initialization code used the old CONFIG_RAM_RK3399_LPDDR4 constant name. This commit changes the condition to use the correct CONFIG_RAM_ROCKCHIP_LPDDR4 constant. --- drivers/ram/rockchip/sdram_rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 00/38] x86: Use qemu-x86_64 to boot EFI installers

2023-03-30 Thread Simon Glass
This series adds various minor features so that qemu-x86_64 can boot the Ubuntu 2022.04 installer using a virtio device: qemu-system-x86_64 -M pc -drive format=raw,file=root.img -bios /tmp/b/qemu-x86_64/u-boot.rom -drive if=virtio,file=ubuntu-22.04.2-desktop-amd64.iso -

[PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-30 Thread Ryan Eatmon
The oe-core class for assembling the fitImage includes the vendor sub-directory (with the / changed to _) in the config sections of the fitImage. Our env var settings for chosing which section to boot from needs to be updated to agree with the fitImage. Signed-off-by: Ryan Eatmon --- include/co

[PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-30 Thread Ryan Eatmon
The oe-core class for assembling the fitImage includes the vendor sub-directory (with the / changed to _) in the config sections of the fitImage. Our env var settings for chosing which section to boot from needs to be updated to agree with the fitImage. Signed-off-by: Ryan Eatmon --- include/co

Re: Missed rename of CONFIG_RAM_RK3399_LPDDR4

2023-03-30 Thread David Sebek
Correction: The correct condition should be: #if defined(CONFIG_RAM_ROCKCHIP_LPDDR4) The constant was renamed from CONFIG_RAM_RK3399_LPDDR4 to CONFIG_RAM_ROCKCHIP_LPDDR4 in commit 26f92be0. I accidentally copy-pasted the wrong value in my previous email. On Thu, Mar 30, 2023 at 4:14 PM Simon Glas

[PATCH 22/38] pci: Support autoconfig in SPL

2023-03-30 Thread Simon Glass
Allow PCI autoconfig to be handled in SPL, so that we can set it up correctly for boards which need to do this before U-Boot proper. This includes qemu-x64_64 which needs to set up the video device while in 32-bit mode. Signed-off-by: Simon Glass --- drivers/pci/Kconfig | 8 driv

[PATCH 12/38] bdinfo: Show the RAM top and approximate stack pointer

2023-03-30 Thread Simon Glass
These are useful pieces of information when debugging. The RAM top shows where U-Boot started allocating memory from, before it relocated. The stack pointer can be checked to ensure it is in the correct region. Signed-off-by: Simon Glass --- cmd/Kconfig | 8 cmd/bdinfo.c | 5 + 2

[PATCH 29/38] pci: Mask the ROM address in case it is already enabled

2023-03-30 Thread Simon Glass
In some cases the video ROM may have been enabled previously, such as by a previous firmware stage. Use the correct address in that case. Signed-off-by: Simon Glass --- drivers/pci/pci_rom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci_rom.c b/drivers/pci/pci_rom.c index

[PATCH 27/38] x86: Init video in SPL if enabled

2023-03-30 Thread Simon Glass
When video is required in SPL, set this up ready for use. Ignore any problems since it may be that video is not actually available and we still want to continue on to U-Boot proper in that case. Make sure that the SPL banner is only shown once. Signed-off-by: Simon Glass --- arch/x86/lib/spl.c

[PATCH 37/38] sandbox: Install ACPI tables on startup

2023-03-30 Thread Simon Glass
With x86 we set up the ACPI tables on startup so they can be examined. Do the same with sandbox, so it is consistent. Signed-off-by: Simon Glass --- board/sandbox/sandbox.c | 16 1 file changed, 16 insertions(+) diff --git a/board/sandbox/sandbox.c b/board/sandbox/sandbox.c in

[PATCH 38/38] efi: Use the installed ACPI tables

2023-03-30 Thread Simon Glass
U-Boot sets up the ACPI tables during startup. Rather than creating a new set, install the existing ones. Create a memory-map record to cover the tables. Signed-off-by: Simon Glass --- lib/efi_loader/efi_acpi.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletio

[PATCH 36/38] sandbox: Correct header order in board file

2023-03-30 Thread Simon Glass
Fix the header order in this file. Signed-off-by: Simon Glass --- board/sandbox/sandbox.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/sandbox/sandbox.c b/board/sandbox/sandbox.c index 2e44bdf0df3e..e72d8164ebf6 100644 --- a/board/sandbox/sandbox.c +++ b/board

[PATCH 35/38] x86: Record the start and end of the tables

2023-03-30 Thread Simon Glass
The ACPI tables are special in that they are passed to EFI as a separate piece, independent of other tables. Also they can be spread over two areas of memory, e.g. with QEMU we end up with tables kept in high memory as well. Add new global_data fields to hold this information and update the bdinf

[PATCH 13/38] part: Allow setting the partition-table type

2023-03-30 Thread Simon Glass
Some devices have multiple partition types available on the same media. It is sometimes useful to see these to check that everything is working correctly. Provide a way to manually set the partition-table type, avoiding the auto-detection process. Signed-off-by: Simon Glass --- cmd/part.c

[PATCH 05/38] x86: Tidy up EFI code in interrupt_init()

2023-03-30 Thread Simon Glass
The ll_boot_init() check handles the EFI case so we don't need the rest of the code. Drop it. Signed-off-by: Simon Glass --- arch/x86/cpu/i386/interrupt.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/arch/x86/cpu/i386/interrupt.c b/arch/x86/cpu/i386/int

RISC-V FIT image type

2023-03-30 Thread Simon Glass
Hi, I notice that in image.h we have IH_ARCH_RISCV but no mention of IH_ARCH_RISCV64. Should we not have two separate image types, as we do with ARM and x86? Otherwise, how would a loader know the word size of the target machine? Regards, Simon

[PATCH 34/38] x86: Enable useful options for qemu-86_64

2023-03-30 Thread Simon Glass
This build can be used to boot standard distro builds, since these are mostly 64-bit these days. Enable some more options, so that all possible EFI UUIDs are decoded, we get a proper printf() in SPL, can search memory for tables, support the full set of standard-boot features, have full logging and

[PATCH 33/38] fs: fat: Support reading from a larger block size

2023-03-30 Thread Simon Glass
At present it is not possible to read from some CDROM drives since the FAT sector size does not match the media's block size. Add a conversion option for this, so that reading is possible. This does increase SPL size for read-only FAT support by 25 bytes but all but 6 are covered by the previous p

[PATCH 32/38] fs: fat: Shrink the size of a few strings

2023-03-30 Thread Simon Glass
To save a few bytes, replace Error with ** and try to use the same string for multiple messages where possible. Signed-off-by: Simon Glass --- fs/fat/fat.c | 12 ++-- fs/fat/fat_write.c | 14 -- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/fs/fat/fa

[PATCH 30/38] x86: Enable display for QEMU 64-bit

2023-03-30 Thread Simon Glass
Enable the various options needed for display to work on the qemu-x86_64 board. This includes expanding the available malloc() memory in SPL, since the PCI bus must be enumerated in order to find the video device. It also includes enabling a bloblist, so that the video parameters can be passed. Th

[PATCH 31/38] x86: Allow logging to be used in SPL reliably

2023-03-30 Thread Simon Glass
When global_data is relocated, log_head moves in memory, meaning that the items in that list point to the wrong place. Disable logging when making the change, then reenable it afterwards, so that logging works normally. Signed-off-by: Simon Glass --- arch/x86/lib/spl.c | 13 + 1 fi

[PATCH 28/38] pci: Adjust video BIOS debugging to be SPL-friendly

2023-03-30 Thread Simon Glass
A hex value is expected for the VGA mode. Drop the 0x prefix, which is not supported in SPL. Signed-off-by: Simon Glass --- drivers/pci/pci_rom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci_rom.c b/drivers/pci/pci_rom.c index ecb6da64c5c9..62cfe60c0fb

[PATCH 26/38] x86: Pass video settings from SPL to U-Boot proper

2023-03-30 Thread Simon Glass
When video is set up in SPL, U-Boot proper needs to use the correct parameters so it can write to the display. Put these in a bloblist so they are available to U-Boot proper. Signed-off-by: Simon Glass --- drivers/pci/pci_rom.c | 78 +++ include/bloblist

[PATCH 25/38] x86: Allow video-BIOS code to be built for SPL

2023-03-30 Thread Simon Glass
With qemu-x86_64 we need to run the video BIOS while in 32-bit mode, i.e. SPL. Add a Kconfig option for this, adjust the Makefile rules and use CONFIG_IS_ENABLED() where needed. Signed-off-by: Simon Glass --- arch/x86/lib/Makefile | 7 --- arch/x86/lib/bios.c | 2 +- drivers/pci/pci_rom

[PATCH 23/38] pci: Allow the video BIOS to work in SPL with QEMU

2023-03-30 Thread Simon Glass
QEMU emulates two common machines (Q35 and i440fx) which use mapping to determine whether RAM is present below 1MB. In order to copy the video BIOS to c we need to flip this mapping over to RAM. This does not happen automatically until SPL has finished running. Switch in RAM at these address s

[PATCH 24/38] pci: Tidy up logging and reporting for video BIOS

2023-03-30 Thread Simon Glass
When running the ROM the code is not very helpful when something goes wrong. Add a little more debugging and some logging of return values to improve this. Signed-off-by: Simon Glass --- drivers/pci/pci_rom.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH 21/38] nvme: Provide more useful debugging messages

2023-03-30 Thread Simon Glass
When scanning fails it is useful to be able to decode what went wrong. Add some debugging for this. Signed-off-by: Simon Glass --- drivers/nvme/nvme.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nv

[PATCH 19/38] x86: Improve the trampoline in 64-bit mode

2023-03-30 Thread Simon Glass
At present this leaves the stack at the pre-relocation value. This is not ideal since we want to have U-Boot running entirely from the top of memory. In addition, the new global_data pointer is not actually used, since the global_data pointer itself is relocated, then the pre-relocation value is c

[PATCH 20/38] Show the malloc base with the bdinfo command

2023-03-30 Thread Simon Glass
It is useful to see the base of the malloc region. This is visible when debugging but not in normal usage. Add it to the global data so that it can be shown. Signed-off-by: Simon Glass --- cmd/bdinfo.c | 1 + common/board_r.c | 7 --- include/asm-gen

[PATCH 18/38] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-03-30 Thread Simon Glass
The CMD_EFIDEBUG option enables debugging so it is reasonable to assume that all effects should be made to decode the dreaded UUIDs favoured by UEFI. Update the table to show them all when CONFIG_CMD_EFIDEBUG is enabled. Signed-off-by: Simon Glass --- lib/uuid.c | 2 +- 1 file changed, 1 inser

[PATCH 17/38] qfw: Set the address of the ACPI tables

2023-03-30 Thread Simon Glass
Once the ACPI tables have been set up, record their address so that it is possible to list them with 'acpi list'. Signed-off-by: Simon Glass --- drivers/misc/qfw.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/misc/qfw.c b/drivers/misc/qfw.c index 9ef95caa8956..0a93feeb4b2e 10

[PATCH 16/38] video: Allow building video drivers for SPL

2023-03-30 Thread Simon Glass
Update the Makefile rules to allow video drivers in SPL. This is useful for 64-bit QEMU on x86, since the video BIOS can only be run from 32-bit mode (i.e. in SPL). Signed-off-by: Simon Glass --- drivers/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/Make

[PATCH 14/38] qfw: Show the file address if available

2023-03-30 Thread Simon Glass
Some files have an associated address. Show this with the 'qfw list' command so that it is possible to dump the data. Signed-off-by: Simon Glass --- cmd/qfw.c | 2 +- doc/usage/cmd/qfw.rst | 28 2 files changed, 17 insertions(+), 13 deletions(-) diff -

[PATCH 15/38] log: Tidy up an ambiguous comment.

2023-03-30 Thread Simon Glass
Add a a bit more detail so it is clear that multiple devices are supported, but only one per driver. Signed-off-by: Simon Glass --- common/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/log.c b/common/log.c index 7cfc49bc28a5..ec33b62e8a6f 100644 --- a/common/l

[PATCH 11/38] acpi: Add a comment to set the acpi tables

2023-03-30 Thread Simon Glass
Sometimes a previous bootloader has written ACPI tables. It is useful to be able to find and list these. Add an 'acpi set' command to set the address for these tables. Signed-off-by: Simon Glass --- cmd/acpi.c | 24 +--- doc/usage/cmd/acpi.rst | 29 ++

[PATCH 07/38] x86: Add a comment for board_init_f_r_trampoline()

2023-03-30 Thread Simon Glass
Add a comment for this function in the header. Change the function (and the one after) to use __noreturn to keep checkpatch happy. Signed-off-by: Simon Glass --- arch/x86/include/asm/u-boot-x86.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/as

[PATCH 10/38] x86: Show an error when a BINS exception occurs

2023-03-30 Thread Simon Glass
Rather than silently hanging, show an error first. This can happen when there is something wrong with the video BIOS. Signed-off-by: Simon Glass --- arch/x86/lib/bios.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/lib/bios.c b/arch/x86/lib/bios.c index 94349ba8

[PATCH 09/38] x86: Correct get_sp() implementation for 64-bit

2023-03-30 Thread Simon Glass
Use an assembler implementation as is done for i386, so that the results are equivalent. Signed-off-by: Simon Glass --- arch/x86/lib/bootm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/bootm.c b/arch/x86/lib/bootm.c index 61cb7bc61168..3196f9ddc2c8 100644 --

[PATCH 06/38] x86: Set high bits of the mtrr base registrer

2023-03-30 Thread Simon Glass
Linux expects all the high bits to be set, not just those needed for the CPU. Ignore the number of CPU bits and set them all. Signed-off-by: Simon Glass --- arch/x86/cpu/mtrr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/cpu/mtrr.c b/arch/x86/cpu/mtrr.c index 1b5f24aab317..bde84

[PATCH 08/38] x86: Show the CPU physical address size with bdinfo

2023-03-30 Thread Simon Glass
This is useful information so show it with the bdinfo command. Signed-off-by: Simon Glass --- arch/x86/lib/bdinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/lib/bdinfo.c b/arch/x86/lib/bdinfo.c index 15390070fe85..0970efa4726f 100644 --- a/arch/x86/lib/bdinfo.c +++ b/arch/x8

[PATCH 04/38] bios_emulator: Drop VIDEO_IO_OFFSET

2023-03-30 Thread Simon Glass
This is always zero in the source tree, so drop it. While we are here, add a comment to _X86EMU_env since it the symbol is actually defined twice, which can cause confusion when building. Signed-off-by: Simon Glass --- drivers/bios_emulator/biosemui.h | 18 +- drivers/

[PATCH 03/38] bios_emulator: Add Kconfig and adjust Makefile for SPL

2023-03-30 Thread Simon Glass
The Kconfig for this is currently inside a particular board. Move it into the correct place and allow use in SPL, so that video can be used there if needed. Signed-off-by: Simon Glass --- board/google/Kconfig | 7 --- drivers/Kconfig | 2 ++ drivers/Makefile

[PATCH 02/38] x86: Allow listing MTRRs in SPL

2023-03-30 Thread Simon Glass
When using video in SPL it is useful to see the values of the MTRR registers. Move this code into a shared file, so it can be called from SPL easily. Signed-off-by: Simon Glass --- arch/x86/cpu/mtrr.c | 61 + arch/x86/include/asm/mtrr.h | 20 +

[PATCH 01/38] x86: Tidy up availability of string functions

2023-03-30 Thread Simon Glass
For now, just enable the fast-but-large string functions in 32-boot U-Boot proper only. Avoid using them in SPL. We cannot use then in 64-bit builds since we only have 32-bit assembly. Signed-off-by: Simon Glass --- arch/x86/include/asm/string.h | 6 +- arch/x86/lib/Makefile | 4 +++

Please pull u-boot-dm

2023-03-30 Thread Simon Glass
Hi Tom, https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/15825 The following changes since commit 565681e596381b5b6db59cf06931e698f2d829e5: imx6sx-udoo-neo-basic: Introduce the u-boot.dtsi (2023-03-28 10:58:16 -0400) are available in the Git repository at: git://git.denx.de/

[PATCH v5 7/8] bootstd: Report missing labels only when asked

2023-03-30 Thread Simon Glass
Use the -l flag to indicate whether to report missing uclasses. Also try to be more helpful when no devices are found. For example, when we see something 'scsi0' requested and nothing was found, this indicates that there are no SCSI devices, so show a suitable message. Move messages out of the lo

[PATCH v5 6/8] bootstd: Show a message sometimes if no bootflows are found

2023-03-30 Thread Simon Glass
Enable some messages that might provide hints, but only for CMD_BOOTFLOW_FULL since otherwise the -l flag is not available. Signed-off-by: Simon Glass --- (no changes since v1) cmd/bootflow.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmd/bootflow.c b/cmd/bootflow.c index 42f6e14a4

[PATCH v5 4/8] rockchip: Move to standard boot

2023-03-30 Thread Simon Glass
Drop the distro-boot scripts and use standard boot instead. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Add back BOOT_TARGETS Changes in v3: - Update rk3588 boards too Changes in v2: - Add new patch to move rockchip to standard boot include/configs/px30_common.h

[PATCH v5 5/8] rockchip: Use the same boot_targets for all boards

2023-03-30 Thread Simon Glass
It doesn't really matter if we mention things which are not present. For example, if 'nvme' is included but the board does not support it, we get a message like: Unknown uclass 'nvme' in label This seems tolerable. If it creates confusion we could perhaps find a way to avoid the message, e.g.

[PATCH v5 3/8] bootstd: Support booting EFI where multiple options exist

2023-03-30 Thread Simon Glass
The current EFI implementation has a strange quirk where it watches loaded files and uses the last-loaded file to determine the device that is being booted from. This is confusing with bootstd, where multiple options may exist. Even loading a device tree will cause it to go wrong. There is no API

[PATCH v5 2/8] virtio: Ensure PCI is set up first

2023-03-30 Thread Simon Glass
Sometimes virtio may rely on PCI, or at least that is what the distro_bootcmd script suggests. Add this in. Signed-off-by: Simon Glass --- Changes in v5: Add new patch to ensure PCI is set up first drivers/virtio/virtio-uclass.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers

[PATCH v5 1/8] bootstd: Tweak bootflow logic for device tree

2023-03-30 Thread Simon Glass
We should only store the FDT filename if we were unable to determine one. Adjust the logic for this. This corrects the case where no FDT is needed to boot, such as with EFI using ACPI. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to tweak bootflow logic for device tree boot/b

Re: Missed rename of CONFIG_RAM_RK3399_LPDDR4

2023-03-30 Thread Jagan Teki
On Fri, Mar 31, 2023 at 2:13 AM David Sebek wrote: > > Correction: The correct condition should be: > #if defined(CONFIG_RAM_ROCKCHIP_LPDDR4) > > The constant was renamed from CONFIG_RAM_RK3399_LPDDR4 to > CONFIG_RAM_ROCKCHIP_LPDDR4 in commit 26f92be0. I accidentally copy-pasted the > wrong valu

[RFC PATCH v7 17/23] test: hush: Fix variable expansion tests for hush 2021

2023-03-30 Thread Francis Laniel
Modifies the expected result for hush 2021. Indeed, there were bugs in actual U-Boot hush which were fixed in upstream Busybox. As hush 2021 is based on upstream Busybox, these bugs no longer exist. Signed-off-by: Francis Laniel --- test/hush/dollar.c | 79 +++

Re: WIP: Signing TI x509 certificates using binman

2023-03-30 Thread Simon Glass
Hi Neha, On Fri, 24 Mar 2023 at 22:28, Neha Malcom Francis wrote: > > Hi Simon, > > Before I roll out the entire series that works for packaging K3 > bootloader images, wanted to get some reviews and comments regarding the > implementation of the signing etype [1] . I believe I've taken into > co

[PATCH 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-03-30 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 51 - ar

[PATCH 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-03-30 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach/sys_proto.h | 10 -- arch/arm/mac

[PATCH 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-03-30 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c| 64 +++

[PATCH 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-03-30 Thread Andrew Davis
The MSMC fixup is something we do based on SoC, not based on the board. So this fixup does not belong in the board files. Move this to the mach-k3 common file so that it does not have to be done in each board that uses these SoCs. We use ft_system_setup() here instead of ft_board_setup() since it

[PATCH 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-03-30 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654-ddrss.c | 4 2 fil

[PATCH 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-03-30 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files changed, 10 insertions(+), 22 deleti

[PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-03-30 Thread Andrew Davis
This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need to check for TI_I2C_BOARD_DETECT before calling this function, which might not be the right guard ifdef should a board use a different method for board

[PATCH 04/12] configs: j721x_evm.h: Remove unneeded check for SYS_K3_SPL_ATF

2023-03-30 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis --- include/configs/j721e_evm.h | 4 +--- include/configs/j721s2_evm.h | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-03-30 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common

[PATCH 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-03-30 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c | 2 +- arch/arm/mach-k3

  1   2   3   >