Re: [PATCH 07/38] x86: Add a comment for board_init_f_r_trampoline()

[Heinrich Schuchardt]

Am 30. März 2023 23:31:56 MESZ schrieb Simon Glass <s...@chromium.org>:
>Add a comment for this function in the header.
>
>Change the function (and the one after) to use __noreturn to keep
>checkpatch happy.
>
>Signed-off-by: Simon Glass <s...@chromium.org>
>---
>
> arch/x86/include/asm/u-boot-x86.h | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/include/asm/u-boot-x86.h 
>b/arch/x86/include/asm/u-boot-x86.h
>index 8f38c2d1c601..1610d7237bcd 100644
>--- a/arch/x86/include/asm/u-boot-x86.h
>+++ b/arch/x86/include/asm/u-boot-x86.h
>@@ -102,8 +102,14 @@ int video_bios_init(void);
>  */
> int fsp_save_s3_stack(void);
> 
>-void  board_init_f_r_trampoline(ulong) __attribute__ ((noreturn));
>-void  board_init_f_r(void) __attribute__ ((noreturn));
>+/**
>+ * board_init_f_r_trampoline() - jump to relocated address with new stack
>+ *
>+ * @sp: New stack pointer to use
>+ */
>+void __noreturn board_init_f_r_trampoline(ulong sp);
>+

missing function description

>+void __noreturn board_init_f_r(void);
> 

ditto

> int arch_misc_init(void);
>