Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Pali Rohár
On Wednesday 22 February 2023 11:59:35 Martin Rowe wrote: > A388 Clearfog Base (SD card model): > - MMC from SD card works > - UART works > - SATA with new defconfig works > - SPI (if you select MVEBU_SPL_BOOT_DEVICE_SPI yourself) works > A388 Clearfog Pro (eMMC model): > - MMC from eMMC works, but

Re: [PATCH RFC u-boot-mvebu 20/59] cmd: mvebu/bubt: Add support for selecting eMMC HW partition

2023-02-22 Thread Pali Rohár
On Thursday 23 February 2023 07:17:26 Stefan Roese wrote: > Hi Pali, > > On 2/22/23 19:06, Pali Rohár wrote: > > On Wednesday 22 February 2023 10:55:54 Stefan Roese wrote: > > > Hi Pali, > > > > > > On 2/21/23 21:18, Pali Rohár wrote: > > > > Support for burning into the correct eMMC HW boot part

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Pali Rohár
On Wednesday 22 February 2023 16:17:32 Tony Dinh wrote: > Hi Pali, > > On Wed, Feb 22, 2023 at 3:40 PM Pali Rohár wrote: > > > > On Wednesday 22 February 2023 15:16:06 Tony Dinh wrote: > > > Hi Pali, > > > > > > On Wed, Feb 22, 2023 at 3:06 PM Pali Rohár wrote: > > > > > > > > On Wednesday 22 Fe

Re: [PATCH] efi_loader: efi_allocate_pages: check parameter pages

2023-02-22 Thread Heinrich Schuchardt
On 2/20/23 09:46, Peng Fan wrote: On 2/20/2023 4:08 AM, Heinrich Schuchardt wrote: On 2/16/23 11:53, Peng Fan (OSS) wrote: From: Peng Fan On i.MX8MM-EVK, when doing UEFI Capsule On Disk, we met such issue, It will create Boot option for capsule on disk: Boot: VenHw(E61D73B9-A384-4ACC-AE

Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

2023-02-22 Thread Miquel Raynal
Hello Marek & Ralph, marek.va...@mailbox.org wrote on Thu, 23 Feb 2023 01:12:49 +0100: > On 2/22/23 20:32, Ralph Siemsen wrote: > > On Wed, Feb 22, 2023 at 07:45:45PM +0100, Marek Vasut wrote: > >> On 2/22/23 19:32, Ralph Siemsen wrote: > >>> On Wed, Feb 22, 2023 at 06:47:44PM +0100, Marek Va

[PATCH] lib: bzip2: remove inlining

2023-02-22 Thread Heinrich Schuchardt
Compiling sandbox_defconfig with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y and gcc 12.2.0-14ubuntu1 leads to a build error: lib/bzip2/bzlib.c: In function 'BZ2_decompress': lib/bzip2/bzlib.c:726:18: error: inlining failed in call to 'always_inline' 'BZ2_indexIntoF': function not considered for in

Re: [PATCH v6 6/6] doc: Add measured boot documentation

2023-02-22 Thread Ilias Apalodimas
Hi Heinrich, [...] > >+ > >+Measured Boot > >+= > > This completely misses o describe measured boot with UEFI. > > @Ilias, do you want to add that in a follow up patch? Yes, I'll do that once I pull Eddie's patches Cheers /Ilias > > >+ > >+U-Boot can perform a measured boot,

Re: Boot from 64-bit memory address?

2023-02-22 Thread Conor Dooley
On 23 February 2023 01:21:01 GMT, "Bernard, Philip" wrote: >Hi, > >Is it possible to boot from a DRAM memory address beyond the 32-bit boundary? >I'm trying to configure a new RISC-V board which has 2GB of DRAM starting at >offset 0x40__. I started from the settings for an existing R

Re: [PATCH v3 65/95] omap: Correct an SPL build error with watchdog

2023-02-22 Thread Stefan Roese
Hi Simon & Tom, On 2/22/23 20:16, Simon Glass wrote: Hi Tom, On Tue, 14 Feb 2023 at 09:43, Tom Rini wrote: On Tue, Feb 14, 2023 at 11:34:47AM -0500, Tom Rini wrote: On Sun, Feb 12, 2023 at 04:16:08PM -0700, Simon Glass wrote: The logic here is strange since the call to hw_watchdog_init() d

Re: [PATCH RFC u-boot-mvebu 20/59] cmd: mvebu/bubt: Add support for selecting eMMC HW partition

2023-02-22 Thread Stefan Roese
Hi Pali, On 2/22/23 19:06, Pali Rohár wrote: On Wednesday 22 February 2023 10:55:54 Stefan Roese wrote: Hi Pali, On 2/21/23 21:18, Pali Rohár wrote: Support for burning into the correct eMMC HW boot partition was broken and removed in commit 96be2f072768 ("mvebu: bubt: Drop dead code"). Reimp

Re: [PATCH v5 30/44] lib: Add an SPL config for LIB_UUID

2023-02-22 Thread Heinrich Schuchardt
Am 22. Februar 2023 17:34:11 MEZ schrieb Simon Glass : >This is selected by PARTITION_UUIDS which has a separate option for SPL. >Add an SPL option for LIB_UUID also, so that we can keep them consistent. > >Also add one for PARTITION_TYPE_GUID to avoid a build error in part_efi.c >which wants to

[PATCH] powerpc/mpc85xx: disable legacy format booting

2023-02-22 Thread Heiko Schocher
disable CONFIG_LEGACY_IMAGE_FORMAT so prevent of booting not signed fitimages. Signed-off-by: Heiko Schocher --- configs/socrates_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/socrates_defconfig b/configs/socrates_defconfig index 24655131a8..df8b31b4e7 100644 --- a/config

Re: [PATCH RFC 0/3] FMP versioning support

2023-02-22 Thread Heinrich Schuchardt
Am 22. Februar 2023 11:40:33 MEZ schrieb Masahisa Kojima : >This series aims to add the versioning support >in FMP protocol implementation. > >EDK2 reference implementation utilizes the FMP Payload Header >inserted right before the capsule payload. With this series, >U-Boot also follows the EDK

Re: [PATCH v5 25/44] sandbox: Tidy up I2C options

2023-02-22 Thread Heiko Schocher
Hello Simon, On 22.02.23 17:34, Simon Glass wrote: > At present we enable the sandbox I2C driver for all builds. Add a separate > Kconfig option to control this, so that it can be disabled in TPL, where > it is not needed. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > dri

Re: [PATCH RFC u-boot-mvebu 15/59] tools: kwboot: Fix parsing UART image without data checksum

2023-02-22 Thread Tony Dinh
Hi Pali, On Tue, Feb 21, 2023 at 12:22 PM Pali Rohár wrote: > > The 32-bit data checksum in UART image is not checked by the BootROM and > also Marvell tools do not generate it. > > So if data checksum stored in UART image does not match calculated checksum > from the image then treat those check

Re: [PULL] u-boot-usb/next

2023-02-22 Thread Marek Vasut
On 2/23/23 02:50, Tom Rini wrote: On Wed, Feb 22, 2023 at 11:09:00PM +0100, Marek Vasut wrote: On 2/22/23 19:37, Tom Rini wrote: On Wed, Feb 22, 2023 at 04:36:08PM +0100, Marek Vasut wrote: The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: Merge tag 'efi-2023-

[PATCH] usb: dwc3-uniphier: Imply PHY

2023-02-22 Thread Marek Vasut
Make sure the PHY subsystem is activated for the uniphier DWC3 glue logic, as it depends on PHY implementation there. Signed-off-by: Marek Vasut --- Cc: Kunihiko Hayashi Cc: Tom Rini --- drivers/usb/dwc3/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/Kconfig b/dri

Re: [PATCH v4 2/4] rockchip: Use an external TPL binary on RK3568

2023-02-22 Thread Kever Yang
Hi Jonas, Simon,     I got below error in buildman with BINMAN_ALLOW_MISSING=1 Building current source for 1 boards (1 thread, 16 jobs per thread)    aarch64:  +   evb-rk3568 +binman: Filename 'rockchip-tpl' bbb not found in input path (.,/home/kever/src/u-boot,board/rockchip/evb_rk3568,arch/ar

Re: [PATCH v1 1/1] tools: env: use /run to store lockfile

2023-02-22 Thread Tom Rini
On Thu, Feb 23, 2023 at 01:06:20AM +, chl...@nuvoton.com wrote: > Hi Tom, > > Is this commit valuable to merge into u-boot upstream? > Thanks your reviewing, just ping this event friendly. Yes, I'll be putting this in next soon, thanks. > > Best regards, > Tim > > -Original Message---

Boot from 64-bit memory address?

2023-02-22 Thread Bernard, Philip
Hi, Is it possible to boot from a DRAM memory address beyond the 32-bit boundary? I'm trying to configure a new RISC-V board which has 2GB of DRAM starting at offset 0x40__. I started from the settings for an existing RISC-V board and made adjustments for my HW, but when I try to boot,

RE: [PATCH v1 1/1] tools: env: use /run to store lockfile

2023-02-22 Thread chl...@nuvoton.com
Hi Tom, Is this commit valuable to merge into u-boot upstream? Thanks your reviewing, just ping this event friendly. Best regards, Tim -Original Message- From: Tom Rini Sent: Friday, February 10, 2023 11:30 PM To: Tim Lee Cc: s...@chromium.org; CS20 CHLi30 ; u-boot@lists.denx.de Subjec

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 14:33, Troy Kisky wrote: > > Hi Simon > > So how is this ? > diff --git a/arch/x86/cpu/apollolake/uart.c b/arch/x86/cpu/apollolake/uart.c > index a9362436000..878aa48ed76 100644 > --- a/arch/x86/cpu/apollolake/uart.c > +++ b/arch/x86/cpu/apollolake/uart.c > @@ -79,

Re: [PULL] u-boot-usb/next

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 11:09:00PM +0100, Marek Vasut wrote: > On 2/22/23 19:37, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 04:36:08PM +0100, Marek Vasut wrote: > > > > > The following changes since commit > > > 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: > > > > > >Merge tag 'efi-2023-04-rc

Re: [PATCH v4 01/11] include: fdtdec: decouple fdt_addr_t and phys_addr_t size

2023-02-22 Thread Kever Yang
Hi Johan,     This update will cause below error on evb-ast2500/2600: $ tools/buildman/buildman -o ${UBOOT_TRAVIS_BUILD_DIR} -w -E -W -e --board ${TEST_PY_BD} ${OVERRIDE} Building current source for 1 boards (1 thread, 24 jobs per thread)    arm:  +   evb-ast2600 +drivers/spi/spi-aspeed-sm

Re: [PATCH v4 1/1] arm64: dts: rockchip: rk3568: Add Radxa ROCK 3 Model A board support

2023-02-22 Thread Vasily Khoruzhick
On Tue, Feb 14, 2023 at 12:11 PM Akash Gajjar wrote: Hi Akash, > Add Radxa ROCK 3 Model A support. sync rk3568-rock-3a.dts from Linux 6.2.0-rc7 > > Board Specifications > - Rockchip RK3568 > - 2/4/8GB LPDDR4 3200MT/s > - eMMC socket, SD card slot Have you actually tested eMMC support? It seems

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Tony Dinh
Hi Pali, On Wed, Feb 22, 2023 at 3:40 PM Pali Rohár wrote: > > On Wednesday 22 February 2023 15:16:06 Tony Dinh wrote: > > Hi Pali, > > > > On Wed, Feb 22, 2023 at 3:06 PM Pali Rohár wrote: > > > > > > On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote: > > > > Hi Pali, > > > > > > > > On Tu

Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

2023-02-22 Thread Marek Vasut
On 2/22/23 20:32, Ralph Siemsen wrote: On Wed, Feb 22, 2023 at 07:45:45PM +0100, Marek Vasut wrote: On 2/22/23 19:32, Ralph Siemsen wrote: On Wed, Feb 22, 2023 at 06:47:44PM +0100, Marek Vasut wrote: Are those fixes in mainline Linux ? Yes, they are in mainline: 2dee50ab9e72 clk: renesas: r9

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Pali Rohár
On Wednesday 22 February 2023 15:16:06 Tony Dinh wrote: > Hi Pali, > > On Wed, Feb 22, 2023 at 3:06 PM Pali Rohár wrote: > > > > On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote: > > > Hi Pali, > > > > > > On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár wrote: > > > > > > > > On Tuesday 21 Feb

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Tony Dinh
Hi Pali, On Wed, Feb 22, 2023 at 3:06 PM Pali Rohár wrote: > > On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote: > > Hi Pali, > > > > On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár wrote: > > > > > > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote: > > > > Hi Pali, > > > > > > > > On Tue

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Pali Rohár
On Wednesday 22 February 2023 14:16:36 Tony Dinh wrote: > Hi Pali, > > On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár wrote: > > > > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote: > > > Hi Pali, > > > > > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár wrote: > > > > > > > > On Tuesday 21 Febru

Re: [PATCH 9/9] Makefile: Show binman missing blob message

2023-02-22 Thread Simon Glass
Hi Tom, On Wed, 22 Feb 2023 at 14:45, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 02:20:08PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 21 Feb 2023 at 16:09, Tom Rini wrote: > > > > > > On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > > > > Hi Jonas > > > > > > > > +Tom

Re: [PULL] u-boot-usb/master

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 05:27:16PM +0100, Marek Vasut wrote: > The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: > > Merge tag 'efi-2023-04-rc3' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2023-02-19 17:03:30 > -0500) > > are available in the Git reposi

Re: [PULL] u-boot-socfpga/master

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 02:04:43AM +0100, Marek Vasut wrote: > The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: > > Merge tag 'efi-2023-04-rc3' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2023-02-19 17:03:30 > -0500) > > are available in the Git reposi

Re: [PATCH 10/11] rockchip: misc: Set eth1addr mac address

2023-02-22 Thread Jonas Karlman
Hi Chen-Yu, On 2023-02-16 03:42, Chen-Yu Tsai wrote: > On Thu, Feb 16, 2023 at 7:57 AM Jonas Karlman wrote: >> >> Set eth1addr when there is an ethernet1 alias in the fdt. > > Maybe it makes sense to set it regardless whether an alias is present > or not? Makes sense, changed to always set eth1

[PATCH v2 11/12] rockchip: rk3568: Read cpuid from otp

2023-02-22 Thread Jonas Karlman
The cpuid on RK3568 is located at 0xa instead of 0x7 as all other SoCs. Add and use a CFG_CPUID_OFFSET to define this offset. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Use ifdef instead of undef - Collect r-b tag arch/arm/dts/rk356x-u-boot.dtsi | 12 arch/ar

[PATCH v2 12/12] rockchip: rk3588: Read cpuid from otp

2023-02-22 Thread Jonas Karlman
Read cpuid from otp and set ethaddr for RK3588. Signed-off-by: Jonas Karlman --- v2: - New patch arch/arm/dts/rk3588s-u-boot.dtsi | 12 arch/arm/mach-rockchip/Kconfig | 2 ++ 2 files changed, 14 insertions(+) diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-

[PATCH v2 10/12] rockchip: misc: Set eth1addr mac address

2023-02-22 Thread Jonas Karlman
Set eth1addr in addition to ethaddr. Also allow fdt fixup of ethernet mac addresses when CMD_NET is disabled. Set ethaddr and eth1addr based on HASH and SHA256 options. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Always set eth1addr along with ethaddr - Collect r-b tag arch

[PATCH v2 07/12] rockchip: efuse: Add support for RK3328

2023-02-22 Thread Jonas Karlman
Add support for rk3328 compatible. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Collect r-b tag drivers/misc/rockchip-efuse.c | 45 +++ 1 file changed, 45 insertions(+) diff --git a/drivers/misc/rockchip-efuse.c b/drivers/misc/rockchip-efuse.c

[PATCH v2 05/12] rockchip: efuse: Refactor to use driver data and ops

2023-02-22 Thread Jonas Karlman
Refactor the driver to use driver data and ops to simplify handling of SoCs that require a unique read op. Move handling of the aligned bounce buffer to main read op in order to keep the SoC unique read op simple. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Print 4 bytes inst

[PATCH v2 06/12] rockchip: efuse: Add support for RK3288 and more

2023-02-22 Thread Jonas Karlman
Add support for rk3066a, rk3188, rk322x and rk3288 compatible. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Use readl instead of readb - Collect r-b tag drivers/misc/Kconfig | 4 --- drivers/misc/rockchip-efuse.c | 68 ++- 2 files cha

[PATCH v2 09/12] rockchip: efuse: Add support for RK3036

2023-02-22 Thread Jonas Karlman
Add support for rk3036 compatible. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Use readl instead of readb - Collect r-b tag drivers/misc/rockchip-efuse.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/misc/rockchip-efuse.c b/

[PATCH v2 03/12] rockchip: otp: Add support for RK3588

2023-02-22 Thread Jonas Karlman
Add support for rk3588 compatible. Adjust offset using driver data in main read op. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Collect r-b tag drivers/misc/rockchip-otp.c | 63 + 1 file changed, 57 insertions(+), 6 deletions(-) diff --g

[PATCH v2 08/12] rockchip: efuse: Add support for RK3128

2023-02-22 Thread Jonas Karlman
Add support for rk3128 compatible. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Use readl instead of readb - Collect r-b tag drivers/misc/rockchip-efuse.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/misc/rockchip-efuse.c b/

[PATCH v2 01/12] rockchip: otp: Refactor to use driver data and ops

2023-02-22 Thread Jonas Karlman
Refactor the driver to use driver data and ops to simplify handling of SoCs that require a unique read op. Use readl_poll_sleep_timeout instead of a custom poll loop, and add validation of input parameter to main read op. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Use readl

[PATCH v2 04/12] rockchip: otp: Add dump_otp debug command

2023-02-22 Thread Jonas Karlman
Add a simple debug command to dump the content of the otp. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Print 4 bytes instead of one 32-bit word - Collect r-b tag drivers/misc/rockchip-otp.c | 35 +++ 1 file changed, 35 insertions(+) diff --gi

[PATCH v2 00/12] rockchip: Add efuse and otp support to more SoCs

2023-02-22 Thread Jonas Karlman
This series refactors and add support for more SoCs to the rockchip efuse and otp driver. Support is added for the following SoCs: - efuse: RK3036, RK3066, RK3128, RK3188, RK3228, RK3288 and RK3328 - otp: RK3568 and RK3588 This also changes so that eth1addr is also set along with ethaddr. And a s

[PATCH v2 02/12] rockchip: otp: Add support for RK3568

2023-02-22 Thread Jonas Karlman
Add support for rk3568 compatible. Handle allocation of an aligned bounce buffer in main read op in order to keep the SoC unique read op simple. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- v2: - Use readl instead of readw - Collect r-b tag drivers/misc/rockchip-otp.c | 67 +++

Re: [PATCH v1 05/24] lib: sha256: prepare for CONFIG_IS_ENABLED changes

2023-02-22 Thread Troy Kisky
OK, I'll try that. BR Troy On Wed, Feb 22, 2023 at 1:20 PM Simon Glass wrote: > On Tue, 21 Feb 2023 at 18:38, Troy Kisky > wrote: > > > > We need to include in order to include > > files that use CONFIG_IS_ENABLED. TO prepare for that > > don't pet the watchdog when USE_HOSTCC is defined. >

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Tony Dinh
Hi Pali, On Tue, Feb 21, 2023 at 11:58 PM Pali Rohár wrote: > > On Tuesday 21 February 2023 21:45:07 Tony Dinh wrote: > > Hi Pali, > > > > On Tue, Feb 21, 2023 at 3:14 PM Pali Rohár wrote: > > > > > > On Tuesday 21 February 2023 15:06:16 Tony Dinh wrote: > > > > Hi Pali, > > > > > > > > On Tue,

Re: [PULL] u-boot-usb/next

2023-02-22 Thread Marek Vasut
On 2/22/23 19:37, Tom Rini wrote: On Wed, Feb 22, 2023 at 04:36:08PM +0100, Marek Vasut wrote: The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: Merge tag 'efi-2023-04-rc3' of https://source.denx.de/u-boot/custodians/u-boot-efi (2023-02-19 17:03:30 -0500) are ava

Re: [PATCH 9/9] Makefile: Show binman missing blob message

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 02:20:08PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 21 Feb 2023 at 16:09, Tom Rini wrote: > > > > On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > > > Hi Jonas > > > > > > +Tom Rini > > > > > > On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > >

Re: [PATCH] rockchip: dts: rk3328: fix sdram params

2023-02-22 Thread Vagrant Cascadian
On 2023-02-10, Jonas Karlman wrote: > The rk3328 sdram driver read sdram parameters from the devicetree into a > struct rk3328_sdram_params using dev_read_u32_array. > > After commit 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30") > changed the size of struct ddr_pctl_regs, a member o

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Pali Rohár
On Wednesday 22 February 2023 21:20:58 Martin Rowe wrote: > Hi > > > Could you send a patch which adds appropriate defconfig file for SPI > > boot? So this configuration would be tested in U-Boot CI automatically. > > Will do. Does it need to be the same as the other defconfigs > otherwise? I sug

Re: [PATCH v2] binman: bintool: Add support for tool directories

2023-02-22 Thread Simon Glass
Hi Neha, On Tue, 21 Feb 2023 at 21:30, Neha Malcom Francis wrote: > > Hi Simon > > On 22/02/23 01:05, Simon Glass wrote: > > Hi Neha, > > > > On Fri, 17 Feb 2023 at 04:46, Neha Malcom Francis wrote: > >> > >> Currently, bintool supports external compilable tools as single > >> executable files.

Re: [PATCH v1 22/24] power: pmic: add dm style definitions if not CONFIG_IS_ENABLED(POWER_LEGACY)

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > This avoids an error in converting to CONFIG_IS_ENABLED(DM_PMIC). > Many boards SPL code needs these definitions to compile, even if > the functions are not linked. > > Signed-off-by: Troy Kisky > --- > > include/power/pmic.h | 2 +- > 1 file c

Re: [PATCH v1 20/24] x86: cpu: i386: cpu: only set pci_ram_top if CONFIG_IS_ENABLED(PCI)

2023-02-22 Thread Simon Glass
Hi Troy, On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > This avoids an error when ifdef CONFIG_PCI is changed to > if CONFIG_IS_ENABLED(PCI) > > Signed-off-by: Troy Kisky > --- > > arch/x86/cpu/i386/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/cpu/i386/cpu.c b/

Re: [PATCH v1 06/24] lib: sha512: prepare for CONFIG_IS_ENABLED changes

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > We need to include in order to include > files that use CONFIG_IS_ENABLED. TO prepare for that > don't pet the watchdog when USE_HOSTCC is defined. > > Signed-off-by: Troy Kisky > --- > > lib/sha512.c | 12 > 1 file changed, 8 ins

Re: [PATCH v3 58/76] Drop ubsha1 tool

2023-02-22 Thread Simon Glass
Hi Peter, On Wed, 22 Feb 2023 at 01:08, Peter Robinson wrote: > > On Tue, Feb 21, 2023 at 7:42 PM Simon Glass wrote: > > > > Hi Peter, > > > > On Mon, 20 Feb 2023 at 03:16, Peter Robinson wrote: > > > > > > On Wed, Feb 1, 2023 at 8:46 PM Simon Glass wrote: > > > > > > > > This seems to have be

Re: [PATCH v1 24/24] CI: add test/usage_of_is_enabled_check.sh

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > Add script usage_of_is_enabled_check to print any configs that > use CONFIG_IS_ENABLED instead of IS_ENABLED and vice versa. > > Add usage_of_is_enabled_commit.sh to generate commits to fix the above > issues. > > You can remove entries from test

Re: [PATCH v1 03/24] lib: md5: prepare for CONFIG_IS_ENABLED changes

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > We need to include in order to include > files that use CONFIG_IS_ENABLED. TO prepare for that > don't pet the watchdog when USE_HOSTCC is defined. > > Signed-off-by: Troy Kisky > --- > > lib/md5.c | 9 +++-- > 1 file changed, 7 insertions

Re: [PATCH v1 08/24] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx

2023-02-22 Thread Simon Glass
Hi Troy, On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for > CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation. > > Signed-off-by: Troy Kisky > --- > > tools/Makefile | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH] tools: binman: minor formatting fix in docs

2023-02-22 Thread Simon Glass
On Wed, 22 Feb 2023 at 13:57, Ralph Siemsen wrote: > > This should fix a rendering oddity when viewing the docs online at > https://u-boot.readthedocs.io/en/latest/develop/package/binman.html > > Signed-off-by: Ralph Siemsen > --- > tools/binman/binman.rst | 4 ++-- > 1 file changed, 2 insertion

Re: [PATCH v1 02/24] lib: crc32: prepare for CONFIG_IS_ENABLED changes

2023-02-22 Thread Simon Glass
Hi Troy, On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > We need to include in order to include > files that use CONFIG_IS_ENABLED. TO prepare for that > be more direct with using defined(USE_HOSTCC). > > Signed-off-by: Troy Kisky > --- > > lib/crc32.c | 12 > 1 file changed,

Re: [PATCH v1 15/24] m53menlo: define ft_board_setup only if CONFIG_IS_ENABLED(OF_LIBFDT)

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > The function ft_board_setup calls do_fixup_by_path_string > which is only available on CONFIG_IS_ENABLED(OF_LIBFDT). > This prepares for the conversion. > > ft_board_setup is only called from image-fdt which is linked by > obj-$(CONFIG_$(SPL_TPL_

Re: [PATCH v1 11/24] ofnode: fdt_support definitions needed if OF_CONTROL is enabled

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > With the use of CONFIG_IS_ENABLED in code, instead of at the preprocessor > level, these defines are still needed if OF_CONTROL is enabled. > > Signed-off-by: Troy Kisky > --- > > include/fdt_support.h | 3 ++- > 1 file changed, 2 insertions(+)

Re: [PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

2023-02-22 Thread Martin Rowe
Hi > Could you send a patch which adds appropriate defconfig file for SPI > boot? So this configuration would be tested in U-Boot CI automatically. Will do. Does it need to be the same as the other defconfigs otherwise? I suggest putting the environment in SPI as well if u-boot is already there (

Re: [PATCH 9/9] Makefile: Show binman missing blob message

2023-02-22 Thread Simon Glass
Hi Tom, On Tue, 21 Feb 2023 at 16:09, Tom Rini wrote: > > On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > > Hi Jonas > > > > +Tom Rini > > > > On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > > > > > When binman is invoked during a build of U-Boot and an external blob is > >

Re: [PATCH v1 23/24] arm: cpu: armv7: ls102xa: fdt: remove eth_device support

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > commit e524f3a449f5 ("net: Remove eth_legacy.c") > > removed struct eth_device > This prevents errors in the conversion to CONFIG_IS_ENABLED(DM_ETH). > > Signed-off-by: Troy Kisky > --- > > arch/arm/cpu/armv7/ls102xa/fdt.c | 12 >

Re: [PATCH v1 13/24] puma-rk3399: remove check for ENV_IS_NOWHERE, it is an SPL config

2023-02-22 Thread Simon Glass
Hi Troy, On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to > CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors > on spl builds. > > Signed-off-by: Troy Kisky > --- > > board/theobroma-systems/puma_rk3399/puma-rk3399.c | 4 -

Re: [PATCH v1 10/24] config_distro_bootcmd: remove booting environment variables from SPL environment

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > SPL environments don't need command that they can never use. > Avoid errors with CONFIG_IS_ENABLED conversions by skipping them now. > > Signed-off-by: Troy Kisky > --- > > include/config_distro_bootcmd.h | 23 +++ > 1 file

Re: [PATCH v1 07/24] tools: prevent CONFIG_IS_ENABLED errors by including linux/kconfig.h

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > We need to include in order to include > files that use CONFIG_IS_ENABLED. > > Signed-off-by: Troy Kisky > --- > > boot/fdt_region.c | 1 + > lib/fdtdec_common.c | 1 + > lib/hash-checksum.c | 1 + > tools/env/fw_env.c | 1 + > tools/fdt_ho

Re: [RFC PATCH v3 9/9] tools: spkgimage: add Renesas SPKG format

2023-02-22 Thread Simon Glass
Hi Ralph, On Wed, 22 Feb 2023 at 14:17, Ralph Siemsen wrote: > > Hi Simon, > > Thanks for your review! > > On Wed, Feb 22, 2023 at 2:17 PM Simon Glass wrote: > > > > Can you please add some details to doc/ for this SoC and how it boots, > > the use of mkimage, etc.? > > Sure, I will cobble somet

Re: [PATCH v1 09/24] x86: cpu: qemu: qemu: remove SPL use with CONFIG_IS_ENABLED

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > CONFIG_IS_ENABLED(SPL_X86_32BIT_INIT) > would check for CONFIG_SPL_SPL_X86_32BIT_INIT for SPL builds > > Signed-off-by: Troy Kisky > --- > > arch/x86/cpu/qemu/qemu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Gl

Re: [PATCH 5/5] binman: Make the tooldir configurable

2023-02-22 Thread Simon Glass
Hi Quentin, On Mon, 20 Feb 2023 at 04:28, Quentin Schulz wrote: > > Hi Simon, > > On 2/18/23 00:19, Simon Glass wrote: > > Add a command-line argument for setting the tooldir, so that the default > > can be overridden. Add this directory to the toolpath automatically. > > Create the directory if

Re: [PATCH v1 05/24] lib: sha256: prepare for CONFIG_IS_ENABLED changes

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > We need to include in order to include > files that use CONFIG_IS_ENABLED. TO prepare for that > don't pet the watchdog when USE_HOSTCC is defined. > > Signed-off-by: Troy Kisky > --- > > lib/sha256.c | 8 ++-- > 1 file changed, 6 insertio

Re: [PATCH v1 14/24] fdt_support: always define fdt_fixup_mtdparts

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > SPL code wants fdt_fixup_mtdparts defined as a NOP > when the function isn't linked in. > > Prepare for ifdef CONFIG_OF_LIBFDT being converted to > if CONFIG_IS_ENABLED(OF_LIBFDT) > > Signed-off-by: Troy Kisky > --- > > include/fdt_support.h |

Re: [PATCH v1 16/24] freescale: common: pfuze: define pfuze_mode_init only if defined(CONFIG_DM_PMIC)

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:39, Troy Kisky wrote: > > pfuze_mode_init calls pmic_reg_read which is only available from > > obj-$(CONFIG_$(SPL_TPL_)DM_PMIC) += pmic-uclass.o > > Prepare for conversion of defined(CONFIG_DM_PMIC) to > CONFIG_IS_ENABLED(DM_PMIC). > > Signed-off-by: Troy Kisky > --- > >

Re: [PATCH v1 04/24] lib: sha1: prepare for CONFIG_IS_ENABLED changes

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > We need to include in order to include > files that use CONFIG_IS_ENABLED. TO prepare for that > don't pet the watchdog when USE_HOSTCC is defined. > > Signed-off-by: Troy Kisky > --- > > lib/sha1.c | 8 ++-- > 1 file changed, 6 insertions

Re: [PATCH v1 01/24] cmd: nvedit: check for ENV_SUPPORT

2023-02-22 Thread Simon Glass
On Tue, 21 Feb 2023 at 18:38, Troy Kisky wrote: > > Avoid error messages when SPL,TPL,VPL build don't > have the environment options of the main build. > This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed > to CONFIG_IS_ENABLED(ENV_IS_IN_xxx). > > Signed-off-by: Troy Kisky > --- > > cm

Re: [RFC PATCH v3 9/9] tools: spkgimage: add Renesas SPKG format

2023-02-22 Thread Ralph Siemsen
Hi Simon, Thanks for your review! On Wed, Feb 22, 2023 at 2:17 PM Simon Glass wrote: > > Can you please add some details to doc/ for this SoC and how it boots, > the use of mkimage, etc.? Sure, I will cobble something together. Any particular good examples to look at for inspiration? > Also as

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 14:06, Troy Kisky wrote: > > On Wed, Feb 22, 2023 at 12:41 PM Troy Kisky > wrote: >> >> >> >>> >>> How does this look ? >>> >>> diff --git a/arch/x86/cpu/apollolake/uart.c b/arch/x86/cpu/apollolake/uart.c >>> index a9362436000..da184638cb9 100644 >>> --- a/arch/x

Re: bootstd breakages

2023-02-22 Thread Simon Glass
Hi Ilias, On Tue, 21 Feb 2023 at 23:35, Ilias Apalodimas wrote: > > Hi Simon, > > Using the attached config U-Boot fails to compile. > > aarch64-linux-gnu-ld.bfd: boot/bootmeth_efi_mgr.o: in function > `efi_mgr_check': > /home/apalos/work/u-boot-tpm/boot/bootmeth_efi_mgr.c:39: undefined > refere

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Troy Kisky
On Wed, Feb 22, 2023 at 12:41 PM Troy Kisky wrote: > > > >> How does this look ? >> >> diff --git a/arch/x86/cpu/apollolake/uart.c >> b/arch/x86/cpu/apollolake/uart.c >> index a9362436000..da184638cb9 100644 >> --- a/arch/x86/cpu/apollolake/uart.c >> +++ b/arch/x86/cpu/apollolake/uart.c >> @@ -79

[PATCH] bootstd: Make BOOTSTD_FULL depend on BOOTSTD

2023-02-22 Thread Simon Glass
Move BOOTSTD_FULL down in the file so that it can be enabled only when BOOTSTD is enabled. This prevents a build error if BOOTSTD is disabled but BOOTSTD_FULL is enabled. Signed-off-by: Simon Glass --- boot/Kconfig | 26 +- 1 file changed, 13 insertions(+), 13 deletions(

[PATCH] tools: binman: minor formatting fix in docs

2023-02-22 Thread Ralph Siemsen
This should fix a rendering oddity when viewing the docs online at https://u-boot.readthedocs.io/en/latest/develop/package/binman.html Signed-off-by: Ralph Siemsen --- tools/binman/binman.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/binman/binman.rst b/tools/

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 12:39, Troy Kisky wrote: > > > On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky > wrote: >> >> On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: >>> >>> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >>> >>> > When switching defined(CONFIG_PCI) to CONFIG_

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Troy Kisky
On Wed, Feb 22, 2023 at 11:39 AM Troy Kisky wrote: > > On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky > wrote: > >> On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: >> >>> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >>> >>> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(

Re: [PATCH v6 6/6] doc: Add measured boot documentation

2023-02-22 Thread Heinrich Schuchardt
Am 22. Februar 2023 19:02:42 MEZ schrieb Eddie James : >Briefly describe the feature and specify the requirements. > >Signed-off-by: Eddie James >--- > doc/usage/index.rst | 1 + > doc/usage/measured_boot.rst | 23 +++ > 2 files changed, 24 insertions(+) > create mode

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-22 Thread Steffen Dirkwinkel
Hi! On Tue, 2023-02-21 at 11:58 +0100, Ulf Samuelsson wrote: > CAUTION: External Email!! > Hi Guys, > We are currently discussing how to support passive serial configuration > of FPGAs in u-boot. > > Checking the u-boot source code reveals that only your boards > actually supports this. > > board/

[PATCH v5 00/44] More tidy-ups of Kconfig options

2023-02-22 Thread Simon Glass
This series was split out of the old 'split config' splc series. It contains clean-up patches which do not depend on split config. This is available at u-boot-dm/spld-working The size changes look pretty good: https://paste.debian.net/1271742/ The remaining patches will move into a new 'splg' se

Re: [PATCH v3 68/95] socfpga: Use the correct condition for SYS_L2_PL310

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 12:16:53PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 14 Feb 2023 at 09:38, Tom Rini wrote: > > > > On Sun, Feb 12, 2023 at 04:16:11PM -0700, Simon Glass wrote: > > > > > Update this to use the PPL condition instead, so that nothing changes when > > > building for SPL

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Troy Kisky
On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky wrote: > On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: > >> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >> >> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) >> > bdf is no longer accessible. So change to preprocessor

Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

2023-02-22 Thread Ralph Siemsen
On Wed, Feb 22, 2023 at 07:45:45PM +0100, Marek Vasut wrote: On 2/22/23 19:32, Ralph Siemsen wrote: On Wed, Feb 22, 2023 at 06:47:44PM +0100, Marek Vasut wrote: Are those fixes in mainline Linux ? Yes, they are in mainline: 2dee50ab9e72 clk: renesas: r9a06g032: Fix UART clkgrp bitsel   merged

Re: [PATCH] fastboot: Only call the bootm command if it is enabled

2023-02-22 Thread Patrick DELAUNAY
Hi, On 2/20/23 07:14, Samuel Holland wrote: This fixes an error with trying to link against do_bootm() when CONFIG_CMD_BOOTM is disabled. Signed-off-by: Samuel Holland --- drivers/fastboot/fb_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fastboot/fb_c

[PATCH 1/2] ARM: remove SPEAR entry in makefile

2023-02-22 Thread Patrick Delaunay
As the lastest spear directories are removed, delete the associated entry in Makefile. Fixes: 570c3dcfc153 ("arm: Remove spear600 boards and the rest of SPEAr support") Signed-off-by: Patrick Delaunay --- arch/arm/cpu/arm926ejs/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/a

[PATCH 2/2] mmc: remove SDHCI SPEAR

2023-02-22 Thread Patrick Delaunay
As the file spear_sdhci.c file is already removed, delete the associated configuration CONFIG_MMC_SDHCI_SPEAR. Fixes: c942fc925e7dab ("mmc: spear: remove the entire spear_sdhci.c file") Signed-off-by: Patrick Delaunay --- drivers/mmc/Kconfig | 12 drivers/mmc/Makefile | 1 - 2 fi

[PATCH v2 09/13] efi: Adjust script to show pre-relocation output on terminal

2023-02-22 Thread Simon Glass
When running with video enabled, the pre-relocation output of U-Boot is currently lost. Add a -serial flag to show it on the terminal. Signed-off-by: Simon Glass --- (no changes since v1) scripts/build-efi.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/build-efi.sh b/scripts/

Re: [PATCH v6 6/6] doc: Add measured boot documentation

2023-02-22 Thread Simon Glass
On Wed, 22 Feb 2023 at 11:02, Eddie James wrote: > > Briefly describe the feature and specify the requirements. > > Signed-off-by: Eddie James > --- > doc/usage/index.rst | 1 + > doc/usage/measured_boot.rst | 23 +++ > 2 files changed, 24 insertions(+) > create mod

Re: [PATCH v6 4/6] bootm: Support boot measurement

2023-02-22 Thread Simon Glass
Hi Eddie, On Wed, 22 Feb 2023 at 11:02, Eddie James wrote: > > Add a configuration option to measure the boot through the bootm > function. Add the measurement state to the booti and bootz paths > as well. > > Signed-off-by: Eddie James > --- > boot/Kconfig| 23 > boot/boot

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Simon Glass
Hi Troy, On Wed, 22 Feb 2023 at 11:43, Troy Kisky wrote: > > On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote: >> >> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: >> >> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) >> > bdf is no longer accessible. So change to prep

  1   2   3   >