Hi Ralph, On Wed, 22 Feb 2023 at 14:17, Ralph Siemsen <ralph.siem...@linaro.org> wrote: > > Hi Simon, > > Thanks for your review! > > On Wed, Feb 22, 2023 at 2:17 PM Simon Glass <s...@chromium.org> wrote: > > > > Can you please add some details to doc/ for this SoC and how it boots, > > the use of mkimage, etc.? > > Sure, I will cobble something together. Any particular good examples > to look at for inspiration?
You could try doc/board/rockchip > > > Also as a follow-on, can you add a binman entry type for this so that > > building a functioning image is automatic? > > I'm talking a look at this as well. In this case though, it would just > automate the call to mkimage, as there are no other binaries. > > > Finally, please add comments to struct spkg_hdr members below > > Yes, although they will be pretty much verbatim from the user manual, > which documents the format. The docs are available publicly, but you > need to click through a few links to reach them. > OK. Still, it is handy to have it in the code. Downloading a PDF to understand the code it not great. Regards, Simon
