[PATCH v2] bootstage: Add SPL support

2021-10-22 Thread Marek Vasut
Allow usage of the bootstage facilities in SPL. Signed-off-by: Marek Vasut Cc: Simon Glass --- V2: Fix multiple misuses of BOOTSTAGE vs SHOW_BOOT_PROGRESS --- arch/x86/cpu/cpu.c| 2 +- board/siemens/iot2050/board.c | 2 +- common/Kconfig.boot | 9 + common/init/boa

Re: Pull request for efi-2022-01-rc1

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 02:14:14PM +0200, Heinrich Schuchardt wrote: > The following changes since commit fb1018106a7bbb1a0d723029f6760b1b1b4d306d: > > Merge branch '2021-10-19-assorted-changes' (2021-10-19 20:45:12 -0400) > > are available in the Git repository at: > > https://source.denx.

Re: [PATCH v3 0/7] arm64: dts: imx8mm: use common binman configuration and further clean-up

2021-10-22 Thread Marcel Ziswiler
On Sat, 2021-10-23 at 01:15 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > > With the move to using binman to generate SPL aka u-boot-spl-ddr.bin and > U-Boot proper aka u-boot.itb every board now covers such configuration > in its own U-Boot specific device tree include. Move the com

Re: [PATCH v4 0/5] board: sl28: target refresh

2021-10-22 Thread Marcel Ziswiler
On Sat, 2021-10-23 at 00:19 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > > Note that this re-base is only compile tested. > > Changes in v4: > - Re-based on top of imx/master. > > Changes in v3: > - none >  - use CONFIG_EFI_CAPSULE_FIRMWARE_FIT instead of >    CONFIG_EFI_CAPSULE_F

Re: [PATCH v4 0/5] board: sl28: target refresh

2021-10-22 Thread Marcel Ziswiler
Hi Michael On Sat, 2021-10-23 at 01:28 +0200, Michael Walle wrote: > Hi Marcel, > > Am 2021-10-23 01:09, schrieb Marcel Ziswiler: > > Sorry, I did not want to upset anybody. I probably should have asked > > first before doing this. > > You could have said the below in the cover letter. Then > I'

[PATCH v2 1/2] net: brcm: netXtreme driver

2021-10-22 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v2: - rebase and remove DM_PCI dependency from BNXT_ETH - remove tautology assignment from debug_resp()

Re: [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Tony Dinh
Hi all, My 2 cents. As a maintainer for some hobbyist downstream u-boots (tracking mainline) and some out-of-tree u-boots, I do lots of envs scripting. The most common scenario for me is to create an env by combining 2 or more strings. Examples, init_usb, init_sata, init_sata_usb and so on, i.e c

Re: [PATCH v4 0/5] board: sl28: target refresh

2021-10-22 Thread Michael Walle
Hi Marcel, Am 2021-10-23 01:09, schrieb Marcel Ziswiler: Sorry, I did not want to upset anybody. I probably should have asked first before doing this. You could have said the below in the cover letter. Then I'd have at least an idea what is going on ;) On Sat, 2021-10-23 at 00:52 +0200, Mich

[PATCH v2 2/2] cmd: brcm: netXtreme commands

2021-10-22 Thread Roman Bacik
From: Bharat Gooty Following netXtreme commands are supported:- Device probe, remove, supported speeds, get/set speeds and get/set MAC address. Signed-off-by: Bharat Gooty Signed-off-by: Roman Bacik --- (no changes since v1) cmd/Kconfig | 2 + cmd/broadcom/Kconfig | 10 ++ cm

[PATCH v2 2/2] cmd: brcm: netXtreme commands

2021-10-22 Thread Roman Bacik
From: Bharat Gooty Following netXtreme commands are supported:- Device probe, remove, supported speeds, get/set speeds and get/set MAC address. Signed-off-by: Bharat Gooty Signed-off-by: Roman Bacik --- (no changes since v1) cmd/Kconfig | 2 + cmd/broadcom/Kconfig | 10 ++ cm

[PATCH v3 7/7] arm64: dts: imx8mm-u-boot.dtsi: improve odd blob-ext naming

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler Rather than using odd implicit blob-ext naming, explicitly specify the type to be of blob-ext and therefore also simplify the node naming. Signed-off-by: Marcel Ziswiler Reviewed-by: Peng Fan --- (no changes since v2) Changes in v2: - Rather than doing that clean-up to

[PATCH v3 4/7] arm64: dts: imx8mm: use common binman configuration

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler With the move to using binman to generate SPL aka u-boot-spl-ddr.bin and U-Boot proper aka u-boot.itb every board now covers such configuration in its own U-Boot specific device tree include. Move the comon part of that configuration to the common imx8mm-u-boot.dtsi include

[PATCH v3 6/7] arm64: dts: imx8mm-u-boot.dtsi: explicitly add spl filename

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler Explicitly add SPL aka u-boot-spl.bin filename. Signed-off-by: Marcel Ziswiler Reviewed-by: Peng Fan --- (no changes since v2) Changes in v2: - Rather than doing that clean-up to the separate binman dtsi now do it to the common u-boot dtsi one. arch/arm/dts/imx8mm-

[PATCH v3 5/7] arm64: dts: imx8mm-u-boot.dtsi: alphabetically re-order properties

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler Alphabetically re-order properties. Signed-off-by: Marcel Ziswiler Reviewed-by: Peng Fan --- (no changes since v2) Changes in v2: - Rather than doing that clean-up to the separate binman dtsi now do it to the common u-boot dtsi one. arch/arm/dts/imx8mm-u-boot.dtsi

[PATCH v3 3/7] arm64: dts: imx8mm-cl-iot-gate-u-boot.dtsi: use common imx8mm-u-boot.dtsi

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler Use common imx8mm-u-boot.dtsi. Signed-off-by: Marcel Ziswiler Reviewed-by: Peng Fan --- (no changes since v2) Changes in v2: - New patch preparing cl-iot-gate. .../dts/imx8mm-cl-iot-gate-optee-u-boot.dtsi | 37 +-- arch/arm/dts/imx8mm-cl-iot-gate-u-b

[PATCH v3 2/7] arm64: dts: imx8mm-cl-iot-gate-u-boot.dtsi: alphabetically re-order

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler Alphabetically re-order nodes and properties. Signed-off-by: Marcel Ziswiler Reviewed-by: Peng Fan --- (no changes since v2) Changes in v2: - New patch preparing cl-iot-gate. .../dts/imx8mm-cl-iot-gate-optee-u-boot.dtsi | 202 +- arch/arm/dts/imx8mm-

[PATCH v3 0/7] arm64: dts: imx8mm: use common binman configuration and further clean-up

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler With the move to using binman to generate SPL aka u-boot-spl-ddr.bin and U-Boot proper aka u-boot.itb every board now covers such configuration in its own U-Boot specific device tree include. Move the comon part of that configuration to the common imx8mm-u-boot.dtsi include

[PATCH v3 1/7] imx8mm-cl-iot-gate: fix imximage intermediate binary naming

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler This fixes the following build time issue: ... BINMAN all binman: Error 1 running 'mkimage -d ./mkimage.spl.mkimage -n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000 ./mkimage-out.spl.mkimage': mkimage.flash.mkimage: Can't open: No such file or directory make: *** [

Re: [PATCH v4 0/5] board: sl28: target refresh

2021-10-22 Thread Marcel Ziswiler
Hi Michael Sorry, I did not want to upset anybody. I probably should have asked first before doing this. On Sat, 2021-10-23 at 00:52 +0200, Michael Walle wrote: > Hi Marcel, > > Am 2021-10-23 00:19, schrieb Marcel Ziswiler: > > From: Marcel Ziswiler > > > > > > Note that this re-base is only

[PATCH] patman: Add "postfix" support to patch subjects

2021-10-22 Thread Sean Anderson
In some communities, it may be necessary to append something after PATCH in the subject line. For example, the Linux networking subsystem expects [1] patch subject prefixes like [RFC PATCH net-next 0/99]. This adds support for such "postfix"s to patman. Although entirely cosmetic, it is still nice

Re: [PATCH v4 0/5] board: sl28: target refresh

2021-10-22 Thread Michael Walle
Hi Marcel, Am 2021-10-23 00:19, schrieb Marcel Ziswiler: From: Marcel Ziswiler Note that this re-base is only compile tested. Care to explain what this is? Why are you taking my patchset and make a new version of it and rebasing it on the wrong tree? Did I miss something? -michael

Re: [PATCH] dfu: dfu_sf: Read the SPI flash in 16 MiB chunks

2021-10-22 Thread Marek Vasut
On 9/14/21 11:31 AM, Lukasz Majewski wrote: On Tue, 14 Sep 2021 05:26:51 +0200 Marek Vasut wrote: Not all SPI flashes and controllers can do continuous transfer longer than 16 MiB, so perform the DFU read in 16 MiB chunks. Signed-off-by: Marek Vasut Cc: Lukasz Majewski --- drivers/dfu/dfu

Re: [PATCH v2] mtd: spi-nor-ids: Reinstate Micron MT25QL02G

2021-10-22 Thread Marek Vasut
On 10/8/21 2:49 PM, Jagan Teki wrote: On Tue, Oct 5, 2021 at 2:29 PM Marek Vasut wrote: This ID disappeared in 5b66fdb29dc ("mtd: spi: Remove unused files"), add the ID back, since the chip is used on devices supported by U-Boot. Fixes: 5b66fdb29dc ("mtd: spi: Remove unused files") Signed-off

[PATCH v4 1/5] board: sl28: enable EFI_SET_TIME support

2021-10-22 Thread Marcel Ziswiler
From: Michael Walle Allow EFI to actually set the time before ExitBootServices(). Signed-off-by: Michael Walle Signed-off-by: Marcel Ziswiler --- Changes in v4: - Re-based on top of imx/master. Changes in v3: - none Changes in v2: - none configs/kontron_sl28_defconfig | 1 + 1 file chang

[PATCH v4 0/5] board: sl28: target refresh

2021-10-22 Thread Marcel Ziswiler
From: Marcel Ziswiler Note that this re-base is only compile tested. Changes in v4: - Re-based on top of imx/master. Changes in v3: - none - use CONFIG_EFI_CAPSULE_FIRMWARE_FIT instead of CONFIG_EFI_CAPSULE_FIRMWARE_RAW Changes in v2: - none - new patch Frieder Schrempf (1): doc: board

[PATCH v4 3/5] board: sl28: enable EFI UpdateCapsule support

2021-10-22 Thread Marcel Ziswiler
From: Michael Walle Enable support for update over EFI UpdateCapsule mechanism. This board doesn't support setting EFI variables after ExitBootservices(). Therefore, we are also enabling EFI_IGNORE_OSINDICATIONS. Signed-off-by: Michael Walle Signed-off-by: Marcel Ziswiler --- Changes in v4:

[PATCH v4 4/5] doc: board: kontron: sl28: Reduce section levels and change title

2021-10-22 Thread Marcel Ziswiler
From: Frieder Schrempf In order to add other Kontron boards to the docs alongside the existing sl28 board, we need to reduce the levels of the sections and change the title. Cc: Fabio Estevam Signed-off-by: Frieder Schrempf Acked-by: Michael Walle Signed-off-by: Marcel Ziswiler --- >From v3

[PATCH v4 5/5] board: sl28: add update image documentation

2021-10-22 Thread Marcel Ziswiler
From: Michael Walle Document the update image and how to use the EFI UpdateCapsule. Signed-off-by: Michael Walle Signed-off-by: Marcel Ziswiler --- Changes in v4: - Re-based on top of imx/master. Changes in v3: - none Changes in v2: - new patch doc/board/kontron/sl28.rst | 15 +++

[PATCH v4 2/5] board: sl28: generate FIT update image

2021-10-22 Thread Marcel Ziswiler
From: Michael Walle Generate a FIT update image during build. The image will be called "u-boot.update" and can be used to build an EFI UpdateCapsule or during DFU mode. Although, the latter isn't supported because there is no USB OTG driver yet. Signed-off-by: Michael Walle Signed-off-by: Marce

[PATCH v2] imx8mm_beacon: Switch to binman for generating image

2021-10-22 Thread Marcel Ziswiler
From: Adam Ford To eliminate a warning when using custom imx tools for generating a binary, use binman to generate flash.bin. Signed-off-by: Adam Ford Signed-off-by: Marcel Ziswiler --- Note that this re-base is only compile tested. Changes in v2: - Re-based on top of imx/master. arch/arm/

Re: Question: LTO and failing objcopy in "u-boot-initial-env" target

2021-10-22 Thread Adam Ford
On Fri, Oct 22, 2021 at 2:26 PM Marek Behún wrote: > > On Fri, 22 Oct 2021 14:19:16 -0500 > Adam Ford wrote: > > > I am not sure it's the right solution, but it appears to work for me > > on a board that uses LTO. I didn't try it with a board that doesn't > > use LTO. > > Need to be tested with

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Vagrant Cascadian
On 2021-10-22, Andre Przywara wrote: > On Fri, 22 Oct 2021 09:47:35 -0700 > Vagrant Cascadian wrote: >> On 2021-10-22, Tom Rini wrote: >> > On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: >> >> On Fri, 22 Oct 2021 11:09:27 -0400 >> >> Tom Rini wrote: >> >> >> > On Fri, Oct 22

Re: [PATCH] imx8mn_beacon: Fix booting hang and switch to binman

2021-10-22 Thread Adam Ford
On Wed, Sep 29, 2021 at 8:26 AM Adam Ford wrote: > > On Thu, Sep 23, 2021 at 3:03 PM Adam Ford wrote: > > > > On Tue, Sep 14, 2021 at 9:49 PM Peng Fan (OSS) wrote: > > > > > > > > > > > > On 2021/9/11 4:19, Adam Ford wrote: > > > > Somewhere along the line, the board stopped being able to boot.

Re: Question: LTO and failing objcopy in "u-boot-initial-env" target

2021-10-22 Thread Marek Behún
On Fri, 22 Oct 2021 14:19:16 -0500 Adam Ford wrote: > I am not sure it's the right solution, but it appears to work for me > on a board that uses LTO. I didn't try it with a board that doesn't > use LTO. Need to be tested with GCC as well as Clang. Marek

Re: Question: LTO and failing objcopy in "u-boot-initial-env" target

2021-10-22 Thread Marek Behún
On Fri, 22 Oct 2021 17:16:18 +0200 Patrick DELAUNAY wrote: > Hi, > > > I made tests with LTO option activated on stm32mp15 boards but if have a > issue > > with the U-Boot target  "u-boot-initial-env" (this command used by YOCTO) > > > $> make u-boot-initial-env > > ... > > GENENV  u-bo

Re: Question: LTO and failing objcopy in "u-boot-initial-env" target

2021-10-22 Thread Adam Ford
On Fri, Oct 22, 2021 at 10:16 AM Patrick DELAUNAY wrote: > > Hi, > > > I made tests with LTO option activated on stm32mp15 boards but if have a > issue > > with the U-Boot target "u-boot-initial-env" (this command used by YOCTO) > > > $> make u-boot-initial-env > > ... > > GENENV u-boot-initial-

[PATCH] gpio: stm32: create include file for driver private data

2021-10-22 Thread Patrick Delaunay
The stm32 gpio driver private data are not needed in arch include files, they are not used by code except for stm32 gpio and pincontrol drivers, using the same IP; the defines for this IP is moved in a new file "stm32_gpio_priv.h" in driver/gpio. This patch avoids to have duplicated file gpio.h fo

[PATCH] socfpga: enable EFI partition support for de0-nano-soc

2021-10-22 Thread Frank Kunz
This fixes boot problems with distributions that use EFI boot like opensuse. Signed-off-by: Frank Kunz --- configs/socfpga_de0_nano_soc_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/socfpga_de0_nano_soc_defconfig b/configs/socfpga_de0_nano_soc_defconfig i

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-22 Thread Heiko Thiery
Hi Simon, Am Fr., 22. Okt. 2021 um 18:07 Uhr schrieb Simon Glass : > > Hi Heiko, > > On Fri, 22 Oct 2021 at 07:24, Heiko Thiery wrote: > > > > Hi, > > > > Am Fr., 22. Okt. 2021 um 14:37 Uhr schrieb Stefano Babic : > > > > > > Hi Heiko, > > > > > > On 22.10.21 10:19, Heiko Thiery wrote: > > > > Hi

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 09:47:35 -0700 Vagrant Cascadian wrote: Hi, > On 2021-10-22, Tom Rini wrote: > > On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: > >> On Fri, 22 Oct 2021 11:09:27 -0400 > >> Tom Rini wrote: > > >> > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún w

Re: [PATCH 6/6] scripts: remove CONFIG_IS_ENABLED in config_whitelist.txt

2021-10-22 Thread Patrick DELAUNAY
Hi Simon On 10/14/21 5:09 PM, Simon Glass wrote: Hi Patrick, On Mon, 4 Oct 2021 at 04:00, Patrick Delaunay wrote: Redefine the macro CONFIG_IS_ENABLED is not allowed, so this entry can be removed in whitelist file. Signed-off-by: Patrick Delaunay --- scripts/config_whitelist.txt | 1 -

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Pali Rohár
On Friday 22 October 2021 09:47:35 Vagrant Cascadian wrote: > do some boards use board-specific tools as part of their build processes? Lot of boards are using mkimage for generating final U-Boot binary. Prior U-Boot 2021.10 all 32-bit mvebu boards used own specific version of mkimage to generate

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Vagrant Cascadian
On 2021-10-22, Tom Rini wrote: > On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: >> On Fri, 22 Oct 2021 11:09:27 -0400 >> Tom Rini wrote: >> > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: >> > > On Fri, 22 Oct 2021 12:09:19 +0200 >> > > Heinrich Schuchardt wrote:

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 04:56:09PM +0100, Andre Przywara wrote: > On Fri, 22 Oct 2021 11:09:27 -0400 > Tom Rini wrote: > > Hi, > > > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > > > On Fri, 22 Oct 2021 12:09:19 +0200 > > > Heinrich Schuchardt wrote: > > > > > > > On 10/21/2

Re: [PATCH 06/14] env: nvram: Cosmetic fix in env_nvram_init()

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Use spaces consistently in assignments instead of tabs. > > Signed-off-by: Marek Behún > --- > env/nvram.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 02/14] env: sf: Use ENV_VALID enum names instead of literals

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > The function env_sf_init_addr() assigns number literals (1) instead of > ENV_VALID to gd->env_valid. Fix this. > > Signed-off-by: Marek Behún > --- > env/sf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH 05/14] env: nvram: Let generic env_init() assign default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_nvram_init() assigns default environment if ENV_INVALID, but this is > done in the generic env_init() function, which calls this initializer, > so drop it from here. > > Signed-off-by: Marek Behún > --- > env/nvram.c

Re: [PATCH 03/14] env: sf: Put ENV_INVALID into gd->env_valid on CRC failure

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_sf_init_addr() says the environment is valid even if it is assigning > default environment due to CRC failure. Change this to ENV_INVALID and > let the generic env_init() function, which calls this initializer, > assig

Re: [PATCH 07/14] env: nowhere: Let generic env_init() assign default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_nowhere_init() assigns default environment if ENV_INVALID, but this > is done in the generic env_init() function, which calls this > initializer, so drop it from here. > > Signed-off-by: Marek Behún > --- > env/nowhe

Re: [PATCH 14/14] env: Use static_assert() to check if default_environment is too large

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:48, Marek Behún wrote: > > From: Marek Behún > > Check sizeof(default_environment) against ENV_SIZE in a static_assert() > instead of runtime. > Only check if !USE_HOSTCC (for in fw_env tool ENV_SIZE expands to a > variable, and cannot be checked statically) nad > !DEFAU

Re: [PATCH 09/14] env: flash: Let generic env_init() assign default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_flash_init() (both implementations) assigns default environment if > ENV_INVALID, but this is done in the generic env_init() function, which > calls this initializer, so drop it from here. > > Signed-off-by: Marek Behú

Re: [PATCH 13/14] env: Always use char for default_environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Sometimes we use uchar and sometimes char for the default environment > array. By always using char, we can get rid of some explicit casts. > > Signed-off-by: Marek Behún > --- > board/Marvell/mvebu_armada-37xx/board.c |

Re: [PATCH 12/14] board: freescale: various boards: Let env subsystem set gd->env_addr

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Various freescale boards set gd->env_addr to default_environment in > board_init(), conditional on CONFIG_ENV_IS_NOWHERE, but this is > redundant, since it is done by env_init() before board_init() is called. > > Let the e

Re: [PATCH 11/14] board: synquacer: developerbox: Don't set gd->env_addr to default_environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > This board sets gd->env_addr to default_environment in board_init(), but > the board has environment in SPI flash according to defconfig. Let the > env API handle environment automatically. > > Signed-off-by: Marek Behún

Re: [PATCH 10/14] env: flash: Cosmetic fix

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Change tab to space in env_flash_init(). > > Signed-off-by: Marek Behún > --- > env/flash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass Feel free to do these code-style all in on

Re: [PATCH 04/14] env: nand: Put ENV_INVALID into gd->env_valid if default environment

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > env_nand_init() says the environment is valid even if it is assigning > default environment due to not being able to access nand pre-reloaction > (determined by macro values). Change this to ENV_INVALID and let the > gener

Re: [PATCH 08/14] env: nowhere: Cosmetic fix

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > Use spaces instead of tabs in assignments, since there are no lines to > align assignment values to. > > Signed-off-by: Marek Behún > --- > env/nowhere.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Revie

Re: [PATCH 01/14] env: sf: Cosmetic fix in env_sf_init_addr()

2021-10-22 Thread Simon Glass
On Fri, 22 Oct 2021 at 07:47, Marek Behún wrote: > > From: Marek Behún > > In the if clause we use tabs and in the else clause spaces. Let's use > spaces in the if clause too. > > Signed-off-by: Marek Behún > --- > env/sf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-b

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-22 Thread Simon Glass
Hi Heiko, On Fri, 22 Oct 2021 at 07:24, Heiko Thiery wrote: > > Hi, > > Am Fr., 22. Okt. 2021 um 14:37 Uhr schrieb Stefano Babic : > > > > Hi Heiko, > > > > On 22.10.21 10:19, Heiko Thiery wrote: > > > Hi Stefano, Hi Simon, > > > > > > Am Do., 21. Okt. 2021 um 15:57 Uhr schrieb Heiko Thiery > > >

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Andre Przywara
On Fri, 22 Oct 2021 11:09:27 -0400 Tom Rini wrote: Hi, > On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > > On Fri, 22 Oct 2021 12:09:19 +0200 > > Heinrich Schuchardt wrote: > > > > > On 10/21/21 15:00, Marek Behún wrote: > > > > BTW, wouldn't it be enough to simply imply TOO

[PATCH] cmd: pxe_utils: sysboot: add label override support

2021-10-22 Thread Amjad Ouled-Ameur
This will allow consumers to choose a pxe label at runtime instead of having to prompt the user. One good use-case for this, is choosing whether or not to apply a dtbo depending on the hardware configuration. e.g: for TI's AM335x EVM, it would be convenient to apply a particular dtbo only when the

Question: LTO and failing objcopy in "u-boot-initial-env" target

2021-10-22 Thread Patrick DELAUNAY
Hi, I made tests with LTO option activated on stm32mp15 boards but if have a issue with the U-Boot target  "u-boot-initial-env" (this command used by YOCTO) $> make u-boot-initial-env ... GENENV  u-boot-initial-env arm-none-linux-gnueabihf-objcopy: env/common.o: can't dump section '.roda

Re: [PATCH v3 1/2] lib: uuid: use RNG device if present

2021-10-22 Thread Patrick DELAUNAY
Hi On 12/18/20 10:28 AM, matthias@kernel.org wrote: From: Matthias Brugger When calculating a random UUID we use a weak seed. Use a RNG device if present to increase entropy. Signed-off-by: Matthias Brugger --- Changes in v3: - use IS_ENABLED instead of #if - use 4 byte for entropy Ch

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 04:59:22PM +0200, Marek Behún wrote: > On Fri, 22 Oct 2021 12:09:19 +0200 > Heinrich Schuchardt wrote: > > > On 10/21/21 15:00, Marek Behún wrote: > > > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > > > platform in Kconfig? > > > > > > > We sho

[PATCH] lib: uuid: fix the test on RNG device presence

2021-10-22 Thread Patrick Delaunay
Correct the test on RNG device presence,when ret is equal to 0, before to call dm_rng_read function. Without this patch the RNG device is not used when present (when ret == 0) or a data abort occurs in dm_rng_read when CONFIG_DM_RNG is activated but the RNG device is not present in device tree (re

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-22 Thread Marek Behún
On Fri, 22 Oct 2021 12:09:19 +0200 Heinrich Schuchardt wrote: > On 10/21/21 15:00, Marek Behún wrote: > > BTW, wouldn't it be enough to simply imply TOOLS_LIBCRYPTO for mvebu > > platform in Kconfig? > > > > We should only use 'imply' for suggested settings and never for hard > requirements.

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 10:06:55AM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > you > wrote: > > > > > > i.e. > > > > var+=value > > > > appends value to var, while > > > > var\+=value > > > > sets variable with name "var+" > > > > My first preference is to disallow + at the e

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 10:08:05AM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20211021160311.GC3577824@bill-the-cat> you wrote: > > > > How bad does it make the parser look if we allow trailing + in variable > > names, by escaping them? It's seemingly the substantive objection at >

Re: [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Tom Rini
On Fri, Oct 22, 2021 at 10:29:26AM +0200, Wolfgang Denk wrote: > Dear Simon, > > In message > <20211021210847.v10.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you > wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is

[PATCH 8/8] pci: pci_mvebu: Fix comment about driver class name

2021-10-22 Thread Pali Rohár
This is a pci driver, not an eth driver. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index b0c673d8c472..ed151a05a4bf 100644 --- a/drivers/pci

[PATCH 5/8] pci: pci_mvebu: Fix place of link up detection

2021-10-22 Thread Pali Rohár
PCI Bridge is always accessible also when link is down. So move detection of link up from mvebu_pcie_of_to_plat() function to mvebu_pcie_valid_addr() function which is used when accessing PCI config space. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 14 -

[PATCH 3/8] pci: pci_mvebu: Properly configure and use PCI Bridge (PCIe Root Port)

2021-10-22 Thread Pali Rohár
The mysterious "Memory controller" PCI device which is present in PCI config space is improperly configured and crippled PCI Bridge which acts as PCIe Root Port for endpoint PCIe card. This PCI Bridge reports in PCI config space incorrect Class Code (Memory Controller) and incorrect Header Type (T

[PATCH 7/8] pci: pci_mvebu: Setup PCI controller to Root Complex mode

2021-10-22 Thread Pali Rohár
Root Complex should be the default mode, let's set it explicitly. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c index e43fa12d3819..b0c673d8c472 100644 --

[PATCH 6/8] pci: pci_mvebu: Do not automatically enable bus mastering on PCI Bridge

2021-10-22 Thread Pali Rohár
Now that PCI Bridge is working, U-Boot's CONFIG_PCI_PNP code automatically enables memory access and bus mastering when it is needed. So do not prematurely enable memory access and bus mastering. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 8 1 file

[PATCH 0/8] pci: pci_mvebu: Fix access to config space and PCIe Root Port

2021-10-22 Thread Pali Rohár
This patch series fixes access to config space and fixes issues with the mysterious "Memory controller" PCI device (which is PCIe Root Port). Tested on Armada 385 Turris Omnia device which has 3 mPCIe slots. PCIe Root Port device is available for each slot on separate bus and has PCI Bridge class

[PATCH 4/8] pci: pci_mvebu: Remove unused functions

2021-10-22 Thread Pali Rohár
Functions mvebu_pcie_get_local_bus_nr() and mvebu_pcie_get_local_dev_nr() are not used, so remove them. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci_mvebu.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_m

[PATCH 2/8] pci: pci_mvebu: Fix read_config() with PCI_SIZE_8 or PCI_SIZE_16

2021-10-22 Thread Pali Rohár
When reading 8 or 16 bits from config space, use appropriate readb() or readw() calls. This ensures that PCIe controller does not read more bits from endpoint card as asked by read_config() function. Technically there should not be an issue with reading data from config space which are not later u

[PATCH 1/8] pci: pci_mvebu: Fix write_config() with PCI_SIZE_8 or PCI_SIZE_16

2021-10-22 Thread Pali Rohár
Current implementation of write_config() is broken for PCI_SIZE_8 or PCI_SIZE_16 as it always uses writel(), which means that write operation is always 32-bit, so upper 24 bits for PCI_SIZE_8 and upper 16 bits for PCI_SIZE_16 are cleared. Fix this by using writeb() and writew(), respectively. Sig

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Marek Behún
Hello Wolfgang, On Fri, 22 Oct 2021 10:06:55 +0200 Wolfgang Denk wrote: > For the '+=' case, there is no way to escape the '+', as all > commonly used escapes are valid characters in the variable name, > too. We can define that backslash is to be also escaped if it is to be used as variable nam

[PATCH 14/14] env: Use static_assert() to check if default_environment is too large

2021-10-22 Thread Marek Behún
From: Marek Behún Check sizeof(default_environment) against ENV_SIZE in a static_assert() instead of runtime. Only check if !USE_HOSTCC (for in fw_env tool ENV_SIZE expands to a variable, and cannot be checked statically) nad !DEFAULT_ENV_INSTANCE_EMBEDDED, for in that case the default_environmen

[PATCH 13/14] env: Always use char for default_environment

2021-10-22 Thread Marek Behún
From: Marek Behún Sometimes we use uchar and sometimes char for the default environment array. By always using char, we can get rid of some explicit casts. Signed-off-by: Marek Behún --- board/Marvell/mvebu_armada-37xx/board.c | 2 +- env/common.c| 6 +++--- include

[PATCH 12/14] board: freescale: various boards: Let env subsystem set gd->env_addr

2021-10-22 Thread Marek Behún
From: Marek Behún Various freescale boards set gd->env_addr to default_environment in board_init(), conditional on CONFIG_ENV_IS_NOWHERE, but this is redundant, since it is done by env_init() before board_init() is called. Let the env subsystem handle this. Signed-off-by: Marek Behún Cc: Ramon

[PATCH 11/14] board: synquacer: developerbox: Don't set gd->env_addr to default_environment

2021-10-22 Thread Marek Behún
From: Marek Behún This board sets gd->env_addr to default_environment in board_init(), but the board has environment in SPI flash according to defconfig. Let the env API handle environment automatically. Signed-off-by: Marek Behún Cc: Masami Hiramatsu --- board/socionext/developerbox/develope

[PATCH 10/14] env: flash: Cosmetic fix

2021-10-22 Thread Marek Behún
From: Marek Behún Change tab to space in env_flash_init(). Signed-off-by: Marek Behún --- env/flash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/flash.c b/env/flash.c index 77d4c030a5..b928880502 100644 --- a/env/flash.c +++ b/env/flash.c @@ -229,7 +229,7 @@ static

[PATCH 08/14] env: nowhere: Cosmetic fix

2021-10-22 Thread Marek Behún
From: Marek Behún Use spaces instead of tabs in assignments, since there are no lines to align assignment values to. Signed-off-by: Marek Behún --- env/nowhere.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/nowhere.c b/env/nowhere.c index dc93b6f2e4..9ebc357dbd 1

[PATCH 07/14] env: nowhere: Let generic env_init() assign default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_nowhere_init() assigns default environment if ENV_INVALID, but this is done in the generic env_init() function, which calls this initializer, so drop it from here. Signed-off-by: Marek Behún --- env/nowhere.c | 1 - 1 file changed, 1 deletion(-) diff --git a/env/nowhere.

[PATCH 06/14] env: nvram: Cosmetic fix in env_nvram_init()

2021-10-22 Thread Marek Behún
From: Marek Behún Use spaces consistently in assignments instead of tabs. Signed-off-by: Marek Behún --- env/nvram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/nvram.c b/env/nvram.c index 297573c4ed..fb265235af 100644 --- a/env/nvram.c +++ b/env/nvram.c @@ -87,

[PATCH 09/14] env: flash: Let generic env_init() assign default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_flash_init() (both implementations) assigns default environment if ENV_INVALID, but this is done in the generic env_init() function, which calls this initializer, so drop it from here. Signed-off-by: Marek Behún --- env/flash.c | 3 --- 1 file changed, 3 deletions(-) dif

[PATCH 05/14] env: nvram: Let generic env_init() assign default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_nvram_init() assigns default environment if ENV_INVALID, but this is done in the generic env_init() function, which calls this initializer, so drop it from here. Signed-off-by: Marek Behún --- env/nvram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 04/14] env: nand: Put ENV_INVALID into gd->env_valid if default environment

2021-10-22 Thread Marek Behún
From: Marek Behún env_nand_init() says the environment is valid even if it is assigning default environment due to not being able to access nand pre-reloaction (determined by macro values). Change this to ENV_INVALID and let the generic env_init() function, which calls this initializer, assign th

[PATCH 03/14] env: sf: Put ENV_INVALID into gd->env_valid on CRC failure

2021-10-22 Thread Marek Behún
From: Marek Behún env_sf_init_addr() says the environment is valid even if it is assigning default environment due to CRC failure. Change this to ENV_INVALID and let the generic env_init() function, which calls this initializer, assign the default environment. Signed-off-by: Marek Behún --- en

[PATCH 01/14] env: sf: Cosmetic fix in env_sf_init_addr()

2021-10-22 Thread Marek Behún
From: Marek Behún In the if clause we use tabs and in the else clause spaces. Let's use spaces in the if clause too. Signed-off-by: Marek Behún --- env/sf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/sf.c b/env/sf.c index e4b7ca9e04..4096e18387 100644 --- a/env

[PATCH 00/14] Some more env fixes

2021-10-22 Thread Marek Behún
From: Marek Behún Hello Tom, Simon and others, here are some various fixes for env. More are to follow after this, the code is horrible and I want to implement something there. Marek Behún (14): env: sf: Cosmetic fix in env_sf_init_addr() env: sf: Use ENV_VALID enum names instead of literal

[PATCH 02/14] env: sf: Use ENV_VALID enum names instead of literals

2021-10-22 Thread Marek Behún
From: Marek Behún The function env_sf_init_addr() assigns number literals (1) instead of ENV_VALID to gd->env_valid. Fix this. Signed-off-by: Marek Behún --- env/sf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/env/sf.c b/env/sf.c index 4096e18387..c251d076d7 100644

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-22 Thread Heiko Thiery
Hi, Am Fr., 22. Okt. 2021 um 14:37 Uhr schrieb Stefano Babic : > > Hi Heiko, > > On 22.10.21 10:19, Heiko Thiery wrote: > > Hi Stefano, Hi Simon, > > > > Am Do., 21. Okt. 2021 um 15:57 Uhr schrieb Heiko Thiery > > : > >> > >> Hi Stefano, Hi Simon, > >> > >> > >> Am Do., 21. Okt. 2021 um 15:29 Uhr

[PATCH v1 3/5] i2c: Add Microchip PolarFire SoC I2C driver

2021-10-22 Thread Padmarao Begari
Add I2C driver code for the Microchip PolarFire SoC. This driver supports I2C data transfer and probe for I2C slave addresses. Signed-off-by: Padmarao Begari --- drivers/i2c/Kconfig | 6 + drivers/i2c/Makefile| 1 + drivers/i2c/i2c-microchip.c | 482 ++

[PATCH v1 1/5] riscv: dts: Split Microchip device tree

2021-10-22 Thread Padmarao Begari
The device tree split into .dtsi and .dts files, common device node for eMMC/SD, enable I2C1, UART1 for console instead of UART0, enable the DDR 2GB memory and in that 288MB memory is reserved for fabric buffer. Signed-off-by: Padmarao Begari --- arch/riscv/dts/microchip-mpfs-icicle-kit.dts | 5

[PATCH v1 4/5] net: macb: Compatible as per device tree

2021-10-22 Thread Padmarao Begari
Update compatible as per Microchip PolarFire SoC ethernet device node. Signed-off-by: Padmarao Begari --- drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 8c6461e717..1b867bd5c2 100644 --- a/drivers/net/macb.c ++

[PATCH v1 2/5] riscv: Update Microchip MPFS Icicle Kit support

2021-10-22 Thread Padmarao Begari
This patch updates Microchip MPFS Icicle Kit support. For now, add Microchip I2C driver, set environment variables for mac addesses and default build for SBI_V02. Signed-off-by: Padmarao Begari --- board/microchip/mpfs_icicle/Kconfig | 5 + board/microchip/mpfs_icicle/mpfs_icicle.c |

[PATCH v1 5/5] doc: board: Update Microchip MPFS Icicle Kit doc

2021-10-22 Thread Padmarao Begari
UART1 uses for U-BOOT and Linux console instead of UART0 and UART0 is reserved for Hart Software Services(HSS). Signed-off-by: Padmarao Begari --- doc/board/microchip/mpfs_icicle.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/doc/board/microchip/mpfs_icicle.r

  1   2   >