[PATCH] Revert "mmc: sdhci: set to INT_DATA_END when there are data"

2021-03-16 Thread Yuezhang.Mo
This reverts commit 17ea3c862865c0d704646f67dbf8412f9ff54f59. In eMMC specification, for the response-with-busy(R1b, R5b) command, the DAT0 will driven to LOW as BUSY status, and in sdhci specification, the transfer complete bit should be wait for BUSY status de-assert. All response-with-busy com

Re: [PATCH u-boot] regmap: fix a serious pointer casting bug

2021-03-16 Thread Simon Glass
Hi Bin, On Tue, 16 Mar 2021 at 21:46, Bin Meng wrote: > > Hi Simon, > > On Tue, Mar 16, 2021 at 2:10 PM Simon Glass wrote: > > > > Hello Marek, > > > > On 03.03.21 14:15, Marek BehĂșn wrote: > > > There is a serious bug in regmap_read() and regmap_write() functions > > > where an uint pointer is

[PATCH v2] riscv: sifive: Rename fu540 board to unleashed

2021-03-16 Thread Bin Meng
In preparation to add SiFive Unmatched board support, let's rename the existing fu540 board to unleashed. Signed-off-by: Bin Meng --- Changes in v2: - fix a typo in the commit message - rename fu540.rst arch/riscv/Kconfig | 6 +++--- arch/riscv/dts/Makefil

Re: [PATCH v2 7/8] board: sifive: add HiFive Unmatched board support

2021-03-16 Thread Green Wan
will fix it. Thanks. - Green On Wed, Mar 17, 2021 at 10:38 AM Bin Meng wrote: > Hi Green, > > On Wed, Mar 17, 2021 at 12:33 AM Green Wan wrote: > > > > Add dts, defconfig and board support for HiFive Unmatched. > > > > Signed-off-by: Green Wan > > --- > > arch/riscv/Kconfig

Re: [PATCH v2 4/8] drivers: ram: sifive: rename fu540_ddr to sifive_ddr

2021-03-16 Thread Green Wan
On Wed, Mar 17, 2021 at 10:34 AM Bin Meng wrote: > Hi Green, > > On Wed, Mar 17, 2021 at 12:33 AM Green Wan wrote: > > > > Rename fu540_ddr.c to sifive_ddr.c for supporting both of fu540 and > > fu740. To avoid 'git mv' info missing, sifive_ddr.c chagnes are > > typo: changes > will fix it. >

Re: [PATCH v2 7/8] board: sifive: add HiFive Unmatched board support

2021-03-16 Thread Bin Meng
Hi Green, On Wed, Mar 17, 2021 at 12:33 AM Green Wan wrote: > > Add dts, defconfig and board support for HiFive Unmatched. > > Signed-off-by: Green Wan > --- > arch/riscv/Kconfig |4 + > arch/riscv/dts/fu740-hifive-unmatched-a00-ddr.dtsi | 1489 > +++

Re: [PATCH v2 4/8] drivers: ram: sifive: rename fu540_ddr to sifive_ddr

2021-03-16 Thread Bin Meng
Hi Green, On Wed, Mar 17, 2021 at 12:33 AM Green Wan wrote: > > Rename fu540_ddr.c to sifive_ddr.c for supporting both of fu540 and > fu740. To avoid 'git mv' info missing, sifive_ddr.c chagnes are typo: changes > included in next patch. > > Signed-off-by: Green Wan > --- > drivers/ram/sifive

Re: [PATCH v2 20/21] binman: Drop repetitive heading for each entry

2021-03-16 Thread Simon Glass
Many entries start 'Entry containing a'. This looks fine in the source code but is annoying when viewed in the htmldocs table of contents. Drop these unnecessary words. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entries.rst| 76 ++---

Re: [PATCH v2 02/21] binman: Document ExpandEntries() in the base class

2021-03-16 Thread Simon Glass
Move the documentation to the base method as it is with other methods. Also update it a little while we are here. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 11 +++ tools/binman/etype/section.py | 6 -- 2 files changed, 11 insertions(+), 6

Re: [PATCH v2 06/21] binman: Add support for u-boot-tpl-nodtb

2021-03-16 Thread Simon Glass
Allow this entry type to be placed in an image. This is the TPL binary, without a devicetree appended. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries| 14 +++ tools/binman/etype/u_boot_tpl_nodtb.py | 27 ++ tools

Re: [PATCH v2 03/21] binman: Update entry help for files-align

2021-03-16 Thread Simon Glass
Regenerate the entry documentation, which step was missed when the files-align feature was added. Fixes: 6eb9932668f ("binman: Support alignment of files") Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries | 1 + 1 file changed, 1 insertion(+) Applied to u-boot

Re: [PATCH v2 07/21] binman: Add support for u-boot-tpl-bss-bad

2021-03-16 Thread Simon Glass
This entry holds the padding between the end of of TPL binary and the end of BSS. This region must be left empty so that the devicetree can be appended correctly and remain accessible without interfering with BSS. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries

Re: [PATCH v2 05/21] binman: Correct the documentation for u-boot-spl-bss-pad

2021-03-16 Thread Simon Glass
The documentation for this entry indicates that the SPL binary is included along with the padding. It is not, so update it to correct the error. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries | 17 ++--- tools/binman/etype/u_boot_spl_b

Re: [PATCH v2 09/21] binman: Allow a way to select expanded entries

2021-03-16 Thread Simon Glass
Add a new command-line option to disable expanded entries. This is needed for most tests, since it is much easier to 'factor out' this function into a separate test and keep the existing packing tests simple. Add the option and select it by default from tests. Signed-off-by: Simon Glass --- (no

Re: [PATCH v2 10/21] binman: Plumb expanded entries through fully

2021-03-16 Thread Simon Glass
Add support for this feature in the control, image and section modules, so that expanded entries will be selected by default. So far there are no expanded entry types, so this is a nop. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/control.py | 24 ++--

Re: [PATCH v2 12/21] Makefile: Pass new entry args to binman

2021-03-16 Thread Simon Glass
To support the use of 'expanded' entries, binman needs to be told whether SPL and TPL have a devicetree and whether they need BSS padding. Add these to the Makefile. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 8 1 file changed, 8 insertions(+) Applied to u-boot-d

Re: [PATCH v2 08/21] binman: Allow using an an 'expanded' entry type

2021-03-16 Thread Simon Glass
As the first step in supporting expanded entries, add a way for binman to automatically select an 'expanded' version of an entry type, if requested. This is controlled by a class method. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 60 ++

Re: [PATCH v2 01/21] binman: Allow extracting to current directory

2021-03-16 Thread Simon Glass
Extracting files to the current directory is not normally a very friendly thing to do, but it can be warranted, e.g. in a new temporary dir. At present binman reports an error when such an attempt is made. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/control.py | 2

Re: [PATCH v2 04/21] binman: Tidy up underscores in entry documentation

2021-03-16 Thread Simon Glass
Several entries currently use an underscore in the entry-type name, but in fact a hyphen is used. Update the docs to fix this as it might be confusing. Also simplify the 'filename' comment and fix the 'operation' typo. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.e

Re: [PATCH v2 11/21] binman: Automatically expand phase binaries into sections

2021-03-16 Thread Simon Glass
When creating an entry, check for an expanded version of that entry, then use it instead. This allows, for example use of: u-boot { }; instead of having to write out in full: u-boot { type = "section"; u-boot-nodtb { }; u-boot-dtb { }; }; Add an imple

Re: [PATCH v2 14/21] x86: dts: Drop unused CONFIG_SPL

2021-03-16 Thread Simon Glass
This cannot be used since the previous #elif has already dealt with SPL. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/dts/u-boot.dtsi | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 13/21] x86: Make use of binman expanded entries

2021-03-16 Thread Simon Glass
We don't need to spell out the separate pieces of U-Boot phase binaries anymore. Revert to using the simple entry and let binman do the expansion itself as needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/dts/u-boot.dtsi | 11 +-- 1 file changed, 1 insertion(+), 10

Re: [PATCH v4 07/42] dm: core: Set up driver model for OF_PLATDATA_INST

2021-03-16 Thread Simon Glass
With this we don't need to scan and bind drivers, not even the root device. We just need to locate the root device that was set up at build time, then set our root in global_data to point to it. Update the code to handle this case. Signed-off-by: Simon Glass --- (no changes since v1) drivers/

Re: [PATCH v2 15/21] doc: Move UEFI under develop/

2021-03-16 Thread Simon Glass
Much of the content here is useful only for development. Move it under that section. Signed-off-by: Simon Glass --- Changes in v2: - Move UEFI under develop/ instead doc/develop/index.rst| 1 + doc/{ => develop}/uefi/index.rst | 4 doc/{ => develop}/uefi/iscs

Re: [PATCH v2 17/21] binman: doc: Add documentation to htmldocs

2021-03-16 Thread Simon Glass
Add a link to binman's documentation and adjust the files so that it is accessible. Use the name README.rst so it is easy to discover when binman is installed without U-Boot. Signed-off-by: Simon Glass --- Changes in v2: - Put binman docs in doc/develop and FIT in doc/usage - Rename README.rst t

Re: [PATCH v2 16/21] doc: Move driver model docs under develop/

2021-03-16 Thread Simon Glass
These docs are useful for developers, not users. Move them under that section. Suggested-by: Heinrich Schuchardt Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to move driver model docs under develop/ doc/{ => develop}/driver-model/bind.rst | 0 doc/{ => develop}

Re: [PATCH v2 19/21] binman: Incorporate entry documentation

2021-03-16 Thread Simon Glass
Update this to avoid sphinx warnings and incorporate it into the new documentaiton tree. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/cmdline.py | 2 +- tools/binman/{README.entries => entries.rst} | 79 +++- tools/binman/etype/cbfs.py

Re: [PATCH v2 18/21] binman: Rearrange documentation into headings

2021-03-16 Thread Simon Glass
Collect the material into different top-level headings to make it easier to read. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/binman.rst | 523 1 file changed, 266 insertions(+), 257 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 21/21] binman: Update various pieces of the documentation

2021-03-16 Thread Simon Glass
A few sections are a little out of date now. Update them. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/binman.rst | 83 ++--- 1 file changed, 44 insertions(+), 39 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 04/42] dm: core: Add macros to access the new linker lists

2021-03-16 Thread Simon Glass
Add macros which work with instantiated devices and uclasses, as created at build time by dtoc. Include variants that can be used in data structures. These are mostly used by dtoc but it is worth documenting them fully for the occasional case where they might come up in user code. Signed-off-by:

Re: [PATCH v4 19/42] sandbox_spl: Increase SPL malloc() size

2021-03-16 Thread Simon Glass
The test framework reinits driver model tests before running each test. Since malloc_simple does not support free(), this eventually runs out of memory. Fix it for now by increasing the space to 32KB. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) confi

Re: [PATCH v4 22/42] sandbox: Create a new sandbox_noinst build

2021-03-16 Thread Simon Glass
Move sandbox_spl over to use OF_PLATDATA_INST. Create a new board to test the case when this is not enabled, since we will be keeping that code around for several months and want to avoid regressions. Skip the dm_test_of_plat_dev() test since driver info is not available for OF_PLATDATA_INST. Sig

Re: [PATCH v4 02/42] sandbox: Drop debug message in os_spl_to_uboot()

2021-03-16 Thread Simon Glass
This is not needed in normal operation. Drop it. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) arch/sandbox/cpu/os.c | 1 - 1 file changed, 1 deletion(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 33/42] dm: doc: Add documentation for of-platdata-inst

2021-03-16 Thread Simon Glass
Add a description of the new features, along with internal technical documentation. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add documentation for of-platdata-inst doc/driver-model/of-plat.rst | 587 +++ 1 file changed, 587 insertio

Re: [PATCH v4 01/42] dtoc: Drop use of DECL() macros

2021-03-16 Thread Simon Glass
We can use extern instead, so let's drop these macros. It adds one more thing to learn about and doesn't make the code any clearer. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to drop DECL() macros from dtoc (to squash in) tools/dtoc/dtb_platdata.py |

Re: [PATCH v4 03/42] linker_lists: Allow use in data structures

2021-03-16 Thread Simon Glass
At present linker lists are designed for use in code. They make use of statements within expressions ({...}), for example. It is possible to generate a reference to a linker_list entry that can be used in data structures, where such features are not permitted. It requires that the reference first

Re: [PATCH v4 05/42] dm: core: Allow dropping run-time binding of devices

2021-03-16 Thread Simon Glass
With OF_PLATDATA_INST devices are bound at build time. We should not need binding of devices at runtime in most cases. However it is inflexible to absolutely prohibit it, so add an option to control this. Update the driver model core so that it does not bind devices. Update device_bind() to return

Re: [PATCH v4 06/42] dm: core: Adjust uclass setup with of-platdata

2021-03-16 Thread Simon Glass
When OF_PLATDATA_INST is enabled we don't need to create the uclass list. Instead we just need to point to the existing list. Update the code accordingly. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/root.c | 8 ++-- include/dm/root.h | 3 +++ 2 files changed, 9 inse

Re: [PATCH v4 35/42] x86: apl: Fix the header order in pmc

2021-03-16 Thread Simon Glass
The dm.h header should come first. In fact it needs to, since otherwise the driver model definitions are not available to dt-structs.h Fix this, since it causes problems with OF_PLATDATA_INST. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/pmc.c | 2 +- 1 file ch

Re: [PATCH v4 08/42] dm: core: Skip adding uclasses with OF_PLATDATA_INST

2021-03-16 Thread Simon Glass
There is no need to ever add new uclasses since these are set up at build time. Update the code to return an error if this is attempted. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/uclass.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Applied to u-boot-dm/ne

Re: [PATCH v4 09/42] dm: Add the new dtoc-generated files to the build

2021-03-16 Thread Simon Glass
Now that dtoc generates some new C files, add these to the build so that the instantiated devices and uclasses can be used. Signed-off-by: Simon Glass --- (no changes since v1) scripts/Makefile.spl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 10/42] dm: core: Include dt-decl.h automatically

2021-03-16 Thread Simon Glass
When dt-structs.h is used, include the dt-decl.h header as well, so that these declarations are available. Signed-off-by: Simon Glass --- (no changes since v1) include/dt-structs.h | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 11/42] dm: test: Avoid destroying uclasses with of-platdata-inst

2021-03-16 Thread Simon Glass
It is not possible to destroy the uclasses when they are created at build time. Skip this step so that SPL test can complete successfully. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Update to deal with test refactoring series test/test-main.c | 30 ++

Re: [PATCH v4 12/42] clk: sandbox: Move priv/plat data to a header file

2021-03-16 Thread Simon Glass
At present the structs used by this driver are not accessible outside it, so cannot be used with OF_PLATDATA_INST. Move them to a header file to fix this. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/include/asm/clk.h | 16 drivers/clk/clk_sandbox.c |

Re: [PATCH v4 13/42] clk: fixed-rate: Export driver parts for OF_PLATDATA_INST

2021-03-16 Thread Simon Glass
We need to allow SoCs to create their own drivers for this so that they can use their own of-platdata structs. To minimise code duplication, export the driver operations and the ofdata_to_plat() setup function. Signed-off-by: Simon Glass --- (no changes since v1) drivers/clk/clk_fixed_rate.c |

Re: [PATCH v4 14/42] clk: sandbox: Create a special fixed-rate driver

2021-03-16 Thread Simon Glass
Create a version of this driver for sandbox so that it can use the of-platdata struct. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox.dtsi | 2 +- arch/sandbox/include/asm/clk.h | 8 drivers/clk/clk_sandbox.c | 33

Re: [PATCH v4 15/42] dm: core: Drop device_get_by_driver_info()

2021-03-16 Thread Simon Glass
This function is now only used in a test. Drop it. Also drop DM_DRVINFO_GET() which was the only purpose for having the function. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Drop DM_DRVINFO_GET() also drivers/core/device.c | 15 --- include/dm/device.h

Re: [PATCH v4 16/42] dm: core: Drop uclass_find_device_by_phandle() with of-platdata

2021-03-16 Thread Simon Glass
At present this function is included in the build but with of-platdata it only services to produce a confusing link error complaining about a call to dev_read_u32_default(). Drop it so that any call to uclass_find_device_by_phandle() is flagged as an error, making it easier to see what is going on

Re: [PATCH v4 18/42] dm: Rename device_get_by_driver_info_idx()

2021-03-16 Thread Simon Glass
This function finds a device by its driver_info index. With of-platdata-inst we do not use driver_info, but instead instantiate udevice records at build-time. However the semantics of using the function are the same in each case: the caller provides an index and gets back a device. So rename the

Re: [PATCH v4 17/42] sandbox: i2c: Move platdata structs to header files

2021-03-16 Thread Simon Glass
At present the structs used by these drivers are declared in the C files and so are not accessible to dtoc. Move them to header files, as required. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/include/asm/i2c.h | 15 +++ arch/sandbox/include/asm/rtc.h | 24

Re: [PATCH v4 20/42] sandbox: i2c: Support i2c emulation with of-platdata

2021-03-16 Thread Simon Glass
At present the i2c emulators require access to the devicetree, which is not possible (by design) with of-platdata. Add a way for drivers to record the of-platdata index of their emulator, so that we can still find the emulator. This allows i2c emulation to work with of-platdata. Signed-off-by: S

Re: [PATCH v4 21/42] Revert "sandbox: Disable I2C emulators in SPL"

2021-03-16 Thread Simon Glass
With recent changes this can be supported again. Add it back. This reverts commit d85f2c4f2970d0ec2f5f075de734afd11200d153. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox.dtsi | 10 +++--- configs/sandbox_spl_defconfig | 1 + drivers/i2c/Makefile |

Re: [PATCH v4 23/42] test: Run sandbox_spl tests on sandbox_noinst

2021-03-16 Thread Simon Glass
Run the tests on this build too, to prevent regressions. Signed-off-by: Simon Glass --- (no changes since v1) test/run | 4 1 file changed, 4 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 24/42] azure/gitlab: Add tests for sandbox_noinst

2021-03-16 Thread Simon Glass
Add this new board to the test plans. Travis-CI is left out, since it is being removed soon due to lack of capacity. Signed-off-by: Simon Glass --- (no changes since v1) .azure-pipelines.yml | 3 +++ .gitlab-ci.yml | 10 +- 2 files changed, 12 insertions(+), 1 deletion(-) Appli

Re: [PATCH v4 25/42] dm: core: Add an option to support SPL in read-only memory

2021-03-16 Thread Simon Glass
Some systems (e.g. x86 APL) run SPL from read-only memory. The device instances created by dtoc are therefore not writeable. To make things work we would need to copy the devices to read/write memory. To avoid this, add an option to use a separate runtime struct for devices, just as is done for dr

Re: [PATCH v4 26/42] dm: core: Create a struct for device runtime info

2021-03-16 Thread Simon Glass
At present when driver model needs to change a device it simply updates the struct udevice structure. But with of-platdata-inst most of the fields are not modified at runtime. In fact, typically only the flags need to change. For systems running SPL from read-only memory it is convenient to separa

Re: [PATCH v4 27/42] dm: core: Move flags to device-runtime info

2021-03-16 Thread Simon Glass
When of-platdata-inst is active, use the flags in the new udevice_rt table, dropping them from the main struct udevice. This ensures that the latter is not updated at runtime. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Leave the flags_ memeber in the same struct posit

Re: [PATCH v4 28/42] dm: core: Allow storing priv/plat data separately

2021-03-16 Thread Simon Glass
At present the device priv/data data allocated by dtoc is stored in the data section along with other variables. On some platforms it is better to allocate space for it separately, e.g. if SPL is running from read-only memory. Create a new space with the same size as that allocated by dtoc, ready

Re: [PATCH v4 29/42] sandbox: Define a region for device priv/plat data

2021-03-16 Thread Simon Glass
Collect this together in one place, so driver model can access set it up in a new place if needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/u-boot-spl.lds | 8 1 file changed, 8 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 30/42] dm: core: Use separate priv/plat data region

2021-03-16 Thread Simon Glass
Make use of the new priv/plat data region if enabled. This is implemented as a simple offset from the position set up by dtoc to the new position. So long as all access goes through dm_priv_to_rw() this is safe. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device.c | 12 +

Re: [PATCH v4 34/42] x86: Define a region for device priv/plat data

2021-03-16 Thread Simon Glass
Collect this together in one place, so driver model can access set it up in a new place if needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/u-boot-spl.lds | 8 1 file changed, 8 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 32/42] dm: doc: Tidy up of-platdata docs

2021-03-16 Thread Simon Glass
This doc has a few pieces that are out-of-date. Fix these. Also we have started to use 'devicetree' instead of 'device tree' or 'device-tree' since it is easier to see as a single term, so replace all ocurrences accordingly. Also move the caveats to the end, since this is a fairly solid part of U-

Re: [PATCH v4 31/42] dm: core: Add warnings to private / platform setters

2021-03-16 Thread Simon Glass
Add a warning to each of these functions so that people do not attempt to use them outside driver model. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Aew patch with warnings for private / platform setters include/dm/device-internal.h | 18 ++ include/d

Re: [PATCH v4 36/42] x86: apl: Tell of-platdata about a required header file

2021-03-16 Thread Simon Glass
This enum is needed to generate build-time devices. Tell dtoc where to find the header, to avoid compile errors in the generated code. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/punit.c | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 37/42] x86: itss: Tidy up bind() for of-platdata-inst

2021-03-16 Thread Simon Glass
With the standard of-platdata we must fix up driver_data manually. With of-platadata-inst this is not necessary, since it is added to the device by dtoc. Update the code to handle this. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/intel_common/itss.c | 5 +++-- 1 file cha

Re: [PATCH v4 38/42] x86: Support a fake PCI device with of-platdata-inst

2021-03-16 Thread Simon Glass
With TPL we don't need full PCI support and it adds to code size. Instead, a simple_bus driver is good enough to be able to read and write the PCI config and do a little basic setup. So at present there are two drivers in U-Boot called pci_x86. One is in UCLASS_PCI, used in SPL and U-Boot proper.

Re: [PATCH v4 41/42] x86: coral: Drop TPM and ACPI interrupts from TPL

2021-03-16 Thread Simon Glass
These devices are not actually built in TPL but are currently active in the TPL devicetree. For of-platdata-inst this means that we will try to generate devices for them, which fails. Update them to be active only in U-Boot proper. Signed-off-by: Simon Glass --- (no changes since v3) Changes i

Re: [PATCH v4 39/42] x86: Don't include reset driver in SPL

2021-03-16 Thread Simon Glass
We don't normally need this driver in TPL/SPL, so drop it for now. It can be enabled by individual boards if needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/dts/reset.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 42/42] x86: apl: Use read-only SPL and new of-platdata

2021-03-16 Thread Simon Glass
With Apollo Lake, SPL is placed in read-only memory. Set this new option so that OF_PLATDATA_INST can be used. Signed-off-by: Simon Glass --- Changes in v4: - Rebase to -next arch/x86/cpu/apollolake/Kconfig | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 40/42] x86: coral: Drop ACPI properties from of-platdata

2021-03-16 Thread Simon Glass
We don't use these in TPL or SPL, so drop them. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Don't drop 'ranges' since we use the full PCI driver in SPL configs/chromebook_coral_defconfig | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH 1/2] of: addr: Abort address translation for parent nodes missing 'ranges'

2021-03-16 Thread Bin Meng
Hi Dario, On Wed, Mar 17, 2021 at 4:57 AM Dario Binacchi wrote: > > Hi Bin, > > > Il 16/03/2021 02:28 Bin Meng ha scritto: > > > > > > Hi Dario, > > > > On Tue, Mar 16, 2021 at 6:49 AM Dario Binacchi wrote: > > > > > > > > > > Il 15/03/2021 19:23 Simon Glass ha scritto: > > > > > > > > > > > >

Re: [PATCH 0/2] power: move power_max77696_init() to board file

2021-03-16 Thread Simon Glass
On Wed, 17 Mar 2021 at 10:52, Jaehoon Chung wrote: > > Dear Tom, > > On 1/28/21 8:42 PM, Jaehoon Chung wrote: > > It's only one board which is using max_77696_init(). > > pmic_max77696.c didn't convert from no-DM to DM. > > So it's waste to maintain in driver directory. > > Is there any opinion? I

Re: [PATCH 0/2] power: move power_max77696_init() to board file

2021-03-16 Thread Peter Robinson
On Tue, Mar 16, 2021 at 10:25 PM Tom Rini wrote: > > On Wed, Mar 17, 2021 at 06:53:16AM +0900, Jaehoon Chung wrote: > > Dear Tom, > > > > On 1/28/21 8:42 PM, Jaehoon Chung wrote: > > > It's only one board which is using max_77696_init(). > > > pmic_max77696.c didn't convert from no-DM to DM. > > >

Re: Patches pending for review

2021-03-16 Thread Tom Rini
On Tue, Mar 16, 2021 at 11:24:10PM +0100, Daniel Schwierzeck wrote: > Am Montag, den 15.03.2021, 21:24 + schrieb Aleksandar Gerasimovski: > > Hi Folks, > > > > Hope you are all well! > > > > I guess you have verry busy times, but I have to ask about the state > > of my last two patches on pat

Re: [PATCH 0/2] power: move power_max77696_init() to board file

2021-03-16 Thread Tom Rini
On Wed, Mar 17, 2021 at 06:53:16AM +0900, Jaehoon Chung wrote: > Dear Tom, > > On 1/28/21 8:42 PM, Jaehoon Chung wrote: > > It's only one board which is using max_77696_init(). > > pmic_max77696.c didn't convert from no-DM to DM. > > So it's waste to maintain in driver directory. > > Is there any

Re: Patches pending for review

2021-03-16 Thread Daniel Schwierzeck
Am Montag, den 15.03.2021, 21:24 + schrieb Aleksandar Gerasimovski: > Hi Folks, > > Hope you are all well! > > I guess you have verry busy times, but I have to ask about the state > of my last two patches on patchwork: > > https://patchwork.ozlabs.org/project/uboot/patch/vi1pr06mb402989c0efe

Re: [PATCH 0/2] power: move power_max77696_init() to board file

2021-03-16 Thread Jaehoon Chung
Dear Tom, On 1/28/21 8:42 PM, Jaehoon Chung wrote: > It's only one board which is using max_77696_init(). > pmic_max77696.c didn't convert from no-DM to DM. > So it's waste to maintain in driver directory. Is there any opinion? If there is no objection about this, let me know, plz. I hope that re

Re: [PATCH 2/2] mmc: mmc-uclass: Assign devnum as alias index in SPL too if CONFIG_SPL_DM_SEQ_ALIAS is enabled

2021-03-16 Thread Jaehoon Chung
On 3/15/21 7:48 PM, Aswath Govindraju wrote: > Assign the nodes alias index as the device number in SPL too, if > CONFIG_SPL_DM_SEQ_ALIAS is enabled. > > Signed-off-by: Aswath Govindraju Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/mmc-uclass.c | 10 +-

Re: [PATCH 1/2] mmc: Check for device with a seq number equal to num before checking against index

2021-03-16 Thread Jaehoon Chung
On 3/15/21 7:48 PM, Aswath Govindraju wrote: > First check if there is an alias for the device tree node defined with the > given num before checking against device index. > > Signed-off-by: Aswath Govindraju Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/mmc.c |

Re: [PATCH 06/34] x86: coral: Update the SD card-detect GPIO

2021-03-16 Thread Jaehoon Chung
On 3/15/21 2:00 PM, Simon Glass wrote: > Since the recent bug fix, it doesn't matter which GPIO phandle is used so > long as the GPIO number is right. Still, we may as well use the correct > one to avoid confusion. > > Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung Best Regards, Jaehoo

Re: [PATCH 05/34] x86: coral: Put the eMMC first

2021-03-16 Thread Jaehoon Chung
On 3/15/21 2:00 PM, Simon Glass wrote: > At present the eMMC device does not have an alias so it appears after > the SD card which is device 1. There is no device 0 which is odd. > > Make the eMMC device be the first one. Update the boot script to use the > new device. > > Signed-off-by: Simon Gl

Re: [PATCH] board: hoperun: Enable recovery SPL for HiHope RZ/G2[HMN] boards

2021-03-16 Thread Lad, Prabhakar
Hi Marek, Thank you for the review. On Mon, Mar 15, 2021 at 11:40 PM Marek Vasut wrote: > > On 3/15/21 11:07 PM, Lad Prabhakar wrote: > > Enable building SPL for HiHope RZ/G2[HMN] boards. > > What is the reason for building the SPL ? > To enable support for recovery using SPL (as done on R-Car p

Re: [PATCH 1/2] of: addr: Abort address translation for parent nodes missing 'ranges'

2021-03-16 Thread Dario Binacchi
Hi Bin, > Il 16/03/2021 02:28 Bin Meng ha scritto: > > > Hi Dario, > > On Tue, Mar 16, 2021 at 6:49 AM Dario Binacchi wrote: > > > > > > > Il 15/03/2021 19:23 Simon Glass ha scritto: > > > > > > > > > +Tom Rini too > > > > > > > > > On Tue, 16 Mar 2021 at 03:48, Bin Meng wrote: > > > > > >

[PATCH v2] bus: ti-sysc: change in a normal driver

2021-03-16 Thread Dario Binacchi
The module defines a duplicate uclass driver for UCLASS_SIMPLE_BUS, but it is not allowed. This breaks of-platdata and makes the result non-deterministic. The driver does not need to be an uclass driver, so lets remove it. I had turned it into an uclass driver because I thought wrongly it had to c

Re: [PATCH 1/1] imx6: icorem6: chmod 644 enigcam.bmp

2021-03-16 Thread Michael Nazzareno Trimarchi
On Tue, Mar 16, 2021 at 9:46 PM Heinrich Schuchardt wrote: > > Bitmap files should not be executable. > > Signed-off-by: Heinrich Schuchardt > --- > tools/logos/engicam.bmp | Bin > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100755 => 100644 tools/logos/engicam.bmp Reviewed-

[PATCH 1/1] imx6: icorem6: chmod 644 enigcam.bmp

2021-03-16 Thread Heinrich Schuchardt
Bitmap files should not be executable. Signed-off-by: Heinrich Schuchardt --- tools/logos/engicam.bmp | Bin 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 tools/logos/engicam.bmp diff --git a/tools/logos/engicam.bmp b/tools/logos/engicam.bmp old mode 100755 new m

Re: [PATCH 5/6 v3] efidebug: add multiple device path instances on Boot####

2021-03-16 Thread Heinrich Schuchardt
On 3/14/21 8:05 PM, Ilias Apalodimas wrote: The UEFI spec allows a packed array of UEFI device paths in the FilePathList[] of an EFI_LOAD_OPTION. The first file path must describe the loaded image but the rest are OS specific. Previous patches parse the device path and try to use the second memb

Re: [PATCH 1/6 v3] efi_selftest: Remove loadfile2 for initrd selftests

2021-03-16 Thread Heinrich Schuchardt
On 3/14/21 8:05 PM, Ilias Apalodimas wrote: We are redefining how u-boot locates the initrd to load via the kernel LoadFile2 protocol. This selftest is not relevant any more, so remove it. A new one will be added later Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt Applied

Re: Flaky EFI test

2021-03-16 Thread Heinrich Schuchardt
On 16.03.21 02:57, Bin Meng wrote: > On Tue, Mar 16, 2021 at 3:08 AM Tom Rini wrote: >> >> On Tue, Mar 16, 2021 at 07:23:23AM +1300, Simon Glass wrote: >> >>> Hi Heinrich, >>> >>> This job failed: >>> >>> https://source.denx.de/u-boot/custodians/u-boot-sh/-/jobs/238476 >>> >>> Do you think this is

[PATCH] ahci: mediatek: fix undefined reference of dev_err

2021-03-16 Thread Frank Wunderlich
From: Frank Wunderlich building with MTK_AHCI enabled results in implicit declaration and undefined reference of dev_err followed by a segfault of gcc drivers/ata/mtk_ahci.c: In function 'mtk_ahci_parse_property': drivers/ata/mtk_ahci.c:65:4: warning: implicit declaration of function 'dev_err' d

[PATCH v2 7/8] board: sifive: add HiFive Unmatched board support

2021-03-16 Thread Green Wan
Add dts, defconfig and board support for HiFive Unmatched. Signed-off-by: Green Wan --- arch/riscv/Kconfig |4 + arch/riscv/dts/fu740-hifive-unmatched-a00-ddr.dtsi | 1489 arch/riscv/dts/hifive-unmatched-a00-u-boot.dtsi| 40 + arch/r

Re: [PATCH] arm: omap3: Make try_unlock_memory() static

2021-03-16 Thread Tom Rini
On Tue, Mar 16, 2021 at 12:18:05PM -0500, Adam Ford wrote: > On Mon, Mar 15, 2021 at 1:43 AM Lokesh Vutla wrote: > > > > > > > > On 07/03/21 9:23 am, Adam Ford wrote: > > > try_unlock_memory() is only used in one file, so make it static > > > in that file and remove it from the sys_proto header fi

Re: [PATCH] arm: omap3: Make try_unlock_memory() static

2021-03-16 Thread Adam Ford
On Mon, Mar 15, 2021 at 1:43 AM Lokesh Vutla wrote: > > > > On 07/03/21 9:23 am, Adam Ford wrote: > > try_unlock_memory() is only used in one file, so make it static > > in that file and remove it from the sys_proto header file. This > > may help with some further optimization in the future. > > >

[PATCH] efi_loader: NULL dereference in EFI console

2021-03-16 Thread Heinrich Schuchardt
Even if CONFIG_DM_VIDEO=y and stdout="vidconsole" a video device may not be available. Check the return values of the relevant functions. If no video output device is available, assume that the serial console is in use. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_console.c | 51 ++

Re: [PATCH u-boot v3.1 01/39] regmap: fix a serious pointer casting bug

2021-03-16 Thread Marek Behun
On Tue, 16 Mar 2021 22:04:17 +0530 Pratyush Yadav wrote: > > + switch (map->width) { > > + case REGMAP_SIZE_8: > > + *valp = u.v8; > > + break; > > + case REGMAP_SIZE_16: > > + *valp = u.v16; > > + break; > > + case REGMAP_SIZE_32: > > + *

Re: Pull request for efi-2021-04-rc5

2021-03-16 Thread Tom Rini
On Tue, Mar 16, 2021 at 12:34:42PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 4103e13534141c31e4e9bf40848ab3a61dabce81: > > Prepare v2021.04-rc4 (2021-03-15 12:06:41 -0400) > > are available in the Git repository at: > > https://source.denx.de/u-bo

Re: [PATCH u-boot v3.1 01/39] regmap: fix a serious pointer casting bug

2021-03-16 Thread Pratyush Yadav
Hi Marek, On 16/03/21 04:07PM, Marek BehĂșn wrote: > There is a serious bug in regmap_read() and regmap_write() functions > where an uint pointer is cast to (void *) which is then cast to (u8 *), > (u16 *), (u32 *) or (u64 *), depending on register width of the map. > > For example given a regmap

[PATCH v2 6/8] drivers: pci: add pcie support for fu740

2021-03-16 Thread Green Wan
Add pcie driver for SiFive fu740, the driver depends on fu740 gpio, clk and reset driver to do init. Force running at Gen1 for better capatible enumeration. Several devices are tested: a) M.2 NVMe SSD b) USB-to-PCI adapter c) Ethernet adapter (E1000 compatible) Signed-off-by: Green Wan --- driv

[PATCH v2 3/8] drivers: clk: add fu740 support

2021-03-16 Thread Green Wan
Add fu740 support. One abstract layer is added for supporting multiple chips such as fu540 and fu740. Signed-off-by: Green Wan --- drivers/clk/sifive/Kconfig | 8 +- drivers/clk/sifive/Makefile | 4 +- drivers/clk/sifive/fu540-prci.c | 769 ++-

[PATCH v2 8/8] drivers: net: macb: add fu740 support

2021-03-16 Thread Green Wan
From: David Abdurachmanov Add fu740 support to macb ethernet driver Signed-off-by: David Abdurachmanov Signed-off-by: Green Wan Reviewed-by: Ramon Fried --- drivers/net/macb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c i

  1   2   >