On Tue, Mar 16, 2021 at 12:18:05PM -0500, Adam Ford wrote: > On Mon, Mar 15, 2021 at 1:43 AM Lokesh Vutla <lokeshvu...@ti.com> wrote: > > > > > > > > On 07/03/21 9:23 am, Adam Ford wrote: > > > try_unlock_memory() is only used in one file, so make it static > > > in that file and remove it from the sys_proto header file. This > > > may help with some further optimization in the future. > > > > > > Signed-off-by: Adam Ford <aford...@gmail.com> > > > > one of omap3 board is failing to build. Can you take a look? > > > > https://source.denx.de/u-boot/custodians/u-boot-ti/-/jobs/237886 > > > > Question on preference...Would you prefer I move the unused function > into the #ifdef area, or should I just mark the function as > __maybe_unused? I am not a fan of #ifdef, but I can move the > function there that is your preference.
If there's already an #ifdef we should restructure the code to live there, yes. -- Tom
signature.asc
Description: PGP signature