Re: [PATCH v2 1/1] cmd: gpt: add eMMC and GPT support

2020-05-07 Thread Michael Nazzareno Trimarchi
Hi On Fri, May 8, 2020 at 8:05 AM Rayagonda Kokatanur wrote: > > From: Corneliu Doban > > Add eMMC and GPT support. > - GPT partition list and command to create the GPT added to u-boot > environment > - eMMC boot commands added to u-boot environment > - new gpt commands (enumarate and setenv)

Re: [PATCH] drivers: net: fsl-mc: fixup msi-map property

2020-05-07 Thread Diana Madalina Craciun
Reviewed-by: Diana Craciun On 5/4/2020 2:47 PM, Laurentiu Tudor wrote: > Similarly to iommu-map, the msi-map property must also be fixed up > in the device tree, in order for the icid -> streamid translation > be possible in the MSI case as well. > > Signed-off-by: Laurentiu Tudor > --- > drive

[PATCH v2 1/1] cmd: gpt: add eMMC and GPT support

2020-05-07 Thread Rayagonda Kokatanur
From: Corneliu Doban Add eMMC and GPT support. - GPT partition list and command to create the GPT added to u-boot environment - eMMC boot commands added to u-boot environment - new gpt commands (enumarate and setenv) that are used by broadcom update scripts and boot commands - eMMC specific u

RE: [PATCH v7 04/22] lib: Makefile: build crc7.c when CONFIG_MMC_SPI

2020-05-07 Thread Pragnesh Patel
>-Original Message- >From: U-Boot On Behalf Of Pragnesh Patel >Sent: 05 May 2020 21:25 >To: Jagan Teki ; Heinrich Schuchardt >; Bin Meng >Cc: U-Boot Mailing List ; Atish Patra >; Palmer Dabbelt ; Paul >Walmsley ; Troy Benjegerdes >; Anup Patel ; Sagar >Kadam ; Rick Chen ; Peng >Fan ; Luka

[PATCH] efi_loader: variable: check a return value of uuid__str_to_bin()

2020-05-07 Thread AKASHI Takahiro
The only error case is that a given UUID is in wrong format. So just return EFI_INVALID_PARAMETER here. Signed-off-by: AKASHI Takahiro Reported-by: Coverity (CID 300333) --- lib/efi_loader/efi_variable.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_v

[PATCH] efi_loader: image_loader: fix a Coverity check against array access

2020-05-07 Thread AKASHI Takahiro
Coverity detected: Using "&opt->CheckSum" as an array. This might corrupt or misinterpret adjacent memory locations. The code should work as far as a structure, IMAGE_OPTIONAL_HEADER(64) is packed, but modify it in more logical form. Subsystem is a member next to CheckSum. Signed-off-by: AKA

[PATCH] cmd: env: fix unreachable statements

2020-05-07 Thread AKASHI Takahiro
C's switch statement takes an integer value for switching. As efi_status_t is defined as unsigned long and each error code has the top bit set, all "cases" cannot be reachable. Signed-off-by: AKASHI Takahiro Reported-by: Coverity (CID 300335) --- cmd/nvedit_efi.c | 20 ++-- 1 fil

[PATCH] efi_loader: variable: fix an reachable statement

2020-05-07 Thread AKASHI Takahiro
The code should jump into error recovery instead of just returning an error. Signed-off-by: AKASHI Takahiro Reported-by: Coverity (CID 300332) --- lib/efi_loader/efi_variable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_

[PATCH] cmd: efidebug: add a comment against Coverity check (300329)

2020-05-07 Thread AKASHI Takahiro
The check here, "Null pointer dereferences," is a false positive. So leave a comment. Signed-off-by: AKASHI Takahiro Reported-by: Coverity (CID 300329) --- cmd/efidebug.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 9769aeeac58b..70aba446a937 100

[PATCH] cmd: efidebug: fix a wrong handling of arguments

2020-05-07 Thread AKASHI Takahiro
Coverity detected a dead code, but actually there is a bug in a check against a number of arguments. So simply fix it. Signed-off-by: AKASHI Takahiro Reported-by: Coverity (CID 300330) --- cmd/efidebug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/efidebug.c b/cmd/efi

Pull request for UEFI sub-system for efi-2020-07-rc2 (3)

2020-05-07 Thread Heinrich Schuchardt
The following changes since commit 69bf66ad8c0d53cc5e64d0f4f2e3bc9ad18e61aa: Merge branch '2020-05-06-master-imports' (2020-05-07 09:02:28 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2020-07-rc2-3 for you to fetch changes u

Re: [PATCH] imx8mp_evk: Make SPL binary size smaller

2020-05-07 Thread Fabio Estevam
Hi Marek, On Thu, May 7, 2020 at 11:56 PM Fabio Estevam wrote: > I will activate them on SPL tomorrow. After activating the SPL clocks I see: clk 69 [ ] imx_clk_gate2 | | `-- dram1_root_clk The dram1_root_clk is not getting turned on. This clock is marked as CLK_IS_C

Re: wandboard does not boot with current mainline

2020-05-07 Thread Heiko Schocher
Hello Fabio, Am 07.05.2020 um 23:16 schrieb Fabio Estevam: Hi Heiko, On Thu, May 7, 2020 at 9:12 AM Heiko Schocher wrote: Hello Fabio, I have my wandboard DL in my automated daily build setup example: http://xeidos.ddns.net/ubtestresults/ and wondered, why my last result is from may 4th .

[PATCH] ddr: k3-am654: EMIF Tool update to 2.02 for IO optimizations and fixes

2020-05-07 Thread praneeth
From: Praneeth Bajjuri EMIF tool for AM65x [1] is now updated from rev 1.98 to 2.02 This update includes * Optimizations in IO configuration. * Fix for byte enablement in GCR registers. * Fixes for PG2.0 including ZQ control. [1]: http://www.ti.com/lit/zip/sprcah7 Acked-by: James Doublesin Si

Re: wandboard does not boot with current mainline

2020-05-07 Thread Heiko Schocher
Hello Tom, Am 07.05.2020 um 16:38 schrieb Tom Rini: On Thu, May 07, 2020 at 02:53:49PM +0200, Heiko Schocher wrote: Hello Fabio, Am 07.05.2020 um 14:12 schrieb Heiko Schocher: Hello Fabio, I have my wandboard DL in my automated daily build setup example: http://xeidos.ddns.net/ubtestresults

Re: [PATCH] imx8mp_evk: Make SPL binary size smaller

2020-05-07 Thread Fabio Estevam
Hi Marek, On Thu, May 7, 2020 at 11:59 PM Marek Vasut wrote: > Enable CONFIG_WATCHDOG in your U-Boot config, that will enable WDT > servicing. Thanks. I changed the defconfig like this: --- a/configs/imx8mm_evk_defconfig +++ b/configs/imx8mm_evk_defconfig @@ -85,5 +85,4 @@ CONFIG_SPL_SYSRESET=

Re: [PATCH] kbuild: add -Werror=implicit-function-declaration

2020-05-07 Thread Simon Glass
Hi Masahiro, On Thu, 7 May 2020 at 19:54, Masahiro Yamada wrote: > > On Fri, May 8, 2020 at 10:39 AM Simon Glass wrote: > > > > Hi Masahiro, > > > > On Thu, 7 May 2020 at 06:21, Masahiro Yamada > > wrote: > > > > > > Add -Werror=implicit-function-declaration as Linux does. > > > > > > If you do

Re: USB keyboard with XHCI on x86?

2020-05-07 Thread Bin Meng
Hi Simon, On Fri, May 8, 2020 at 10:38 AM Simon Glass wrote: > > Hi Bin, > > Does this work for you? It doesn't work for me in interrupt mode, only > in control-endpoint mode. Is that expected? > > Also I notice that some broken devices don't work or cause a crash. > I don't have a board to test

Re: [PATCH] imx8mp_evk: Make SPL binary size smaller

2020-05-07 Thread Marek Vasut
On 5/8/20 4:56 AM, Fabio Estevam wrote: > Hi Marek, > > On Thu, May 7, 2020 at 10:40 PM Marek Vasut wrote: > >> Disable tiny printf in SPL, because that's really broken with >> dm_dump_all(), run dm_dump_all() just after power_init_board() in >> board/freescale/imx8m{p,q}_evk/spl.c and compare

Re: USB keyboard with XHCI on x86?

2020-05-07 Thread Marek Vasut
On 5/8/20 4:41 AM, Simon Glass wrote: > Hi Marek, > > On Thu, 7 May 2020 at 20:39, Marek Vasut wrote: >> >> On 5/8/20 4:38 AM, Simon Glass wrote: >>> Hi Bin, >>> >>> Does this work for you? It doesn't work for me in interrupt mode, only >>> in control-endpoint mode. Is that expected? >>> >>> Also

Re: [PATCH] imx8mp_evk: Make SPL binary size smaller

2020-05-07 Thread Fabio Estevam
Hi Marek, On Thu, May 7, 2020 at 10:40 PM Marek Vasut wrote: > Disable tiny printf in SPL, because that's really broken with > dm_dump_all(), run dm_dump_all() just after power_init_board() in > board/freescale/imx8m{p,q}_evk/spl.c and compare the results. There is > likely gonna be a missing d

Re: USB keyboard with XHCI on x86?

2020-05-07 Thread Simon Glass
Hi Marek, On Thu, 7 May 2020 at 20:39, Marek Vasut wrote: > > On 5/8/20 4:38 AM, Simon Glass wrote: > > Hi Bin, > > > > Does this work for you? It doesn't work for me in interrupt mode, only > > in control-endpoint mode. Is that expected? > > > > Also I notice that some broken devices don't work

Re: [PATCH] ARM: uniphier: delete or replace includes

2020-05-07 Thread Simon Glass
Hi Masahiro, On Thu, 7 May 2020 at 20:31, Masahiro Yamada wrote: > > Hi Simon, > > > On Fri, May 8, 2020 at 10:37 AM Simon Glass wrote: > > > > Hi Masahiro, > > > > On Thu, 7 May 2020 at 07:10, Masahiro Yamada > > wrote: > > > > > > pulls in a lot of bloat. is unneeded in most of > > > places

Re: USB keyboard with XHCI on x86?

2020-05-07 Thread Marek Vasut
On 5/8/20 4:38 AM, Simon Glass wrote: > Hi Bin, > > Does this work for you? It doesn't work for me in interrupt mode, only > in control-endpoint mode. Is that expected? > > Also I notice that some broken devices don't work or cause a crash. I recall some keyboards didn't work in interrupt mode,

USB keyboard with XHCI on x86?

2020-05-07 Thread Simon Glass
Hi Bin, Does this work for you? It doesn't work for me in interrupt mode, only in control-endpoint mode. Is that expected? Also I notice that some broken devices don't work or cause a crash. Regards, SImon

Re: [PATCH] ARM: uniphier: delete or replace includes

2020-05-07 Thread Masahiro Yamada
Hi Simon, On Fri, May 8, 2020 at 10:37 AM Simon Glass wrote: > > Hi Masahiro, > > On Thu, 7 May 2020 at 07:10, Masahiro Yamada > wrote: > > > > pulls in a lot of bloat. is unneeded in most of > > places. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > > > I'm wary of this. I think tha

Re: [PATCH] kbuild: add -Werror=implicit-function-declaration

2020-05-07 Thread Masahiro Yamada
On Fri, May 8, 2020 at 10:39 AM Simon Glass wrote: > > Hi Masahiro, > > On Thu, 7 May 2020 at 06:21, Masahiro Yamada > wrote: > > > > Add -Werror=implicit-function-declaration as Linux does. > > > > If you do not check the prototype, it may go wrong run-time. > > It is better to break the build,

Re: [PATCH] imx8mp_evk: Make SPL binary size smaller

2020-05-07 Thread Marek Vasut
On 5/8/20 3:07 AM, Fabio Estevam wrote: > On Thu, May 7, 2020 at 8:59 AM Fabio Estevam wrote: >> >> Commit f24dea4e1b52 ("ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK") caused >> the u-boot-spl.bin binary size to grow by around 2000 bytes, which makes the >> board to fail to boot. > > The new S

Re: [PATCH 1/2] test: describe naming conventions for macro UNIT_TEST

2020-05-07 Thread Simon Glass
On Wed, 6 May 2020 at 17:28, Stephen Warren wrote: > > On 5/6/20 10:26 AM, Heinrich Schuchardt wrote: > > Strict naming conventions have to be followed for Python function > > generate_ut_subtest() to collect C unit tests to be executed via > > command 'ut'. > > > > Describe the requirements both

Re: [RFC] dm: uclass: add functions to get device by platdata

2020-05-07 Thread Simon Glass
Hi Walter, On Wed, 6 May 2020 at 06:57, Walter Lozano wrote: > > Hi Simon, > > On 23/4/20 00:38, Walter Lozano wrote: > > Hi Simon, > > > > On 21/4/20 14:36, Simon Glass wrote: > >> Hi Walter, > >> > >> On Fri, 17 Apr 2020 at 15:18, Walter Lozano > >> wrote: > >>> Hi Simon, > >>> > >>> On 9/4/20

Re: [PATCH] kbuild: add -Werror=implicit-function-declaration

2020-05-07 Thread Simon Glass
Hi Masahiro, On Thu, 7 May 2020 at 06:21, Masahiro Yamada wrote: > > Add -Werror=implicit-function-declaration as Linux does. > > If you do not check the prototype, it may go wrong run-time. > It is better to break the build, and require to include correct > headers. > > Signed-off-by: Masahiro Y

Re: U-CLASS SPI Bus and Devices

2020-05-07 Thread Simon Glass
Hi Rudolf, On Wed, 18 Mar 2020 at 05:25, Rudolf J Streif wrote: > > I ran into an issue today with a U-CLASS SPI NOR flash device on a NXP > FlexSPI controller. U-Boot started correctly from the flash device but > using 'sf probe 0:0' would always return 'Invalid bus 0 (err=-19)'. This > error me

Re: [PATCH v4 5/5] doc: add bind/unbind command documentation

2020-05-07 Thread Simon Glass
On Thu, 30 Apr 2020 at 04:06, Patrice Chotard wrote: > > Add documentation in doc/drivel-model for the bind/unbind command. > Part of this documentation is extracted from original patch commit > message: > commit 49c752c93a78 ("cmd: Add bind/unbind commands to bind a device to a > driver from the

Re: [PATCH v1 3/3] drivers: pinctrl-single: add request api

2020-05-07 Thread Simon Glass
Hi Rayagonda, On Thu, 30 Apr 2020 at 05:03, Rayagonda Kokatanur wrote: > > Hi Simon, > > On Wed, Apr 29, 2020 at 11:34 PM Simon Glass wrote: > > > > Hi Rayagonda, > > > > +Stephen Warren > > > > On Wed, 29 Apr 2020 at 10:36, Rayagonda Kokatanur > > wrote: > > > > > > Add pinctrl_ops->request ap

Re: [PATCH v1 2/3] drivers: pinctrl-single: add support to parse gpio properties

2020-05-07 Thread Simon Glass
Hi Rayagonda, On Thu, 30 Apr 2020 at 05:10, Rayagonda Kokatanur wrote: > > Hi Simon, > > On Wed, Apr 29, 2020 at 11:34 PM Simon Glass wrote: > > > > Hi Rayagonda, > > > > +Stephen Warren > > > > On Wed, 29 Apr 2020 at 10:35, Rayagonda Kokatanur > > wrote: > > > > > > Parse different gpio proper

Re: [PATCH] ARM: uniphier: delete or replace includes

2020-05-07 Thread Simon Glass
Hi Masahiro, On Thu, 7 May 2020 at 07:10, Masahiro Yamada wrote: > > pulls in a lot of bloat. is unneeded in most of > places. > > Signed-off-by: Masahiro Yamada > --- > > arch/arm/mach-uniphier/arm32/cache-uniphier.c | 1 - > arch/arm/mach-uniphier/arm32/psci.c | 1

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-07 Thread Marek Vasut
On 5/7/20 10:46 PM, Samuel Holland wrote: > On 5/6/20 12:02 PM, trini at konsulko.com (Tom Rini) wrote: >> I'm not sure that it is. Can we easily/safely memmove the data to be >> aligned? Is that really a better option in this case than ensuring >> alignment within the file? > >>>

Re: [PATCH v1 1/3] drivers: pinctrl-single: handle different register width

2020-05-07 Thread Simon Glass
Hi Rayagonda, On Thu, 30 Apr 2020 at 04:06, Rayagonda Kokatanur wrote: > > On Wed, Apr 29, 2020 at 11:34 PM Simon Glass wrote: > > > > Hi Rayagonda, > > > > +Stephen Warren > > > > On Wed, 29 Apr 2020 at 10:35, Rayagonda Kokatanur > > wrote: > > > > > > Add support to use different register rea

Re: [PATCH v2 2/4] regmap: Allow providing read/write callbacks through struct regmap_config

2020-05-07 Thread Simon Glass
Hi Vignesh, On Thu, 7 May 2020 at 03:08, Vignesh Raghavendra wrote: > > > > On 06/05/20 8:17 pm, Simon Glass wrote: > > Hi Pratyush, > > > > On Tue, 5 May 2020 at 13:47, Pratyush Yadav wrote: > >> > >> Hi Simon, > >> > >> I would be taking up this series and address the comments. > >> > >> On 10

Re: Re: [RFC PATCH 2/2] arch: x86: apl: Use devicetree for FSP configuration

2020-05-07 Thread Simon Glass
Hi Bernhard, On Thu, 7 May 2020 at 01:53, Bernhard Messerklinger wrote: > > Hi Simon, > > >Hi Bernhard, > > > >On Thu, 30 Apr 2020 at 03:16, Bernhard Messerklinger > > wrote: > >> > >> A the moment the FSP configuration is a mix of hard coded values > >and > >> devicetree properties. > >> This pa

Re: [PATCH] imx8mp_evk: Make SPL binary size smaller

2020-05-07 Thread Fabio Estevam
On Thu, May 7, 2020 at 8:59 AM Fabio Estevam wrote: > > Commit f24dea4e1b52 ("ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK") caused > the u-boot-spl.bin binary size to grow by around 2000 bytes, which makes the > board to fail to boot. The new SPL size is 97kB, which is below the limit define i

Re: [PATCH 5/8] efi_loader: Make the pkcs7 header parsing function an extern

2020-05-07 Thread Akashi Takahiro
On Thu, May 07, 2020 at 04:48:30PM +0530, Sughosh Ganu wrote: > On Thu, 7 May 2020 at 13:04, Akashi Takahiro > wrote: > > > On Thu, Apr 30, 2020 at 11:06:27PM +0530, Sughosh Ganu wrote: > > > The pkcs7 header parsing functionality is pretty generic, and can be > > > used by other features like ca

Re: [PATCH 6/8] efi: capsule: Add support for uefi capsule authentication

2020-05-07 Thread Akashi Takahiro
On Thu, May 07, 2020 at 05:20:35PM +0530, Sughosh Ganu wrote: > On Thu, 7 May 2020 at 13:49, Akashi Takahiro > wrote: > > > Sughosh, > > > > On Thu, Apr 30, 2020 at 11:06:28PM +0530, Sughosh Ganu wrote: > > > Add support for authenticating uefi capsules. Most of the signature > > > verification f

Re: [PATCH v3 6/7] ARM: dts: rk3399-evb: usb3.0 host support

2020-05-07 Thread Frank Wang
Hi Peter, On 2020/5/7 16:17, Peter Robinson wrote: On Thu, May 7, 2020 at 9:13 AM Frank Wang wrote: Configure 'tcphy1' and 'usbdrd_dwc3_1' nodes to support USB3.0 host for Rockchip RK3399 Evaluation Board. Signed-off-by: Frank Wang --- Changes for v3: - drop dtsi changes to keep the same wit

Re: efi_loader: pkcs7_parse_message() returns error pointer

2020-05-07 Thread AKASHI Takahiro
Heinrich, On Thu, May 07, 2020 at 04:47:22PM +0200, Heinrich Schuchardt wrote: > On 07.05.20 02:17, Patrick Wildt wrote: > > Since pkcs7_parse_message() returns an error pointer, we must not > > check for NULL. We have to explicitly set msg to NULL in the error > > case, otherwise the call to pkc

Re: [PATCH 3/8] qemu: arm64: Add support for efi firmware management protocol routines

2020-05-07 Thread Akashi Takahiro
On Thu, May 07, 2020 at 10:47:47PM +0200, Heinrich Schuchardt wrote: > On 5/7/20 4:33 AM, Akashi Takahiro wrote: > > On Fri, May 01, 2020 at 11:33:42AM +0200, Heinrich Schuchardt wrote: > >> On 4/30/20 9:13 PM, Sughosh Ganu wrote: > >>> > >>> On Fri, 1 May 2020 at 00:09, Heinrich Schuchardt >>>

[PATCH 2/3] mksunxi_fit_atf.sh: Update FIT component descriptions

2020-05-07 Thread Samuel Holland
Since commit d879616e9e64 ("spl: fit: simplify logic for FDT loading for non-OS boots"), the SPL looks at the "os" properties of FIT images to determine where to append the FDT. The "os" property of the "firmware" image also determines how to execute the next stage of the boot process, as in 1d379

[PATCH] ARC: DTS: cleanup USB node names

2020-05-07 Thread Eugeniy Paltsev
Remove redundant '0x' from node names. Signed-off-by: Eugeniy Paltsev --- arch/arc/dts/axs10x_mb.dtsi | 4 ++-- arch/arc/dts/hsdk-common.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arc/dts/axs10x_mb.dtsi b/arch/arc/dts/axs10x_mb.dtsi index 5b77642b8d7..33

[PATCH 1/3] spl: fit: Minimally parse OS properties with FIT_IMAGE_TINY

2020-05-07 Thread Samuel Holland
Some boards, specifically 64-bit Allwinner boards (sun50i), are extremely limited on SPL size. One strategy that was used to make space was to remove the FIT "os" property parsing code, because it uses a rather large lookup table. However, this forces the legacy FIT parsing code path, which requir

[PATCH 3/3] sunxi: Add support for including SCP firmware

2020-05-07 Thread Samuel Holland
Allwinner sun50i SoCs contain an OpenRISC 1000 CPU that functions as a System Control Processor, or SCP. ARM Trusted Firmware (ATF) communicates with the SCP over SCPI to implement the PSCI system suspend and shutdown functionality. Currently, SCP firmware is optional; the system will boot and run

Re: efi_loader: efi_variable_parse_signature() returns NULL on error

2020-05-07 Thread Patrick Wildt
On Thu, May 07, 2020 at 03:53:29PM +0200, Heinrich Schuchardt wrote: > On 07.05.20 09:15, AKASHI Takahiro wrote: > > On Thu, May 07, 2020 at 02:13:18AM +0200, Patrick Wildt wrote: > >> efi_variable_parse_signature() returns NULL on error, so IS_NULL() > > IS_NULL() seems to be a typo. I will repla

Re: Setting up test.py for a platform with 2 U-Boots?

2020-05-07 Thread Stephen Warren
On 5/7/20 12:48 PM, Tom Rini wrote: > Hey, > > So I'm trying to enable our test.py framework on am65x_evm_r5 + > am65x_evm_a53. The short version is this platform has an R5 core that > sets things up and fires off the A53 cores. So there's two U-Boots and > the console log looks like this (I use

Re: [PATCH 1/1] test: stabilize test_efi_secboot

2020-05-07 Thread AKASHI Takahiro
On Thu, May 07, 2020 at 11:14:17PM +0200, Heinrich Schuchardt wrote: > On 5/7/20 2:36 AM, AKASHI Takahiro wrote: > > Heinrich, > > > > On Mon, May 04, 2020 at 12:33:26PM +0200, Heinrich Schuchardt wrote: > >> When setting up the console via function efi_console_register() we call > >> query_console

[PATCH 3/3] sunxi: H6: Enable Ethernet on the Pine H64

2020-05-07 Thread Samuel Holland
Now that the EMAC driver supports the H6 SoC, we can enable the Ethernet hardware on the Pine H64 board. Signed-off-by: Samuel Holland --- configs/pine_h64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pine_h64_defconfig b/configs/pine_h64_defconfig index 8937c51bd0..8787

[PATCH 1/3] net: sun8i_emac: Use consistent clock bitfield definitions

2020-05-07 Thread Samuel Holland
While the R40 uses a different register for EMAC clock configuration than other chips, the register has a very similar layout. Reuse the existing bitfield definitions in this file, since they match. This allows the driver to compile on the H6 platform, where the CCM_GMAC_CTRL definitions are not p

[PATCH 2/3] net: sun8i_emac: Add support for the H6 variant

2020-05-07 Thread Samuel Holland
The H6 EMAC is very similar to the H3 variant, except that it uses the same pinmux as R40. Add support for it. Signed-off-by: Samuel Holland --- drivers/net/sun8i_emac.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun

[PATCH] spl: Always define preloader_console_init

2020-05-07 Thread Samuel Holland
A large number of boards call preloader_console_init unconditionally. Currently, they fail to build with CONFIG_SPL_SERIAL=n, because the function is undefined in that case. To fix the build, always define preloader_console_init, but make it no-op when CONFIG_SPL_SERIAL=n. For the few boards that

[PATCH] sunxi: Silence warning about non-static inline function

2020-05-07 Thread Samuel Holland
When compiling with CONFIG_SPL_SERIAL=n, gcc warns about mbus_configure_port not being marked as static: In file included from include/common.h:34, from arch/arm/mach-sunxi/dram_sunxi_dw.c:11: include/log.h:185:4: warning: 'printf' is static but used in inline function 'mbus_conf

Re: wandboard does not boot with current mainline

2020-05-07 Thread Fabio Estevam
Hi Heiko, On Thu, May 7, 2020 at 9:12 AM Heiko Schocher wrote: > > Hello Fabio, > > I have my wandboard DL in my automated daily build setup example: > > http://xeidos.ddns.net/ubtestresults/ > > and wondered, why my last result is from may 4th ... > > (Ok, there is a bug, that I do not see not b

Re: [PATCH 1/1] test: stabilize test_efi_secboot

2020-05-07 Thread Heinrich Schuchardt
On 5/7/20 2:36 AM, AKASHI Takahiro wrote: > Heinrich, > > On Mon, May 04, 2020 at 12:33:26PM +0200, Heinrich Schuchardt wrote: >> When setting up the console via function efi_console_register() we call >> query_console_serial(). This functions sends an escape sequence to the >> terminal to query th

Re: [PATCH 8/8] qemu: arm64: Add documentation for capsule update

2020-05-07 Thread Heinrich Schuchardt
On 5/7/20 4:10 AM, Akashi Takahiro wrote: > On Fri, May 01, 2020 at 11:17:27AM +0530, Sughosh Ganu wrote: >> On Fri, 1 May 2020 at 00:57, Tom Rini wrote: >> >>> On Fri, May 01, 2020 at 12:38:45AM +0530, Sughosh Ganu wrote: On Fri, 1 May 2020 at 00:07, Heinrich Schuchardt >>> wrote:

Re: [PATCH 3/8] qemu: arm64: Add support for efi firmware management protocol routines

2020-05-07 Thread Heinrich Schuchardt
On 5/7/20 4:33 AM, Akashi Takahiro wrote: > On Fri, May 01, 2020 at 11:33:42AM +0200, Heinrich Schuchardt wrote: >> On 4/30/20 9:13 PM, Sughosh Ganu wrote: >>> >>> On Fri, 1 May 2020 at 00:09, Heinrich Schuchardt >> > wrote: >>> >>> On 4/30/20 7:36 PM, Sughosh Ganu wr

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-07 Thread Samuel Holland
On 5/6/20 12:02 PM, trini at konsulko.com (Tom Rini) wrote: > I'm not sure that it is. Can we easily/safely memmove the data to be > aligned? Is that really a better option in this case than ensuring > alignment within the file? Can't we use the new mkimage -B option to enfo

Re: [PATCH 1/1] efi_loader: fix 'efidebug bootorder'

2020-05-07 Thread Heinrich Schuchardt
On 5/7/20 8:46 AM, AKASHI Takahiro wrote: > On Wed, Apr 29, 2020 at 09:23:01PM +0200, Heinrich Schuchardt wrote: >> * don't copy GUIDs for no reason >> * shorten print format strings by using variable names >> * don't use the run-time table to access exported functions > > I don't much care about t

[PATCH v2] arm: mvebu: Convert CRS305-1G-4S board to CRS3xx-98DX3236

2020-05-07 Thread Luka Kovacic
Convert the CRS305-1G-4S board to CRS3xx-98DX3236 to enable easier implementation of new CRS3xx series boards, based on Marvell Prestera 98DX3236. Signed-off-by: Luka Kovacic Cc: Luka Perkov Cc: Jakov Petrina --- Changes for v2: - Fix the patch failing to merge into the current U-Boot tree

Re: [PATCH 0/2] u-boot support for ODROID-C4

2020-05-07 Thread Beniamino Galvani
On Wed, May 06, 2020 at 09:59:17AM +0200, Neil Armstrong wrote: > Hi Beniamino, > > On 05/05/2020 22:22, Beniamino Galvani wrote: > > Hi, > > > > these two patches add initial u-boot support for Hardkernel ODROID-C4. > > Thanks for the patchset, I already have one in my test tree, by you did bea

[PATCH] arm: mvebu: Convert CRS305-1G-4S board to CRS3xx-98DX3236

2020-05-07 Thread Luka Kovacic
Convert the CRS305-1G-4S board to CRS3xx-98DX3236 to enable easier implementation of new CRS3xx series boards, based on Marvell Prestera 98DX3236. Signed-off-by: Luka Kovacic Cc: Luka Perkov Cc: Jakov Petrina --- arch/arm/dts/armada-xp-crs305-1g-4s.dts | 103 +--- arch/arm/dt

RE: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

2020-05-07 Thread Tiaki Rice
Eugen, Ah, I suspect the issue might be might be because I changed the subject inside the file but the did not change the filename. I shouldn't have done it that way anyway. Regarding windows vs linux, doing a diff between them showed no differences aside from the tag at the end describing the

RE: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

2020-05-07 Thread Tiaki Rice
Eugen, Thanks for the speedy reply, I did not know about this script! I must have glossed over it in the uboot patch documentation page. The commit line is 82 characters which is longer than the preferred max of 75. Oops. Don't think this warning would be stopping the patch going through thoug

Re: [PATCH v4 12/12] phy: atheros: consolidate {ar8031|ar8035}_config()

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:59AM +0200, Michael Walle wrote: > The two functions are now exactly the same, remove one of them. > > Signed-off-by: Michael Walle > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 11/12] phy: atheros: ar8035: remove static clock config

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:58AM +0200, Michael Walle wrote: > We can configure the clock output in the device tree. Disable the > hardcoded one in here. This is highly board-specific and should have > never been enabled in the PHY driver. > > If bisecting shows that this commit breaks your boa

Re: [PATCH v4 10/12] phy: atheros: add device tree bindings and config

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:57AM +0200, Michael Walle wrote: > Add support for configuring the CLK_25M pin as well as the RGMII I/O > voltage by the device tree. > > By default the AT803x PHYs outputs the 25MHz clock of the XTAL input. > But this output can also be changed by software to other

Re: [PATCH v4 08/12] phy: atheros: introduce debug read and write functions

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:55AM +0200, Michael Walle wrote: > Provide functions to read and write the Atheros debug registers. > > Signed-off-by: Michael Walle > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 06/12] phy: atheros: fix AR8021 PHY ID mask

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:53AM +0200, Michael Walle wrote: > The upper bits are all the OUI. > > Signed-off-by: Michael Walle > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 05/12] phy: atheros: Clarify the intention of ar8021_config

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:52AM +0200, Michael Walle wrote: > From: Vladimir Oltean > > Debug register 5 contains TX_CLK DELAY at bit 8 and reserved values at > the other bit positions, just like the other PHYs in the family do. > Therefore, it is not necessary to hardcode the reserved values

Re: [PATCH v4 09/12] phy: atheros: move delay config to common function

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:56AM +0200, Michael Walle wrote: > Signed-off-by: Michael Walle > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 07/12] phy: atheros: use defines for PHY IDs

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:54AM +0200, Michael Walle wrote: > Signed-off-by: Michael Walle > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 02/12] phy: atheros: Use common functions for RGMII internal delays

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:49AM +0200, Michael Walle wrote: > From: Vladimir Oltean > > Signed-off-by: Vladimir Oltean > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 03/12] phy: atheros: Clarify the configuration of the CLK_25M output pin

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:50AM +0200, Michael Walle wrote: > From: Vladimir Oltean > > Also take the opportunity to use the phy_read_mmd and phy_write_mmd > convenience functions. > > Signed-off-by: Vladimir Oltean > Acked-by: Joe Hershberger Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v4 04/12] phy: atheros: Explicitly disable RGMII delays

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:51AM +0200, Michael Walle wrote: > From: Vladimir Oltean > > To eliminate any doubts about the out-of-reset value of the PHY, that > the driver previously relied on. > > If bisecting shows that this commit breaks your board you probably have > a wrong PHY interface

Re: [PATCH v4 01/12] phy: atheros: Make RGMII Tx delays actually configurable for AR8035

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 12:11:48AM +0200, Michael Walle wrote: > From: Vladimir Oltean > > Delete the extraneous write to debug reg 5 that enables Tx delay > > When the driver was originally introduced in commit "6027384a phylib: > Add Atheros AR8035 GETH PHY support", the Tx delay was being >

Setting up test.py for a platform with 2 U-Boots?

2020-05-07 Thread Tom Rini
Hey, So I'm trying to enable our test.py framework on am65x_evm_r5 + am65x_evm_a53. The short version is this platform has an R5 core that sets things up and fires off the A53 cores. So there's two U-Boots and the console log looks like this (I used SOURCE_DATE_EPOCH to give both binaries the sa

[PATCH v2] drivers: crypto: mod_exp_sw: Re-add DM_FLAG_PRE_RELOC

2020-05-07 Thread Jan Kiszka
From: Jan Kiszka This driver is safe to use in SPL without relocation. Denying DM_FLAG_PRE_RELOC prevents its usability for verifying the main U-Boot or other artifacts from the SPL unless needless enabling the full driver set (SPL_OF_PLATDATA). Fixes: 17e117408571 ("drivers: crypto: rsa_mod_exp

[PATCH] lib: rsa: Also check for presence of r-squared property

2020-05-07 Thread Jan Kiszka
From: Jan Kiszka Better than crashing later if it is missing. Signed-off-by: Jan Kiszka --- lib/rsa/rsa-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c index 80e817314b..f7ae174cb0 100644 --- a/lib/rsa/rsa-verify.c +++ b/

[PATCH v2 1/1] efi_loader: put device tree into EfiACPIReclaimMemory

2020-05-07 Thread Heinrich Schuchardt
According to the UEFI spec ACPI tables should be placed in EfiACPIReclaimMemory. Let's do the same with the device tree. Suggested-by: Ard Biesheuvel Cc: Grant Likely Signed-off-by: Heinrich Schuchardt --- v2: adjust the unit test --- cmd/bootefi.c | 4 ++-- li

Re: [PATCH][v4 6/6] board: tbs2910: add documentation

2020-05-07 Thread Soeren Moch
Denis, do you plan to re-send a fixed version of this series? Thanks, Soeren On 01.03.20 14:59, Soeren Moch wrote: > On 27.02.20 01:37, Denis 'GNUtoo' Carikli wrote: >> This documents the u-boot installation procedure and the >> hardware in order to get started. > Thanks for adding this documen

[PATCH] Makefile: add file 'defconfig' to clean target

2020-05-07 Thread Heinrich Schuchardt
File 'defconfig' is a build artifact of 'make savedefconfig'. Remove it when cleaning. Signed-off-by: Heinrich Schuchardt --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cc99873062..88b356c40b 100644 --- a/Makefile +++ b/Makefile @@ -203

Re: efi_loader: pkcs7_parse_message() returns error pointer

2020-05-07 Thread Heinrich Schuchardt
On 07.05.20 02:17, Patrick Wildt wrote: > Since pkcs7_parse_message() returns an error pointer, we must not > check for NULL. We have to explicitly set msg to NULL in the error > case, otherwise the call to pkcs7_free_message() on the goto err > path will assume it's a valid object. > > Signed-off

Re: Bisected: omap_hsmmc 3.3V IO voltage incompatible with N900 (Was: Re: Bisected: mmc cause reboot loops on N900)

2020-05-07 Thread Pali Rohár
On Thursday 07 May 2020 19:10:14 Faiz Abbas wrote: > On 26/04/20 3:59 am, Pali Rohár wrote: > > On Sunday 26 April 2020 00:20:07 Pali Rohár wrote: > >> On Saturday 25 April 2020 23:26:15 Pali Rohár wrote: > >>> Now I tried git bisect and here is problematic commit which caused whole > >>> reboot lo

Re: [PATCH v2] misc: i2c_eeprom: implement different probe test eeprom offset

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 18:02, Baruch Siach wrote: > Hi Heiko, > > On Thu, May 07 2020, Heiko Schocher wrote: >> Am 07.05.2020 um 10:53 schrieb Eugen Hristev: >>> Because of this commit : >>> 5ae84860b0 ("misc: i2c_eeprom: verify that the chip is functional at >>> probe()") >>> at probe time, each eeprom i

Re: [PATCH v2] misc: i2c_eeprom: implement different probe test eeprom offset

2020-05-07 Thread Baruch Siach
Hi Heiko, On Thu, May 07 2020, Heiko Schocher wrote: > Am 07.05.2020 um 10:53 schrieb Eugen Hristev: >> Because of this commit : >> 5ae84860b0 ("misc: i2c_eeprom: verify that the chip is functional at >> probe()") >> at probe time, each eeprom is tested for read at offset 0. >> >> The Atmel AT24M

Re: efi_loader: pkcs7_parse_message() returns error pointer

2020-05-07 Thread Heinrich Schuchardt
On 07.05.20 02:17, Patrick Wildt wrote: > Since pkcs7_parse_message() returns an error pointer, we must not > check for NULL. We have to explicitly set msg to NULL in the error > case, otherwise the call to pkcs7_free_message() on the goto err > path will assume it's a valid object. @Takahiro I t

Re: [PATCH] sf: Add Macronix MX25R6435F SPI NOR flash to flash parameters array

2020-05-07 Thread Jagan Teki
On Sun, May 3, 2020 at 6:10 PM Peng Fan wrote: > > From: Ye Li > > On i.mx7ulp EVK board, we use MX25R6435F NOR flash, add its parameters > and IDs to flash parameter array. Otherwise, the flash probe will fails. > > Signed-off-by: Ye Li > Signed-off-by: Peng Fan > --- Applied to u-boot-spi/ma

Re: [PATCH] clk: Fix clk func names in comments

2020-05-07 Thread Jagan Teki
On Fri, May 1, 2020 at 11:45 PM Jagan Teki wrote: > > clk function names in comments should be prefix with > clk instead of clock. > > Fix it. > > Cc: Simon Glass > Cc: Tom Rini > Signed-off-by: Jagan Teki > --- Applied to u-boot-spi/master

Re: [PATCH 2/2] spi: Zap lpc32xx_ssp driver-related code

2020-05-07 Thread Jagan Teki
On Fri, May 1, 2020 at 10:05 PM Jagan Teki wrote: > > lpc32xx_ssp driver is deprecated, no active updates > and no board user, hence dropped the same. > > Cc: Vladimir Zapolskiy > Cc: Albert ARIBAUD > Cc: Tom Rini > Signed-off-by: Jagan Teki > --- Applied to u-boot-spi/master

Re: wandboard does not boot with current mainline

2020-05-07 Thread Tom Rini
On Thu, May 07, 2020 at 02:53:49PM +0200, Heiko Schocher wrote: > Hello Fabio, > > Am 07.05.2020 um 14:12 schrieb Heiko Schocher: > > Hello Fabio, > > > > I have my wandboard DL in my automated daily build setup example: > > > > http://xeidos.ddns.net/ubtestresults/ > > > > and wondered, why my

Re: [PATCH 2/2] phy: Use _nodev naming convention if non-device clients

2020-05-07 Thread Jagan Teki
On Fri, May 1, 2020 at 11:44 PM Jagan Teki wrote: > > Clients that are requesting some of uclass API's > without a device (with ofnode) usually have _nodev > naming convention. > > - clk_get_by_index_nodev > - clk_get_by_name_nodev > - reset_get_by_index_nodev > - gpio_request_by_name_nodev > > So

Re: [PATCH v3 1/3] iopoll: Add read_poll_timeout common API

2020-05-07 Thread Jagan Teki
On Sat, May 2, 2020 at 12:45 PM Jagan Teki wrote: > > Add read_poll_timeout common API similar to Linux iopoll. > > readx_poll_timeout will trigger read_poll_timeout with > proper op. This will help to extend the functionalities > like sleep_us to poll timeout in future. > > This change is referen

Re: [PATCH] arm: dtsi: sama5d2: Add uart4 definition to sama5d2.dtsi

2020-05-07 Thread Eugen.Hristev
On 07.05.2020 17:23, Tiaki Rice wrote: > Eugen, > > Ah, I suspect the issue might be might be because I changed the subject > inside the file but the did not change the filename. I shouldn't have done it > that way anyway. Regarding windows vs linux, doing a diff between them showed > no differ

Re: [PATCH] x86: mtrr: Drop the mask display when changing an mtrr

2020-05-07 Thread Bin Meng
On Thu, May 7, 2020 at 10:13 PM Simon Glass wrote: > > We don't need to print this information since it is shown when the MTRRs > are displayed. Drop it. > > Signed-off-by: Simon Glass > --- > > cmd/x86/mtrr.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng

  1   2   >