Re: [U-Boot] [RESEND][PATCH 5/9] clk: Add Actions Semi OWL clock support

2018-06-11 Thread Manivannan Sadhasivam
Hi Simon, On Mon, Jun 11, 2018 at 01:38:42PM -0600, Simon Glass wrote: > Hi, > > On 11 June 2018 at 09:48, Manivannan Sadhasivam > wrote: > > This commit adds Actions Semi OWL family base clock and S900 SoC specific > > clock support. For S900 peripheral clock support, only UART clock has been >

[U-Boot] [PATCH v2 5/8] fdtgrep: Separate out checking of two allocations

2018-06-11 Thread Simon Glass
The current code might succeed on the first allocation and fail on the second. Separate the checks to avoid this problem. Of course, free() will never fail and the chances that (when allocating two small areas) one will succeed and one will fail are just as remote. But this keeps coverity happy.

[U-Boot] [UBOOT PATCH v2 3/3] spi: xilinx_spi: Added support to read JEDEC-id twice at the boot time

2018-06-11 Thread Vipul Kumar
This patch is for the startup block issue in the spi controller. SPI clock is passing through STARTUP block to FLASH. STARTUP block don't provide clock as soon as QSPI provides command. So, first command fails. This patch added support to read JEDEC id in xilinx_spi_xfer (). Signed-off-by: Vipul

Re: [U-Boot] [PATCH v4 10/16] efi: sandbox: Add relocation constants

2018-06-11 Thread Simon Glass
Hi Alex, On 11 June 2018 at 23:44, Alexander Graf wrote: > > > On 12.06.18 07:27, Simon Glass wrote: >> Hi Alex, >> >> On 24 May 2018 at 06:34, Alexander Graf wrote: >>> >>> >>> On 16.05.18 17:42, Simon Glass wrote: Add these so that we can build the EFI loader for sandbox. The values are >

[U-Boot] [PATCH v2 7/8] spi: sandbox: Fix memory leak in sandbox_sf_bind_emul()

2018-06-11 Thread Simon Glass
Move the strdup() call so that it is only done when we know we will bind the device. Reported-by: Coverity (CID: 131216) Signed-off-by: Simon Glass --- Changes in v2: - Fre the string when device_bind() fails, and presumably doesn't need it drivers/mtd/spi/sandbox.c | 7 --- 1 file change

Re: [U-Boot] [PATCH 6/8] rsa: Fix missing memory leak on error in fdt_add_bignum()

2018-06-11 Thread Simon Glass
Hi Heinrich, On 9 June 2018 at 13:50, Heinrich Schuchardt wrote: > On 06/09/2018 08:22 PM, Simon Glass wrote: >> Thsi function can fail without freeing all its memory. Fix it. >> >> Reported-by: Coverity (CID: 131217) >> Signed-off-by: Simon Glass >> --- >> >> lib/rsa/rsa-sign.c | 4 +--- >> 1

[U-Boot] [PATCH v2 8/8] sandbox: swap_case: Increase number of base address regs

2018-06-11 Thread Simon Glass
At present the code overruns the bar[] array. Fix this. At the same time, drop the leading / from the "/spl" path so that we can run U-Boot SPL with: spl/u-boot-spl rather than requiring: /path/to/spl/u-boot-spl Reported-by: Coverity (CID: 131199) Signed-off-by: Simon Glass Reviewed-by

Re: [U-Boot] [PATCH v4 07/16] efi: sandbox: Add distroboot support

2018-06-11 Thread Simon Glass
Hi Alex, On 11 June 2018 at 23:42, Alexander Graf wrote: > > > On 12.06.18 07:27, Simon Glass wrote: >> Hi Alex, >> >> On 24 May 2018 at 06:32, Alexander Graf wrote: >>> >>> >>> On 16.05.18 17:42, Simon Glass wrote: With sandbox these values depend on the host system. Let's assume that it >

[U-Boot] [PATCH v2 6/8] rsa: Fix missing memory leak on error in fdt_add_bignum()

2018-06-11 Thread Simon Glass
Thsi function can fail without freeing all its memory. Fix it. Reported-by: Coverity (CID: 131217) Signed-off-by: Simon Glass --- Changes in v2: - Add a comment defending the technical memory leaks that remain lib/rsa/rsa-sign.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions

[U-Boot] [PATCH v2 4/8] fdtgrep: Fix logic of free() in do_fdtgrep()

2018-06-11 Thread Simon Glass
This loop never actually exits, but the way the code is written this is not obvious. Add an explicit error check. Reported-by: Coverity (CID: 131280) Signed-off-by: Simon Glass --- Changes in v2: - Add a missing free() from one error path tools/fdtgrep.c | 5 - 1 file changed, 4 insertions

Re: [U-Boot] [PATCH 7/8] spi: sandbox: Fix memory leak in sandbox_sf_bind_emul()

2018-06-11 Thread Simon Glass
Hi Heinrich, On 10 June 2018 at 05:35, Simon Glass wrote: > Hi Heinrich, > > On 9 June 2018 at 11:54, Heinrich Schuchardt wrote: >> On 06/09/2018 08:22 PM, Simon Glass wrote: >>> Move the strdup() call so that it is only done when we know we will bind >>> the device. >>> >>> Reported-by: Coverit

[U-Boot] [PATCH v2 1/8] log: Fix incorect range check in log_get_cat_name()

2018-06-11 Thread Simon Glass
This allows access to an element after the end of the array. Fix it. Reported-by: Coverity (CID: 173279) Signed-off-by: Simon Glass --- Changes in v2: - Change log_get_cat_name() to always return a valid string, even if the uclass is not found common/log.c | 10 +++--- include/log.h |

[U-Boot] [PATCH v2 2/8] console: Fix handling of NULL global_data

2018-06-11 Thread Simon Glass
Both putc() and puts() can be called before global_data is set up. Some of the code paths don't handle this correctly. Add an explicit test before any member is accessed. Reported-by: Coverity (CID: 169030) Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- Changes in v2: None co

[U-Boot] [PATCH v2 3/8] sandbox: Use memcpy() to move overlapping regions

2018-06-11 Thread Simon Glass
The use of strcpy() to remove characters at the start of a string is safe in U-Boot, since we know the implementation. But in os.c we are using the C library's strcpy() function, where this behaviour is not permitted. Update the code to use memcpy() instead. Reported-by: Coverity (CID: 173279) Si

Re: [U-Boot] [PATCH 4/8] fdtgrep: Fix logic of free() in do_fdtgrep()

2018-06-11 Thread Simon Glass
Hi Heinrich, On 9 June 2018 at 13:44, Heinrich Schuchardt wrote: > On 06/09/2018 08:22 PM, Simon Glass wrote: >> This loop never actually exits, but the way the code is written this is >> not obvious. Add an explicit error check. >> >> Reported-by: Coverity (CID: 131280) >> >> Signed-off-by: Simo

Re: [U-Boot] [PATCH 5/8] fdtgrep: Separate out checking of two allocations

2018-06-11 Thread Simon Glass
Hi Heinrich, On 9 June 2018 at 13:46, Heinrich Schuchardt wrote: > On 06/09/2018 08:22 PM, Simon Glass wrote: >> The current code might succeed on the first allocation and fail on the >> second. Separate the checks to avoid this problem. >> >> Of course, free() will never fail and the chances tha

[U-Boot] [PATCH v2 0/8] Fix some coverity warnings

2018-06-11 Thread Simon Glass
This series attempts to fix various problems reported by Coverity, in subsystems where I have some knowledge. Changes in v2: - Change log_get_cat_name() to always return a valid string, even if the uclass is not found - Also remove the leading / from the "/spl" path - Add a missing free() from

[U-Boot] [UBOOT PATCH v2 2/3] spi: xilinx_spi: Modify transfer logic xilinx_spi_xfer() function

2018-06-11 Thread Vipul Kumar
This patch modify xilinx_spi_xfer() function and add rxfifo() and txfifo() functions to add the modularity. Signed-off-by: Vipul Kumar Signed-off-by: Siva Durga Prasad Paladugu --- drivers/spi/xilinx_spi.c | 98 +++- 1 file changed, 63 insertions(+),

[U-Boot] [UBOOT PATCH v2 0/3] spi:xilinx_spi: Modify xilinx spi driver

2018-06-11 Thread Vipul Kumar
This series of patches do the following: - This patch added support to get reg base address from DTS file - Added rxfifo() and txfifo() functions to add the modularity - Added support to read JEDEC-id twice at the boot time Changes in v2: - Split single patch into the series of patches Michal Sim

[U-Boot] [UBOOT PATCH v2 1/3] spi: xilinx: Read reg base address from DTS file

2018-06-11 Thread Vipul Kumar
From: Michal Simek This patch added support to read register base address from DTS file. Signed-off-by: Michal Simek Signed-off-by: Vipul Kumar --- drivers/spi/xilinx_spi.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/spi/xilinx_spi.c b

[U-Boot] [PATCH] efi.h: Do not use config options

2018-06-11 Thread Alexander Graf
Currently efi.h determines a few bits of its environment according to config options. This falls apart with the efi stub support which may result in efi.h getting pulled into the stub as well as real U-Boot code. In that case, one may be 32bit while the other one is 64bit. This patch changes the c

[U-Boot] [PATCH] efi_loader: Rename sections to allow for implicit data

2018-06-11 Thread Alexander Graf
Some times gcc may generate data that is then used within code that may be part of an efi runtime section. That data could be jump tables, constants or strings. In order to make sure we catch these, we need to ensure that gcc emits them into a section that we can relocate together with all the oth

Re: [U-Boot] [PATCH v4 10/16] efi: sandbox: Add relocation constants

2018-06-11 Thread Alexander Graf
On 12.06.18 07:27, Simon Glass wrote: > Hi Alex, > > On 24 May 2018 at 06:34, Alexander Graf wrote: >> >> >> On 16.05.18 17:42, Simon Glass wrote: >>> Add these so that we can build the EFI loader for sandbox. The values are >>> for x86_64 so potentially bogus. But we don't support relocation w

Re: [U-Boot] [PATCH v4 07/16] efi: sandbox: Add distroboot support

2018-06-11 Thread Alexander Graf
On 12.06.18 07:27, Simon Glass wrote: > Hi Alex, > > On 24 May 2018 at 06:32, Alexander Graf wrote: >> >> >> On 16.05.18 17:42, Simon Glass wrote: >>> With sandbox these values depend on the host system. Let's assume that it >>> is x86_64 for now. >>> >>> Signed-off-by: Simon Glass >>> --- >>>

Re: [U-Boot] [PATCH v5 02/13] efi: Init the 'rows' and 'cols' variables

2018-06-11 Thread Heinrich Schuchardt
On 06/12/2018 07:26 AM, Simon Glass wrote: > The current code causes a compiler error on gcc 4.8.4 as used by sandbox > on Ubuntu 14.04, which is fairly recent. Init these variables to fix the > problem. > > Signed-off-by: Simon Glass Is this needed after Alex's http://git.denx.de/?p=u-boot.git;

Re: [U-Boot] [PATCH v5 01/13] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox

2018-06-11 Thread Heinrich Schuchardt
On 06/12/2018 07:26 AM, Simon Glass wrote: > This does not work at present and gives the following error: > > output: 'ld.bfd: read in flex scanner failed > scripts/Makefile.lib:390: recipe for target > 'lib/efi_selftest/efi_selftest_miniapp_return_efi.so' failed > > It may be possible to figure

Re: [U-Boot] [PATCH v4 00/16] efi: Enable basic sandbox support for EFI loader

2018-06-11 Thread Simon Glass
Hi Heinrich, On 16 May 2018 at 23:31, Heinrich Schuchardt wrote: > On 05/16/2018 07:13 PM, Heinrich Schuchardt wrote: >> On 05/16/2018 05:42 PM, Simon Glass wrote: >>> A limitation of the EFI loader at present is that it does not build with >>> sandbox. This makes it hard to write tests, since sa

Re: [U-Boot] HS200 for SDHCI is broken

2018-06-11 Thread Masahiro Yamada
2018-06-12 14:26 GMT+09:00 Masahiro Yamada : > Hi Siva, Michal. > > > I noticed drivers/mmc/sdhci-cadence.c > not working for my boards. > > > git-bisect points the following commit: > > > > commit 434f9d454eb1a17bb7f5cdb21167ccbe7e41da39 > Author: Siva Durga Prasad Paladugu > Date: Tue May 29 2

[U-Boot] [PATCH v5 09/13] efi: Split out test init/uninit into functions

2018-06-11 Thread Simon Glass
We plan to run more than one EFI test. In order to avoid duplicating code, create functions which handle preparing for running the test and cleaning up afterwards. Also shorten the awfully long variable names here. Signed-off-by: Simon Glass --- Changes in v5: - Drop call to efi_init_obj_list()

[U-Boot] HS200 for SDHCI is broken

2018-06-11 Thread Masahiro Yamada
Hi Siva, Michal. I noticed drivers/mmc/sdhci-cadence.c not working for my boards. git-bisect points the following commit: commit 434f9d454eb1a17bb7f5cdb21167ccbe7e41da39 Author: Siva Durga Prasad Paladugu Date: Tue May 29 20:03:10 2018 +0530 mmc: sdhci: Update sdhci_send_command() to

Re: [U-Boot] [PATCH v4 07/16] efi: sandbox: Add distroboot support

2018-06-11 Thread Simon Glass
Hi Alex, On 24 May 2018 at 06:32, Alexander Graf wrote: > > > On 16.05.18 17:42, Simon Glass wrote: >> With sandbox these values depend on the host system. Let's assume that it >> is x86_64 for now. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v4: None >> Changes in v3: None >> Chang

[U-Boot] [PATCH v5 07/13] efi: Add a comment about duplicated ELF constants

2018-06-11 Thread Simon Glass
These constants are defined in arch-specific code but redefined here. Add a TODO to clean this up. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- Changes in v5: - Drop period after "elf" in comment Changes in v4: None Changes in v3: None Changes in v2: None lib/efi_loader/ef

[U-Boot] [PATCH v5 12/13] efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-06-11 Thread Simon Glass
This function can be used from do_bootefi_exec() so that we use mostly the same code for a normal EFI application and an EFI test. Rename the function and use it in both places. Signed-off-by: Simon Glass --- Changes in v5: - Rebase to master Changes in v4: - Rebase to master Changes in v3: -

[U-Boot] [PATCH v5 11/13] efi: Create a function to set up for running EFI code

2018-06-11 Thread Simon Glass
Add a new bootefi_run_prepare() function which holds common code used to set up U-Boot to run EFI code. Make use of this from the existing bootefi_test_prepare() function, as well as do_bootefi_exec(). Also shorten a few variable names. Signed-off-by: Simon Glass --- Changes in v5: - Drop call

[U-Boot] [PATCH v5 06/13] efi: sandbox: Add relocation constants

2018-06-11 Thread Simon Glass
Add these so that we can build the EFI loader for sandbox. The values are for x86_64 so potentially bogus. But we don't support relocation within sandbox anyway. Signed-off-by: Simon Glass --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None lib/efi_loader/efi_ru

[U-Boot] [PATCH v5 05/13] efi: sandbox: Add distroboot support

2018-06-11 Thread Simon Glass
With sandbox these values depend on the host system. Let's assume that it is x86_64 for now. Signed-off-by: Simon Glass --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None include/config_distro_bootcmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[U-Boot] [PATCH v5 13/13] buildman: Add a --boards option to specify particular boards to build

2018-06-11 Thread Simon Glass
At present 'buildman sandbox' will build all 5 boards for the sandbox architecture rather than the single board 'sandbox'. The only current way to exclude sandbox_spl, sandbox_noblk, etc. is to use -x which is a bit clumbsy. Add a --boards option to allow individual build targets to be specified.

Re: [U-Boot] [PATCH v4 10/16] efi: sandbox: Add relocation constants

2018-06-11 Thread Simon Glass
Hi Alex, On 24 May 2018 at 06:34, Alexander Graf wrote: > > > On 16.05.18 17:42, Simon Glass wrote: >> Add these so that we can build the EFI loader for sandbox. The values are >> for x86_64 so potentially bogus. But we don't support relocation within >> sandbox anyway. >> >> Signed-off-by: Simon

[U-Boot] [PATCH v5 08/13] efi: sandbox: Enable EFI loader builder for sandbox

2018-06-11 Thread Simon Glass
This allows this feature to build within sandbox. This is for testing purposes only since it is not possible for sandbox to load native code. Signed-off-by: Simon Glass --- Changes in v5: None Changes in v4: None Changes in v3: - Init the 'rows' and 'cols' vars to avoid a compiler error (gcc 4.8

[U-Boot] [PATCH v5 03/13] efi: sandbox: Adjust memory usage for sandbox

2018-06-11 Thread Simon Glass
With sandbox the U-Boot code is not mapped into the sandbox memory range so does not need to be excluded when allocating EFI memory. Update the EFI memory init code to take account of that. Also use mapmem instead of a cast to convert a memory address to a pointer. Signed-off-by: Simon Glass ---

[U-Boot] [PATCH v5 04/13] sandbox: smbios: Update to support sandbox

2018-06-11 Thread Simon Glass
At present this code casts addresses to pointers so cannot be used with sandbox. Update it to use mapmem instead. Signed-off-by: Simon Glass --- Changes in v5: None Changes in v4: None Changes in v3: - Drop incorrect map_sysmem() in write_smbios_table() Changes in v2: None lib/smbios.c | 32 +

[U-Boot] [PATCH v5 10/13] efi: sandbox: Add a simple 'bootefi test' command

2018-06-11 Thread Simon Glass
This jumps to test code which can call directly into the EFI support. It does not need a separate image so it is easy to write tests with it. This test can be executed without causing problems to the run-time environemnt (e.g. U-Boot does not need to reboot afterwards). For now the test just outp

[U-Boot] [PATCH v5 02/13] efi: Init the 'rows' and 'cols' variables

2018-06-11 Thread Simon Glass
The current code causes a compiler error on gcc 4.8.4 as used by sandbox on Ubuntu 14.04, which is fairly recent. Init these variables to fix the problem. Signed-off-by: Simon Glass --- Changes in v5: None Changes in v4: - Move the fix to query_console_serial() Changes in v3: - Add new patch to

[U-Boot] [PATCH v5 00/13] efi: Enable basic sandbox support for EFI loader

2018-06-11 Thread Simon Glass
A limitation of the EFI loader at present is that it does not build with sandbox. This makes it hard to write tests, since sandbox is used for most testing in U-Boot. This series enables the EFI loader feature. It allows sandbox to build and run a trivial function which calls the EFI API to output

[U-Boot] [PATCH v5 01/13] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox

2018-06-11 Thread Simon Glass
This does not work at present and gives the following error: output: 'ld.bfd: read in flex scanner failed scripts/Makefile.lib:390: recipe for target 'lib/efi_selftest/efi_selftest_miniapp_return_efi.so' failed It may be possible to figure this out with suitable linker magic but it does not seem

Re: [U-Boot] [PATCH v2 3/3] common: Generic loader for file system

2018-06-11 Thread Chee, Tien Fong
On Mon, 2018-06-11 at 13:38 -0600, Simon Glass wrote: > Hi, > > On 11 June 2018 at 08:15, Marek Vasut wrote: > > > > On 06/11/2018 04:13 PM, Chee, Tien Fong wrote: > > > > > > On Mon, 2018-06-11 at 16:03 +0200, Marek Vasut wrote: > > > > > > > > On 06/11/2018 03:55 PM, Chee, Tien Fong wrote: >

Re: [U-Boot] [RFC PATCH] fpga: zynq: Add encrypted bitstream support with auto detect

2018-06-11 Thread Siva Durga Prasad Paladugu
Hi Stefan, > -Original Message- > From: stefan.herbrechtsme...@weidmueller.com > [mailto:stefan.herbrechtsme...@weidmueller.com] > Sent: Monday, June 11, 2018 9:33 PM > To: Siva Durga Prasad Paladugu ; > ste...@herbrechtsmeier.net > Cc: u-boot@lists.denx.de; michal.si...@xilinx.com; mon...

Re: [U-Boot] [PATCH] x86: Use microcode update from device tree for all processors

2018-06-11 Thread Bin Meng
Hi Ivan, On Sat, Apr 21, 2018 at 1:47 AM, Ivan Gorinov wrote: > Hi Bin, > > On Wed, Apr 18, 2018 at 07:05:28PM -0600, Bin Meng wrote: >> >> > >> >> > If there is no ROM image, ucode_base and ucode_size are not initialized >> >> > and >> >> > the microcode update data from DTB applied by microcod

Re: [U-Boot] [PATCH 08/13] x86: cougarcanyon2: Enable CPU driver and SMP support

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:32 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> This enables the 206ax cpu driver on Intel Cougar Canyon 2 board, >> so that SMP can be supported too. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/dts/cougarcanyon2.dts | 33 +++

Re: [U-Boot] [PATCH 10/13] x86: irq: Change LINK_V2N and LINK_N2V to inline functions

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:33 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> LINK_V2N and LINK_N2V are currently defines, so they cannot handle >> complex logics. Change to inline functions for future extension. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/cpu/irq.c

Re: [U-Boot] [PATCH 05/13] x86: ivybridge: Enable 206ax cpu driver for FSP build

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:31 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> At present this 206ax cpu driver is only built when FSP is not used. >> This updates the Makefile to enable the build for both cases. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/cpu/ivybridg

Re: [U-Boot] [PATCH 03/13] x86: cougarcanyon2: Update dts for SPI lock down

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:31 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> It turns out that like Braswell, Intel FSP for IvyBridge requires >> SPI controller settings to be locked down, as the U-Boot ICH SPI >> driver fails with the following message on Cougar Canyon 2 boar

Re: [U-Boot] [PATCH 09/13] x86: irq: Remove chipset specific irq router drivers

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:33 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> At present there are 3 irq router drivers. One is the common one >> and the other two are chipset specific for queensbay and quark. >> However these are really the same drivers as the core logic is >>

Re: [U-Boot] [PATCH 04/13] x86: cougarcanyon2: Remove CONFIG_HAVE_INTEL_ME

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:31 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> As README.x86 already mentions, there are two SPI flashes mounted >> on Intel Cougar Canyon 2 board, called SPI-0 and SPI-1 respectively. >> SPI-0 stores the flash descriptor and the ME firmware. SPI-

Re: [U-Boot] [PATCH 06/13] x86: ivybridge: Drop CONFIG_USBDEBUG

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:32 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> This is not used anywhere. Clean this up. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/cpu/intel_common/mrc.c | 5 - >> arch/x86/cpu/ivybridge/model_206ax.c | 15 --- >>

Re: [U-Boot] [PATCH 07/13] x86: chromebook_link: Remove dm-pre-reloc property in the cpu nodes

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:33 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> The 206ax cpu driver does not require pre-relocation flag to work. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/dts/chromebook_link.dts | 5 - >> 1 file changed, 5 deletions(-) >> > > Rev

Re: [U-Boot] [PATCH 02/13] x86: ivybridge: Imply USB_XHCI_HCD

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:30 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> The Panther Point chipset connected to Ivybridge has xHC integrated, >> imply it. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/cpu/ivybridge/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >

Re: [U-Boot] [PATCH 01/13] usb: xhci-pci: Fix compiler warning

2018-06-11 Thread Bin Meng
On Fri, Jun 8, 2018 at 4:29 AM, Simon Glass wrote: > On 3 June 2018 at 18:04, Bin Meng wrote: >> This fixes the following compiler warning: >> >> "warning: cast from pointer to integer of different size >> [-Wpointer-to-int-cast]" >> >> Signed-off-by: Bin Meng >> --- >> >> drivers/usb/host/

[U-Boot] [PATCH] gpio: omap_gpio: Name GPIO's by bank and index with DM_GPIO

2018-06-11 Thread Adam Ford
There are multiple GPIO banks with up to 32 pins / bank. When using 'gpio status -a' to read the pins, this patch displays both GPIO_ similar to how the device trees display in addition to displaying gpio_# Signed-off-by: Adam Ford diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.

[U-Boot] [PATCH] arm: mach-omap2/omap3/clock.c: Enable all GPIO with CMD_GPIO

2018-06-11 Thread Adam Ford
When CMD_GPIO is enabled the command 'gpio status -a' can cause a hang or reboot if GPIO banks are not enabled, because it scans all banks. This patch enables all GPIO banks so 'gpio status -a' can fully execute. Signed-off-by: Adam Ford diff --git a/arch/arm/mach-omap2/omap3/clock.c b/arch/ar

[U-Boot] [PATCH V3] arm: mvebu: Add Helios4 Armada 38x initial support

2018-06-11 Thread dgilmore
From: Dennis Gilmore The helios4 is built on the SolidRun Armada 38x SOM. The port os based on the ClearFog board, using information from https://github.com/helios-4/u-boot-marvell as well as dtb input from https://github.com/helios-4/linux-marvell Signed-off-by: Dennis Gilmore Signed-off-by: D

Re: [U-Boot] [PATCH v2 1/2] dm: mdio: add a uclass for MDIO

2018-06-11 Thread Joe Hershberger
Hi Ken, Thanks for tackling this. On Wed, Jun 6, 2018 at 9:08 PM, wrote: > From: Ken Ma > > Add a uclass which provides access to MDIO busses and includes > operations required by MDIO. > The implementation is based on the existing mii/phy/mdio data > structures and APIs. > This patch also add

Re: [U-Boot] [PATCH v2 2/3] rk3288: Disable JTAG function from sdmmc0 IO

2018-06-11 Thread Carlo Caione
On Mon, 2018-06-11 at 10:41 +0200, Dr. Philipp Tomsich wrote: > > On 11 Jun 2018, at 10:08, Carlo Caione wrote: /cut > > +#define GRF_SOC_CON0 0xff770244 > > #define GRF_SOC_CON2 0xff77024c > > Could you convert these to ‘const uintptr_t GRF_SOC_CON0 = …’ ? > The compiler will generate the same

Re: [U-Boot] [PATCH 03/18] x86: efi: app: Fix broken EFI application

2018-06-11 Thread Bin Meng
Hi Heinrich, On Tue, Jun 12, 2018 at 1:18 AM, Heinrich Schuchardt wrote: > On 06/10/2018 03:25 PM, Bin Meng wrote: >> The EFI application does not boot currently. It's due to the call >> to syscon_get_by_driver_data() in cpu_init_r() maps to nowhere as >> CONFIG_SYSCON is not included in the conf

[U-Boot] [PATCH V3] block: Add SPL_BLOCK_CACHE and default n

2018-06-11 Thread Adam Ford
When enabling BLOCK_CACHE on devices with limited RAM during SPL, some devices may not boot. This creates an option to enable block caching in SPL by defaults off. It is dependent on SPL_BLK Fixes: 46960ad6d09b ("block: Have BLOCK_CACHE default to y in some cases") Signed-off-by: Adam Ford ---

Re: [U-Boot] [PATCH 05/18] efi: Fix efi_uintn_t for 64-bit EFI payload

2018-06-11 Thread Alexander Graf
On 11.06.18 11:11, Bin Meng wrote: > Hi Alex, > > On Sun, Jun 10, 2018 at 9:25 PM, Bin Meng wrote: >> Since commit bb0bb91cf0aa ("efi_stub: Use efi_uintn_t"), EFI x86 >> 64-bit payload does not work anymore. The call to GetMemoryMap() >> in efi_stub.c fails with return code EFI_INVALID_PARAMETE

Re: [U-Boot] [RESEND][PATCH 5/9] clk: Add Actions Semi OWL clock support

2018-06-11 Thread Simon Glass
Hi, On 11 June 2018 at 09:48, Manivannan Sadhasivam wrote: > This commit adds Actions Semi OWL family base clock and S900 SoC specific > clock support. For S900 peripheral clock support, only UART clock has been > added for now. > > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm/include/

Re: [U-Boot] [PATCH 2/4] soc: qualcomm: Add Shared Memory Manager driver

2018-06-11 Thread Simon Glass
Hi Ramon, On 11 June 2018 at 13:14, Ramon Fried wrote: > > > On Mon, Jun 11, 2018 at 5:53 PM, Simon Glass wrote: >> >> Hi Ramon, >> >> On 9 June 2018 at 03:06, Ramon Fried wrote: >> > The Shared Memory Manager driver implements an interface for allocating >> > and accessing items in the memory

Re: [U-Boot] [PATCH 00/18] x86: efi: Fixes and enhancements to application and payload support

2018-06-11 Thread Simon Glass
Hi Bin, On 11 June 2018 at 09:53, Bin Meng wrote: > > Hi Simon, > > On Mon, Jun 11, 2018 at 10:53 PM, Simon Glass wrote: > > Hi Bin, > > > > On 10 June 2018 at 05:24, Bin Meng wrote: > >> Unfortunately the EFI x86 application and payload support have been > >> broken for quite a while. This ser

Re: [U-Boot] [PATCH v2 3/3] common: Generic loader for file system

2018-06-11 Thread Simon Glass
Hi, On 11 June 2018 at 08:15, Marek Vasut wrote: > On 06/11/2018 04:13 PM, Chee, Tien Fong wrote: >> On Mon, 2018-06-11 at 16:03 +0200, Marek Vasut wrote: >>> On 06/11/2018 03:55 PM, Chee, Tien Fong wrote: >>> [...] > >> >>> Linux firmware loading method is diff

Re: [U-Boot] [PATCH 2/4] soc: qualcomm: Add Shared Memory Manager driver

2018-06-11 Thread Ramon Fried
On Mon, Jun 11, 2018 at 5:53 PM, Simon Glass wrote: > Hi Ramon, > > On 9 June 2018 at 03:06, Ramon Fried wrote: > > The Shared Memory Manager driver implements an interface for allocating > > and accessing items in the memory area shared among all of the > > processors in a Qualcomm platform. >

[U-Boot] [PATCH 07/11] dm: core: Add a way to bind a device by ofnode

2018-06-11 Thread Simon Glass
Add a new device_bind_ofnode() function which can bind a device given its ofnode. This allows binding devices more easily with livetree nodes. Signed-off-by: Simon Glass --- drivers/core/device.c| 8 include/dm/device-internal.h | 4 2 files changed, 12 insertions(+) diff

[U-Boot] [PATCH 10/11] dm: core: Add a function to decode a memory region

2018-06-11 Thread Simon Glass
Add a way to decode a memory region, including the memory type (sram or sdram) and its start address and size. Signed-off-by: Simon Glass --- drivers/core/of_extra.c | 81 + include/dm/of_extra.h | 45 +++ 2 files changed, 126 insert

[U-Boot] [PATCH 06/11] log: Add a way to log a return value with a message

2018-06-11 Thread Simon Glass
It is sometimes useful to show a message when logging an error return value, perhaps to add a few details about the problem. Add a function to support this. Signed-off-by: Simon Glass --- include/log.h | 8 1 file changed, 8 insertions(+) diff --git a/include/log.h b/include/log.h ind

[U-Boot] [PATCH 08/11] dm: spi: Update sandbox SPI emulation driver to use ofnode

2018-06-11 Thread Simon Glass
Update the parameters sandbox_sf_bind_emul to support livetree. Signed-off-by: Simon Glass --- drivers/mtd/spi/sandbox.c | 9 + include/spi_flash.h | 2 +- test/dm/spi.c | 8 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/spi/sandb

[U-Boot] [PATCH 11/11] dm: core: Add logging of some common errors

2018-06-11 Thread Simon Glass
Add additional logging so that common errors when finding a device by ofnode are easier to debug. Signed-off-by: Simon Glass --- drivers/core/uclass.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index 0085d3fb

[U-Boot] [PATCH 04/11] dm: core: Add comments to ofnode_read_resource() functoins

2018-06-11 Thread Simon Glass
These functions are missing comments. Add some. Signed-off-by: Simon Glass --- include/dm/ofnode.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h index 85cb87b83f..61c42311f8 100644 --- a/include/dm/ofnode.h +++ b/include/d

[U-Boot] [PATCH 05/11] dm: core: Add a way to find an ofnode by compatible string

2018-06-11 Thread Simon Glass
Add an ofnode_by_compatible() to allow iterating through ofnodes with a given compatible string. Signed-off-by: Simon Glass --- drivers/core/ofnode.c | 12 include/dm/ofnode.h | 11 +++ 2 files changed, 23 insertions(+) diff --git a/drivers/core/ofnode.c b/drivers/core/o

[U-Boot] [PATCH 09/11] dm: core: Update of_read_fmap_entry() for livetree

2018-06-11 Thread Simon Glass
Update this function to take an ofnode so that it can work with livetree. Signed-off-by: Simon Glass --- drivers/core/of_extra.c | 8 drivers/misc/cros_ec.c | 4 ++-- include/dm/of_extra.h | 6 ++ 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/core/of_ex

[U-Boot] [PATCH 02/11] dm: core: Add ofnode function to read a 64-bit int

2018-06-11 Thread Simon Glass
We have a 32-bit version of this function. Add a 64-bit version as well so we can easily read 64-bit ints from the device tree. Signed-off-by: Simon Glass --- drivers/core/of_access.c | 19 +++ drivers/core/ofnode.c| 32 include/dm/of_access.

[U-Boot] [PATCH 03/11] dm: core: Fix a few ofnode function comments

2018-06-11 Thread Simon Glass
Tidy up three return-value errors. Signed-off-by: Simon Glass --- include/dm/ofnode.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h index dbb4273db6..85cb87b83f 100644 --- a/include/dm/ofnode.h +++ b/include/dm/ofnode.h @@ -262,

[U-Boot] [PATCH 01/11] fdt: Add device tree memory bindings

2018-06-11 Thread Simon Glass
From: Michael Pratt Support a default memory bank, specified in reg, as well as board-specific memory banks in subtree board-id nodes. This allows memory information to be provided in the device tree, rather than hard-coded in, which will make it simpler to handle similar devices with different

[U-Boot] [PATCH 00/11] dm: Add more core features for livetree

2018-06-11 Thread Simon Glass
This adds various minor features for livetree, mostly related to memory handling. Michael Pratt (1): fdt: Add device tree memory bindings Simon Glass (10): dm: core: Add ofnode function to read a 64-bit int dm: core: Fix a few ofnode function comments dm: core: Add comments to ofnode_rea

[U-Boot] [PATCH] arm: Do not clear LR on exception in SPL

2018-06-11 Thread Andrew F. Davis
When an exception or interrupt occurs the link register (LR) may contain the source of the exception, although we do not print the value it may still be extracted with a debugger. When in SPL we loop on getting and exception, but use a linking branch, which over-writes the LR value, use a regular b

[U-Boot] [PATCH v3 1/4] rk3288: veyron: Init boot-on regulators

2018-06-11 Thread Carlo Caione
From: Carlo Caione Use regulators_enable_boot_on() to init all the regulators with regulator-boot-on property. Signed-off-by: Carlo Caione Reviewed-by: Simon Glass Reviewed-by: Philipp Tomsich Acked-by: Philipp Tomsich --- arch/arm/mach-rockchip/rk3288-board.c | 6 ++ 1 file changed, 6

[U-Boot] [PATCH v3 3/4] rockchip: veyron: Set vcc33_sd regulator value

2018-06-11 Thread Carlo Caione
From: Carlo Caione On the veyron board the vcc33_sd regulator is used as vmmc-supply for the SD card. This regulator is powered in the MMC core during power on but its value is never actually set. In the veyron platform the reset value for the LDO output is 1.8V while the standard (min and max)

[U-Boot] [PATCH v3 4/4] rk3288: Convert register defines to const uintptr_t

2018-06-11 Thread Carlo Caione
From: Carlo Caione No functional change but at least we can now guarantee type safety. Signed-off-by: Carlo Caione --- arch/arm/mach-rockchip/rk3288-board.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-rockchip/rk3288-board.c b/arch/arm/mach-rockchip/

[U-Boot] [PATCH v3 2/4] rk3288: Disable JTAG function from sdmmc0 IO

2018-06-11 Thread Carlo Caione
From: Carlo Caione The GRF_SOC_CON0.grf_force_jtag bit is automatically set at boot and it is preventing the SDMMC to work correctly. Disable the JTAG function on the assumption that a working SD has higher priority over JTAG. Signed-off-by: Carlo Caione Reviewed-by: Simon Glass Reviewed-by: P

[U-Boot] [PATCH v3 0/4] rk3288: veyron: Enable SDMMC when booting from SPI

2018-06-11 Thread Carlo Caione
From: Carlo Caione These patches toghether with the previously submitted patch [0] enable the chromebook veyron jerry to use the SDMMC interface when U-Boot is not chainloaded by depthcharge but booted directly from SPI. [0] https://marc.info/?l=u-boot&m=152836928803742&w=2 Changelog: V2: - Ad

Re: [U-Boot] [PATCH 05/18] efi: Fix efi_uintn_t for 64-bit EFI payload

2018-06-11 Thread Heinrich Schuchardt
On 06/11/2018 06:35 PM, Bin Meng wrote: > Hi Heinrich, > > On Mon, Jun 11, 2018 at 11:31 PM, Heinrich Schuchardt > wrote: >> On 06/11/2018 01:36 AM, Bin Meng wrote: >>> Hi Heinrich, >>> >>> On Mon, Jun 11, 2018 at 2:17 AM, Heinrich Schuchardt >>> wrote: On 06/10/2018 04:30 PM, Bin Meng wro

[U-Boot] [PATCH 3/3] pico-imx7d: Adjust the dtb name

2018-06-11 Thread Otavio Salvador
From: Fabio Estevam Since kernel commit 41bbeadceb03 ("ARM: dts: imx7d-pico-pi: Separate into cpu and baseboard dts") the dtb name has changed. Fix it accordingly. Signed-off-by: Fabio Estevam Signed-off-by: Otavio Salvador --- include/configs/pico-imx7d.h | 2 +- 1 file changed, 1 insertio

[U-Boot] [PATCH 2/3] spl: Add default values for ARCH_MX7

2018-06-11 Thread Otavio Salvador
From: Fabio Estevam ARCH_MX6 has default values for SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR and SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR. Do the same for ARCH_MX7 so that users may have a consistent experience through the i.MX families. Signed-off-by: Fabio Estevam Signed-off-by: Otavio Salvador --- c

[U-Boot] [PATCH 1/3] wandboard: Remove hardcoded baudrate from "console" variable

2018-06-11 Thread Otavio Salvador
We should use the baudrate variable available inside U-Boot environment to allow it to be changed dynamically. Signed-off-by: Otavio Salvador --- include/configs/wandboard.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/wandboard.h b/include/configs/wandboa

Re: [U-Boot] [PATCH v2 2/3] rk3288: Disable JTAG function from sdmmc0 IO

2018-06-11 Thread Dr. Philipp Tomsich
On 11 Jun 2018, at 19:08, Carlo Caione wrote: > > On Mon, 2018-06-11 at 10:41 +0200, Dr. Philipp Tomsich wrote: >>> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > /cut >>> +#define GRF_SOC_CON0 0xff770244 >>> #define GRF_SOC_CON2 0xff77024c >> >> Could you convert these to ‘const uintptr_t

Re: [U-Boot] [PATCH] sunxi: use CONFIG_DEFAULT_FDT_FILE everywhere

2018-06-11 Thread Martin Kelly
(ping Jagan) On 06/06/2018 10:51 AM, Martin Kelly wrote: On 06/06/2018 07:58 AM, Maxime Ripard wrote: On Mon, Jun 04, 2018 at 11:15:34AM -0700, Martin Kelly wrote: [snip as the thread is getting long] On 06/04/2018 01:21 AM, Maxime Ripard wrote: On Fri, Jun 01, 2018 at 10:16:32AM -0700, Mart

Re: [U-Boot] [PATCH 03/18] x86: efi: app: Fix broken EFI application

2018-06-11 Thread Heinrich Schuchardt
On 06/10/2018 03:25 PM, Bin Meng wrote: > The EFI application does not boot currently. It's due to the call > to syscon_get_by_driver_data() in cpu_init_r() maps to nowhere as > CONFIG_SYSCON is not included in the configuration. > > EFI application is built as a shared library, so GCC won't compl

Re: [U-Boot] [PATCH v2] net: mvgbe: extract common code for SMI wait

2018-06-11 Thread Joe Hershberger
On Sat, Jun 9, 2018 at 3:46 AM, Chris Packham wrote: > Combine repeated code from smi_reg_read/smi_reg_write into a common > function smi_wait_ready. > > Reviewed-by: Stefan Roese > Signed-off-by: Chris Packham Acked-by: Joe Hershberger ___ U-Boot ma

Re: [U-Boot] [PATCH 05/18] efi: Fix efi_uintn_t for 64-bit EFI payload

2018-06-11 Thread Bin Meng
Hi Heinrich, On Mon, Jun 11, 2018 at 11:31 PM, Heinrich Schuchardt wrote: > On 06/11/2018 01:36 AM, Bin Meng wrote: >> Hi Heinrich, >> >> On Mon, Jun 11, 2018 at 2:17 AM, Heinrich Schuchardt >> wrote: >>> On 06/10/2018 04:30 PM, Bin Meng wrote: Hi Heinrich, On Sun, Jun 10, 2018 a

Re: [U-Boot] Please pull u-boot-fsl-qoriq master

2018-06-11 Thread York Sun
On 06/11/2018 05:29 AM, Tom Rini wrote: > On Sat, Jun 09, 2018 at 04:57:44AM +, York Sun wrote: >> On 06/08/2018 09:39 PM, Tom Rini wrote: >>> On Fri, Jun 08, 2018 at 11:49:32PM +, York Sun wrote: >>> Tom, The following changes since commit 71002b508a1bc0986023764f155f0

[U-Boot] [PATCH] mmc: Remove hwpartition help text when command is disabled

2018-06-11 Thread Alex Kiernan
When the `mmc hwpartition` command is disabled, remove the associated help text. Signed-off-by: Alex Kiernan --- cmd/mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/mmc.c b/cmd/mmc.c index c2ee2d9c0a..3920a1836a 100644 --- a/cmd/mmc.c +++ b/cmd/mmc.c @@ -935,6 +935,7 @@ U_BOOT_C

  1   2   >