On 09/25/2017 04:12 AM, Simon Glass wrote:
> On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
>> Run a 10 ms periodic timer and check that it is called 10 times
>> while waiting for 100 ms single shot timer.
>>
>> Raise the TPL level to the level of the 10 ms timer and observe
>> that the
On 09/25/2017 04:11 AM, Simon Glass wrote:
> Hi Heinrich,
>
> On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
>> For the correct implementation of the task priority level (TPL)
>> calling the notification function must be queued.
>>
>> Add a status field 'queued' to events.
>>
>> In fun
+ Adam, who authored the reverted patch for omap3.
On Friday 22 September 2017 07:50 PM, Jaehoon Chung wrote:
> On 09/21/2017 11:51 PM, Jean-Jacques Hiblot wrote:
>> This series enables the ADMA present in some OMAP SOCs.
>> On a DRA7 the performances when reading from the eMMC go from 18MB/s
>>
On 09/25/2017 04:12 AM, Simon Glass wrote:
> Hi Heinrich,
>
> On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
>> Check that the notification function of an
>> EVT_SIGNAL_EXIT_BOOT_SERVICES event is called
>> exactly once.
>>
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> lib/efi_self
Dear Tom,
Could you pull these patches into u-boot/master?
If there is a problem, let me know, plz.
Other patches needs to check more, so i didn't apply them.
If i need to send PR again, i will send the PR as "take v2" for other patches.
(Patches relevant to HS200 and omap_hsmmc.)
The following
Hi,
On 09/25/2017 11:15 AM, Simon Glass wrote:
> Hi,
>
> On 22 September 2017 at 08:20, Jaehoon Chung wrote:
>> On 09/21/2017 11:51 PM, Jean-Jacques Hiblot wrote:
>>> This series enables the ADMA present in some OMAP SOCs.
>>> On a DRA7 the performances when reading from the eMMC go from 18MB/s
On 09/25/2017 04:14 AM, Simon Glass wrote:
> On 21 September 2017 at 10:30, Heinrich Schuchardt wrote:
>> Provide comments describing the boot service functions.
>>
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> lib/efi_loader/efi_boottime.c | 640
>> +-
For some special reset times for longer pcie devices, in this case, the
pcie device may on polling compliance state, the RC considers the pcie
device is link up, but the pcie device is not link up, only the L0 state
is link up state. So add the link up status judgement mechanisms.
Signed-off-by: B
Hi,
On 16 September 2017 at 23:12, Lokesh Vutla wrote:
> Simon,
>
> On 9/16/2017 9:43 PM, Simon Glass wrote:
>> Hi,
>>
>> On 16 September 2017 at 07:43, Tom Rini wrote:
>>> On Sat, Sep 16, 2017 at 05:14:31PM +0530, Lokesh Vutla wrote:
Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout lo
Hi,
On 18 September 2017 at 13:10, Rob Clark wrote:
> On Mon, Sep 18, 2017 at 2:01 AM, Heinrich Schuchardt
> wrote:
>> On 09/18/2017 12:59 AM, Simon Glass wrote:
>>> Add an implementation of setjmp() and longjmp() which rely on the
>>> underlying host C library. Since we cannot know how large t
On 18 September 2017 at 12:18, Philipp Tomsich
wrote:
> The BROM supports forcing it to enter download-mode, if an appropriate
> result/cmd-word is returned to it. There already is a series to
> support this in review, so this prepares the (newly C-version) of the
> back-to-bootrom code to accept
Hi Bin
> -Original Message-
> From: Bin Meng [mailto:bmeng...@gmail.com]
> Sent: Friday, September 22, 2017 9:24 PM
> To: Ran Wang
> Cc: open list ; Albert Aribaud
> ; Prabhakar Kushwaha
> ; Ashish Kumar ;
> York Sun ; Z.q. Hou
> Subject: Re: [U-Boot] [PATCH v2 1/2] ls1088ardb: Enable US
Hi Marek,
On 24 September 2017 at 07:05, Marek Vasut wrote:
> On 09/24/2017 02:52 PM, Tom Rini wrote:
>> On Sun, Sep 24, 2017 at 02:07:27PM +0200, Marek Vasut wrote:
>>> On 09/24/2017 01:36 PM, Tom Rini wrote:
On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote:
> On 09/24/2017 0
On 22 September 2017 at 09:37, wrote:
> From: Lee Jones
>
> Add missing ramdisk_addr_r param and set it to 0x4800
>
> Signed-off-by: Lee Jones
> ---
>
> v2: rebase on v2017.09
>
> include/configs/stih410-b2260.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glass
___
On 21 September 2017 at 10:30, Heinrich Schuchardt wrote:
> Provide comments describing the boot service functions.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_boottime.c | 640
> +-
> 1 file changed, 638 insertions(+), 2 deletions(-
On 24 September 2017 at 01:00, Heinrich Schuchardt wrote:
> We now require a dtc version which is not yet available in
> many distros.
>
> Indicate to the user where he will find the sources.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
Reviewe
On 22 September 2017 at 09:37, wrote:
> From: Nicolas Le Bayon
>
> 32MB are reserved for Trusted Zone purpose
Isn't this called TrustZone ?
>
> Signed-off-by: Nicolas Le Bayon
> ---
>
> v2: rebase on v2017.09
>
> include/configs/stih410-b2260.h | 2 +-
> 1 file changed, 1 insertion(+), 1 del
Hi Heinrich,
On 19 September 2017 at 11:44, Heinrich Schuchardt wrote:
> Up to now we depended on an exported variable to build u-boot.rom.
> What we build should be specified by the configuration file.
>
> With this patch the export variable is deprecated and replaced by the
> Kconfig option CON
On 21 September 2017 at 08:30, Jean-Jacques Hiblot wrote:
> From: Kishon Vijay Abraham I
>
> Add a new function to parse host controller dt node and
> set mmc_config. This function can be used by mmc controller
> drivers to set the generic mmc_config.
> This function can be extended to set other
On 20 September 2017 at 14:54, Heinrich Schuchardt wrote:
> ad503ffe9c6 efi_loader: refactor boot device and loaded_image handling
> leads to an error when building with CONFIG_CMD_BOOTEFI_SELFTEST=y
> This patch fixes the problem.
>
> Fixes: ad503ffe9c6 efi_loader: refactor boot device and loaded
On 18 September 2017 at 11:47, Rob Clark wrote:
> This is needed to run 'bootefi' from sandbox. I suspect StartImage()
> must have been broken too on x86.
>
> Signed-off-by: Rob Clark
> ---
> cmd/bootefi.c | 2 +-
> include/efi.h | 2 +-
> lib/efi_loader/efi_boot
On 20 September 2017 at 05:50, Klaus Goger
wrote:
> The livetree codepath of ofnode_get_addr_size always used the "reg"
> property for of_get_property. Use the property parameter of the function
> call instead and check the return value if the property exists.
> Otherwise return FDT_ADDR_T_NONE.
>
On 20 September 2017 at 13:14, Heinrich Schuchardt wrote:
> The EFI selftest has been broken by a patch on efi-next.
> We should enable CONFIG_CMD_BOOTEFI_SELFTEST on
> qemu-x86_defconfig and qemu-x86_64_defconfig by default
> to catch this type of problem in the Travis CI tests.
>
> These systems
On 22 September 2017 at 09:37, wrote:
> From: Patrice Chotard
>
> Update environment variable by updating:
> _ BOOT_TARGET_DEVICE
> _ CONFIGS_BOOTARGS
> _ kernel_addr_r, fdtfile, fdt_addr_r, scriptaddr, fdt_high, intird_high
>
> Signed-off-by: Patrice Chotard
> ---
>
> v2: rebase on v2017.09
On 15 September 2017 at 23:10, Masahiro Yamada
wrote:
> U-Boot widely uses error() as a bit noisier variant of printf().
>
> This macro causes name conflict with the following line in
> include/linux/compiler-gcc.h:
>
> # define __compiletime_error(message) __attribute__((error(message)))
>
> Th
On 19 September 2017 at 07:49, Philipp Tomsich
wrote:
> Apparently, our earlier assumption that the BROM will always set up
> the iomux for SDcard communication does not always hold true: when
> booting U-Boot from the on-module (on the RK3368-uQ7) eMMC, the SDcard
> pins are not set up and need t
On 22 September 2017 at 00:39, zijun_hu wrote:
> From: zijun_hu
>
> the new GD address is calculated via board data BD currently
> it require the new GD area locates below BD tightly, so a strict
> constraint is imposed on memory layout which maybe make special
> platform unpleasant.
>
> fix it b
On 21 September 2017 at 16:51, Sam Protsenko wrote:
> When eMMC was formattaed for Linux partition table, "userdata" partition
> is missing. In this case, part_get_info_by_name() iterates over all
> registered drivers (which are PART_TYPE_EFI, PART_TYPE_DOS and
> PART_TYPE_ISO). And when it comes
On 18 September 2017 at 12:18, Philipp Tomsich
wrote:
> The RK3188 implementation previously passed the address of the stack
> frame created during save_boot_params via pmu->os_reg[2]. This was not
> strictly necessary, as the save_boot_params() function was called
> twice (first: for TPL, saving
Hi,
On 22 September 2017 at 08:20, Jaehoon Chung wrote:
> On 09/21/2017 11:51 PM, Jean-Jacques Hiblot wrote:
>> This series enables the ADMA present in some OMAP SOCs.
>> On a DRA7 the performances when reading from the eMMC go from 18MB/s
>> to 43MB/s.
>> Also while were at it, fix some incorrec
On Mon, Sep 25, 2017 at 10:15 AM, Simon Glass wrote:
> On 24 September 2017 at 01:00, Heinrich Schuchardt wrote:
>> We now require a dtc version which is not yet available in
>> many distros.
>>
>> Indicate to the user where he will find the sources.
>>
>> Signed-off-by: Heinrich Schuchardt
>> -
Hi Heinrich,
On 18 September 2017 at 05:02, Heinrich Schuchardt wrote:
> On 09/18/2017 12:59 AM, Simon Glass wrote:
>> This jumps to test code which can call directly into the EFI support. It
>> does not need a separate image so it is easy to write tests with it.
>>
>> For now the test just outpu
Hi Jean-Jacques,
On 21 September 2017 at 09:03, Jean-Jacques Hiblot wrote:
> dev_read_string_count() is used to get the number of strings in a
> stringlist.
> dev_read_string_index() is used to get a string in the stringlist based on
> its position in the list.
>
> Signed-off-by: Jean-Jacques Hib
Hi York,
On 20 September 2017 at 09:20, York Sun wrote:
> On 09/18/2017 08:47 AM, York Sun wrote:
>> On 09/17/2017 10:55 AM, Simon Glass wrote:
>>> Hi York,
>>>
>>> On 14 September 2017 at 13:01, York Sun wrote:
This partially reverts commit 15eb1d43bf470b85e9031c2fce7e0ce7b27dd321
whi
Hi Rob,
On 21 September 2017 at 08:22, Rob Clark wrote:
> On Thu, Sep 21, 2017 at 12:58 AM, Simon Glass wrote:
>> Hi,
>>
>> On 20 September 2017 at 08:09, Rob Clark wrote:
>>> On Wed, Sep 20, 2017 at 5:08 AM, Alexander Graf wrote:
On 14.09.17 00:05, Rob Clark wrote:
>
>
On 21 September 2017 at 04:56, Heinrich Schuchardt wrote:
> Realloc does not free the old memory area if it fails.
>
> Identified by cppcheck.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> arch/sandbox/cpu/os.c | 20 ++--
> 1 file changed, 14 insertions(+), 6 deletions(-)
Revie
On 15 September 2017 at 06:02, Philipp Tomsich
wrote:
> The BROM supports forcing it to enter download-mode, if an appropriate
> result/cmd-word is returned to it. There already is a series to
> support this in review, so this prepares the (newly C-version) of the
> back-to-bootrom code to accept
On 20 September 2017 at 23:09, Suneel Garapati wrote:
> add blk child devices to ignore list while displaying usb tree graph,
> also preamble should not be set for blk child devices.
> add usb_emul to ignore list in usb_show_info. otherwise usb tree and
> info commands may cause crash treating blk
Hi,
On 22 September 2017 at 10:19, Alexander Graf wrote:
> Hi Philipp,
>
>
> On 09/21/2017 10:57 AM, Dr. Philipp Tomsich wrote:
>>
>> Simon & Alexander,
>>
>> It appears our setjmp/longjmp prototypes and implementations are
>> in non-compliance with current C-standards (I checked against
>> both
On 21 September 2017 at 02:08, wrote:
> From: Patrice Chotard
>
> Add missing .priv_auto_alloc_size() callback.
> Previously private struct stm32_clk was not allocate
> which leads to unpredictable behaviour
>
> Signed-off-by: Patrice Chotard
> ---
> drivers/clk/clk_stm32f7.c | 13 +++-
Hi Duncan,
On 21 September 2017 at 14:32, Duncan Hare wrote:
> Mods to:
> cmd/net.cnet/Makefilenet/net.cinclude/net.hnet/wget.cnet/wget.hnet/ping.c
> I do not know how to do patches, I'm a noobat this:
There is some documentation here.
https://www.denx.de/wiki/U-Boot/Patches
If you read all of
On 22 September 2017 at 23:30, zijun_hu wrote:
> From: zijun_hu
>
> relocate_code() allocates 32 bytes stack frame but only 16 bytes are
> freed before return. it will cause errors to possible previous frames
> and doesn't make relocate_code() look like a function.
>
> fix by freeing 32 bytes sta
On 21 September 2017 at 10:41, Heinrich Schuchardt wrote:
> EFI_ENTRY and EFI_EXIT calls must match.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_boottime.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Simon Glass
___
U
Hi Rob,
On 18 September 2017 at 11:03, Rob Clark wrote:
> On Mon, Sep 18, 2017 at 11:07 AM, Rob Clark wrote:
>> On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark wrote:
>>> On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark wrote:
On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote:
> On Sun, Sep 17,
On 19 September 2017 at 05:23, Faiz Abbas wrote:
> The size variable may not be always be a mulitple of
> ARCH_DMA_MINALIGN and using it to flush cache leads to cache
> misaligned warnings.
>
> Therefore, round up the size to a multiple of ARCH_DMA_MINLAIGN
> when allocating private data.
>
> Sign
Hi,
I'm testing a new Xilinx zynqmp dev board and was not able to probe the
qspi with the latest mainline U-Boot. I see that there is a 'zynqmp_qspi'
driver in the Xilinx tree [1] but nothing in mainline. After a little
digging, I found a thread on the list [2] (and [3]) and was wondering in
what
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> We should be able to call efi_set_timer repeatedly.
> So let us reset the signaled state here.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_boottime.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Simon Glas
+Bin
Hi Heinrich,
On 21 September 2017 at 05:11, Heinrich Schuchardt wrote:
> Hello Simon,
>
> sandbox_defconfig has
>
> arch/sandbox/include/asm/types.h:60: typedef u32 phys_addr_t;
>
> even if building on a 64bit machine.
>
> This results in a warning
>
> CC drivers/demo/demo-uclass.o
>
On 15 September 2017 at 07:57, Philipp Tomsich
wrote:
> The RK3368-uQ7 ATF has been moved back to 0x10 (1MB from the start
> of DRAM) to avoid it overwriting the active SPL stage during FIT image
> loading. This change adapts the .its to match up (again) with our ATF
> repository for the RK33
On 15 September 2017 at 23:10, Masahiro Yamada
wrote:
> Many drivers use dev_err, dev_info, etc. for logging. Currently,
> we are relying on , but I guess the best home is
> , taking into account that Linux defines them in
> .
>
> For now, I am keeping the ones in because lots of
> Linux-origina
Hi Sam,
On 21 September 2017 at 16:51, Sam Protsenko wrote:
> There is already existing function part_get_info_by_name().
> But sometimes user is particularly interested in looking for only
> specific partition type. This patch implements such an API that
> provides partition searching by name fo
On 15 September 2017 at 06:02, Philipp Tomsich
wrote:
> The save_boot_params_ret() prototype (for those of us, that have a
> valid SP on entry and can implement save_boot_params() in C), was
> previously only defined for !defined(CONFIG_ARM64).
>
> This moves the declaration to a common block to e
Hi Bin,
On 22 September 2017 at 07:37, Bin Meng wrote:
> Hi Simon,
>
> On Thu, Sep 21, 2017 at 12:58 PM, Simon Glass wrote:
>> Hi Bin,
>>
>> On 20 September 2017 at 08:41, Bin Meng wrote:
>>>
>>> Hi Simon,
>>>
>>> On Wed, Sep 20, 2017 at 9:50 PM, Simon Glass wrote:
>>> > Hi Bin,
>>> >
>>> > On
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> Define variable holding tpl.
> Implement RaiseTPL and RestoreTPL.
> Implement TPL check in efi_signal_event.
> Implement TPL check in efi_wait_for_event.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_boottime.c | 32
Hi Rob,
On 18 September 2017 at 09:07, Rob Clark wrote:
> On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark wrote:
>> On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark wrote:
>>> On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote:
On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt
wrote:
>
On 21 September 2017 at 23:24, Stefan Roese wrote:
> On 21.09.2017 19:03, Heinrich Schuchardt wrote:
>>
>> memset(newpart, '\0', sizeof(newpart));
>> only initializes the firest 4 or 8 bytes of *newpart and not the whole
>> structure disk_part.
>>
>> We should use sizeof(struct disk_part).
>>
>> I
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> A Python test script is provided that runs the EFI selftest
> if CONFIG_CMD_EFI_SELFTEST=y.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> test/py/tests/test_efi_selftest.py | 25 +
> 1 file changed, 25 insertion
Hi Jean-Jacques,
On 15 September 2017 at 04:57, Jean-Jacques Hiblot wrote:
> Sort include files in accordance to U-Boot coding style.
>
> Signed-off-by: Jean-Jacques Hiblot
> ---
> lib/fdtdec.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lib/fdtdec.c b/li
Hi Heinrich,
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> Check that the notification function of an
> EVT_SIGNAL_EXIT_BOOT_SERVICES event is called
> exactly once.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_selftest/Makefile| 3 +
> lib/efi_
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> All events of type EVT_SIGNAL_EXIT_BOOT_SERVICES have to be
> notified when ExitBootServices is invoked.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_boottime.c | 11 +++
> 1 file changed, 11 insertions(+)
On 18 September 2017 at 15:29, Heinrich Schuchardt wrote:
> The necessary parameters for running Python tests on qemu are
> tedious to find.
>
> The patch adds examples for u-boot-test-console and
> u-boot-test-reset.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> v2
> Include all necessa
Hi Heinrich,
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> For the correct implementation of the task priority level (TPL)
> calling the notification function must be queued.
>
> Add a status field 'queued' to events.
>
> In function efi_signal_event set status queued if a notificat
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> This unit test uses timer events to check the implementation
> of the following boottime services:
> CreateEvent, CloseEvent, WaitForEvent, CheckEvent, SetTimer
>
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_selftest/Makefile
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> Run a 10 ms periodic timer and check that it is called 10 times
> while waiting for 100 ms single shot timer.
>
> Raise the TPL level to the level of the 10 ms timer and observe
> that the notification function is not called again.
>
> Lo
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> A testing framework for the EFI API is provided.
> It can be executed with the 'bootefi selftest' command.
>
> It is coded in a way that at a later stage we may turn it
> into a standalone EFI application. The current build system
> does
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:
> Macro EFI_CALL was introduced to call an UEFI function.
> Unfortunately it does not support return values.
> Most UEFI functions have a return value.
>
> So let's rename EFI_CALL to EFI_CALL_VOID and introduce a
> new EFI_CALL macro that
On 15 September 2017 at 01:45, Heinrich Schuchardt wrote:
> Add a missing comment.
>
> Reported-by: Simon Glass
> Signed-off-by: Heinrich Schuchardt
> ---
> Patch is directly applicable to efi-next.
>
> Reported by Simon
> Re: [PATCH 15/23] efi_loader: implement ConnectController
> https://lists
On 09/24/2017 11:39 PM, Tom Rini wrote:
> On Thu, Sep 21, 2017 at 04:51:32PM +0200, Jean-Jacques Hiblot wrote:
>
>> This reverts commit 46831c1a4cda75d92f7ad18d4e2b1eb196c62b2f.
>> This reserved area at the beginning of struct hsmm, will be used later to
>> support ADMA
>>
>> Signed-off-by: Jean-J
From: Alison Chaiken
Create a common exit for most of the error handling code in
do_rename_gpt_parts. Delete the list elements in disk_partitions
before calling INIT_LIST_HEAD from get_gpt_info() a second time.
The SIZEOF_MISMATCH error is not addressed, since that problem was
already fixed by
On 09/25/2017 12:53 AM, Rob Clark wrote:
On Sun, Sep 24, 2017 at 5:38 PM, Tom Rini wrote:
On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote:
Can you post, unrelated, the code that totally crashed sandbox? Maybe
that's a problem we need to fix too :)
jfwiw, I've started lookin
I can confirm that this patch fixes the issue I was seeing (data_abort, single
and dual-bit ecc errors during dram_ecc_scrubbing).
Tested on a board with the Marvell AlleyCat3 switch/SoC.
Cheers,
Joshua Scott
From: Chris Packham
Sent: Saturday, 23 Sept
On Sun, Sep 24, 2017 at 10:39:30PM +0200, Łukasz Majewski wrote:
> Hi Tom,
>
> >On Sun, Sep 24, 2017 at 06:50:01PM +0200, Marek Vasut wrote:
> >>On 09/24/2017 04:26 PM, Tom Rini wrote:
> >>>The following series has been applied. I am posting this for the record.
> >>>
> >>>For the record, I do no
On Sun, Sep 24, 2017 at 5:38 PM, Tom Rini wrote:
> On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote:
>
>> The previous commit fixed a problem in FAT code where going back to the
>> root directory using '..' wouldn't work correctly on FAT12 or FAT16.
>> Add a test to exercise this c
On Sun, Sep 24, 2017 at 5:07 PM, Tuomas Tynkkynen
wrote:
> Currently we can only test FAT32 which is the default FAT version that
> mkfs.vfat creates by default. Instead make it explicitly create either a
> FAT16 or a FAT32 volume. This allows us to exercise more code, for
> instance the root dire
On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote:
> The previous commit fixed a problem in FAT code where going back to the
> root directory using '..' wouldn't work correctly on FAT12 or FAT16.
> Add a test to exercise this case (which was once fixed in commit
> 18a10d46f26 "fat:
On Mon, Sep 25, 2017 at 12:07:35AM +0300, Tuomas Tynkkynen wrote:
> If we end up back in the root directory via a '..' directory entry, set
> itr->is_root accordingly. Failing to do that gives spews like
> "Invalid FAT entry" and being unable to access directory entries located
> past the first cl
On Mon, Sep 25, 2017 at 12:07:34AM +0300, Tuomas Tynkkynen wrote:
> Currently we can only test FAT32 which is the default FAT version that
> mkfs.vfat creates by default. Instead make it explicitly create either a
> FAT16 or a FAT32 volume. This allows us to exercise more code, for
> instance the r
The previous commit fixed a problem in FAT code where going back to the
root directory using '..' wouldn't work correctly on FAT12 or FAT16.
Add a test to exercise this case (which was once fixed in commit
18a10d46f26 "fat: handle paths that include ../" but reintroduced due to
the directory iterat
If we end up back in the root directory via a '..' directory entry, set
itr->is_root accordingly. Failing to do that gives spews like
"Invalid FAT entry" and being unable to access directory entries located
past the first cluster of the root directory on FAT12/FAT16.
Fixes: 8eafae209c35 ("fat/fs:
Currently we can only test FAT32 which is the default FAT version that
mkfs.vfat creates by default. Instead make it explicitly create either a
FAT16 or a FAT32 volume. This allows us to exercise more code, for
instance the root directory handling is done differently in FAT32 than
the older FATs.
Hi Tom,
On Sun, Sep 24, 2017 at 06:50:01PM +0200, Marek Vasut wrote:
On 09/24/2017 04:26 PM, Tom Rini wrote:
The following series has been applied. I am posting this for the record.
For the record, I do not believe that using git submodules is a good approach
here. We have a small amount of
On Sat, Sep 23, 2017 at 6:51 AM, Tuomas Tynkkynen
wrote:
> On 09/23/2017 01:26 PM, Tuomas Tynkkynen wrote:
>>
>> Hi,
>>
>> FAT file systems created by GNU mtools have a problem that mtools doesn't
>> initialize the first cluster field of the '.' and '..' directory entries.
>> That is, with the fol
In the receive function all return values should be filled.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_net.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c
index 5344210fff..e5faa
Remove extraneous commas.
Add comment.
Signed-off-by: Heinrich Schuchardt
---
include/efi_api.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/efi_api.h b/include/efi_api.h
index 308baeec49..8c227ce703 100644
--- a/include/efi_api.h
+++ b/include/efi_api.
The length of a MAC address is 6.
We have to set this length in the EFI_SIMPLE_NETWORK_MODE
structure of the EFI_SIMPLE_NETWORK_PROTOCOL.
Without this patch iPXE fails to initialize the network with
error message
SNP MAC(001e0633bcbf,0x0) has invalid hardware address length 0
Signed-off-by: Heinr
Provide the simple network protocol revision.
This revision number could be used to identify backwards compatible
enhancements of the protocol.
Signed-off-by: Heinrich Schuchardt
---
include/efi_api.h| 3 +++
lib/efi_loader/efi_net.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/
Add %pm as format string to print a MAC address.
This is helpful when analyzing network problems.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_selftest/efi_selftest_console.c | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/lib/efi_selftest/
We need to call some boottime services internally.
Our GUIDs are stored as const efi_guid_t *.
The boottime services never change GUIDs.
So we can define the parameters as const efi_guid_t *.
Signed-off-by: Heinrich Schuchardt
---
include/efi_api.h | 27 ++-
The size fields in the Simple Network Protocol are all
UINTN in the UEFI spec. So use size_t.
Provide a function description of the receive function.
Signed-off-by: Heinrich Schuchardt
---
include/efi_api.h| 4 ++--
lib/efi_loader/efi_net.c | 24
2 files change
A timer event is defined. The timer handler cares for receiving new
packets.
efi_timer_check is called both in efi_net_transmit and efi_net_receive
to enable events during network communication.
Calling efi_timer_check in efi_net_get_status is implemented in a
separate patch.
Signed-off-by: Hein
EFI_ENTRY and EFI_EXIT calls must match.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_boottime.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index cbc4007f7b..2c2620a46d 100644
--- a/lib/efi_loader/efi_boottime.
Enclose definition in parantheses to allow using efi_st_error
like a void function.
Signed-off-by: Heinrich Schuchardt
---
include/efi_selftest.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/efi_selftest.h b/include/efi_selftest.h
index 76304a2b2a..7273a0f49a 1
The returned interrupt status was wrong.
As out transmit buffer is empty we need to always set
EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT.
When we have received a packet we need to set
EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT.
Furthermore we should call efi_timer_check() to handle events.
Signed-off-by:
U-Boot does not implement all functions of the simple network
protocol. The unimplemented functions return either of
EFI_SUCCESS and EFI_INVALID_PARAMETER.
The UEFI spec foresees to return EFI_UNSUPPORTED in these cases.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_net.c | 10 -
This patch provices an EFI application to check the correct function
of the Simple Network Protocol implementation.
It sends a DHCP request and analyzes the DHCP offer.
Different error conditions including a 10s timeout are checked.
A successful execution will look like this:
=> bootefi nettest
The UEFI spec defines the length parameters of CopyMem and SetMem
as UINTN. We should size_t here.
The source buffer of CopyMem should be marked as const.
Signed-off-by: Heinrich Schuchardt
---
include/efi_api.h | 7 +++
lib/efi_loader/efi_boottime.c | 10 +-
2 files ch
The WaitForPacket event informs tha a network package has been
received by the SimpleNetworkProtocol.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_net.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c
index 3
This patch series focuses on
* correction of parameter types for boot services
* fixes for the SetMem and CopyMem boot services
* fixes for the simple network protocol implementation (SNP)
* a unit test for SetMem, CopyMem and the simple network protocol
The unit test broadcasts a DHCPDISCOVER mes
WaitForPacket is an event and not a function pointer.
Signed-off-by: Heinrich Schuchardt
---
include/efi_api.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/efi_api.h b/include/efi_api.h
index c44dc9d0cb..308baeec49 100644
--- a/include/efi_api.h
+++ b/include/efi_a
The UEFI spec defines parameter index of WaitForEvent as UINTN*.
So we should use size_t here.
I deliberately do not use UINTN because I hold a following patch
that will eliminate UINTN because uppercase types to not match
the U-Boot coding style.
Signed-off-by: Heinrich Schuchardt
---
include/
1 - 100 of 137 matches
Mail list logo