On 09/25/2017 04:14 AM, Simon Glass wrote: > On 21 September 2017 at 10:30, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: >> Provide comments describing the boot service functions. >> >> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> >> --- >> lib/efi_loader/efi_boottime.c | 640 >> +++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 638 insertions(+), 2 deletions(-) > > Great to see this - but please can you put these comments in the > header file? That's the file that people read to see the API. > > nit: efi_locate_protocol() needs a @return >
Most of the functions are static. @Alex Where do you want the comments - for boottime structure members - for non-static functions - for static functions with forward declaration? Best regards Heinrich _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
