On Sun, Sep 24, 2017 at 5:38 PM, Tom Rini <tr...@konsulko.com> wrote: > On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote: > >> The previous commit fixed a problem in FAT code where going back to the >> root directory using '..' wouldn't work correctly on FAT12 or FAT16. >> Add a test to exercise this case (which was once fixed in commit >> 18a10d46f26 "fat: handle paths that include ../" but reintroduced due to >> the directory iterator refactoring). >> >> This test only very barely catches the problem - without the fix the >> size command still gives valid output but the additional spurious >> "Invalid FAT entry" error message makes it not get caught in the >> 'egrep -A3 ' output. I tried to make a proper test that grows the root >> directory to two clusters lots of with dummy files but that causes the >> write tests to crash the sandbox totally... > > Can you post, unrelated, the code that totally crashed sandbox? Maybe > that's a problem we need to fix too :)
jfwiw, I've started looking at the fat_write code, so even a failing/crashing test is useful. BR, -R > Otherwise fine, but we need to update the expected results. > > -- > Tom > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
